venetian 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 45874ec60b54aad7880937459b50c7f6810caf8a4879136214b5b65420a7e8f1
-  data.tar.gz: a578ee37916a536710644e91b58ea19e866104c0212a0f8a9ea3c073e05f2638
+  metadata.gz: 3ee00e1fcd1d1b3976326488aa3eaa280ef4f90d12df08f19dace106544caa9c
+  data.tar.gz: 424a96d951611a582d5308f8039757c5924eaf5d35bc9afa4b66ba4552285e09
 SHA512:
-  metadata.gz: 1f6f8d0da92fd1efdc4d182147b379d94e7d6c7760d5616d50b9e0d64cfae9c6131dea3062dde8d9e02178821c4d9eefe052e32b0ab75285d4551a3f8df506e8
-  data.tar.gz: 989463ee3ae50a4d9c543c9660c51f941dbf2a8ba60f0aee635642ef2c1b4705c35945b738421a84fc81fa6e9dcdc58d11445e34bc04b3f006dd087cf600e8d0
+  metadata.gz: 01ccabe77ade214053540011f0c57c13fde15ccd65417f932d10e0901d91f72ab38a48dcc73891eb4efb3cd7e7c877bd3e5787b84bd38cd677b42d13df989ecc
+  data.tar.gz: 332c96c6d356616a18f6c4ecb599bb18fa370ecd4038311052fd8a406f740cba29aac82d4376a0fd400bda460ee5906d34edf9dd565bf10e782e99d7b67420dc

data/README.md

@@ -1,7 +1,7 @@
 # Venetian
 
 Want stable system tests with Playwright, but don't want a Heath Robinson/Rube Goldberg setup in CI to try to keep the Ruby gem and Node
-package in sync? This gem packages a Node executable plus the common Playwright package, using builds produced by Playwright for other
+package in sync? This gem packages a Node executable plus the common Playwright package, in the same way Playwright is packaged for other
 languages.
 
 ## Installation

data/lib/venetian/executable.rb

@@ -143,12 +143,16 @@ module Venetian
         return custom_exe_path if ENV.key?(INSTALL_DIR_ENV_VAR)
 
         Upstream::NATIVE_PLATFORMS.select { |platform, _| Gem::Platform.match_gem?(Gem::Platform.new(platform), gem_name) }
-                                  .collect { |platform, _info| File.join(exe_dir, platform, "node") }
+                                  .collect { |platform, info| File.join(exe_dir, platform, info.executable_name) }
                                   .detect { |candidate| File.exist?(candidate) }
       end
 
       def custom_exe_path
-        File.join(exe_dir, "node").then { |path| path if File.exist?(path) }
+        File.join(exe_dir, custom_exe_name).then { |path| path if File.exist?(path) }
+      end
+
+      def custom_exe_name
+        Gem.win_platform? ? "node.exe" : "node"
       end
 
       def gem_platforms_unsupported?

data/lib/venetian/upstream.rb

@@ -7,26 +7,43 @@ module Venetian
   #
   # Provides platform mappings and URLs for Playwright.
   module Upstream
-    # map of gem platform strings to Playwright CDN platform strings and executable names inside the driver zip
-    NATIVE_PLATFORMS = {
-      "x86_64-linux" => "linux",
-      "aarch64-linux" => "linux-arm64",
-      "x86_64-darwin" => "mac",
-      "arm64-darwin" => "mac-arm64",
-      "x64-mingw-ucrt" => "win32_x64"
-    }.freeze
-
-    # base for driver download URLs
-    BASE_URL = "https://playwright.azureedge.net/builds/driver"
-
-    # Returns the URL to download the driver for the given platform.
-    def self.driver_download_url(playwright_platform)
-      "#{BASE_URL}/playwright-#{Playwright::COMPATIBLE_PLAYWRIGHT_VERSION}-#{playwright_platform}.zip"
+    # Describes how to assemble the Playwright driver for a single gem platform.
+    #
+    # +node_dir+:: the platform infix used in Node.js release archive names (e.g. "linux-x64")
+    # +windows+:: whether this platform's Node.js archive is a Windows build (.zip, node.exe)
+    PlatformInfo = Data.define(:node_dir, :windows) do
+      # Returns the filename of the Node executable inside the assembled driver.
+      def executable_name
+        windows ? "node.exe" : "node"
+      end
+
+      # Returns the file extension of the Node.js release archive for this platform.
+      def node_archive_extension
+        windows ? "zip" : "tar.gz"
+      end
+
+      # Returns the URL to download the Node.js release archive for the given version.
+      def node_url_for(version)
+        "#{NODE_DIST_URL}/v#{version}/node-v#{version}-#{node_dir}.#{node_archive_extension}"
+      end
     end
 
-    # Returns a hash that maps platforms to download URLs.
-    def self.download_urls
-      NATIVE_PLATFORMS.transform_values { |value| driver_download_url(value) }
+    # map of gem platform strings to Node.js release info
+    NATIVE_PLATFORMS = { "x86_64-linux" => PlatformInfo.new(node_dir: "linux-x64", windows: false),
+                         "aarch64-linux" => PlatformInfo.new(node_dir: "linux-arm64", windows: false),
+                         "x86_64-darwin" => PlatformInfo.new(node_dir: "darwin-x64", windows: false),
+                         "arm64-darwin" => PlatformInfo.new(node_dir: "darwin-arm64", windows: false),
+                         "x64-mingw-ucrt" => PlatformInfo.new(node_dir: "win-x64", windows: true) }.freeze
+
+    # base for the npm registry, source of the playwright-core package
+    NPM_REGISTRY_URL = "https://registry.npmjs.org"
+
+    # base for Node.js release downloads
+    NODE_DIST_URL = "https://nodejs.org/dist"
+
+    # Returns the URL to download the playwright-core npm package containing the driver's JS sources.
+    def self.playwright_core_url
+      "#{NPM_REGISTRY_URL}/playwright-core/-/playwright-core-#{Playwright::COMPATIBLE_PLAYWRIGHT_VERSION}.tgz"
     end
 
     # Returns the gemspec files for the base gem.

data/lib/venetian/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Venetian
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
   COMPATIBLE_PLAYWRIGHT_VERSION = "1.62.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: venetian
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Justin Malčić