vend 0.0.4 → 0.0.5

data/lib/vend/base.rb

@@ -147,6 +147,17 @@ module Vend
       false
     end
 
+    # Override this with arguments that are required on every collection
+    # request.  I.e, to default to 500 items per page:
+    #
+    #   def default_collection_request_args
+    #     super.merge(:url_params => {:page_size => 500})
+    #   end
+    #
+    def self.default_collection_request_args
+      {}
+    end
+
     # Overrides respond_to? to query the attrs hash for the key before
     # proxying it to the object
     def respond_to?(method_name)

data/lib/vend/resource/register_sale.rb

@@ -13,6 +13,10 @@ module Vend
           RegisterSaleProduct.new(sale_product_attrs)
         end
       end
+
+      def self.default_collection_request_args
+        super.merge(:url_params => {:page_size => 200})
+      end
     end
 
   end

data/lib/vend/resource_collection.rb

@@ -21,7 +21,7 @@ module Vend
       @client       = client
       @target_class = target_class
       @endpoint     = endpoint
-      @request_args = request_args
+      @request_args = target_class.default_collection_request_args.merge(request_args)
     end
 
     def each

data/lib/vend/version.rb

@@ -1,3 +1,3 @@
 module Vend #:nodoc:
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/integration/register_sale_spec.rb

@@ -19,7 +19,9 @@ describe Vend::Resource::RegisterSale do
   let(:expected_collection_length) { 1 }
 
   it_should_behave_like "a resource with a singular GET endpoint"
-  it_should_behave_like "a resource with a collection GET endpoint"
+  it_should_behave_like "a resource with a collection GET endpoint" do
+    let(:append_to_url) { '?page_size=200' }
+  end
 
   specify "register_sales are findable by state" do
     client.RegisterSale.should respond_to(:find_by_state)

data/spec/support/shared_examples/integration.rb

@@ -22,14 +22,20 @@ shared_examples "a resource with a collection GET endpoint" do
   let(:username)  {"foo"}
   let(:password)  {"bar"}
   let(:store)     {"baz"}
+  let(:append_to_url) { '' }
 
   let(:client) do
     Vend::Client.new(store, username, password)
   end
 
   it "gets the collection" do
-    stub_request(:get, "https://#{username}:#{password}@#{store}.vendhq.com/api/#{class_basename.to_s.underscore.pluralize}").
-    to_return(:status => 200, :body => get_mock_from_path(:get))
+    url = "https://%s:%s@%s.vendhq.com/api/%s%s" % [
+      username, password, store, class_basename.to_s.underscore.pluralize,
+      append_to_url
+    ]
+    stub_request(:get, url).to_return(
+      :status => 200, :body => get_mock_from_path(:get)
+    )
 
     collection = build_receiver.all
     collection.count.should == expected_collection_length

data/spec/vend/base_spec.rb

@@ -270,6 +270,11 @@ describe Vend::Base do
 
   end
 
+  describe '.default_collection_request_args' do
+    subject { Vend::Resource::Foo }
+    its(:default_collection_request_args) { should == {} }
+  end
+
   describe ".paginates?" do
 
     subject { Vend::Resource::Foo }

data/spec/vend/resource_collection_spec.rb

@@ -3,9 +3,11 @@ require 'spec_helper'
 describe Vend::ResourceCollection do
 
   let(:client)        { mock("client") }
-  let(:target_class)  { mock("target_class") }
+  let(:target_class)  {
+    mock("target_class", :default_collection_request_args => {})
+  }
   let(:endpoint)      { "endpoint" }
-  let(:request_args)  { mock("request_args") }
+  let(:request_args)  { {} }
 
   subject { described_class.new(client, target_class, endpoint, request_args) }
 
@@ -25,6 +27,14 @@ describe Vend::ResourceCollection do
       its(:request_args)  { should == {} }
     end
 
+    context "when target class has default request args" do
+      subject {
+        described_class.new(client, target_class, endpoint)
+      }
+      before { target_class.stub(:default_collection_request_args => {:foo => :bar}) }
+      its(:request_args)  { should == {:foo => :bar}}
+    end
+
   end
 
   describe "#each" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vend
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-24 00:00:00.000000000 Z
+date: 2012-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -160,7 +160,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 100082207733883280
+      hash: 2360460495322174527
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -169,7 +169,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 100082207733883280
+      hash: 2360460495322174527
 requirements: []
 rubyforge_project: vend
 rubygems_version: 1.8.24