velov 0.1.8 → 0.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 49505933cd5632137d5cda7a083c4a91c5a0ab78
-  data.tar.gz: f03b66d52400946f4c663ea3d6350e60d744ba87
+  metadata.gz: 27fccd8e49639215948efb3253d5a12b6cbb51c0
+  data.tar.gz: e0bc547822e46c11e1d34e5157c6df6bbea9d33a
 SHA512:
-  metadata.gz: a2a58f4ad7b04c9640cd7cf4919709b13affe4b2af9d63faa70acbf713753b9a020a138610e6c4dd2af374486f3afec3b8b5b65d8a159109fb76fbf3a684e7e0
-  data.tar.gz: f6f59dffed3ccbcab969df56556296ce244a5a83260e70a7efb49aca4865d6f6e9921ba1338d7daa23b0b95f26302a5c5b4ba9979f1fb7c1f1bf093a39340ba5
+  metadata.gz: ea28fd31b982735326b6aef066df67e6dd6d7e519e6132350e862339562c36e0d7f91a5a4fe99552e72379b76728da22eb0208037c35721b15e91a2ce84e1668
+  data.tar.gz: fa3aeec19b9a4c91c2c84b292f14fbadca41ddfc4750d49e823e2ffa8c5e529b8a3e3c56b8e2366cb44e7ef63773800428c6430b31b50a633271ad1fc7ef147c

data/lib/velov/api.rb

@@ -1,14 +1,14 @@
 module Velov
+  # API logic extracted into a class
   class API
     API_HOST = 'https://download.data.grandlyon.com'
-    API_ENDPOINT = "/ws/smartdata/jcd_jcdecaux.jcdvelov/all.json"
-    # DRY API Calls
+    API_ENDPOINT = '/ws/smartdata/jcd_jcdecaux.jcdvelov/all.json'
     def self.get(params = {})
       connection ||= Faraday.new API_HOST do |conn|
-        conn.response :json, :content_type => /\bjson$/
+        conn.response :json, content_type: /\bjson$/
         conn.adapter Faraday.default_adapter
       end
       connection.get API_ENDPOINT, params
     end
   end
-end
+end

data/lib/velov/station.rb

@@ -1,4 +1,5 @@
 module Velov
+  # A Velo'v station
   class Station
     include Virtus.model
 
@@ -27,7 +28,7 @@ module Velov
       @address_complement = params[Velov::ADDRESS_COMPLEMENT]
       @city = params[Velov::CITY]
       @district_number = params[Velov::DISTRICT_NUMBER].to_i
-      @bonus = params[Velov::BONUS] == "Oui"
+      @bonus = params[Velov::BONUS] == 'Oui'
       @position = params[Velov::POSITION]
       @lat = params[Velov::LATITUDE].to_f
       @lng = params[Velov::LONGITUDE].to_f
@@ -40,13 +41,17 @@ module Velov
       @last_update = DateTime.parse(params[Velov::LAST_UPDATE])
     end
 
+    # Find a bike Station.
+    #
+    # @param [Integer] station number
+    # @return [Station] Station object, nil if not found
     def self.find_by_number(number)
-      # nil if not found
-      StationList.fetch({ "field" => "number", "value" => number}).to_a.first
+      StationList.fetch('field' => 'number', 'value' => number).to_a.first
     end
 
-    def distance_to(lat,lng)
-      Geocoder::Calculations.distance_between([@lat,@lng], [lat,lng], units: :km)
+    def distance_to(lat, lng)
+      Geocoder::Calculations.distance_between([@lat, @lng], [lat, lng],
+                                              units: :km)
     end
   end
-end
+end

data/lib/velov/station_list.rb

@@ -1,9 +1,32 @@
 module Velov
+  # A Velo'v station list
   class StationList
     include Virtus.model
 
     attribute :list, Array[Station], default: []
 
+    # Fetch data of all stations
+    def self.fetch(params = {})
+      response = API.get(params)
+
+      build_list(response.body)
+    end
+
+    def self.from_json(json)
+      build_list(JSON.parse(json))
+    end
+
+    def self.build_list(data)
+      station_list = StationList.new
+
+      data['values'].each do |station_params|
+        station_list.add_station(station_params)
+      end
+
+      station_list
+    end
+    private_class_method :build_list
+
     def add_station(params)
       @list << Station.new(params)
     end
@@ -16,16 +39,9 @@ module Velov
       @list
     end
 
-    # Fetch data of all stations
-    def self.fetch(params = {})
-      response = API.get(params)
-
-      build_list(response.body)
-    end
-
-    def nearest(lat,lng)
+    def nearest(lat, lng)
       @list.sort_by do |station|
-        station.distance_to(lat,lng)
+        station.distance_to(lat, lng)
       end
     end
 
@@ -42,30 +58,14 @@ module Velov
     end
 
     def walking_distance(start, arrival)
-      start_station = self.nearest(start.first, start.last).find do |station|
-        station.status == "OPEN" and station.available_bikes > 0
+      start_station = nearest(start.first, start.last).find do |station|
+        station.status == 'OPEN' && station.available_bikes > 0
       end
-      arrival_station = self.nearest(arrival.first, arrival.last).find do |station|
-        station.status == "OPEN" and station.available_bike_stands > 0
+      arrival_station = nearest(arrival.first, arrival.last).find do |station|
+        station.status == 'OPEN' && station.available_bike_stands > 0
       end
-      start_station.distance_to(start.first, start.last) + arrival_station.distance_to(arrival.first, arrival.last)
-    end
-
-    def self.from_json(json)
-      build_list(JSON.parse(json))
+      start_station.distance_to(start.first, start.last) +
+        arrival_station.distance_to(arrival.first, arrival.last)
     end
-
-    private
-      def self.build_list(data)
-        station_list = StationList.new
-        
-        data["values"].each do |station_params|
-          station_list.add_station(station_params)
-        end
-
-        station_list
-      end
-
-
   end
-end
+end

data/lib/velov/version.rb

@@ -1,3 +1,3 @@
 module Velov
-  VERSION = "0.1.8"
+  VERSION = '0.1.10'
 end

data/lib/velov.rb

@@ -2,13 +2,12 @@ require 'virtus'
 require 'faraday'
 require 'faraday_middleware'
 require 'geocoder'
-require "velov/version"
-require "velov/api"
-require "velov/station"
-require "velov/station_list"
-
+require 'velov/version'
+require 'velov/api'
+require 'velov/station'
+require 'velov/station_list'
+# Define API Constants
 module Velov
-  # Define API Constants
   NUMBER = 0
   NAME = 1
   ADDRESS = 2

data/velov.gemspec

@@ -18,12 +18,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", '~> 1.6'
-  spec.add_development_dependency "rake" , '~> 10.3'
-  spec.add_development_dependency "rspec", '~> 2.99'
+  spec.add_development_dependency "bundler", '~> 1.9'
+  spec.add_development_dependency "rake" , '~> 10.4'
+  spec.add_development_dependency "rspec", '~> 3.2'
   spec.add_development_dependency "vcr", '~> 2.9'
-  spec.add_development_dependency "webmock", '~> 1.18'
-  spec.add_development_dependency "coveralls", '~> 0.7'
+  spec.add_development_dependency "webmock", '~> 1.21'
+  spec.add_development_dependency "coveralls", '~> 0.8'
  
   spec.add_runtime_dependency     "faraday", '~> 0.9'
   spec.add_runtime_dependency     "faraday_middleware", '~> 0.9'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: velov
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.10
 platform: ruby
 authors:
 - Pierre-Baptiste Béchu
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-07 00:00:00.000000000 Z
+date: 2015-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.9'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.3'
+        version: '10.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.3'
+        version: '10.4'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.99'
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.99'
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -72,28 +72,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.18'
+        version: '1.21'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.18'
+        version: '1.21'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -197,7 +197,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Ruby Wrapper for Velov API (Public Bike Sharing System of Lyon, France)