vanity_slug 0.0.3 → 0.0.4

data/README.md

@@ -1,6 +1,6 @@
 # VanitySlug
 
-Add unique vanity urls to any model without use of redirects. Middleware matches routes that don't resolve with the Rails router and checks if they match a slug from any vanity-slug enabled model. If found, the env["PATH_INFO"] is changed like so:
+Add unique vanity urls to any model without use of redirects. Middleware matches routes that don't resolve with the Rails router and checks if they match a slug from any vanity-slug enabled model. If found, the `env["PATH_INFO"]` is changed like so:
 
     Given a Post with slug "my-post-title" and id 1, and a Category with slug "the-category" and id 2:
 
@@ -32,7 +32,7 @@ Or install it yourself as:
   * action: route vanity slug will resolve to (default: RESTful show route i.e. "/posts/:id"). Route must be defined.
   * field_to_slug: which column to use in vanity slug generation (default: :name).
   * slug_field: which column to store generated slug (default: :slug).
-  * uniqueness_scope: method or attribute to use as uniqueness check in slug
+  * uniqueness_scope: method or attribute to use as uniqueness scope in slug
     generation (default: nil).
 
 #### Config
@@ -52,20 +52,17 @@ Use to scope the finder based on rack env, i.e. host parameter. Should return a
 
   ```ruby
     class Post < ActiveRecord::Base
-      attr_accessible :title, :site
+      attr_accesible :title
 
-      has_vanity_slug action: "/posts/:id", 
-        field_to_slug: :title, 
-        uniqueness_scope: :site_id
+      has_vanity_slug field_to_slug: :title, uniqueness_scope: :site_id
 
       belongs_to :site
     end
 
     class Category < ActiveRecord::Base
-      attr_accessible :name, :site
+      attr_accesible :name
 
-      has_vanity_slug action: "/categories/:id/slug", 
-        slug_field: :permalink
+      has_vanity_slug action: "/categories/:id/slug", slug_field: :permalink
 
       belongs_to :site
     end
@@ -79,7 +76,7 @@ Use to scope the finder based on rack env, i.e. host parameter. Should return a
 
   ```ruby
     VanitySlug.path_scope = Proc.new{|env|
-      { organization_id: Organization.find_by_host(env["HTTP_HOST"]).try(:id) }
+      { site_id: Site.find_by_domain(env["HTTP_HOST"]).try(:id) }
     }
   ```
 

data/lib/vanity_slug/active_record.rb

@@ -68,7 +68,7 @@ ActiveSupport.on_load :active_record do
               klass.slug_field => slug_to_check 
             }))
 
-            finder = finder.where("id != ?", id) if klass == self.class
+            finder = finder.where("id != ?", self.id) if klass.to_s == self.class.to_s
             finder.count > 0
           end
 

data/lib/vanity_slug/version.rb

@@ -1,3 +1,3 @@
 module VanitySlug
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/vanity_slug_spec.rb

@@ -28,21 +28,22 @@ class Site < ActiveRecord::Base
 end
 
 describe VanitySlug do
-  context "setting slugs" do
-    let(:str) { "slug me" }
-    let(:str_slugged) { "slug-me" }
+  let(:str) { "slug me" }
+  let(:str_slugged) { "slug-me" }
 
-    before do
-      @site_1 = Site.create domain: "a.com"
-      @site_2 = Site.create domain: "b.com"
+  before do
+    @site_1 = Site.create domain: "a.com"
+    @site_2 = Site.create domain: "b.com"
 
-      @post_1 = Post.create title: str, site: @site_1
-      @post_2 = Post.create title: str, site: @site_1
-      @post_3 = Post.create title: str, site: @site_2
+    @post_1 = Post.create title: str, site: @site_1
+    @post_2 = Post.create title: str, site: @site_1
+    @post_3 = Post.create title: str, site: @site_2
 
-      @category_1 = Category.create name: str, site: @site_1
-      @category_2 = Category.create name: str, site: @site_2
-    end
+    @category_1 = Category.create name: str, site: @site_1
+    @category_2 = Category.create name: str, site: @site_2
+  end
+
+  context "setting slugs" do
 
     it { @post_1.slug.should eq str_slugged }
     it { @post_2.slug.should eq str_slugged+"-1" }
@@ -80,4 +81,14 @@ describe VanitySlug do
       VanitySlug.find(env).should be_false
     end
   end
+
+  context "updating slug source column" do
+    let(:new_title) { "#{str} edit" }
+    before do
+      @post_1.update_attributes title: new_title
+    end
+
+    it { @post_1.should be_valid }
+    it { @post_1.title.should eq new_title }
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vanity_slug
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-13 00:00:00.000000000 Z
+date: 2012-12-18 00:00:00.000000000 Z
 dependencies: []
 description: root level Vanity Slug for any model
 email: