vanity 4.0.1 → 4.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dcc07c2cfd7af5205d43f6ef16a4fe4607772b99613933ef37e53bbd16062ba3
-  data.tar.gz: c2e194bc26d672eb44c692cbdd9955476844898f53c0a39cd11ff04acbcc7c46
+  metadata.gz: ea9d4e9d211abdf50a36e8d8bd1ede2d826b4d556ae52ef7537ee8f86cf3e0e8
+  data.tar.gz: 583ba00d677b13d9c27f0e5556f238f99b197614ada1a5fa3d68d1822fb1edca
 SHA512:
-  metadata.gz: 51422c6d58f2b8aa110c79737d4aead1edc2da7ed13def526880b37c730837831ae6104b695c25656cd6e9077c906ae45d06626d354e62197e3d50555f5dcec0
-  data.tar.gz: 12201f41ce6edc971928cb146cbb53c2ae09b9a61f6053ae888fa01ef180e05166836eb3f165f26adcba34f3dac523b4970593ecf7926a43d6604255afc0d8fa
+  metadata.gz: 679b3b9e5f5271b96bf57e7275edbcdd59765c0ccf80be786a71f8bfcf091dfb2d820eee1a6e3b4105ee49c462aed87ac4278f0146d5791f1923a3ecbf527ae6
+  data.tar.gz: 1a905082e51bfe15294333e43bd18b55c2c22926194b22ac7c03f74902578fcc5865c82b2cd0580d10dae0d42b3c4e7edf50a024ed996a5d846a1afe1f5b27f8

data/CHANGELOG

@@ -1,3 +1,9 @@
+CHANGELOG
+
+== 4.0.2 (2022-03-03)
+
+* Use Redis#exists? and fallback to #exists which could be either boolean or integer in recent redis gem versions (@bsedin)
+
 == 4.0.1 (2022-03-06)
 
 * Fix YAML alias support in `vanity.yml` (@frostmark)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    vanity (4.0.1)
+    vanity (4.0.2)
       i18n
 
 GEM
@@ -33,7 +33,7 @@ GEM
       execjs
     coffee-script-source (1.9.1)
     colorator (0.1)
-    concurrent-ruby (1.1.9)
+    concurrent-ruby (1.1.10)
     crack (0.3.1)
     execjs (2.5.2)
     fakefs (0.6.7)
@@ -107,8 +107,8 @@ GEM
     rb-inotify (0.9.5)
       ffi (>= 0.5.0)
     redcarpet (3.5.1)
-    redis (4.0.3)
-    redis-namespace (1.6.0)
+    redis (4.6.0)
+    redis-namespace (1.8.2)
       redis (>= 3.0.4)
     regexp_parser (2.2.1)
     rexml (3.2.5)

data/gemfiles/rails52.gemfile.lock

@@ -7,7 +7,7 @@ GIT
 PATH
   remote: ..
   specs:
-    vanity (4.0.1)
+    vanity (4.0.2)
       i18n
 
 GEM
@@ -217,8 +217,8 @@ GEM
     rb-inotify (0.9.10)
       ffi (>= 0.5.0, < 2)
     redcarpet (3.4.0)
-    redis (4.0.1)
-    redis-namespace (1.6.0)
+    redis (4.6.0)
+    redis-namespace (1.8.2)
       redis (>= 3.0.4)
     regexp_parser (2.2.1)
     rexml (3.2.5)

data/gemfiles/rails60.gemfile.lock

@@ -7,7 +7,7 @@ GIT
 PATH
   remote: ..
   specs:
-    vanity (4.0.1)
+    vanity (4.0.2)
       i18n
 
 GEM
@@ -215,8 +215,8 @@ GEM
     rb-inotify (0.9.10)
       ffi (>= 0.5.0, < 2)
     redcarpet (3.4.0)
-    redis (4.0.1)
-    redis-namespace (1.6.0)
+    redis (4.6.0)
+    redis-namespace (1.8.2)
       redis (>= 3.0.4)
     regexp_parser (2.2.1)
     rexml (3.2.5)

data/gemfiles/rails61.gemfile.lock

@@ -7,7 +7,7 @@ GIT
 PATH
   remote: ..
   specs:
-    vanity (4.0.1)
+    vanity (4.0.2)
       i18n
 
 GEM
@@ -215,8 +215,8 @@ GEM
     rb-inotify (0.9.10)
       ffi (>= 0.5.0, < 2)
     redcarpet (3.4.0)
-    redis (4.0.1)
-    redis-namespace (1.6.0)
+    redis (4.6.0)
+    redis-namespace (1.8.2)
       redis (>= 3.0.4)
     regexp_parser (2.2.1)
     rexml (3.2.5)

data/lib/vanity/adapters/redis_adapter.rb

@@ -117,7 +117,13 @@ module Vanity
 
       def is_experiment_completed?(experiment) # rubocop:todo Naming/PredicateName
         call_redis_with_failover do
-          @experiments.exists("#{experiment}:completed_at")
+          if @experiments.respond_to?(:exists?)
+            @experiments.exists?("#{experiment}:completed_at")
+          else
+            exists = @experiments.exists("#{experiment}:completed_at")
+
+            exists.is_a?(Numeric) ? exists > 0 : exists
+          end
         end
       end
 

data/lib/vanity/version.rb

@@ -1,5 +1,5 @@
 module Vanity
-  VERSION = "4.0.1"
+  VERSION = "4.0.2"
 
   module Version
     version = VERSION.to_s.split(".").map { |i| i.to_i }

data/test/adapters/redis_adapter_test.rb

@@ -62,7 +62,7 @@ describe Vanity::Adapters::RedisAdapter do
 
   it "gracefully fails in #is_experiment_completed?" do
     redis_adapter, mocked_redis = stub_redis
-    mocked_redis.stubs(:exists).raises(RuntimeError)
+    mocked_redis.stubs(:exists?).raises(RuntimeError)
 
     assert_silent do
       redis_adapter.is_experiment_completed?("price_options")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vanity
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.0.2
 platform: ruby
 authors:
 - Assaf Arkin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-03-07 00:00:00.000000000 Z
+date: 2022-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -295,7 +295,7 @@ metadata:
 post_install_message: To get started run vanity --help
 rdoc_options:
 - "--title"
-- Vanity 4.0.1
+- Vanity 4.0.2
 - "--main"
 - README.md
 - "--webcvs"