vanity 2.2.6 → 2.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 63e3e69d3a1d79cb7f36548e9b7c5a2ddf626b17
-  data.tar.gz: 645fa9b2a710b2f0b7f631747bda160aed94c9eb
+  metadata.gz: 30ab64490eb076e3145a45d198b65778073979d6
+  data.tar.gz: 318343bcd0ba889d85cef2c4a3e8cf7b95ac8d78
 SHA512:
-  metadata.gz: 1aba836ab77005465669a51695f8eb6fb01ac76841eea6cff3e5202b9c8275eb7777bf0c0dc1ff2c5f623d6e981bc161dcb8689b19f985f74a2a86bfe0c0b84e
-  data.tar.gz: 8e134db0be9cc68e9effd93170fa931bf03787cdc57bb438842ee5399aab8f549f33ca90c7afbe462da7d50bf3c2dacc7ab6a01bbf3af6506d7b0848df05c3ed
+  metadata.gz: 08ac7419f74bb5282753cf8f5303de34eea8b6bb91c9c9a2483d40d9b23475864940db3f64f27887409ff7bb98676a0c685e0847a6064f068c4402e366fe222a
+  data.tar.gz: 044f52924d4c36026360db12f36585517267ddeb3149a0858a8204c906966252144c6a9c4360aa6a03aba5aabf41ee0710e021bc026c927bac1a0b1045714b71

data/.gitignore

@@ -1,6 +1,6 @@
 vendor
 log/*
-test/dummy/db/*.sqlite3
+test/dummy/**/*.sqlite3
 test/dummy/log/*.log
 test/dummy/tmp/
 
@@ -15,4 +15,4 @@ html
 .bundle
 .rvmrc
 .ruby-version
-.ruby-gemset
+.ruby-gemset

data/CHANGELOG

@@ -1,3 +1,12 @@
+== Unreleased
+
+== 2.2.7 (2016-12-21)
+* Fix 'base 17' typo, correct id bucketing (#308, @bazzargh)
+* Update docs about `rebalance_frequency`  (#310, @sdhull)
+* Resolve Rails 5 deprecation warning for Mime::HTML (#313, @terracatta)
+* Update MockAdapter and testing using it (#316, #309 @urbanautomaton)
+* Deprecate calling #ab_seen with alternative instance (#317, @urbanautomaton)
+
 == 2.2.6 (2016-10-04)
 * Fixes for `Vanity.ab_test()` vs.  view helper `ab_test` (@phillbaker)
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    vanity (2.2.6)
+    vanity (2.2.7)
       i18n
 
 GEM

data/doc/ab_testing.textile

@@ -162,9 +162,14 @@ ab_test "noodle_test" do
   alternatives "spaghetti", "linguine"
   metrics :signup
   score_method :bayes_bandit_score
+  rebalance_frequency 100
 end
 </pre>
 
+Note: Setting the score method to `bayes_bandit_score` won't adjust alternative probabilities (ie, you won't get the benefit of maximizing conversions) unless you also set `rebalance_frequency`, which controls how many impressions must pass before rebalancing alternative probabilities.
+
+Also note that impressions count is stored in-memory and is therefore reset upon restart of your app.
+
 h3(#test).  A/B Testing and Code Testing
 
 If you're presenting more than one alternative to visitors of your site, you'll want to test more than one alternative.  Don't let A/B testing become A/broken.

data/gemfiles/rails32.gemfile.lock

@@ -7,7 +7,7 @@ GIT
 PATH
   remote: ..
   specs:
-    vanity (2.2.6)
+    vanity (2.2.7)
       i18n
 
 GEM

data/gemfiles/rails41.gemfile.lock

@@ -7,7 +7,7 @@ GIT
 PATH
   remote: .././
   specs:
-    vanity (2.2.6)
+    vanity (2.2.7)
       i18n
 
 GEM

data/gemfiles/rails42.gemfile.lock

@@ -7,7 +7,7 @@ GIT
 PATH
   remote: ..
   specs:
-    vanity (2.2.6)
+    vanity (2.2.7)
       i18n
 
 GEM

data/gemfiles/rails42_protected_attributes.gemfile.lock

@@ -7,7 +7,7 @@ GIT
 PATH
   remote: ../
   specs:
-    vanity (2.2.6)
+    vanity (2.2.7)
       i18n
 
 GEM

data/gemfiles/rails5.gemfile.lock

@@ -7,7 +7,7 @@ GIT
 PATH
   remote: ../
   specs:
-    vanity (2.2.6)
+    vanity (2.2.7)
       i18n
 
 GEM

data/lib/vanity/adapters/abstract_adapter.rb

@@ -142,6 +142,16 @@ module Vanity
         fail "Not implemented"
       end
 
+      private
+
+      def with_ab_seen_deprecation(experiment, identity, alternative)
+        if alternative.respond_to?(:id)
+          Vanity.configuration.logger.warn(%q{Deprecated: #ab_seen should be passed the alternative id, not an Alternative instance})
+          yield experiment, identity, alternative.id
+        else
+          yield experiment, identity, alternative
+        end
+      end
     end
   end
 end

data/lib/vanity/adapters/active_record_adapter.rb

@@ -255,9 +255,11 @@ module Vanity
       end
 
       # Determines if a participant already has seen this alternative in this experiment.
-      def ab_seen(experiment, identity, alternative)
-        participant = VanityParticipant.retrieve(experiment, identity, false)
-        participant && participant.seen == alternative.id
+      def ab_seen(experiment, identity, alternative_or_id)
+        with_ab_seen_deprecation(experiment, identity, alternative_or_id) do |expt, ident, alt_id|
+          participant = VanityParticipant.retrieve(expt, ident, false)
+          participant && participant.seen == alt_id
+        end
       end
 
       # Returns the participant's seen alternative in this experiment, if it exists
@@ -273,7 +275,7 @@ module Vanity
       # previously recorded as participating in this experiment.
       def ab_add_conversion(experiment, alternative, identity, count = 1, implicit = false)
         participant = VanityParticipant.retrieve(experiment, identity, false)
-        VanityParticipant.retrieve(experiment, identity, implicit, :converted => alternative)
+        VanityParticipant.retrieve(experiment, identity, implicit, :converted => alternative, :seen => alternative)
         VanityExperiment.retrieve(experiment).increment_conversion(alternative, count)
       end
 

data/lib/vanity/adapters/mock_adapter.rb

@@ -111,9 +111,7 @@ module Vanity
       end
 
       def ab_counts(experiment, alternative)
-        @experiments[experiment] ||= {}
-        @experiments[experiment][:alternatives] ||= {}
-        alt = @experiments[experiment][:alternatives][alternative] ||= {}
+        alt = alternative(experiment, alternative)
         { :participants => alt[:participants] ? alt[:participants].size : 0,
           :converted    => alt[:converted] ? alt[:converted].size : 0,
           :conversions  => alt[:conversions] || 0 }
@@ -134,17 +132,29 @@ module Vanity
       end
 
       def ab_add_participant(experiment, alternative, identity)
-        @experiments[experiment] ||= {}
-        @experiments[experiment][:alternatives] ||= {}
-        alt = @experiments[experiment][:alternatives][alternative] ||= {}
+        alt = alternative(experiment, alternative)
         alt[:participants] ||= Set.new
         alt[:participants] << identity
       end
 
+      def ab_seen(experiment, identity, alternative_or_id)
+        with_ab_seen_deprecation(experiment, identity, alternative_or_id) do |expt, ident, alt_id|
+          if ab_assigned(expt, ident) == alt_id
+            alt_id
+          end
+        end
+      end
+
+      def ab_assigned(experiment, identity)
+        alternatives_for(experiment).each do |alt_id, alt_state|
+          return alt_id if alt_state[:participants].include?(identity)
+        end
+
+        nil
+      end
+
       def ab_add_conversion(experiment, alternative, identity, count = 1, implicit = false)
-        @experiments[experiment] ||= {}
-        @experiments[experiment][:alternatives] ||= {}
-        alt = @experiments[experiment][:alternatives][alternative] ||= {}
+        alt = alternative(experiment, alternative)
         alt[:participants] ||= Set.new
         alt[:converted] ||= Set.new
         alt[:conversions] ||= 0
@@ -170,6 +180,20 @@ module Vanity
       def destroy_experiment(experiment)
         @experiments.delete experiment
       end
+
+      private
+
+      def alternative(experiment, alternative)
+        alternatives_for(experiment)[alternative] ||= {}
+        alternatives_for(experiment)[alternative]
+      end
+
+      def alternatives_for(experiment)
+        @experiments[experiment] ||= {}
+        @experiments[experiment][:alternatives] ||= {}
+
+        @experiments[experiment][:alternatives]
+      end
     end
   end
 end

data/lib/vanity/adapters/mongodb_adapter.rb

@@ -200,9 +200,11 @@ module Vanity
       end
 
       # Determines if a participant already has seen this alternative in this experiment.
-      def ab_seen(experiment, identity, alternative)
-        participant = @participants.find(:experiment=>experiment, :identity=>identity).limit(1).projection(:seen=>1).first
-        participant && participant["seen"].first == alternative.id
+      def ab_seen(experiment, identity, alternative_or_id)
+        with_ab_seen_deprecation(experiment, identity, alternative_or_id) do |expt, ident, alt_id|
+          participant = @participants.find(:experiment=>expt, :identity=>ident).limit(1).projection(:seen=>1).first
+          participant && participant["seen"].first == alt_id
+        end
       end
 
       # Returns the participant's seen alternative in this experiment, if it exists

data/lib/vanity/adapters/redis_adapter.rb

@@ -87,7 +87,7 @@ module Vanity
 
       def metric_values(metric, from, to)
         single = @metrics.mget(*(from.to_date..to.to_date).map { |date| "#{metric}:#{date}:value:0" }) || []
-        single.map { |v| [v] }
+        single.map { |v| [v.to_i] }
       end
 
       def destroy_metric(metric)
@@ -175,12 +175,14 @@ module Vanity
         end
       end
 
-      def ab_seen(experiment, identity, alternative)
-        call_redis_with_failover(experiment, identity, alternative) do
-          if @experiments.sismember "#{experiment}:alts:#{alternative.id}:participants", identity
-            alternative
-          else
-            nil
+      def ab_seen(experiment, identity, alternative_or_id)
+        with_ab_seen_deprecation(experiment, identity, alternative_or_id) do |expt, ident, alt_id|
+          call_redis_with_failover(expt, ident, alt_id) do
+            if @experiments.sismember "#{expt}:alts:#{alt_id}:participants", ident
+              alt_id
+            else
+              nil
+            end
           end
         end
       end

data/lib/vanity/connection.rb

@@ -31,7 +31,7 @@ module Vanity
     #   )
     # @since 2.0.0
     def initialize(specification=nil)
-      @specification = specification || DEFAULT_SPECIFICATION
+      @specification = Specification.new(specification || DEFAULT_SPECIFICATION).to_h
 
       if Autoconnect.playground_should_autoconnect?
         @adapter = setup_connection(@specification)
@@ -54,47 +54,59 @@ module Vanity
 
     private
 
-    def setup_connection(spec)
-      case spec
-      when String
-        spec_hash = build_specification_hash_from_url(spec)
-        establish_connection(spec_hash)
-      when Hash
-        validate_specification_hash(spec)
-        if spec[:redis]
-          establish_connection(
-            adapter: :redis,
-            redis: spec[:redis]
-          )
+    def setup_connection(specification)
+      establish_connection(specification)
+    end
+
+    def establish_connection(spec)
+      Adapters.establish_connection(spec)
+    end
+
+    class Specification
+      def initialize(spec)
+        case spec
+        when String
+          @spec = build_specification_hash_from_url(spec)
+        when Hash
+          if spec[:redis]
+            @spec = {
+              adapter: :redis,
+              redis: spec[:redis]
+            }
+          else
+            @spec = spec
+          end
         else
-          establish_connection(spec)
+          raise InvalidSpecification.new("Unsupported connection specification: #{spec.inspect}")
         end
-      else
-        raise InvalidSpecification.new("Unsupported connection specification: #{spec.inspect}")
+
+        validate_specification_hash(@spec)
       end
-    end
 
-    def build_specification_hash_from_url(connection_url)
-      uri = URI.parse(connection_url)
-      params = CGI.parse(uri.query) if uri.query
-      {
-        adapter: uri.scheme,
-        username: uri.user,
-        password: uri.password,
-        host: uri.host,
-        port: uri.port,
-        path: uri.path,
-        params: params
-      }
-    end
+      def to_h
+        @spec
+      end
 
-    def validate_specification_hash(spec)
-      all_symbol_keys = spec.keys.all? { |key| key.is_a?(Symbol) }
-      raise InvalidSpecification unless all_symbol_keys
-    end
+      private
 
-    def establish_connection(spec)
-      Adapters.establish_connection(spec)
+      def validate_specification_hash(spec)
+        all_symbol_keys = spec.keys.all? { |key| key.is_a?(Symbol) }
+        raise InvalidSpecification unless all_symbol_keys
+      end
+
+      def build_specification_hash_from_url(connection_url)
+        uri = URI.parse(connection_url)
+        params = CGI.parse(uri.query) if uri.query
+        {
+          adapter: uri.scheme,
+          username: uri.user,
+          password: uri.password,
+          host: uri.host,
+          port: uri.port,
+          path: uri.path,
+          params: params
+        }
+      end
     end
   end
-end
+end

data/lib/vanity/experiment/ab_test.rb

@@ -610,7 +610,7 @@ module Vanity
           end
         end
 
-        Digest::MD5.hexdigest("#{name}/#{identity}").to_i(17) % @alternatives.size
+        Digest::MD5.hexdigest("#{name}/#{identity}").to_i(16) % @alternatives.size
       end
 
       # Saves the assignment of an alternative to a person and performs the
@@ -635,7 +635,7 @@ module Vanity
         # if we have an on_assignment block, call it on new assignments
         if defined?(@on_assignment_block) && @on_assignment_block
           assignment = alternatives[index]
-          if !connection.ab_seen @id, identity, assignment
+          if !connection.ab_seen @id, identity, index
             @on_assignment_block.call(Vanity.context, identity, assignment, self)
           end
         end

data/lib/vanity/frameworks/rails.rb

@@ -348,7 +348,7 @@ module Vanity
     # Step 3: Open your browser to http://localhost:3000/vanity
     module Dashboard
       def index
-        render :file=>Vanity.template("_report"),:content_type=>Mime::HTML, :locals=>{
+        render :file=>Vanity.template("_report"),:content_type=>Mime[:html], :locals=>{
           :experiments=>Vanity.playground.experiments,
           :experiments_persisted=>Vanity.playground.experiments_persisted?,
           :metrics=>Vanity.playground.metrics
@@ -356,7 +356,7 @@ module Vanity
       end
 
       def participant
-        render :file=>Vanity.template("_participant"), :locals=>{:participant_id => params[:id], :participant_info => Vanity.playground.participant_info(params[:id])}, :content_type=>Mime::HTML
+        render :file=>Vanity.template("_participant"), :locals=>{:participant_id => params[:id], :participant_info => Vanity.playground.participant_info(params[:id])}, :content_type=>Mime[:html]
       end
 
       def complete

data/lib/vanity/version.rb

@@ -1,5 +1,5 @@
 module Vanity
-  VERSION = "2.2.6"
+  VERSION = "2.2.7"
 
   module Version
     version = VERSION.to_s.split(".").map { |i| i.to_i }

data/test/adapters/active_record_adapter_test.rb

@@ -0,0 +1,19 @@
+require "test_helper"
+require 'vanity/adapters/active_record_adapter'
+require 'adapters/shared_tests'
+
+describe Vanity::Adapters::ActiveRecordAdapter do
+
+  def specification
+    Vanity::Connection::Specification.new(VanityTestHelpers::DATABASE_OPTIONS["active_record"])
+  end
+
+  def adapter
+    Vanity::Adapters::ActiveRecordAdapter.new(specification.to_h)
+  end
+
+  if ENV["DB"] == "active_record"
+    include Vanity::Adapters::SharedTests
+  end
+
+end

data/test/adapters/mock_adapter_test.rb

@@ -0,0 +1,16 @@
+require 'test_helper'
+require 'adapters/shared_tests'
+
+describe Vanity::Adapters::MockAdapter do
+
+  def specification
+    Vanity::Connection::Specification.new(VanityTestHelpers::DATABASE_OPTIONS["mock"])
+  end
+
+  def adapter
+    Vanity::Adapters::MockAdapter.new({})
+  end
+
+  include Vanity::Adapters::SharedTests
+
+end

data/test/adapters/mongodb_adapter_test.rb

@@ -0,0 +1,19 @@
+require "test_helper"
+require 'vanity/adapters/mongodb_adapter'
+require 'adapters/shared_tests'
+
+describe Vanity::Adapters::MongodbAdapter do
+
+  def specification
+    Vanity::Connection::Specification.new(VanityTestHelpers::DATABASE_OPTIONS["mongodb"])
+  end
+
+  def adapter
+    Vanity::Adapters::MongodbAdapter.new(specification.to_h)
+  end
+
+  if ENV["DB"] == "mongodb"
+    include Vanity::Adapters::SharedTests
+  end
+
+end

data/test/adapters/redis_adapter_test.rb

@@ -1,4 +1,6 @@
 require "test_helper"
+require 'vanity/adapters/redis_adapter'
+require 'adapters/shared_tests'
 
 describe Vanity::Adapters::RedisAdapter do
   before do
@@ -6,6 +8,16 @@ describe Vanity::Adapters::RedisAdapter do
     require "redis/namespace"
   end
 
+  def specification
+    Vanity::Connection::Specification.new(VanityTestHelpers::DATABASE_OPTIONS["redis"])
+  end
+
+  def adapter
+    Vanity::Adapters::RedisAdapter.new(specification.to_h)
+  end
+
+  include Vanity::Adapters::SharedTests
+
   it "warns on disconnect error" do
     if defined?(Redis)
       assert_silent do

data/test/adapters/shared_tests.rb

@@ -0,0 +1,336 @@
+require 'time'
+
+module Vanity::Adapters::SharedTests
+
+  DummyAlternative = Struct.new(:id)
+
+  def identity
+    'test-identity'
+  end
+
+  def experiment
+    :experiment
+  end
+
+  def alternative
+    1
+  end
+
+  def metric_name
+    :purchases
+  end
+
+  def run_experiment
+    @subject.ab_add_participant(experiment, alternative, identity)
+    @subject.ab_add_participant(experiment, alternative, 'other-identity')
+    @subject.ab_add_conversion(experiment, alternative, identity, 2)
+  end
+
+  def self.included(base)
+    base.instance_eval do
+      before do
+        @subject = adapter
+        @subject.flushdb
+
+        metric "purchases"
+
+        new_ab_test "experiment" do
+          alternatives :control, :test
+          default :control
+          metrics :purchases
+        end
+      end
+
+      describe 'metrics methods' do
+        describe '#get_metric_last_update_at' do
+          it 'is nil if the metric has never been tracked' do
+            refute(@subject.get_metric_last_update_at(metric_name))
+          end
+
+          it 'returns the time of the last tracked event if present' do
+            time = Time.now
+            @subject.metric_track(metric_name, time, identity, [1])
+
+            assert_in_delta(
+              time,
+              @subject.get_metric_last_update_at(metric_name),
+              1.0
+            )
+          end
+        end
+
+        describe '#metric_values' do
+          it 'returns the tracked metrics from the given range, binned by date' do
+            time_1 = Time.iso8601("2016-01-01T00:00:00+00:00")
+            time_2 = Time.iso8601("2016-01-01T12:00:00+00:00")
+            time_3 = Time.iso8601("2016-01-02T00:00:00+00:00")
+            time_4 = Time.iso8601("2016-01-02T12:00:00+00:00")
+            time_5 = Time.iso8601("2016-01-03T12:00:00+00:00")
+
+            @subject.metric_track(metric_name, time_1, identity, [1])
+            @subject.metric_track(metric_name, time_2, identity, [2])
+            @subject.metric_track(metric_name, time_3, identity, [4])
+            @subject.metric_track(metric_name, time_4, identity, [8])
+            @subject.metric_track(metric_name, time_5, identity, [16])
+
+            assert_equal(
+              [[3], [12]],
+              @subject.metric_values(metric_name, time_1, time_4)
+            )
+          end
+        end
+
+        describe '#destroy_metric' do
+          it 'removes all data related to the metric' do
+            @subject.metric_track(metric_name, Time.now, identity, [1])
+
+            @subject.destroy_metric(metric_name)
+
+            refute(@subject.get_metric_last_update_at(metric_name))
+          end
+        end
+      end
+
+      describe 'generic experiment methods' do
+        describe '#experiment_persisted?' do
+          it 'returns false if the experiment is unknown' do
+            refute(@subject.experiment_persisted?("other_experiment"))
+          end
+
+          it 'returns true if the experiment has been created' do
+            @subject.set_experiment_created_at("other_experiment", Time.now)
+
+            assert(@subject.experiment_persisted?("other_experiment"))
+          end
+        end
+
+        describe '#set_experiment_created_at' do
+          it 'sets the experiment creation date' do
+            time = Time.now
+            @subject.set_experiment_created_at(experiment, time)
+
+            assert_in_delta(
+              time,
+              @subject.get_experiment_created_at(experiment),
+              1.0
+            )
+          end
+        end
+
+        describe '#destroy_experiment' do
+          it 'removes all information about the experiment' do
+            run_experiment
+            @subject.destroy_experiment(experiment)
+
+            refute(@subject.experiment_persisted?(experiment))
+          end
+        end
+
+        describe '#is_experiment_enabled?' do
+          def with_experiments_start_enabled(enabled)
+            begin
+              original_value = Vanity.configuration.experiments_start_enabled
+              Vanity.configuration.experiments_start_enabled = enabled
+              yield
+            ensure
+              Vanity.configuration.experiments_start_enabled = original_value
+            end
+          end
+
+          describe 'when experiments start enabled' do
+            it 'is true when the enabled value is unset' do
+              with_experiments_start_enabled(true) do
+                assert(@subject.is_experiment_enabled?("other_experiment"))
+              end
+            end
+
+            it 'is false when the enabled value is set to false' do
+              with_experiments_start_enabled(true) do
+                @subject.set_experiment_enabled("other_experiment", false)
+
+                refute(@subject.is_experiment_enabled?("other_experiment"))
+              end
+            end
+          end
+
+          describe 'when experiments do not start enabled' do
+            it 'is false when the enabled value is unset' do
+              with_experiments_start_enabled(false) do
+                refute(@subject.is_experiment_enabled?("other_experiment"))
+              end
+            end
+
+            it 'is true when the enabled value is set to true' do
+              with_experiments_start_enabled(false) do
+                @subject.set_experiment_enabled("other_experiment", true)
+
+                assert(@subject.is_experiment_enabled?("other_experiment"))
+              end
+            end
+          end
+        end
+
+        describe '#is_experiment_completed?' do
+          it 'is true if the completion date is set' do
+            @subject.set_experiment_completed_at(experiment, Time.now)
+
+            assert(@subject.is_experiment_completed?(experiment))
+          end
+
+          it 'is false if the completion date is unset' do
+            refute(@subject.is_experiment_completed?(experiment))
+          end
+        end
+      end
+
+      describe 'A/B test methods' do
+        describe '#ab_add_conversion' do
+          it 'adds the participant and the conversion when implicit=true' do
+            @subject.ab_add_conversion(experiment, alternative, identity, 1, true)
+
+            assert_equal(
+              {:participants => 1, :conversions => 1, :converted => 1},
+              @subject.ab_counts(experiment, alternative)
+            )
+          end
+        end
+
+        describe '#ab_add_participant' do
+          it 'adds the participant to the specified alternative' do
+            @subject.ab_add_participant(experiment, alternative, identity)
+
+            assert_equal(
+              {:participants => 1, :conversions => 0, :converted => 0},
+              @subject.ab_counts(experiment, alternative)
+            )
+          end
+        end
+
+        describe '#ab_seen' do
+          describe 'called with an Alternative instance' do
+            def capture_logs
+              require 'stringio'
+              original_logger = Vanity.configuration.logger
+              log_output = StringIO.new
+              Vanity.configuration.logger = Logger.new(log_output)
+              yield
+              log_output.string
+            ensure
+              Vanity.configuration.logger = original_logger
+            end
+
+            before do
+              @alternative_instance = DummyAlternative.new(alternative)
+            end
+
+            it 'emits a deprecation warning' do
+              @subject.ab_add_participant(experiment, alternative, identity)
+
+              out = capture_logs do
+                @subject.ab_seen(experiment, identity, @alternative_instance)
+              end
+
+              assert_match(/Deprecated/, out)
+            end
+
+            it 'returns a truthy value if the identity is assigned to the alternative' do
+              @subject.ab_add_participant(experiment, alternative, identity)
+
+              assert(@subject.ab_seen(experiment, identity, @alternative_instance))
+            end
+
+            it 'returns a falsey value if the identity is not assigned to the alternative' do
+              @subject.ab_add_participant(experiment, alternative, identity)
+
+              refute(@subject.ab_seen(experiment, identity, DummyAlternative.new(2)))
+            end
+          end
+
+          describe 'called with an alternative id' do
+            it 'returns a truthy value if the identity is assigned to the alternative' do
+              @subject.ab_add_participant(experiment, alternative, identity)
+
+              assert(@subject.ab_seen(experiment, identity, alternative))
+            end
+
+            it 'returns a falsey value if the identity is not assigned to the alternative' do
+              @subject.ab_add_participant(experiment, alternative, identity)
+
+              refute(@subject.ab_seen(experiment, identity, 2))
+            end
+          end
+        end
+
+        describe '#ab_assigned' do
+          it 'returns the assigned alternative if present' do
+            @subject.ab_add_participant(experiment, alternative, identity)
+
+            assert_equal(
+              alternative,
+              @subject.ab_assigned(experiment, identity)
+            )
+          end
+
+          it 'returns nil if the identity has no assignment' do
+            assert_equal(
+              nil,
+              @subject.ab_assigned(experiment, identity)
+            )
+          end
+        end
+
+        describe '#ab_counts' do
+          it 'returns the counts of participants, conversions and converted for the alternative' do
+            run_experiment
+
+            assert_equal(
+              {:participants => 2, :conversions => 2, :converted => 1},
+              @subject.ab_counts(experiment, alternative)
+            )
+          end
+        end
+
+        describe '#ab_get_outcome' do
+          it 'returns the outcome if one is set' do
+            @subject.ab_set_outcome(experiment, alternative)
+
+            assert_equal(
+              alternative,
+              @subject.ab_get_outcome(experiment)
+            )
+          end
+
+          it 'returns nil otherwise' do
+            assert_equal(
+              nil,
+              @subject.ab_get_outcome(experiment)
+            )
+          end
+        end
+
+        describe '#ab_show' do
+          it 'forces an alternative to be shown to the given identity' do
+            @subject.ab_show(experiment, identity, alternative)
+
+            assert_equal(
+              alternative,
+              @subject.ab_showing(experiment, identity)
+            )
+          end
+        end
+
+        describe '#ab_not_showing' do
+          it 'cancels a previously-set showing alternative' do
+            @subject.ab_show(experiment, identity, alternative)
+            @subject.ab_not_showing(experiment, identity)
+
+            assert_equal(
+              nil,
+              @subject.ab_showing(experiment, identity)
+            )
+          end
+        end
+      end
+    end
+  end
+end

data/test/test_helper.rb

@@ -43,12 +43,14 @@ module VanityTestHelpers
   # We go destructive on the database at the end of each run, so make sure we
   # don't use databases you care about. For Redis, we pick database 15
   # (default is 0).
-  DATABASE = {
+  DATABASE_OPTIONS = {
     "redis" => "redis://localhost/15",
     "mongodb" => "mongodb://localhost/vanity",
     "active_record" =>  { :adapter => "active_record", :active_record_adapter =>"default" },
     "mock" => "mock:/"
-  }[ENV["DB"]] or raise "No support yet for #{ENV["DB"]}"
+  }
+
+  DATABASE = DATABASE_OPTIONS[ENV["DB"]] or raise "No support yet for #{ENV["DB"]}"
 
   TEST_DATA_FILES = Dir[File.expand_path("../data/*",  __FILE__)]
   VANITY_CONFIGS = TEST_DATA_FILES.each.with_object({}) do |path, hash|

data/test/vanity_test.rb

@@ -108,12 +108,16 @@ describe Vanity do
           f.write(connection_config)
         end
 
-        Vanity.reset!
-        Vanity.disconnect!
-        Vanity::Connection.stubs(:new)
-        Vanity.connect!
+        out, _err = capture_io do
+          Vanity.reset!
+          Vanity.configuration.logger = Logger.new($stdout)
+          Vanity.disconnect!
+          Vanity::Connection.stubs(:new)
+          Vanity.connect!
+        end
 
         assert_equal false, Vanity.configuration.collecting
+        assert_match(/Deprecated/, out)
       end
     end
   end
@@ -178,4 +182,4 @@ describe Vanity do
       refute_same original_configuration, Vanity.reload!
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vanity
 version: !ruby/object:Gem::Version
-  version: 2.2.6
+  version: 2.2.7
 platform: ruby
 authors:
 - Assaf Arkin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-04 00:00:00.000000000 Z
+date: 2016-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -224,7 +224,11 @@ files:
 - lib/vanity/templates/vanity.js
 - lib/vanity/vanity.rb
 - lib/vanity/version.rb
+- test/adapters/active_record_adapter_test.rb
+- test/adapters/mock_adapter_test.rb
+- test/adapters/mongodb_adapter_test.rb
 - test/adapters/redis_adapter_test.rb
+- test/adapters/shared_tests.rb
 - test/autoconnect_test.rb
 - test/cli_test.rb
 - test/commands/report_test.rb
@@ -286,7 +290,7 @@ metadata: {}
 post_install_message: To get started run vanity --help
 rdoc_options:
 - "--title"
-- Vanity 2.2.6
+- Vanity 2.2.7
 - "--main"
 - README.md
 - "--webcvs"
@@ -310,7 +314,11 @@ signing_key:
 specification_version: 4
 summary: Experience Driven Development framework for Ruby
 test_files:
+- test/adapters/active_record_adapter_test.rb
+- test/adapters/mock_adapter_test.rb
+- test/adapters/mongodb_adapter_test.rb
 - test/adapters/redis_adapter_test.rb
+- test/adapters/shared_tests.rb
 - test/autoconnect_test.rb
 - test/cli_test.rb
 - test/commands/report_test.rb