valvat 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9b64b4bcee899d80f3c9205b541eeaf7123df7560e47528368bedc0e06d85f85
-  data.tar.gz: 31f18a7bf075a71c719002e3b34dd4a057da7ba85aeaf7283385d7ffc98f7dcb
+  metadata.gz: 6c35eea0081e4df97219ee215ea3321c8add02bc130c5b28488f1dca676765dc
+  data.tar.gz: 4ba7b89f223d26d1ac9d967944d6c2e0dbea74c3c6066f1d69d0e2f42ba204c8
 SHA512:
-  metadata.gz: 2b419833c23922a653f932995541e25300a8897529cd3bfdea2078de762f5829451e35c1a658510cfbd64978f0f6165471d1331e1673d381ef5c0ecd6ca6380a
-  data.tar.gz: e595829c058d7b2b89a644b779c4ea95c66eb9d416e395a4b32cf4d28f73bcb717f55c720fe51dd8d027092c94ae04b3c094cd1e7fbf1fe95d833330851a37d5
+  metadata.gz: ab9623bd1d680546ca7978751b6536b626d2d5cb9ae35240b5152d4e7c9512e99e025481bf0a844254e6ad14d3f1f320dbf54ab6901387e354b7682c45cb3c3c
+  data.tar.gz: 79a69d5d148b86282f609d66bf053a1b14d4bd86621d7277a5f17d1d1df6c6fd5c9731cff4eca8c8bb9dde9f1265eef7ea03c60d2d66876b0f255d97a9596a6b

checksums.yaml.gz.sig

@@ -1,4 +1,4 @@
-Y���ހ�"$K>
-�K�����-|�Vh#�g��H�h��v�X����28����p@�u�@�Pk�P	�n��1�k�8��k��Y	�月x�c��a�g�
-�'z18�9�Z-�[��^Vb[6�6��-�=j�{�8�m�J̰l�u�vN��N���[T��/x���eg�e���&ݔpr 9���tk��		*�0�5�-�V���t�ݾH&�K�|�2�G�$d4���0��h���C{�Ct�C��<���:�����&z6%��(Ƒ�ZC.J���fIy���uZ���ި �De��wyOa�͖_�V���ԷD\���}n��u���1DN�>�tó
-l(�N��O�6qY��T߳��9c��jK6��
+p���:��:�Bӻ�7���-�8���A1��
+�L��W3,��Z��@\��ϳbć�P,DJ�������X���ݧ�8Ըҋ�L�$s�8��o�?>��K��""J��C͒8�W����δ����!��6Ϝ3����&n�qP�P�u�W��������D�<&S��������d#Z��K���n��Y+Jw�`r;I&=�Ў'丌X<��
�ws�˶�
+mk��c�k��qk�rh$��:C����ZIƈ�
�Y��@���׼�/U�
+���&s��W

data/CHANGES.md

@@ -1,7 +1,15 @@
 
 ### dev
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.9.1...master)
+[full changelog](http://github.com/yolk/valvat/compare/v1.0.1...master)
+
+### 1.0.1 / 2020-12-06
+
+[full changelog](http://github.com/yolk/valvat/compare/v1.0.0...v1.0.1)
+
+* Added missing spaces to malformatted portuegese locale file
+* Removed GB from EU_COUNTRIES / EU_MEMBER_STATES but kept support
+* Fixed typo in error message: UNK(N)OWN (by [Igor Gonchar](https://github.com/gigorok))
 
 ### 1.0.0 / 2020-11-06
 

data/README.md

@@ -5,6 +5,10 @@ valvat
 
 Validates european vat numbers. Standalone or as a ActiveModel validator.
 
+## A note on Brexit
+
+Valvat supports validating VAT-IDs from the UK by syntax & checksum for now. Validation against the VIES web service will probably stop working (and return `false`) in 2021.
+
 ## Features
 
 * Simple syntax verification
@@ -201,7 +205,7 @@ To allow vat numbers from outside of europe, add something like this to your mod
       validates :vat_number, valvat: true, if: :eu?
 
       def eu?
-        Valvat::Utils::EU_COUNTRIES.include?(country_code)
+        Valvat::Utils::EU_MEMBER_STATES.include?(country_code)
       end
     end
 

data/certs/yolk.pem

@@ -1,25 +1,25 @@
 -----BEGIN CERTIFICATE-----
 MIIELDCCApSgAwIBAgIBATANBgkqhkiG9w0BAQsFADAgMR4wHAYDVQQDDBVzZWJh
-c3RpYW4vREM9eW8vREM9bGswHhcNMTkxMTE1MTIzMzUwWhcNMjAxMTE0MTIzMzUw
+c3RpYW4vREM9eW8vREM9bGswHhcNMjEwMTA2MTAzMDU3WhcNMjIwMTA2MTAzMDU3
 WjAgMR4wHAYDVQQDDBVzZWJhc3RpYW4vREM9eW8vREM9bGswggGiMA0GCSqGSIb3
-DQEBAQUAA4IBjwAwggGKAoIBgQC96oQ16N6R0H69fWFfsfHo2oIJHtLgETPK6ly+
-tLeznJsZomCkZgFS0wNwnExr9qlH+AmygvNoaniVq/Pp2+2jwMuLgk5hkZMRM8Rf
-i3wp5LCbW4BysT1rURQoqfo4iH8d60WgUl2Ggou70RMGlizvgvGOfszxfRTkuNXd
-Eisbzs3UTKIWdx/umzHW4hbfbZcJ89cXoRLbxPjzozCfXPymmimlyva3Tu3QrxNH
-/IBdzni9qj6gctmTYgWHMwzRJz+yJBY7V3G7jss/3vWaAoOhLns5bJUAXOvNsR4D
-sWE5676q+Hi8Ti7B7AvWhqxB+9HSevjNrK+fNV7GFNRtbPW6o6vzYjPhtsdjluzP
-94UA2AC6rjxtzNgzaXtQHZAnBjCf6ayoqbizh++SHU7J+tdoyxHjSfKPfdIW0P7Z
-W5npDb+b2kGTa6cclciBpRqyZWVz0CIgi06k+GuxgroQVf7465CEjyh2krQqGXtt
-A7d8gWiKsxpZgOjh5wFmFT97h8MCAwEAAaNxMG8wCQYDVR0TBAIwADALBgNVHQ8E
-BAMCBLAwHQYDVR0OBBYEFOGxpUkCn17xMxFtmn/CFk5W57s6MBoGA1UdEQQTMBGB
+DQEBAQUAA4IBjwAwggGKAoIBgQC1KB7VOGa6pr926eaL2xCrnbnTxadpjq+6JoFj
+6rvDpmgD8wkdfU7aFTwBiEK9JKzhqCoW86Rt/8wOrEJRMXz1QBbpMBSrubtMB+0/
+N59hKPLwgBkhbxY7BwGnujxnTICgiGzkhjlgBe/MisoabfK5Tn84GWVk5e0/LUp1
+qTRkSgcaDlnKs2/dAUo1lXHa13TJeemgz76TYx4p4J2w7VGh7WS2ax5SNWKw+J+q
+HVSHT2Chc+a7As2cJyU/r2jX0oqSfvyg09CmF0inUBykeiuB9aeP/Me29hvg13/D
+r1gaQ3/Vyfuqjs8lrwIZCWLU607g5q3+UM884WWpvApsZwzajNM2+9l5jay7Dnan
+m05PcDtMYbPHiMyvuN9Vp4YIRqSBXP/DPGMnIYXbpzAQgtZymPQ8I3k8doj9q4+E
+2Cf+x/nqvF09r/+gJj4ybzNW23zU6mhZ+xzBTDWrWBDetz+Y3wdbU5X6j08jLuEg
+mMHmtgFdr/4VQxeaon7kHPR3DUsCAwEAAaNxMG8wCQYDVR0TBAIwADALBgNVHQ8E
+BAMCBLAwHQYDVR0OBBYEFG8VE8+yijOldghb3w0MpSQnrslxMBoGA1UdEQQTMBGB
 D3NlYmFzdGlhbkB5by5sazAaBgNVHRIEEzARgQ9zZWJhc3RpYW5AeW8ubGswDQYJ
-KoZIhvcNAQELBQADggGBAEDGrRAAvS7w793sYSoE8VAt45pw71zio2BgdcpYRoHB
-rdaghjIVg77lybTmKdRGPM1T9m4zL01xddrqpgQFflVLmd/JVfEHwkLfJzZKvpy+
-1vxgdIHhXkBB9G/X+LZC3PtMQx4f6BYIyf4kiVrTSWiKeeftFsH1tdvU5oYR7Gzy
-dugPR09J0oVA/DiLlzfUy9o2meH8QyCGX8c0LHY8gx4C4orZz+FIFZczZB1FUOeu
-LjR/yNUh7bYqwVHTQL5sajfQMFyt8HotazwdBvUETXGZW3VQZymR99gcMjr/H4xg
-mPEildrYsY7glEKryCc2YDYC1ahqWshnpOLqAXatonsoDBXpVKl+HGsUnrnCiaxh
-ctN4at+sy0CqPL+zXqp14b34rO0lP6hf0l+/LnuM96ImE+Rw+3gPX2iOtqivhrfM
-rAFNAD1QEGN6elQdy1MRuXwjcUhM8P8ofLDEaE225TSZvAI+XoCxW2PSsQj5cGER
-9vbf6JSKzQPa/HeBoU0s1Q==
------END CERTIFICATE-----
+KoZIhvcNAQELBQADggGBAIky67U9hnB8d4qMKwXHGb3Ne7JLvEigtEhjqGlDVecb
+C94vQ8Jg7lYB3kKVjvFN2drptq/JUpxmAxPQIqfx39gKcKyv0BjkroVFE8MS1324
+khMOZFOoSPMd9pkpm7oJ1M+sCYcUM+tPKnU8Ojq6r9j5b5XrbxG8YSpwahva3Vap
+1g0+3KzuWPpFjFen1VbS/Sb1cyE5uQtUj7lVcdhF3EFvzXkUMUUtJ4xsk114znFO
+986sKab5AjlJ7TnsmPphCv/UXans7rAVB2lnozlt/kw6dcct5JD4kz1tD6AmO5Qd
+jWRuKNZs66GBglRvseKoypXz1XDCCu1m/uI1IGmKnq8Ry+IeRq9RnlvbfPvSxRIx
+9aowoL79T9plhcEcEX/KYRp8ht1z+3Vyk2UVZP8Xl5x+K44co5xdhljYi1gtw0w8
+KzzULF0bF9oNpXwBEamlH2myNb19u1W8ijobQ7Y19ca8UFHr5LI32ZW5Zlmep8je
+vb+o07oLRx3t2T/EO4DZ1w==
+-----END CERTIFICATE-----

data/lib/valvat/error.rb

@@ -2,7 +2,7 @@ class Valvat
   Error = Class.new(RuntimeError)
 
   class ViesError < Error
-    def initialize(faultstring='UNKOWN')
+    def initialize(faultstring='UNKNOWN')
       @faultstring = faultstring
     end
 
@@ -25,4 +25,4 @@ class Valvat
   RateLimitError = Class.new(ViesError)
 
   UnknownViesError = Class.new(ViesError)
-end
+end

data/lib/valvat/local.rb

@@ -22,8 +22,9 @@ class Valvat
     Valvat::Utils.vat_country_to_iso_country(vat_country_code)
   end
 
+  # TODO: Remove method / not in use
   def european?
-    Valvat::Utils::EU_COUNTRIES.include?(iso_country_code)
+    Valvat::Utils::EU_MEMBER_STATES.include?(iso_country_code)
   end
 
   def to_a

data/lib/valvat/locales/pt.yml

@@ -4,31 +4,31 @@ pt:
       invalid_vat: O NIF %{country_adjective} não é válido.
   valvat:
     country_adjectives:
-    eu: europeu
-    at: austríaco
-    be: belga
-    bg: búlgaro
-    cy: cipriota
-    cz: checo
-    de: alemão
-    dk: dinamarquês
-    ee: estónio
-    es: espanhol
-    fi: finlandês
-    fr: francês
-    gb: britânico
-    gr: grego
-    hu: húngaro
-    ie: irlandês
-    it: italiano
-    lt: lituano
-    lu: luxemburguês
-    lv: letão
-    mt: maltês
-    nl: holandês
-    pl: polaco
-    pt: português
-    ro: romeno
-    se: sueco
-    si: esloveno
-    sk: eslovaco
+      eu: europeu
+      at: austríaco
+      be: belga
+      bg: búlgaro
+      cy: cipriota
+      cz: checo
+      de: alemão
+      dk: dinamarquês
+      ee: estónio
+      es: espanhol
+      fi: finlandês
+      fr: francês
+      gb: britânico
+      gr: grego
+      hu: húngaro
+      ie: irlandês
+      it: italiano
+      lt: lituano
+      lu: luxemburguês
+      lv: letão
+      mt: maltês
+      nl: holandês
+      pl: polaco
+      pt: português
+      ro: romeno
+      se: sueco
+      si: esloveno
+      sk: eslovaco

data/lib/valvat/utils.rb

@@ -1,7 +1,11 @@
+require 'date'
+
 class Valvat
   module Utils
 
-    EU_COUNTRIES = %w(AT BE BG CY CZ DE DK EE ES FI FR GB GR HR HU IE IT LT LU LV MT NL PL PT RO SE SI SK)
+    EU_MEMBER_STATES = %w(AT BE BG CY CZ DE DK EE ES FI FR GR HR HU IE IT LT LU LV MT NL PL PT RO SE SI SK)
+    SUPPORTED_STATES = EU_MEMBER_STATES + %w(GB)
+    EU_COUNTRIES = EU_MEMBER_STATES # TODO: Remove constant
     COUNTRY_PATTERN = /\A([A-Z]{2})(.+)\Z/
     NORMALIZE_PATTERN = /[[:space:][:punct:][:cntrl:]]+/
 
@@ -9,7 +13,7 @@ class Valvat
       COUNTRY_PATTERN =~ vat
       result = [$1, $2]
       iso_country = vat_country_to_iso_country(result[0])
-      EU_COUNTRIES.include?(iso_country) ? result : [nil, nil]
+      country_is_supported?(iso_country) ? result : [nil, nil]
     end
 
     def self.normalize(vat)
@@ -23,5 +27,9 @@ class Valvat
     def self.iso_country_to_vat_country(iso_country)
       iso_country == "GR" ? "EL" : iso_country
     end
+
+    def self.country_is_supported?(iso_country)
+      SUPPORTED_STATES.include?(iso_country)
+    end
   end
 end

data/lib/valvat/version.rb

@@ -1,3 +1,3 @@
 class Valvat
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/spec/active_model/validations/valvat_validator_spec.rb

@@ -42,6 +42,10 @@ if defined?(ActiveModel)
   end
 
   describe Invoice do
+    before do
+      I18n.locale = :en
+    end
+
     context "with valid VAT number" do
       it "should be valid" do
         expect(Invoice.new(vat_number: "DE259597697")).to be_valid
@@ -60,6 +64,28 @@ if defined?(ActiveModel)
         expect(invoice.errors[:vat_number]).to eql(["is not a valid German VAT number"])
       end
 
+      context "on DE locale" do
+        before do
+          I18n.locale = :de
+        end
+
+        it "should add translated error message" do
+          invoice.valid?
+          expect(invoice.errors[:vat_number]).to eql(["ist keine gültige deutsche USt-IdNr."])
+        end
+      end
+
+      context "on PT locale" do
+        before do
+          I18n.locale = :pt
+        end
+
+        it "should add translated error message" do
+          invoice.valid?
+          expect(invoice.errors[:vat_number]).to eql(["O NIF alemão não é válido."])
+        end
+      end
+
       context "with i18n translation in place" do
         before do
           I18n.backend.store_translations(:en, activemodel: {

data/spec/valvat/utils_spec.rb

@@ -59,7 +59,7 @@ describe Valvat::Utils do
       expect(Valvat::Utils.vat_country_to_iso_country("EL")).to eql("GR")
     end
 
-    Valvat::Utils::EU_COUNTRIES.each do |iso|
+    Valvat::Utils::EU_MEMBER_STATES.each do |iso|
       it "returns unchanged iso country code '#{iso}'" do
         expect(Valvat::Utils.vat_country_to_iso_country(iso)).to eql(iso)
       end
@@ -71,9 +71,27 @@ describe Valvat::Utils do
       expect(Valvat::Utils.iso_country_to_vat_country("GR")).to eql("EL")
     end
 
-    Valvat::Utils::EU_COUNTRIES.reject{|c| c == "GR"}.each do |c|
+    Valvat::Utils::EU_MEMBER_STATES.each do |c|
       it "returns unchanged VAT country code '#{c}'" do
         expect(Valvat::Utils.iso_country_to_vat_country(c)).to eql(c)
+      end unless c == "GR"
+    end
+  end
+
+  describe "#country_is_supported?" do
+    Valvat::Utils::EU_MEMBER_STATES.each do |code|
+      it "returns true on #{code}" do
+        expect(Valvat::Utils.country_is_supported?(code)).to eql(true)
+      end
+    end
+
+    it "returns true on GB" do
+      expect(Valvat::Utils.country_is_supported?("GB")).to eql(true)
+    end
+
+    ["US", "AE", "CA", "CN", "BR", "AU", "NO", "ML"].each do |code|
+      it "returns false on #{code}" do
+        expect(Valvat::Utils.country_is_supported?(code)).to eql(false)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: valvat
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Sebastian Munz
@@ -11,30 +11,30 @@ cert_chain:
 - |
   -----BEGIN CERTIFICATE-----
   MIIELDCCApSgAwIBAgIBATANBgkqhkiG9w0BAQsFADAgMR4wHAYDVQQDDBVzZWJh
-  c3RpYW4vREM9eW8vREM9bGswHhcNMTkxMTE1MTIzMzUwWhcNMjAxMTE0MTIzMzUw
+  c3RpYW4vREM9eW8vREM9bGswHhcNMjEwMTA2MTAzMDU3WhcNMjIwMTA2MTAzMDU3
   WjAgMR4wHAYDVQQDDBVzZWJhc3RpYW4vREM9eW8vREM9bGswggGiMA0GCSqGSIb3
-  DQEBAQUAA4IBjwAwggGKAoIBgQC96oQ16N6R0H69fWFfsfHo2oIJHtLgETPK6ly+
-  tLeznJsZomCkZgFS0wNwnExr9qlH+AmygvNoaniVq/Pp2+2jwMuLgk5hkZMRM8Rf
-  i3wp5LCbW4BysT1rURQoqfo4iH8d60WgUl2Ggou70RMGlizvgvGOfszxfRTkuNXd
-  Eisbzs3UTKIWdx/umzHW4hbfbZcJ89cXoRLbxPjzozCfXPymmimlyva3Tu3QrxNH
-  /IBdzni9qj6gctmTYgWHMwzRJz+yJBY7V3G7jss/3vWaAoOhLns5bJUAXOvNsR4D
-  sWE5676q+Hi8Ti7B7AvWhqxB+9HSevjNrK+fNV7GFNRtbPW6o6vzYjPhtsdjluzP
-  94UA2AC6rjxtzNgzaXtQHZAnBjCf6ayoqbizh++SHU7J+tdoyxHjSfKPfdIW0P7Z
-  W5npDb+b2kGTa6cclciBpRqyZWVz0CIgi06k+GuxgroQVf7465CEjyh2krQqGXtt
-  A7d8gWiKsxpZgOjh5wFmFT97h8MCAwEAAaNxMG8wCQYDVR0TBAIwADALBgNVHQ8E
-  BAMCBLAwHQYDVR0OBBYEFOGxpUkCn17xMxFtmn/CFk5W57s6MBoGA1UdEQQTMBGB
+  DQEBAQUAA4IBjwAwggGKAoIBgQC1KB7VOGa6pr926eaL2xCrnbnTxadpjq+6JoFj
+  6rvDpmgD8wkdfU7aFTwBiEK9JKzhqCoW86Rt/8wOrEJRMXz1QBbpMBSrubtMB+0/
+  N59hKPLwgBkhbxY7BwGnujxnTICgiGzkhjlgBe/MisoabfK5Tn84GWVk5e0/LUp1
+  qTRkSgcaDlnKs2/dAUo1lXHa13TJeemgz76TYx4p4J2w7VGh7WS2ax5SNWKw+J+q
+  HVSHT2Chc+a7As2cJyU/r2jX0oqSfvyg09CmF0inUBykeiuB9aeP/Me29hvg13/D
+  r1gaQ3/Vyfuqjs8lrwIZCWLU607g5q3+UM884WWpvApsZwzajNM2+9l5jay7Dnan
+  m05PcDtMYbPHiMyvuN9Vp4YIRqSBXP/DPGMnIYXbpzAQgtZymPQ8I3k8doj9q4+E
+  2Cf+x/nqvF09r/+gJj4ybzNW23zU6mhZ+xzBTDWrWBDetz+Y3wdbU5X6j08jLuEg
+  mMHmtgFdr/4VQxeaon7kHPR3DUsCAwEAAaNxMG8wCQYDVR0TBAIwADALBgNVHQ8E
+  BAMCBLAwHQYDVR0OBBYEFG8VE8+yijOldghb3w0MpSQnrslxMBoGA1UdEQQTMBGB
   D3NlYmFzdGlhbkB5by5sazAaBgNVHRIEEzARgQ9zZWJhc3RpYW5AeW8ubGswDQYJ
-  KoZIhvcNAQELBQADggGBAEDGrRAAvS7w793sYSoE8VAt45pw71zio2BgdcpYRoHB
-  rdaghjIVg77lybTmKdRGPM1T9m4zL01xddrqpgQFflVLmd/JVfEHwkLfJzZKvpy+
-  1vxgdIHhXkBB9G/X+LZC3PtMQx4f6BYIyf4kiVrTSWiKeeftFsH1tdvU5oYR7Gzy
-  dugPR09J0oVA/DiLlzfUy9o2meH8QyCGX8c0LHY8gx4C4orZz+FIFZczZB1FUOeu
-  LjR/yNUh7bYqwVHTQL5sajfQMFyt8HotazwdBvUETXGZW3VQZymR99gcMjr/H4xg
-  mPEildrYsY7glEKryCc2YDYC1ahqWshnpOLqAXatonsoDBXpVKl+HGsUnrnCiaxh
-  ctN4at+sy0CqPL+zXqp14b34rO0lP6hf0l+/LnuM96ImE+Rw+3gPX2iOtqivhrfM
-  rAFNAD1QEGN6elQdy1MRuXwjcUhM8P8ofLDEaE225TSZvAI+XoCxW2PSsQj5cGER
-  9vbf6JSKzQPa/HeBoU0s1Q==
+  KoZIhvcNAQELBQADggGBAIky67U9hnB8d4qMKwXHGb3Ne7JLvEigtEhjqGlDVecb
+  C94vQ8Jg7lYB3kKVjvFN2drptq/JUpxmAxPQIqfx39gKcKyv0BjkroVFE8MS1324
+  khMOZFOoSPMd9pkpm7oJ1M+sCYcUM+tPKnU8Ojq6r9j5b5XrbxG8YSpwahva3Vap
+  1g0+3KzuWPpFjFen1VbS/Sb1cyE5uQtUj7lVcdhF3EFvzXkUMUUtJ4xsk114znFO
+  986sKab5AjlJ7TnsmPphCv/UXans7rAVB2lnozlt/kw6dcct5JD4kz1tD6AmO5Qd
+  jWRuKNZs66GBglRvseKoypXz1XDCCu1m/uI1IGmKnq8Ry+IeRq9RnlvbfPvSxRIx
+  9aowoL79T9plhcEcEX/KYRp8ht1z+3Vyk2UVZP8Xl5x+K44co5xdhljYi1gtw0w8
+  KzzULF0bF9oNpXwBEamlH2myNb19u1W8ijobQ7Y19ca8UFHr5LI32ZW5Zlmep8je
+  vb+o07oLRx3t2T/EO4DZ1w==
   -----END CERTIFICATE-----
-date: 2020-11-06 00:00:00.000000000 Z
+date: 2021-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon