valvat 0.4.2 → 0.4.3

data/CHANGES.md

@@ -1,10 +1,16 @@
 ### dev
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.4.2...master)
+[full changelog](http://github.com/yolk/valvat/compare/v0.4.3...master)
 
 ### 0.4.2 / 2012-11-16
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.4,1...v0.4.2)
+[full changelog](http://github.com/yolk/valvat/compare/v0.4.2...v0.4.3)
+
+* Fixed error handling in Lookup (by [bmurzeau](https://github.com/bmurzeau))
+
+### 0.4.2 / 2012-11-16
+
+[full changelog](http://github.com/yolk/valvat/compare/v0.4.1...v0.4.2)
 
 * Fixed usage with savon version 1.2
 * Require version 1.2 of the savon gem from now on
@@ -12,53 +18,53 @@
 
 ### 0.4.1 / 2012-07-17
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.4,0...v0.4.1)
+[full changelog](http://github.com/yolk/valvat/compare/v0.4.0...v0.4.1)
 
 * Fixed issue with current savon version & required more recent savon version
 
 ### 0.4.0 / 2012-07-17
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.3,6...v0.4.0)
+[full changelog](http://github.com/yolk/valvat/compare/v0.3.6...v0.4.0)
 
 * Added support for company details and requester identifiers in successful responses
-(by [lcx](https://github.com/lcx)) 
-* Added Valvat::Lookup.last_error for debugging 
+(by [lcx](https://github.com/lcx))
+* Added Valvat::Lookup.last_error for debugging
 
 ### 0.3.6 / 2012-04-10
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.3,5...v0.3.6)
+[full changelog](http://github.com/yolk/valvat/compare/v0.3.5...v0.3.6)
 
 * Fixed wrong regexp for Belgium numbers (by [opsidao](https://github.com/opsidao))
 
 ### 0.3.5 / 2012-02-02
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.3,4...v0.3.5)
+[full changelog](http://github.com/yolk/valvat/compare/v0.3.4...v0.3.5)
 
 * Swedish translation (by [henrik](https://github.com/henrik))
 * English fixes (by [henrik](https://github.com/henrik))
 
 ### 0.3.4 / 2011-08-01
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.3,3...v0.3.4)
+[full changelog](http://github.com/yolk/valvat/compare/v0.3.3...v0.3.4)
 
 * Normalize all input on initialization (by [SpoBo](https://github.com/SpoBo))
 
 ### 0.3.3 / 2011-06-02
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.3,2...v0.3.3)
+[full changelog](http://github.com/yolk/valvat/compare/v0.3.2...v0.3.3)
 
 * Add Valvat::Utils.iso_country_to_vat_country (by [Deb Bassett](https://github.com/urbanwide))
 
 ### 0.3.2 / 2011-01-14
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.3,1...v0.3.2)
+[full changelog](http://github.com/yolk/valvat/compare/v0.3.1...v0.3.2)
 
 * Fixed localization strings (en/de)
 * Moved locales folder to lib/valvat/locales
 
 ### 0.3.1 / 2011-01-12
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.3,0...v0.3.1)
+[full changelog](http://github.com/yolk/valvat/compare/v0.3.0...v0.3.1)
 
 * ActiveModel validation: Failed validations with _match_country_ now use error message with country from given attribute
 * ActiveModel validation: Failed validations with _match_country_ skip lookup and syntax checks

data/README.md

@@ -10,7 +10,7 @@ Validates european vat numbers. Standalone or as a ActiveModel validator.
 * Works standalone without ActiveModel
 * I18n locales for country specific error messages
 
-valvat is tested and works with ruby 1.8.7/1.9.2 and ActiveModel 3.0.
+valvat is tested and works with ruby 1.8.7/1.9.3 and ActiveModel 3.2.9
 
 ## Installation
 
@@ -22,12 +22,12 @@ To verify the syntax of a vat number:
 
     Valvat.new("DE345789003").valid?
     => true or false
-  
+
 To check if the given vat number exists via the VIES web service:
 
     Valvat.new("DE345789003").exists?
     => true or false or nil
-  
+
 *IMPORTANT* Keep in mind that the VIES web service might be offline at some time for some countries. If this happens `exists?` or `Valvat::Lookup.validate` will return `nil`.
 
 Visit [http://ec.europa.eu/taxation_customs/vies/viesspec.do](http://ec.europa.eu/taxation_customs/vies/viesspec.do) for more accurate information at what time the service for a specific country will be down.
@@ -36,47 +36,47 @@ It is also possible to bypass initializing a Valvat instance and check the synta
 
     Valvat::Syntax.validate("DE345789003")
     => true or false
-  
+
 Or to lookup a vat number string directly via VIES web service:
 
     Valvat::Lookup.validate("DE345789003")
     => true or false or nil
-    
+
 ## Details & request identifier
 
 If you need all details and not only if the VAT is valid, pass {:detail => true} as second parameter to the lookup call.
 
     Valvat.new("IE6388047V").exists?(:detail => true)
     => {
-      :country_code=>"IE", :vat_number => "6388047V", 
-      :request_date => Date.today, :name=>"GOOGLE IRELAND LIMITED", 
+      :country_code=>"IE", :vat_number => "6388047V",
+      :request_date => Date.today, :name=>"GOOGLE IRELAND LIMITED",
       :address=>"1ST & 2ND FLOOR ,GORDON HOUSE ,BARROW STREET ,DUBLIN 4"
     } or false or nil
-    
+
 According to EU law, or at least as Austria sees it, it's mandatory to verify the UID number of every new customer, but also to check the UID Number periodicaly. To prove that you have checked the UID number, the VIES Web service can return a requestIdentifier.
 
 To receive a requestIdentifier you need to pass your own VAT number in the options hash. In this Example, Google (VAT IE6388047V) is checking the validity of eBays VAT number (LU21416127)
 
     Valvat.new("LU21416127").exists?(:my_vat => "IE6388047V")
     => {
-      :country_code=>"LU", :vat_number => "21416127", 
-      :request_date => Date.today, :name=>"EBAY EUROPE S.A R.L.", 
+      :country_code=>"LU", :vat_number => "21416127",
+      :request_date => Date.today, :name=>"EBAY EUROPE S.A R.L.",
       :address => "22, BOULEVARD ROYAL\nL-2449  LUXEMBOURG",
       :company_type => nil, :request_identifier => "some_uniq_string"
     } or false or nil
 
-## ActiveModel/Rails3 Usage
+## Usage with ActiveModel / Rails 3
 
 ### Loading
 
 When the valvat gem is required and ActiveModel is already loaded, everything will work fine out of the box. If your load order differs just add
 
     require 'valvat/active_model'
-  
+
 after ActiveModel has been loaded.
 
 ### Simple syntax validation
-  
+
 To validate the attribute `vat_number` add this to your model:
 
     class MyModel < ActiveRecord::Base
@@ -84,18 +84,18 @@ To validate the attribute `vat_number` add this to your model:
     end
 
 ### Additional lookup validation
-  
+
 To additionally perform a lookup via VIES:
 
     validates :vat_number, :valvat => {:lookup => true}
-  
+
 By default this will validate to true if the VIES web service is down. To fail in this case simply add the `:fail_if_down` option:
 
     validates :vat_number, :valvat => {:lookup => :fail_if_down}
 
 ### Additional ISO country code validation
 
-If you want the vat number’s (ISO) country to match another country attribute, use the _match_country_ option: 
+If you want the vat number’s (ISO) country to match another country attribute, use the _match_country_ option:
 
     validates :vat_number, :valvat => {:match_country => :country}
 
@@ -108,36 +108,36 @@ By default blank vat numbers validate to false. To change this add the `:allow_b
     validates :vat_number, :valvat => {:allow_blank => true}
 
 ### Allow vat numbers outside of europe
-  
+
 To allow vat numbers from outside of europe, add something like this to your model (country_code should return a upcase ISO country code):
 
     class MyModel < ActiveRecord::Base
       validates :vat_number, :valvat => true, :if => :eu?
-      
+
       def eu?
         Valvat::Utils::EU_COUNTRIES.include?(country_code)
       end
     end
-    
+
 ## Utilities
 
 To split a vat number into the country code and the remaining chars:
 
     Valvat::Utils.split("ATU345789003")
     => ["AT", "U345789003"]
-    
+
 or
 
     Valvat.new("ATU345789003").to_a
     => ["AT", "U345789003"]
-  
+
 Both methods always return an array. If it can not detect the country or the given country is located outside of europe it returns `[nil, nil]`. Please note that this does not strictly return the ISO country code: for greek vat numbers this returns the ISO language code 'EL' instead of the ISO country code 'GR'.
 
 To extract the ISO country code of a given vat number:
 
     Valvat.new("EL7345789003").iso_country_code
     => "GR"
-  
+
 To extract the vat country code (first two chars in every european vat number):
 
     Valvat.new("EL7345789003").vat_country_code
@@ -147,7 +147,7 @@ To normalize a vat number:
 
     Valvat::Utils.normalize("atu345789003")
     => "ATU345789003"
-  
+
 This basically just removes trailing spaces and ensures all chars are uppercase.
 
 ## Links
@@ -166,6 +166,6 @@ This basically just removes trailing spaces and ensures all chars are uppercase.
 
 ## BlaBla
 
-Copyright (c) 2011 Yolk Sebastian Munz & Julia Soergel GbR
+Copyright (c) 2011-2012 Yolk Sebastian Munz & Julia Soergel GbR
 
 Beyond that, the implementation is licensed under the MIT License.

data/lib/valvat/lookup.rb

@@ -18,7 +18,7 @@ class Valvat
         response[:valid] && (options[:detail] || options[:requester_vat]) ?
           filter_detail(response) : response[:valid]
       rescue => err
-        if err.respond_to?(:to_hash) && err.to_hash[:fault] && e(rr.to_hash[:fault][:faultstring] || "").upcase =~ /INVALID_INPUT/
+        if err.respond_to?(:to_hash) && err.to_hash[:fault] && (err.to_hash[:fault][:faultstring] || "").upcase =~ /INVALID_INPUT/
           return false
         end
         raise err if options[:raise_error]

data/lib/valvat/version.rb

@@ -1,3 +1,3 @@
 class Valvat
-  VERSION = "0.4.2"
+  VERSION = "0.4.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: valvat
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-16 00:00:00.000000000 Z
+date: 2012-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon