values 1.0.1 → 1.1.0

data/README.md

@@ -16,8 +16,14 @@ These mostly look like classes created using Struct, but fix two problems with t
 Values fixes both of these:
     Point = Value.new(:x, :y)
     Point.new(1)
-    => SOME EXCEPTION
+    => ArgumentError: wrong number of arguments, 1 for 2
+    from /Users/tcrayford/Projects/ruby/values/lib/values.rb:7:in `block (2 levels) in new
+    from (irb):5:in new
+    from (irb):5
+    from /usr/local/bin/irb:12:in `<main>
 
     p = Point.new(1,2)
     p.x = 1
-    => SOME EXCEPTION
+    => NoMethodError: undefined method x= for #<Point:0x00000100943788 @x=0, @y=1>
+    from (irb):6
+    from /usr/local/bin/irb:12:in <main>

data/VERSION

@@ -1 +1 @@
-1.0.1
+1.1.0

data/lib/values.rb

@@ -8,8 +8,30 @@ class Value
         fields.each_with_index do |field, index|
           instance_variable_set('@' + field.to_s, input_fields[index])
         end
+        @__fields = fields
         self.freeze
       end
+
+      def ==(other)
+        self.eql?(other)
+      end
+
+      def eql?(other)
+        return false if other.class != self.class
+        result = true
+        @__fields.each do |field|
+          result = result && self.send(field) == other.send(field)
+        end
+        return result
+      end
+
+      def hash
+        result = 0
+        @__fields.each do |field|
+          result += field.hash
+        end
+        return result + self.class.hash
+      end
     end
   end
 end

data/spec/values_spec.rb

@@ -49,4 +49,25 @@ describe 'values' do
     m = Money.new(1, 'USD')
     lambda {m.instance_variable_set('@amount',2)}.should raise_error
   end
+
+  describe '#hash and equality' do
+    Y = Value.new(:x, :y)
+
+    it 'is equal to another value with the same fields' do
+      Point.new(0,0).should == Point.new(0,0)
+    end
+
+    it 'is not equal to an object with a different class' do
+      Point.new(0,0).should_not == Y.new(0,0)
+    end
+
+    it 'has an equal hash if the fields are equal' do
+      p = Point.new(0,0)
+      p.hash.should == Point.new(0,0).hash
+    end
+
+    it 'does not have an equal hash if the class is different' do
+      Point.new(0,0).hash.should_not == Y.new(0,0).hash
+    end
+  end
 end

data/values.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{values}
-  s.version = "1.0.1"
+  s.version = "1.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Tom Crayford"]

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 1
-  - 0
   - 1
-  version: 1.0.1
+  - 0
+  version: 1.1.0
 platform: ruby
 authors: 
 - Tom Crayford
@@ -111,7 +111,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -580871131718748459
+      hash: 2901597111501063009
       segments: 
       - 0
       version: "0"