value_semantics 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36400a694002cc8c879dfbad099d365e2674edf63ad258794094e2bb41f894da
-  data.tar.gz: f8f67ee234971124bcb65e487d59ed3126c8f51406b1bc4cc9d93eb1d70a5262
+  metadata.gz: 0d5af9c70cace0213a309865f7fb2eaf09759d3f654d530d577d9067ee8e025d
+  data.tar.gz: 31ef2d58e797173040691bc6ac57703751102c40519c8bcd4913f6fa24e97481
 SHA512:
-  metadata.gz: 9d8becb2999466ceb24b0c9e6139ab089a64f019304c8803e6412e6a4818965dac59c601fc65f950c7e29cd5f4e27895a37e677baac6054e554e4fe749f2b5a6
-  data.tar.gz: 67d37d2f3fe4f07a6c54fdec2546e3a2b2e12ee92b1aa69a914382fee08ad9b0a2bfc00948e38f1b17b1608a6247763e507e255640add73c0ea0a3c5d6bac9b0
+  metadata.gz: 051b338a932d31e4e74a2699bd45a9a740e7fe8673f8833e566254c4be8262f90947160784db895d1706c40a8f910db21ea0999a90a3df6d65481dd60932a626
+  data.tar.gz: 8860483b155c84402fc6964967b29ba1cef4f6a1b46409752b714d139c78625b02d0bcf184a4eb671bb2b94c4b4442938fcacec32e07f854f934e2defb87e811

data/.travis.yml

@@ -3,7 +3,7 @@ rvm:
   - 2.3.7
   - 2.4.4
   - 2.5.1
-script: bundle exec rspec
+script: bin/mutation_test.sh
 deploy:
   provider: rubygems
   on:

data/README.md

@@ -1,4 +1,6 @@
+[![Gem Version](https://badge.fury.io/rb/value_semantics.svg)](https://badge.fury.io/rb/value_semantics)
 [![Build Status](https://travis-ci.org/tomdalling/value_semantics.svg?branch=master)](https://travis-ci.org/tomdalling/value_semantics)
+![Mutation Coverage](https://img.shields.io/badge/mutation%20coverage-100%25-brightgreen.svg)
 
 ValueSemantics
 ==============

data/bin/mutation_test.sh

@@ -0,0 +1,6 @@
+#!/bin/sh
+set -ue
+
+PATTERN=${1:-ValueSemantics*}
+
+bundle exec mutant --include lib --require value_semantics --use rspec "$PATTERN"

data/lib/value_semantics.rb

@@ -1,23 +1,23 @@
 module ValueSemantics
   def self.for_attributes(&block)
     attributes = DSL.run(&block)
-    generate_module(attributes)
+    generate_module(attributes.freeze)
   end
 
   def self.generate_module(attributes)
-    Module.new.tap do |m|
+    Module.new do
       # include all the instance methods
-      m.include(Semantics)
+      include(Semantics)
 
       # define the attr readers
       attributes.each do |attr|
-        m.module_eval("def #{attr.name}; #{attr.instance_variable}; end")
+        module_eval("def #{attr.name}; #{attr.instance_variable}; end")
       end
 
       # define BaseClass.attributes class method
-      m.const_set(:ATTRIBUTES__, attributes)
-      m.define_singleton_method(:included) do |base|
-        base.const_set(:ValueSemantics_Generated, m)
+      const_set(:ATTRIBUTES__, attributes)
+      def self.included(base)
+        base.const_set(:ValueSemantics_Generated, self)
         class << base
           def attributes
             self::ATTRIBUTES__
@@ -54,7 +54,7 @@ module ValueSemantics
     end
 
     def ==(other)
-      (other.is_a?(self.class) || is_a?(other.class)) && other.to_h == to_h
+      (other.is_a?(self.class) || is_a?(other.class)) && other.to_h.eql?(to_h)
     end
 
     def eql?(other)
@@ -75,7 +75,7 @@ module ValueSemantics
   end
 
   class Attribute
-    attr_reader :name, :has_default, :default_value
+    attr_reader :name, :has_default, :default_value, :validator
 
     def initialize(name:, has_default:, default_value:, validator:)
       @name = name.to_sym
@@ -120,7 +120,7 @@ module ValueSemantics
     end
 
     def validate?(value)
-      !!(@validator === value)
+      validator === value
     end
 
     def instance_variable
@@ -163,26 +163,26 @@ module ValueSemantics
       ArrayOf.new(element_validator)
     end
 
-    def declare_attribute(attr_name, validator=Anything, default: NOT_SPECIFIED)
+    def def_attr(attr_name, validator=Anything, default: NOT_SPECIFIED)
       __attributes << Attribute.new(
         name: attr_name,
-        has_default: default != NOT_SPECIFIED,
+        has_default: !(NOT_SPECIFIED.equal?(default)),
         default_value: default,
         validator: validator,
       )
     end
 
-    def method_missing(name, *args, &block)
+    def method_missing(name, *args)
       if respond_to_missing?(name)
-        declare_attribute(name, *args, &block)
+        def_attr(name, *args)
       else
         super
       end
     end
 
-    def respond_to_missing?(method_name, include_private = false)
-      first_letter = method_name.to_s[0]
-      (first_letter == first_letter.downcase) || super
+    def respond_to_missing?(method_name, _include_private=nil)
+      first_letter = method_name[0]
+      first_letter.eql?(first_letter.downcase)
     end
   end
 
@@ -190,12 +190,12 @@ module ValueSemantics
     extend self
 
     def ===(value)
-      true.eql?(value) || false.eql?(value)
+      true.equal?(value) || false.equal?(value)
     end
   end
 
   module Anything
-    def self.===(value)
+    def self.===(_)
       true
     end
   end

data/lib/value_semantics/version.rb

@@ -1,3 +1,3 @@
 module ValueSemantics
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/value_semantics.gemspec

@@ -29,7 +29,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.15"
   spec.add_development_dependency "rspec", "~> 3.7.0"
-  #spec.add_development_dependency "mutant-rspec"
+  spec.add_development_dependency "mutant-rspec"
   spec.add_development_dependency "byebug"
   spec.add_development_dependency "gem-release"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: value_semantics
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Tom Dalling
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-09-04 00:00:00.000000000 Z
+date: 2018-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.7.0
+- !ruby/object:Gem::Dependency
+  name: mutant-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -83,6 +97,7 @@ files:
 - LICENSE.txt
 - README.md
 - bin/console
+- bin/mutation_test.sh
 - bin/setup
 - lib/value_semantics.rb
 - lib/value_semantics/version.rb