value_object-ruby 1.1.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d9fc7f483875f6696ab2d7c7b3ce6e9d56d5128c
-  data.tar.gz: 95da1a8a7ea68c15737b1fb35abbd9e63cc5a185
+  metadata.gz: c3c57b81e95b17456845c98c47e46139419b2e7f
+  data.tar.gz: 36668d890f197b9d17d32258126ec8ed1d00e04b
 SHA512:
-  metadata.gz: 02568a1247cd0da8c2814c61c295ac4079803a38f4eab52075adc2101826fb809dc82b54720798ca67903ea009602e6c7c0988b5995fce158968fd02252080b1
-  data.tar.gz: 0c2f4a9973d8a95a99e0cd571a08cacd6c6a60cbb6e4e45fad5f2591236c44730c09585143331161d581208d1a23440fec9245be4da23911d7eba013b48c5526
+  metadata.gz: 7296c54efeb28c7edf1438916f41103ae786860ef07856783decec84b0e15b3e77807c1d1b466ae270760828aff88cbc9b262c8a4223c03f558538bfa45d1925
+  data.tar.gz: 3d236b5aa11ced5065e42578f68949a97f1a46a34aba8e8dedcf64bda0ce0f2a3e16525801b58bfedac108da18bf91a82f2e2403ea6cb6c539aacb2622fdda8c

data/README.md

@@ -32,7 +32,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-1. Fork it ( https://github.com/[my-github-username]/value_object/fork )
+1. Fork it ( https://github.com/xjunior/value_object/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/lib/value_object.rb

@@ -1,4 +1,5 @@
-require "value_object/version"
-require "value_object/base"
-require "value_object/attribute"
-require "value_object/errors"
+require 'value_object/version'
+require 'value_object/dsl'
+require 'value_object/base'
+require 'value_object/attribute'
+require 'value_object/errors'

data/lib/value_object/attribute.rb

@@ -5,15 +5,15 @@ module ValueObject
     end
 
     module ClassMethods
-      def value_attribute(name, klass)
-        id_attr = "#{name}_id"
+      def value_attribute(attr_name, klass)
+        id_attr = "#{attr_name}_id"
 
-        define_method name do
+        define_method attr_name do
           klass.find self.public_send(id_attr)
         end
 
-        define_method "#{name}=" do |obj|
-          self.public_send("#{id_attr}=", obj.id)
+        define_method "#{attr_name}=" do |obj|
+          self.public_send("#{id_attr}=", obj.key)
         end
       end
     end

data/lib/value_object/base.rb

@@ -1,26 +1,12 @@
 module ValueObject
-  class Base < Struct.new(:name, :id)
-    class << self
-      def find(id)
-        return unless id
-        all.find {|v| v.id.to_s.eql?(id.to_s)} || raise(ValueObject::InvalidValue, "#{self.name} with id #{id} not found")
-      end
+  # Rubocop wants me to document you
+  class Base
+    extend ::ValueObject::DSL
 
-      attr_accessor :all
+    attr_reader :key
 
-      protected
-
-      def value(name, id, *args)
-        object = new(name, id, *args)
-        define_value_getter object
-
-        @all ||= []
-        @all << object
-      end
-
-      def define_value_getter(object)
-        define_singleton_method(object.name) { object }
-      end
+    def initialize(key)
+      @key = key
     end
   end
 end

data/lib/value_object/dsl.rb

@@ -0,0 +1,31 @@
+module ValueObject
+  module DSL
+    def find(key)
+      return unless key
+      object = all.find { |v| v.key.to_s.eql?(key.to_s) }
+      object || raise_invalid_value(key)
+    end
+
+    attr_accessor :all
+
+    protected
+
+    def value(*args)
+      object = new(*args)
+      define_value_getter object
+
+      @all ||= []
+      @all << object
+    end
+
+    private
+
+    def define_value_getter(object)
+      define_singleton_method(object.key) { object }
+    end
+
+    def raise_invalid_value(key)
+      raise(ValueObject::InvalidValue, "#{self} #{key} not found")
+    end
+  end
+end

data/lib/value_object/errors.rb

@@ -1,4 +1,4 @@
 module ValueObject
-  class InvalidValue < defined?(ActiveRecord::RecordNotFound) ? ActiveRecord::RecordNotFound : StandardError
+  class InvalidValue < StandardError
   end
 end

data/lib/value_object/i18n.rb

@@ -3,7 +3,7 @@ require 'i18n'
 module ValueObject
   module I18n
     def name_s
-      ::I18n.t(self.name, scope: [:value_objects, self.class.name.to_sym], default: self.name)
+      ::I18n.t(self.key, scope: [:value_objects, self.class.name.to_sym], default: self.key)
     end
   end
 end

data/lib/value_object/version.rb

@@ -1,3 +1,3 @@
 module ValueObject
-  VERSION = "1.1.0"
+  VERSION = "2.0.1"
 end

data/value_object.gemspec

@@ -25,4 +25,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.9"
   spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "pry", "~> 0.10"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: value_object-ruby
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Carlos Palhares
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-06-24 00:00:00.000000000 Z
+date: 2016-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
 description: ValueObjects compliant with most ruby ORM, allowing a class to have a
   relation with a value object in similarly to any other relation
 email:
@@ -59,6 +73,7 @@ files:
 - lib/value_object.rb
 - lib/value_object/attribute.rb
 - lib/value_object/base.rb
+- lib/value_object/dsl.rb
 - lib/value_object/errors.rb
 - lib/value_object/i18n.rb
 - lib/value_object/version.rb
@@ -83,7 +98,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: ValueObjects compliant with most ruby ORM