valle 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7c0c148d64fc0b076b0575401d9c4918333fb7b8
-  data.tar.gz: 94db8d353ef331cd637eba7186e2509ab021035f
+  metadata.gz: 03548fc5db23ebbefcdbfd0215fd6b770b37ae5b
+  data.tar.gz: c5254b2a714721e09610e9f7b958a00f61813a3b
 SHA512:
-  metadata.gz: bb10fe590b5426ed77e95da67aabd3800379a6d3afc2c625f22a48c08e3e6b91c1ad9787e84b15d4f6da1a1dd38f2314332320dbc1a5e2c26d92840ee9bec0d0
-  data.tar.gz: feb65d2c8e597d4623f35e72735f886318ba3a17cf18ec2aa7b5b58d2be315cca52f4c66d722372a5a3d2ac392036fdd9bb04b80d8450c1f7ce7e6a5679ffabb
+  metadata.gz: 79dcc9f84474cd7578106b21aad7c6533cfb13e526867d14a5846307ccfcf7f2bf511c98f71a892da3e5666dae71dac882d28d0cd334850f016120c352d3a84a
+  data.tar.gz: ab8ec2d290146f03dfd7e1a139ecc7e75d3ee02c4944487fdb344050526d2fb54b6ef4ff2516ca3dd689eb3af77b3895e2c0759ae78ee73423f4cfc54629fd71

data/.dockerignore

@@ -0,0 +1,2 @@
+pkg/
+temp/

data/.travis.yml

@@ -1,8 +1,21 @@
-language: ruby
+sudo: false
+
 rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1.0
+  - 2.3.0
+  - ruby-head
+  - rbx-2
+  - jruby-head
+
+matrix:
+  allow_failures:
+    - rvm: ruby-head
+    - rvm: rbx-2
+    - rvm: jruby-head
+  fast_finish: true
+
 branches:
   only:
     - master
+
+before_install:
+  - gem update bundler

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.1.0 / 2016-03-18
+
+* fixed #23: issue with config.chache_classes=true [a.nikishin]
+
 ## 1.0.1 / 2014-07-22
 
 * fix has_and_belongs_to_many causes Model to crash on initialization (#18) [Anton Kalyaev]

data/Dockerfile

@@ -0,0 +1,13 @@
+FROM ruby:latest
+
+# fixes cucumber bug where it cannot find bundler
+RUN gem install bundler --no-ri --no-rdoc
+
+RUN mkdir -p /usr/src/lib
+WORKDIR /usr/src/lib
+
+COPY Gemfile* /usr/src/lib/
+COPY *.gemspec /usr/src/lib/
+RUN bundle install
+
+COPY . /usr/src/lib/

data/Gemfile

@@ -6,10 +6,10 @@ gemspec
 gem 'rake'
 
 group :test do
-  gem 'rails', '~> 4.1.0'
+  gem 'rails', '~> 4.2.6'
 
   gem 'minitest', '~> 5'
   gem 'minitest-reporters'
-  gem 'cucumber'
-  gem 'aruba'
+  gem 'cucumber', '~> 2.3.2'
+  gem 'aruba', '~> 0.14.1'
 end

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012 - 2014 Anton Kalyaev
+Copyright (c) 2012 - 2016 Anton Kalyaev
 
 MIT License
 

data/Makefile

@@ -0,0 +1,7 @@
+docker_build:
+	docker build -t valle .
+
+docker_test:
+	docker run -it --rm -v "$(PWD)":/usr/src/lib valle bundle exec rake
+
+.PHONY: docker_build docker_test

data/README.md

@@ -15,11 +15,6 @@ Example:
     PG::Error: ERROR:  value "2147483648" is out of range for type integer
     : SELECT  "users".* FROM "users"  WHERE "users"."id" = $1 LIMIT 1
 
-### Rails versions currently supported
-
-- 3.x
-- 4.x
-
 ### Supported ActiveRecord field types
 
 - `:primary_key`
@@ -41,6 +36,8 @@ Or install it yourself:
 
     $ gem install valle
 
+If you are using other framework than Rails (e.g. Sinatra), call `Valle::Hooks.init` method during the boot process.
+
 ## Usage
 
 By default, this gem adds validators to all your ActiveRecord models. If that is the behavior you want, you don't need to tweak it.
@@ -77,6 +74,23 @@ end
 
 There is a similar gem, called [validates_lengths_from_database](http://github.com/rubiety/validates_lengths_from_database). It solves only one part of the problem — applicable to strings. Valle, however, is designed to work with all possible field types.
 
+## Docker container
+
+If you have [docker](http://www.docker.com/) installed on your machine, you can
+spin up a sandbox and run test suite in a few seconds:
+
+```
+$ docker build -t valle .
+$ docker run -it --rm -v "$PWD":/usr/src/lib valle bundle exec rake
+```
+
+Or simply use Makefile commands:
+
+```
+$ make docker_build
+$ make docker_test
+```
+
 ## Contributing
 
 1. Fork it
@@ -88,14 +102,12 @@ There is a similar gem, called [validates_lengths_from_database](http://github.c
 
 ## Credits
 
-Authors:
+Original authors:
 
 - [Anton Kalyaev](http://github.com/akalyaev)
 - [Andrew Kulakov](http://github.com/Andrew8xx8)
 - [Alexander Kirillov](http://github.com/saratovsource)
 
-Maintained by kaize team.
-
 Thank you to all our amazing [contributors](http://github.com/kaize/valle/contributors)!
 
 ## License

data/features/configuration.feature

@@ -1,4 +1,3 @@
-@disable-bundler
 Feature:
   In order to temporary disable Valle or apply it only to a subset of models,
   as a user of Rails, I would like to use valle initializer options.
@@ -10,7 +9,7 @@ Feature:
     And I add "valle" from this project as a dependency
     And I successfully run `bundle install`
     And I successfully run `bundle exec rails g model User name:string`
-    And I successfully run `bundle exec rake db:migrate --trace`
+    And I successfully run `bundle exec rake db:migrate -v`
 
   Scenario: Setting enabled option to false disable Valle
     When I write to "config/initializers/valle.rb" with:
@@ -34,12 +33,12 @@ Feature:
         end
       end
       """
-    When I successfully run `bundle exec rake test --trace`
+    When I successfully run `bundle exec rake test -v`
     Then the output should contain "1 runs, 1 assertions, 0 failures, 0 errors"
 
   Scenario: Using the exclude_models option should skip the models specified in the list
     When I successfully run `bundle exec rails g model Post title:string`
-    And I successfully run `bundle exec rake db:migrate --trace`
+    And I successfully run `bundle exec rake db:migrate -v`
     And I write to "config/initializers/valle.rb" with:
       """
       Valle.configure do |config|
@@ -75,7 +74,7 @@ Feature:
         end
       end
       """
-    When I successfully run `bundle exec rake test --trace`
+    When I successfully run `bundle exec rake test -v`
     Then the output should contain "2 runs, 3 assertions, 0 failures, 0 errors"
 
   Scenario: Using exclude_attributes option should allow us to skip some attributes
@@ -102,5 +101,5 @@ Feature:
         end
       end
       """
-    When I successfully run `bundle exec rake test --trace`
+    When I successfully run `bundle exec rake test -v`
     Then the output should contain "1 runs, 1 assertions, 0 failures, 0 errors"

data/features/sets_validations.feature

@@ -6,7 +6,7 @@ Feature: sets validations
     And I add "valle" from this project as a dependency
     And I successfully run `bundle install`
     And I successfully run `bundle exec rails g model User name:string`
-    And I successfully run `bundle exec rake db:migrate --trace`
+    And I successfully run `bundle exec rake db:migrate -v`
 
   @disable-bundler
   Scenario: Using Valle automatically sets validations
@@ -27,5 +27,5 @@ Feature: sets validations
         end
       end
       """
-    When I successfully run `bundle exec rake test --trace`
+    When I successfully run `bundle exec rake test -v`
     Then the output should contain "1 runs, 2 assertions, 0 failures, 0 errors"

data/lib/valle/railtie.rb

@@ -1,6 +1,6 @@
 module Valle
   class Railtie < ::Rails::Railtie #:nodoc:
-    config.after_initialize do
+    initializer "valle.after_initialize" do
       Valle::Hooks.init
     end
   end

data/test/lib/abstract_adapter/character_limited_column_test.rb

@@ -3,21 +3,21 @@ require "test_helper"
 class CharacterLimitedColumnTest < TestCase
 
   def test_maximum_should_return_value_for_string_column
-    original_column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "varchar(255)")
+    original_column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", ::ActiveRecord::Type::String.new(limit: 255))
     column = Valle::AbstractAdapter::CharacterLimitedColumn.new(original_column)
 
     assert column.maximum
   end
 
   def test_maximum_should_return_correct_value_for_string_column_if_user_redefine_limit
-    original_column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "varchar(200)")
+    original_column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", ::ActiveRecord::Type::String.new(limit: 200))
     column = Valle::AbstractAdapter::CharacterLimitedColumn.new(original_column)
 
     assert_equal 200, column.maximum
   end
 
   def test_minimum_should_return_nil
-    original_column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "varchar")
+    original_column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", ::ActiveRecord::Type::String.new)
     column = Valle::AbstractAdapter::CharacterLimitedColumn.new(original_column)
 
     assert_nil column.minimum

data/test/lib/abstract_adapter/column_wrapper_test.rb

@@ -4,14 +4,14 @@ require "active_record"
 class ColumnWrapperTest < TestCase
 
   def test_wrap_should_return_instance_of_character_limited_column_for_string_column
-    column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "varchar(255)")
+    column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", ::ActiveRecord::Type::String.new(limit: 255))
     wrapped_column = Valle::AbstractAdapter::ColumnWrapper.wrap(column)
 
     assert wrapped_column.is_a?(Valle::AbstractAdapter::CharacterLimitedColumn)
   end
 
   def test_wrap_should_return_instance_of_byte_limited_column_for_int_column
-    column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "int")
+    column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", 25, ::ActiveRecord::Type::Integer.new)
     wrapped_column = Valle::AbstractAdapter::ColumnWrapper.wrap(column)
 
     assert wrapped_column.is_a?(Valle::AbstractAdapter::ByteLimitedColumn)

data/test/test_helper.rb

@@ -2,6 +2,7 @@ require 'bundler/setup'
 Bundler.require
 
 require "active_record"
+require "active_support/core_ext/hash/keys"
 
 require 'minitest/autorun'
 require "minitest/reporters"

data/valle.gemspec

@@ -1,5 +1,4 @@
 # -*- encoding: utf-8 -*-
-require File.expand_path('../lib/valle/version', __FILE__)
 
 Gem::Specification.new do |gem|
   gem.authors       = ["Anton Kalyaev"]
@@ -14,7 +13,7 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = "valle"
   gem.require_paths = ["lib"]
-  gem.version       = Valle::VERSION
+  gem.version       = "1.1.0"
 
   gem.add_dependency 'activerecord', '>= 3.0'
   gem.add_dependency 'activesupport'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valle
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Anton Kalyaev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-22 00:00:00.000000000 Z
+date: 2016-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -47,12 +47,15 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".dockerignore"
 - ".gitignore"
 - ".travis.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
+- Dockerfile
 - Gemfile
 - LICENSE
+- Makefile
 - README.md
 - Rakefile
 - features/configuration.feature
@@ -70,7 +73,6 @@ files:
 - lib/valle/manager.rb
 - lib/valle/railtie.rb
 - lib/valle/validation_setter.rb
-- lib/valle/version.rb
 - test/lib/abstract_adapter/character_limited_column_test.rb
 - test/lib/abstract_adapter/column_wrapper_test.rb
 - test/test_helper.rb
@@ -95,7 +97,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.2
 signing_key: 
 specification_version: 4
 summary: Built-in limit validations for your ActiveRecord model.

data/lib/valle/version.rb

@@ -1,3 +0,0 @@
-module Valle
-  VERSION = "1.0.1"
-end