valle 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9cfb09e0752993ed015ff6737ffb430e1c3ec37d
-  data.tar.gz: ee3bb21e2c0dddefac91cd8bfdaea011d1c26b7f
+  metadata.gz: 7c0c148d64fc0b076b0575401d9c4918333fb7b8
+  data.tar.gz: 94db8d353ef331cd637eba7186e2509ab021035f
 SHA512:
-  metadata.gz: 864f0b25a5c2e7f360dd2fbfa3cd7e86814491a316b4dfea97598524d4aa82f5a9ed97e95f044df9d5524bd91ecd5a0a80ad739d194fd2f479687426313f41c6
-  data.tar.gz: a8b91e752476c7d15657122477c327bb2e79030a14f4297ec03ca276e8212b66beff4a0d89784db3ea2366a2428b0cc38770d36309347dbc12fd611c9a2ee5db
+  metadata.gz: bb10fe590b5426ed77e95da67aabd3800379a6d3afc2c625f22a48c08e3e6b91c1ad9787e84b15d4f6da1a1dd38f2314332320dbc1a5e2c26d92840ee9bec0d0
+  data.tar.gz: feb65d2c8e597d4623f35e72735f886318ba3a17cf18ec2aa7b5b58d2be315cca52f4c66d722372a5a3d2ac392036fdd9bb04b80d8450c1f7ce7e6a5679ffabb

data/.travis.yml

@@ -2,6 +2,7 @@ language: ruby
 rvm:
   - 1.9.3
   - 2.0.0
+  - 2.1.0
 branches:
   only:
     - master

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.0.1 / 2014-07-22
+
+* fix has_and_belongs_to_many causes Model to crash on initialization (#18) [Anton Kalyaev]
+
 ## 1.0.0 / 2014-01-14
 
 * attributes option changed to exclude_attributes [Anton Kalyaev]

data/CONTRIBUTING.md

@@ -0,0 +1,33 @@
+# Contributing
+
+We love pull requests. Here's a quick guide.
+
+Fork, then clone the repo:
+
+    git clone git@github.com:your-username/valle.git
+
+Make sure the tests pass:
+
+    rake
+
+Make your change. Add tests for your change. Make the tests pass:
+
+    rake
+
+Push to your fork and [submit a pull request][pr].
+
+[pr]: https://github.com/kaize/valle/compare/
+
+At this point you're waiting on us. We like to at least comment on pull requests
+within three business days (and, typically, one business day). We may suggest
+some changes or improvements or alternatives.
+
+Some things that will increase the chance that your pull request is accepted:
+
+* Write tests.
+* Follow common [style guides][style].
+* Write a [good commit message][commit].
+* squash your commits before sending PR.
+
+[style]: https://github.com/thoughtbot/guides/tree/master/style
+[commit]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

data/Gemfile

@@ -3,11 +3,13 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in valle.gemspec
 gemspec
 
-gem 'rails', '~> 4.0.0'
-
 gem 'rake'
-gem 'minitest'
-gem 'guard-minitest'
-gem 'turn'
-gem 'cucumber', '~> 1.0.0'
-gem 'aruba'
+
+group :test do
+  gem 'rails', '~> 4.1.0'
+
+  gem 'minitest', '~> 5'
+  gem 'minitest-reporters'
+  gem 'cucumber'
+  gem 'aruba'
+end

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012 - 2013 Anton Kalyaev
+Copyright (c) 2012 - 2014 Anton Kalyaev
 
 MIT License
 

data/README.md

@@ -88,12 +88,14 @@ There is a similar gem, called [validates_lengths_from_database](http://github.c
 
 ## Credits
 
-Team members:
+Authors:
 
 - [Anton Kalyaev](http://github.com/akalyaev)
 - [Andrew Kulakov](http://github.com/Andrew8xx8)
 - [Alexander Kirillov](http://github.com/saratovsource)
 
+Maintained by kaize team.
+
 Thank you to all our amazing [contributors](http://github.com/kaize/valle/contributors)!
 
 ## License

data/features/configuration.feature

@@ -35,7 +35,7 @@ Feature:
       end
       """
     When I successfully run `bundle exec rake test --trace`
-    Then the output should contain "1 tests, 1 assertions, 0 failures, 0 errors"
+    Then the output should contain "1 runs, 1 assertions, 0 failures, 0 errors"
 
   Scenario: Using the exclude_models option should skip the models specified in the list
     When I successfully run `bundle exec rails g model Post title:string`
@@ -76,7 +76,7 @@ Feature:
       end
       """
     When I successfully run `bundle exec rake test --trace`
-    Then the output should contain "2 tests, 3 assertions, 0 failures, 0 errors"
+    Then the output should contain "2 runs, 3 assertions, 0 failures, 0 errors"
 
   Scenario: Using exclude_attributes option should allow us to skip some attributes
     When I write to "config/initializers/valle.rb" with:
@@ -103,4 +103,4 @@ Feature:
       end
       """
     When I successfully run `bundle exec rake test --trace`
-    Then the output should contain "1 tests, 1 assertions, 0 failures, 0 errors"
+    Then the output should contain "1 runs, 1 assertions, 0 failures, 0 errors"

data/features/sets_validations.feature

@@ -28,4 +28,4 @@ Feature: sets validations
       end
       """
     When I successfully run `bundle exec rake test --trace`
-    Then the output should contain "1 tests, 2 assertions, 0 failures, 0 errors"
+    Then the output should contain "1 runs, 2 assertions, 0 failures, 0 errors"

data/lib/valle/hooks.rb

@@ -50,9 +50,15 @@ module Valle
         # skip AR::SchemaMigration (AR >= 4.X)
         return false if (defined?(ActiveRecord::SchemaMigration) && subclass == ActiveRecord::SchemaMigration)
 
-        Valle.can_process_model?(subclass.model_name) &&
-        inherited_from_class == ActiveRecord::Base &&
-        subclass.table_exists?
+        begin
+          model_name = subclass.model_name
+
+          Valle.can_process_model?(model_name) &&
+            inherited_from_class == ActiveRecord::Base &&
+            subclass.table_exists?
+        rescue ArgumentError
+          false
+        end
       end
     end
   end

data/lib/valle/version.rb

@@ -1,3 +1,3 @@
 module Valle
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/test/lib/abstract_adapter/character_limited_column_test.rb

@@ -3,21 +3,21 @@ require "test_helper"
 class CharacterLimitedColumnTest < TestCase
 
   def test_maximum_should_return_value_for_string_column
-    original_column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "string(255)")
+    original_column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "varchar(255)")
     column = Valle::AbstractAdapter::CharacterLimitedColumn.new(original_column)
 
     assert column.maximum
   end
 
   def test_maximum_should_return_correct_value_for_string_column_if_user_redefine_limit
-    original_column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "string(200)")
+    original_column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "varchar(200)")
     column = Valle::AbstractAdapter::CharacterLimitedColumn.new(original_column)
 
     assert_equal 200, column.maximum
   end
 
   def test_minimum_should_return_nil
-    original_column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "string")
+    original_column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "varchar")
     column = Valle::AbstractAdapter::CharacterLimitedColumn.new(original_column)
 
     assert_nil column.minimum

data/test/lib/abstract_adapter/column_wrapper_test.rb

@@ -4,7 +4,7 @@ require "active_record"
 class ColumnWrapperTest < TestCase
 
   def test_wrap_should_return_instance_of_character_limited_column_for_string_column
-    column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "string")
+    column = ::ActiveRecord::ConnectionAdapters::Column.new("test_column", "", "varchar(255)")
     wrapped_column = Valle::AbstractAdapter::ColumnWrapper.wrap(column)
 
     assert wrapped_column.is_a?(Valle::AbstractAdapter::CharacterLimitedColumn)

data/test/test_helper.rb

@@ -3,7 +3,9 @@ Bundler.require
 
 require "active_record"
 
-MiniTest::Unit.autorun
+require 'minitest/autorun'
+require "minitest/reporters"
+Minitest::Reporters.use! [Minitest::Reporters::DefaultReporter.new(:color => true)]
 
-class TestCase < MiniTest::Unit::TestCase
+class TestCase < MiniTest::Test
 end

metadata

@@ -1,41 +1,41 @@
 --- !ruby/object:Gem::Specification
 name: valle
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Anton Kalyaev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-14 00:00:00.000000000 Z
+date: 2014-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Valle automatically sets minimum and maximum values for the fields of
@@ -47,9 +47,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE
 - README.md
@@ -84,17 +85,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Built-in limit validations for your ActiveRecord model.