valle 0.2.3 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a2397c0090d814c90a8741d75a8f7f180577cbe3
-  data.tar.gz: 54a8ea77e0490b1a287368c8ec5a478a355170cf
+  metadata.gz: 9cfb09e0752993ed015ff6737ffb430e1c3ec37d
+  data.tar.gz: ee3bb21e2c0dddefac91cd8bfdaea011d1c26b7f
 SHA512:
-  metadata.gz: eaae640af84fb06801a8558f59b609e4df68b6805a8259272e09afc0d5c5ded123578aa1f044b32fddfdfec09db8de67ae7ce6599fde7449ffdbb8f8f1d768f4
-  data.tar.gz: 011c1cc4f6a3cf91ffee20cc197a6f4bbec5e034b6efef1dd36c4e1475dcdd8212ea80d3c6d521db9f2296c211852f946de4b27f34b66afbfb2ebd9917c04b73
+  metadata.gz: 864f0b25a5c2e7f360dd2fbfa3cd7e86814491a316b4dfea97598524d4aa82f5a9ed97e95f044df9d5524bd91ecd5a0a80ad739d194fd2f479687426313f41c6
+  data.tar.gz: a8b91e752476c7d15657122477c327bb2e79030a14f4297ec03ca276e8212b66beff4a0d89784db3ea2366a2428b0cc38770d36309347dbc12fd611c9a2ee5db

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.0.0 / 2014-01-14
+
+* attributes option changed to exclude_attributes [Anton Kalyaev]
+* models option changed to exclude_models [Anton Kalyaev]
+
 ## 0.2.3 / 2013-12-16
 
 * fixes issue #12 with breaking rake db:migrate:reset [Marcus Geißler]

data/README.md

@@ -45,11 +45,11 @@ Or install it yourself:
 
 By default, this gem adds validators to all your ActiveRecord models. If that is the behavior you want, you don't need to tweak it.
 
-However, you can specify what models to take into account by adding the file `config/initializers/valle.rb` containing:
+However, you can skip some of them by adding the file `config/initializers/valle.rb` containing:
 
 ```ruby
 Valle.configure do |config|
-  config.models = %w(User, Post)
+  config.exclude_models = %w(Post)
 end
 ```
 
@@ -63,12 +63,12 @@ end
 
 ### Disabling Valle on specific attributes
 
-There are cases where you need to skip validation for a particular attribute (see [#4](https://github.com/kaize/valle/issues/4)). For example, *CarrierWave* stores images temporarily in attributes, so calling `save` on them will fail because of its LengthValidator (255 characters maximum). You can disable Valle for such fields using the `attributes` configuration option:
+There are cases where you need to skip validation for a particular attribute (see [#4](https://github.com/kaize/valle/issues/4)). For example, *CarrierWave* stores images temporarily in attributes, so calling `save` on them will fail because of its LengthValidator (255 characters maximum). You can disable Valle for such fields using the `exclude_attributes` configuration option:
 
 ```ruby
 Valle.configure do |config|
-  config.attributes = {
-    'User' => %w(id name) # Model => Array of attributes to validate
+  config.exclude_attributes = {
+    'User' => %w(image)
   }
 end
 ```

data/features/configuration.feature

@@ -37,13 +37,13 @@ Feature:
     When I successfully run `bundle exec rake test --trace`
     Then the output should contain "1 tests, 1 assertions, 0 failures, 0 errors"
 
-  Scenario: Using the models option should limit the effect of the Valle to the models specified in the list
+  Scenario: Using the exclude_models option should skip the models specified in the list
     When I successfully run `bundle exec rails g model Post title:string`
     And I successfully run `bundle exec rake db:migrate --trace`
     And I write to "config/initializers/valle.rb" with:
       """
       Valle.configure do |config|
-        config.models = %w(Post)
+        config.exclude_models = %w(User)
       end
       """
     And I write to "test/unit/user_test.rb" with:
@@ -78,12 +78,12 @@ Feature:
     When I successfully run `bundle exec rake test --trace`
     Then the output should contain "2 tests, 3 assertions, 0 failures, 0 errors"
 
-  Scenario: Using attributes option should allow us to skip some attributes
+  Scenario: Using exclude_attributes option should allow us to skip some attributes
     When I write to "config/initializers/valle.rb" with:
       """
       Valle.configure do |config|
-        config.attributes = {
-          'User' => %w(id)
+        config.exclude_attributes = {
+          'User' => %w(name)
         }
       end
       """

data/lib/valle.rb

@@ -33,30 +33,31 @@ module Valle
     ##
     # Can we process this model
     #
-    # If the user turned gem on only for certain models,
-    # we need to check whether the model is in the list.
+    # If the user wants to exclude some models,
+    # we need to check whether the model is on the list.
     #
     # @param [String] model_name the model name
     # @see Valle::Configuration
     #
     def can_process_model?(model_name)
-      options[:models].nil? ||
-        options[:models].is_a?(Array) && options[:models].include?(model_name)
+      options[:exclude_models].nil? ||
+        options[:exclude_models].is_a?(Array) && !options[:exclude_models].include?(model_name)
     end
 
     ##
     # Can we process this attribute
     #
     # If the user wants to skip some attributes, we need to check
-    # whether we should add validators to column or not.
+    # whether we should add validators to that column or not.
     #
     # @param [String] model_name model name
     # @param [String] attribute attribute name
     # @see Valle::Configuration
     #
     def can_process_column?(model_name, attribute)
-      !options[:attributes].has_key?(model_name) ||
-        options[:attributes][model_name].is_a?(Array) && options[:attributes][model_name].include?(attribute)
+      options[:exclude_attributes].nil? ||
+        !options[:exclude_attributes].has_key?(model_name) ||
+        options[:exclude_attributes][model_name].is_a?(Array) && !options[:exclude_attributes][model_name].include?(attribute)
     end
   end
 end

data/lib/valle/configuration.rb

@@ -1,5 +1,4 @@
 require 'active_support/core_ext/module/attribute_accessors'
-require 'active_support/hash_with_indifferent_access'
 
 module Valle
   module Configuration
@@ -8,8 +7,8 @@ module Valle
 
     self.options = {
       enabled: true, # gem is enabled by default
-      models: nil, # selects all AR models by default
-      attributes: ActiveSupport::HashWithIndifferentAccess.new, # adds validators to all attributes by default
+      exclude_models: nil, # selects all AR models by default
+      exclude_attributes: nil, # adds validators to all attributes by default
     }
 
     def configure
@@ -20,12 +19,12 @@ module Valle
       self.options[:enabled] = value
     end
 
-    def models=(collection)
-      self.options[:models] = collection
+    def exclude_models=(collection)
+      self.options[:exclude_models] = collection
     end
 
-    def attributes=(mapping)
-      self.options[:attributes] = mapping
+    def exclude_attributes=(mapping)
+      self.options[:exclude_attributes] = mapping
     end
   end
 end

data/lib/valle/version.rb

@@ -1,3 +1,3 @@
 module Valle
-  VERSION = "0.2.3"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valle
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 1.0.0
 platform: ruby
 authors:
 - Anton Kalyaev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-16 00:00:00.000000000 Z
+date: 2014-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord