valkyrie 3.1.5 → 3.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4efad2e357e3b34a76b6e6b9c3362d48c571388b7ac8979bbf6e38a1047bf8ce
-  data.tar.gz: 40cd0c353e5f04e9eaffa22fb0ea3f13eedf97033b0ce17e6cfa3746ca79fcc9
+  metadata.gz: 7439f8be7099e4b54998826abda9222d07226ff7a54fdb868f2ab7d99596fd56
+  data.tar.gz: 866c57941b2e2604a8d7bd8b013e0b31c07dd909404733cfb7043c61412389ad
 SHA512:
-  metadata.gz: 418d8f6390418de4b76230db5f0a980b79a6d6109250d72a40480b2ca1f5e59fab6ca8ece7334ed6e2a29e81be7b488aeb41cbaa6ec94814752e5d4da00c4b1b
-  data.tar.gz: 62e9f00d29a7d3d16ad8d9211925618b13b995a09f24c7cb72dd94fa68b124dc1686a9fc333a21bc305e2118e0b3015282a871165fe5de04a67b941d56cfd85d
+  metadata.gz: 89d1857a2f40c0d8c32c6a31a9ff1247e9b8c32aa84e917c77c3d89e6a0cb52c7548802852914ddcf11d9805f3cf0b6784331f937cf9004b18e63ecb27449971
+  data.tar.gz: 5b143107a9ca53b86c83c5ba884635fb869919a7641c1373324193f9ac918684557177cf2c2519f5d8eeb0420bd48404037da5fb46c84d5a17bda0e4381b72f7

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+# v3.2.0 2024-04-10
+
+## Changes since last release
+
+* Add cleanup functionality to StreamFile#disk_path. ([tpendragon](https://github.com/tpendragon))
+
+Additional thanks to the following for code review and issue reports leading to this release:
+
+* [dchandekstark](https://github.com/dchandekstark)
+* [cgalarza](https://github.com/cgalarza)
+
 # v3.1.5 2024-04-10
 
 ## Changes since last release

data/lib/valkyrie/specs/shared_specs/file.rb

@@ -14,5 +14,13 @@ RSpec.shared_examples 'a Valkyrie::StorageAdapter::File' do
     it "returns an existing disk path" do
       expect(File.exist?(file.disk_path)).to eq true
     end
+    it "can accept a block" do
+      disk_path = nil
+      file.disk_path do |f_path|
+        expect(File.exist?(f_path)).to eq true
+        disk_path = f_path
+      end
+      expect(disk_path).not_to be_nil
+    end
   end
 end

data/lib/valkyrie/storage_adapter.rb

@@ -25,12 +25,13 @@ module Valkyrie
 
       # Find the adapter associated with the provided short name
       # @param short_name [Symbol]
-      # @return [Valkyrie::StorageAdapter]
+      # @return [Object] the storage adapter
       # @raise Valkyrie::StorageAdapter::AdapterNotFoundError when we are unable to find the named adapter
       def find(short_name)
         storage_adapters.fetch(short_name)
       rescue KeyError
-        raise "Unable to find #{self} with short_name of #{short_name.inspect}. Registered adapters are #{storage_adapters.keys.inspect}"
+        raise AdapterNotFoundError, "Unable to find #{self} with short_name of #{short_name.inspect}. " \
+                                    "Registered adapters are #{storage_adapters.keys.inspect}"
       end
 
       # Search through all registered storage adapters until it finds one that
@@ -53,7 +54,8 @@ module Valkyrie
 
       # Return the registered storage adapter which handles the given ID.
       # @param id [Valkyrie::ID]
-      # @return [Valkyrie::StorageAdapter]
+      # @return [Object] the storage adapter
+      # @raise [Valkyrie::StorageAdapter::AdapterNotFoundError]
       def adapter_for(id:)
         handler = storage_adapters.values.find do |storage_adapter|
           storage_adapter.handles?(id: id)
@@ -74,7 +76,12 @@ module Valkyrie
       end
 
       def disk_path
-        Pathname.new(io.path)
+        path = Pathname.new(io.path)
+        if block_given?
+          yield path
+        else
+          path
+        end
       end
 
       # @param digests [Array<Digest>]
@@ -89,7 +96,7 @@ module Valkyrie
       end
 
       # @param size [Integer]
-      # @param digests [Array<Digest>]
+      # @param digests [Hash<String, String>] map of digest algorithm names to digest values.
       # @return [Boolean]
       def valid?(size: nil, digests:)
         return false if size && io.size.to_i != size.to_i
@@ -102,17 +109,34 @@ module Valkyrie
 
     class StreamFile < File
       def disk_path
-        Pathname.new(tmp_file.path)
+        path = Pathname.new(tmp_file.path)
+        if block_given?
+          yield path
+          clean_tmp_file
+        else
+          path
+        end
+      end
+
+      def close
+        super
+        clean_tmp_file
       end
 
       private
 
+      def clean_tmp_file
+        return unless @tmp_file
+        ::File.delete(tmp_file.path)
+        @tmp_file = nil
+      end
+
       def tmp_file_name
         id.to_s.tr(':/', '__')
       end
 
       def tmp_file_path
-        ::File.join(Dir.tmpdir, tmp_file_name)
+        ::File.join(Dir.tmpdir, "#{SecureRandom.uuid}-#{tmp_file_name}")
       end
 
       def tmp_file

data/lib/valkyrie/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Valkyrie
-  VERSION = "3.1.5"
+  VERSION = "3.2.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valkyrie
 version: !ruby/object:Gem::Version
-  version: 3.1.5
+  version: 3.2.0
 platform: ruby
 authors:
 - Trey Pendragon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-04-10 00:00:00.000000000 Z
+date: 2024-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-struct