valkyrie 2.2.0 → 3.0.0.pre.beta.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a9562026fbee014b2e1f3076826af96c850373e9ff94eeb1921facbad11edcec
-  data.tar.gz: '0119066f0cf241db23c9a29d7f9501803c669df197bda350f0706d2b2db6120d'
+  metadata.gz: 240eb74a4be15202ae2036ac9a0067b1aadc23e65ad583638b6cd2874540a845
+  data.tar.gz: 65568d10c48dcadbee70bff7c23360a6e0b149f874b5ebe493b5770afb6e4362
 SHA512:
-  metadata.gz: 63279c6ea99e08f10dcb8b6aa6cd6fada5d60937852dde46ad08b2923e3d129eb03442be0d4a11640affefeda7367fdabc9d93bb6c90f53b25c71fc12dea7cc4
-  data.tar.gz: cd471fa3caa33b644cca4c5897104225dbdc3fafe0d10a889d102a03e6e5ba74aa9284cd5fc27933ded7c842e2d09f0326d66119290df557f7ca1c29e2c7f2e2
+  metadata.gz: 29b4ebfb067823191dfb2ca74151765ad8157f2c4b7b89cbecaf882e8e6f32eded31fdfb326ca198192e50574a562f8582205bab921d248707f2993b31960528
+  data.tar.gz: 1fc174038d3baac66d35e431211ed83e38d2531395f86ecfeee106a612631d42a1f2fa11fe55a561617d3a23561763707100c701a73a06147db11bb073a60636

data/.circleci/config.yml

@@ -28,7 +28,7 @@ jobs:
         environment:
           CATALINA_OPTS: "-Djava.awt.headless=true -Dfile.encoding=UTF-8 -server -Xms512m -Xmx1024m -XX:NewSize=256m -XX:MaxNewSize=256m -XX:PermSize=256m -XX:MaxPermSize=256m -XX:+DisableExplicitGC"
           JAVA_OPTIONS: "-Djetty.http.port=8998 -Dfcrepo.dynamic.jms.port=61618 -Dfcrepo.dynamic.stomp.port=61614"
-      - image: fcrepo/fcrepo:6.0.0-beta-1
+      - image: fcrepo/fcrepo:6.0.0
         environment:
           CATALINA_OPTS: "-Djava.awt.headless=true -Dfile.encoding=UTF-8 -server -Xms512m -Xmx1024m -XX:NewSize=256m -XX:MaxNewSize=256m -XX:PermSize=256m -XX:MaxPermSize=256m -XX:+DisableExplicitGC -Dorg.apache.tomcat.util.buf.UDecoder.ALLOW_ENCODED_SLASH=true"
           JAVA_OPTS: "-Djetty.http.port=8978 -Dfcrepo.dynamic.jms.port=61619 -Dfcrepo.dynamic.stomp.port=61615 -Dorg.apache.tomcat.util.buf.UDecoder.ALLOW_ENCODED_SLASH=true"
@@ -40,6 +40,16 @@ jobs:
       FEDORA_6_PORT: 8080
     steps:
       - checkout
+
+      - run:
+          name: Check for 'master' branch
+          command: |
+              git fetch --all --quiet --prune --prune-tags
+              if [[ -n "$(git branch --all --list master */master)" ]]; then
+                  echo "A branch named 'master' was found. Please remove it."
+                  echo "$(git branch --all --list master */master)"
+              fi
+              [[ -z "$(git branch --all --list master */master)" ]]
       - run:
           name: Wait for solr
           command: dockerize -wait tcp://localhost:8994 -timeout 1m
@@ -55,7 +65,7 @@ jobs:
       - restore_cache:
          keys:
            - bundle-{{ checksum "<< parameters.gemfile >>" }}-{{ checksum "valkyrie.gemspec" }}-<< parameters.ruby >>-6
-      - run: sudo apt-get update && sudo apt-get install -y libpq-dev
+      - run: sudo apt update -y && sudo apt-get install -y libpq-dev lsof
       - run:
           name: Set BUNDLE_GEMFILE
           command: |

data/.lando.yml

@@ -44,7 +44,7 @@ services:
     volumes:
       fedora6:
     services:
-      image: fcrepo/fcrepo:6.0.0-beta-1
+      image: fcrepo/fcrepo:6.0.0
       command:
         - "catalina.sh"
         - "run"

data/.rubocop.yml

@@ -39,3 +39,10 @@ Naming/FileName:
   Exclude:
     - 'Appraisals'
     - 'Gemfile'
+Metrics/MethodLength:
+  Exclude:
+    - 'lib/valkyrie/persistence/postgres/persister.rb'
+    - 'lib/valkyrie/persistence/fedora/persister.rb'
+Metrics/CyclomaticComplexity:
+  Exclude:
+    - 'lib/valkyrie/persistence/postgres/persister.rb'

data/CHANGELOG.md

@@ -1,3 +1,29 @@
+# v3.0.0.beta1 2021-10-18
+
+## Changes since last release
+
+* More informative NoMethodError for missing custom queries.
+  [no-reply](https://github.com/no-reply)
+* Persisters error if you save something which existed at query time, but has
+  since been deleted.
+* Shared write-only persisters.
+* Solr ModelConverter performance.
+* Don't hold open a file handle from StorageAdapter#upload/find_by
+* Files can be #close'd.
+* Remove Draper
+* Remove deprecated string equality function.
+* Remove deprecated BlacklistedValue.
+* Allow reform upgrade to 2.6.
+* Don't require a specific error message in shared specs
+  [tpendragon](https://github.com/tpendragon)
+
+Additional thanks to the following for code review and issue reports leading to
+this release:
+
+[hackartisan](https://github.com/hackartisan)
+[eliotjordan](https://github.com/eliotjordan)
+
+
 # v2.2.0 2021-05-06
 
 ## Changes since last release
@@ -60,9 +86,9 @@ this release:
 * Use `::` prefixed names for `JSON::LD` references.
   [no-reply](https://github.com/no-reply)
 * Use SVG instead of PNG for version badge.
-  [hackmastera](https://github.com/hackmastera)
+  [hackartisan](https://github.com/hackartisan)
 * Fix Rubocop for latest Bixby.
-  [hackmastera](https://github.com/hackmastera)
+  [hackartisan](https://github.com/hackartisan)
 * Valkyrie IDs equal string equivalent of ID to String with config
   [jlevnhv](https://github.com/jlevnhv)
 * Add optional model parameter to find_inverse_references_by and
@@ -207,7 +233,7 @@ involved for their contributions in the last year:
 [cjcolvar](https://github.com/cjcolvar)
 [dgcliff](https://github.com/dgcliff)
 [escowles](https://github.com/escowles)
-[hackmastera](https://github.com/hackmastera)
+[hackartisan](https://github.com/hackartisan)
 [jeremyf](https://github.com/jeremyf)
 [jrgriffiniii](https://github.com/jrgriffiniii)
 [kelynch](https://github.com/kelynch)
@@ -288,17 +314,17 @@ this release:
 * Provide a warning when postgres adapter overwrites an ID, deprecate this
   behavior so it will throw an exception in the future.
   [cam156](https://github.com/cam156)
-  [hackmastera](https://github.com/hackmastera)
+  [hackartisan](https://github.com/hackartisan)
   [tpendragon](https://github.com/tpendragon)
 * Add support for passing just an ID to find_inverse_references_by
   [cam156](https://github.com/cam156)
-  [hackmastera](https://github.com/hackmastera)
+  [hackartisan](https://github.com/hackartisan)
 * Fix memory adapter raising an exception in find_by_alternate_identifier when
   there are resources without the alternate_identifier attribute.
   [jeremyf](https://github.com/jeremyf)
 * Provide a warning when using the postgres adapter without manually providing
   the pg gem, so it can be an optional dependency in 2.0.0.
-  [hackmastera](https://github.com/hackmastera)
+  [hackartisan](https://github.com/hackartisan)
 * Provide guidance in specs on how to define alternate_ids
   [cjcolvar](https://github.com/cjcolvar)
 * Upload files to Fedora using form/multipart.
@@ -344,17 +370,17 @@ Additional thanks to the following for code review:
 * Provide a warning when postgres adapter overwrites an ID, deprecate this
   behavior so it will throw an exception in the future.
   [cam156](https://github.com/cam156)
-  [hackmastera](https://github.com/hackmastera)
+  [hackartisan](https://github.com/hackartisan)
   [tpendragon](https://github.com/tpendragon)
 * Add support for passing just an ID to find_inverse_references_by
   [cam156](https://github.com/cam156)
-  [hackmastera](https://github.com/hackmastera)
+  [hackartisan](https://github.com/hackartisan)
 * Fix memory adapter raising an exception in find_by_alternate_identifier when
   there are resources without the alternate_identifier attribute.
   [jeremyf](https://github.com/jeremyf)
 * Provide a warning when using the postgres adapter without manually providing
   the pg gem, so it can be an optional dependency in 2.0.0.
-  [hackmastera](https://github.com/hackmastera)
+  [hackartisan](https://github.com/hackartisan)
 * Provide guidance in specs on how to define alternate_ids
   [cjcolvar](https://github.com/cjcolvar)
 * Upload files to Fedora using form/multipart.
@@ -405,7 +431,7 @@ this release:
 ## Changes since last release
 
 * Fix solr persister to pass through exceptions on timeout
-  [hackmastera](https://github.com/hackmastera)
+  [hackartisan](https://github.com/hackartisan)
 * Fix generated specs to work with shared_specs expectation
   [revgum](https://github.com/revgum)
 
@@ -452,7 +478,7 @@ following participants who made it happen:
 * [cam156](https://github.com/cam156)
 * [DanCoughlin](https://github.com/DanCoughlin)
 * [escowles](https://github.com/escowles)
-* [hackmastera](https://github.com/hackmastera)
+* [hackartisan](https://github.com/hackartisan)
 * [jrgriffiniii](https://github.com/jrgriffiniii)
 * [mtribone](https://github.com/mtribone)
 * [tpendragon](https://github.com/tpendragon)
@@ -469,7 +495,7 @@ following participants who made it happen:
 ## Changes since last release
 
 * Loosened ActiveRecord restriction to allow upgrading pg gem to 1.0.
-    [hackmastera](https://github.com/hackmastera)
+    [hackartisan](https://github.com/hackartisan)
 
 # v1.1.0 2018-05-08
 
@@ -548,7 +574,7 @@ Initial Release
 * [dlpierce](https://github.com/dlpierce)
 * [escowles](https://github.com/escowles)
 * [geekscruff](https://github.com/geekscruff)
-* [hackmastera](https://github.com/hackmastera)
+* [hackartisan](https://github.com/hackartisan)
 * [jcoyne](https://github.com/jcoyne)
 * [jeremyf](https://github.com/jeremyf)
 * [jgondron](https://github.com/jgondron)

data/CONTRIBUTING.md

@@ -22,6 +22,28 @@ https://wiki.duraspace.org/display/samvera/Samvera+Community+Intellectual+Proper
 
 You should also add yourself to the `CONTRIBUTORS.md` file in the root of the project.
 
+## Language
+The language we use matters.  Today, tomorrow, and for years to come
+people will read the code we write.  They will judge us for our
+design, logic, and the words we use to describe the system.
+Our words should be accessible.  Favor descriptive words that give
+meaning while avoiding reinforcing systemic inequities.  For example,
+in the Samvera community, we should favor using allowed\_list instead
+of whitelist, denied\_list instead of blacklist, or source/copy
+instead of master/slave.
+We're going to get it wrong, but this is a call to keep working to
+make it right.  View our code and the words we choose as a chance to
+have a conversation. A chance to grow an understanding of the systems
+we develop as well as the systems in which we live.
+See [“Blacklists” and “whitelists”: a salutary warning concerning the
+prevalence of racist language in discussions of predatory
+publishing](https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6148600/) for
+further details.
+
+If you're working on PR for this project, create a feature branch off of `main`.
+
+Please ***do not*** create a branch called `master` for this repository or as part of your pull request; the branch will either need to be removed or renamed before it can be considered for inclusion in the code base and history of our repositories.
+
 ## Contribution Tasks
 
 * Reporting Issues
@@ -45,10 +67,10 @@ You should also add yourself to the `CONTRIBUTORS.md` file in the root of the pr
 
 * Fork the repository on GitHub
 * Create a topic branch from where you want to base your work.
-  * This is usually the master branch.
-  * To quickly create a topic branch based on master; `git branch fix/master/my_contribution master`
-  * Then checkout the new branch with `git checkout fix/master/my_contribution`.
-  * Please avoid working directly on the `master` branch.
+  * This is usually the main branch.
+  * To quickly create a topic branch based on main; `git branch fix/main/my_contribution main`
+  * Then checkout the new branch with `git checkout fix/main/my_contribution`.
+  * Please avoid working directly on the `main` branch.
   * You may find the [hub suite of commands](https://github.com/defunkt/hub) helpful
 * Make sure you have added sufficient tests and documentation for your changes.
   * Test functionality with RSpec; Test features / UI with Capybara.
@@ -109,15 +131,15 @@ You should also add yourself to the `CONTRIBUTORS.md` file in the root of the pr
 ### Submitting Changes
 
 * Read the article ["Using Pull Requests"](https://help.github.com/articles/using-pull-requests) on GitHub.
-* Make sure your branch is up to date with its parent branch (i.e. master)
-  * `git checkout master`
+* Make sure your branch is up to date with its parent branch (i.e. main)
+  * `git checkout main`
   * `git pull --rebase`
   * `git checkout <your-branch>`
-  * `git rebase master`
+  * `git rebase main`
   * It is a good idea to run your tests again.
 * If you've made more than one commit take a moment to consider whether squashing commits together would help improve their logical grouping.
   * [Detailed Walkthrough of One Pull Request per Commit](http://ndlib.github.io/practices/one-commit-per-pull-request/)
-  * `git rebase --interactive master` ([See Github help](https://help.github.com/articles/interactive-rebase))
+  * `git rebase --interactive main` ([See Github help](https://help.github.com/articles/interactive-rebase))
   * Squashing your branch's changes into one commit is "good form" and helps the person merging your request to see everything that is going on.
 * Push your changes to a topic branch in your fork of the repository.
 * Submit a pull request from your fork to the project.

data/README.md

@@ -239,7 +239,7 @@ custom adapters, but your application will still work.
 Using the shared specs in your own models is described in more detail on the [Shared Specs Wiki
 page](https://github.com/samvera/valkyrie/wiki/Shared-Specs).
 
-### Fedora 5 Compatibility
+### Fedora 5/6 Compatibility
 When configuring your adapter, include the `fedora_version` parameter in your metadata or storage adapter
 config.  If Fedora requires auth, you can also include that in the URL, e.g.:
 
@@ -282,3 +282,7 @@ This software has been developed by and is brought to you by the Samvera communi
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/samvera/valkyrie/.
+
+If you're working on PR for this project, create a feature branch off of `main`.
+
+This repository follows the [Samvera Community Code of Conduct](https://samvera.atlassian.net/wiki/spaces/samvera/pages/405212316/Code+of+Conduct) and [language recommendations](https://github.com/samvera/maintenance/blob/master/templates/CONTRIBUTING.md#language).  Please ***do not*** create a branch called `master` for this repository or as part of your pull request; the branch will either need to be removed or renamed before it can be considered for inclusion in the code base and history of this repository.

data/lib/valkyrie/id.rb

@@ -25,27 +25,12 @@ module Valkyrie
     delegate :hash, to: :state
 
     def eql?(other)
-      return string_equality(other) if Valkyrie.config.id_string_equality == true
-      default_equality(other)
+      other == to_str
     end
     alias == eql?
 
     protected
 
-    def default_equality(other)
-      output = (other.class == self.class && other.state == state)
-      return output if output == true
-      if output == false && string_equality(other) && Valkyrie.config.id_string_equality.nil?
-        warn "[DEPRECATION] Valkyrie::IDs will always be equal to their string counterparts in 3.0.0. " \
-          "To silence this message, please either compare IDs or set Valkyrie.config.id_string_equality = true."
-      end
-      false
-    end
-
-    def string_equality(other)
-      other == to_str
-    end
-
     def state
       [@id]
     end

data/lib/valkyrie/persistence/buffered_persister.rb

@@ -24,8 +24,8 @@ module Valkyrie::Persistence
       @buffer_class = buffer_class
     end
 
-    def save(resource:)
-      persister.save(resource: resource)
+    def save(resource:, external_resource: false)
+      persister.save(resource: resource, external_resource: external_resource)
     end
 
     def save_all(resources:)

data/lib/valkyrie/persistence/composite_persister.rb

@@ -24,14 +24,14 @@ module Valkyrie::Persistence
     end
 
     # (see Valkyrie::Persistence::Memory::Persister#save)
-    def save(resource:)
+    def save(resource:, external_resource: false)
       # Assume the first persister is the canonical data store; that's the optlock we want
       first, *rest = *persisters
-      cached_resource = first.save(resource: resource)
+      cached_resource = first.save(resource: resource, external_resource: external_resource)
       # Don't pass opt lock tokens to other persisters
       internal_resource = cached_resource.dup
       internal_resource.clear_optimistic_lock_token!
-      rest.inject(internal_resource) { |m, persister| persister.save(resource: m) }
+      rest.inject(internal_resource) { |m, persister| persister.save(resource: m, external_resource: true) }
       # return the one with the desired opt lock token
       cached_resource
     end

data/lib/valkyrie/persistence/custom_query_container.rb

@@ -39,25 +39,17 @@ module Valkyrie::Persistence
     attr_reader :query_service, :query_handlers
     def initialize(query_service:)
       @query_service = query_service
-      @query_handlers = []
+      @query_handlers = {}
     end
 
     def register_query_handler(query_handler)
-      @query_handlers << query_handler
-    end
-
-    def method_missing(meth_name, *args, &block)
-      query_handler = find_query_handler(meth_name).new(query_service: query_service)
-      return super unless query_handler
-      query_handler.__send__(meth_name, *args, &block)
-    end
-
-    def find_query_handler(method)
-      query_handlers.find { |x| x.queries.include?(method) }
-    end
-
-    def respond_to_missing?(meth_name, _args)
-      find_query_handler(meth_name).present?
+      query_handler.queries.each do |query|
+        handler = query_handler.new(query_service: query_service)
+        query_handlers[query.to_sym] = handler
+        define_singleton_method query do |*args, &block|
+          query_handlers[query.to_sym].__send__(query, *args, &block)
+        end
+      end
     end
   end
 end

data/lib/valkyrie/persistence/fedora/persister/model_converter.rb

@@ -313,7 +313,6 @@ module Valkyrie::Persistence::Fedora
         end
 
         # Generate a new RDF hash URI for the "child" graph for the ModelConverter::Property
-        # @see https://github.com/fcrepo4/fcrepo4/blob/master/fcrepo-kernel-modeshape/src/main/java/org/fcrepo/kernel/modeshape/rdf/JcrRdfTools.java#L455
         # @return [RDF::Graph]
         def subject_uri
           @subject_uri ||= ::RDF::URI(RDF::Node.new.to_s.gsub("_:", "#"))

data/lib/valkyrie/persistence/fedora/persister/orm_converter.rb

@@ -99,6 +99,7 @@ module Valkyrie::Persistence::Fedora
 
         # Class for handling cases where deny listed values should not be mapped
         class DenylistedValue < ::Valkyrie::ValueMapper
+          FedoraValue.register(self)
           # Determines whether or not the value has a denied namespace for the RDF statement object
           # (i. e. avoid attempting to map any RDF statements making assertions about LDP containers or resource internal to Fedora)
           # @param [Property] value
@@ -113,14 +114,6 @@ module Valkyrie::Persistence::Fedora
           end
         end
 
-        # @deprecated
-        # Class for handling cases where deny listed values should not be mapped
-        # @see DenylistedValue
-        class BlacklistedValue < DenylistedValue
-          FedoraValue.register(self)
-          warn "[DEPRECATION] Samvera is deprecating '#{self}' in 3.0.0. Use #{DenylistedValue} instead."
-        end
-
         # Class for handling cases where the RDF subject of a Property references a separate resource using a hash URI
         class DifferentSubject < ::Valkyrie::ValueMapper
           FedoraValue.register(self)
@@ -547,16 +540,6 @@ module Valkyrie::Persistence::Fedora
             key
           end
 
-          # @deprecated
-          # Determines whether or not a key is on the deny list for mapping
-          # (For example <http://fedora.info/definitions> assertions are not mapped to Valkyrie attributes)
-          # @param [Symbol] key
-          # @return [Boolean]
-          def blacklist?(key)
-            warn "[DEPRECATION] Samvera is deprecating '#{self.class}#blacklist?' in 3.0.0. Use #{self.class}#deny? instead."
-            deny?(key)
-          end
-
           # Determines whether or not a key is on the deny list for mapping
           # (For example <http://fedora.info/definitions> assertions are not mapped to Valkyrie attributes)
           # @param [Symbol] key
@@ -575,14 +558,6 @@ module Valkyrie::Persistence::Fedora
             Array(values)
           end
 
-          # @deprecated
-          # Retrieve a list of denied URIs for predicates
-          # @return [Array<String>]
-          def blacklist
-            warn "[DEPRECATION] Samvera is deprecating '#{self.class}#blacklist' in 3.0.0. Use #{self.class}#denylist instead."
-            denylist
-          end
-
           # Retrieve a list of denied URIs for predicates
           # @return [Array<String>]
           def denylist

data/lib/valkyrie/persistence/fedora/persister.rb

@@ -13,7 +13,7 @@ module Valkyrie::Persistence::Fedora
     end
 
     # (see Valkyrie::Persistence::Memory::Persister#save)
-    def save(resource:)
+    def save(resource:, external_resource: false)
       initialize_repository
       internal_resource = resource.dup
       internal_resource.created_at ||= Time.current
@@ -35,6 +35,8 @@ module Valkyrie::Persistence::Fedora
       alternate_resources ? save_reference_to_resource(persisted_resource, alternate_resources) : persisted_resource
     rescue Ldp::PreconditionFailed
       raise Valkyrie::Persistence::StaleObjectError, "The object #{internal_resource.id} has been updated by another process."
+    rescue Ldp::Gone
+      raise Valkyrie::Persistence::ObjectNotFoundError, "The object #{resource.id} is previously persisted but not found at save time."
     end
 
     # (see Valkyrie::Persistence::Memory::Persister#save_all)

data/lib/valkyrie/persistence/memory/persister.rb

@@ -5,7 +5,7 @@ module Valkyrie::Persistence::Memory
   # @note Documentation for persisters in general is maintained here.
   class Persister
     attr_reader :adapter
-    delegate :cache, to: :adapter
+    delegate :cache, :query_service, to: :adapter
 
     # @param adapter [Valkyrie::Persistence::Memory::MetadataAdapter] The memory adapter which
     #   holds the cache for this persister.
@@ -16,11 +16,18 @@ module Valkyrie::Persistence::Memory
 
     # Save a single resource.
     # @param resource [Valkyrie::Resource] The resource to save.
+    # @param external_resource [Boolean] Whether the resource to be saved comes
+    #   from a different metadata store. Allows a resource to be saved even if
+    #   it's not already in the store. For example, if you're indexing a
+    #   resource into Solr - it's saved in your primary metadata store, but not
+    #   in Solr, so it's okay if it doesn't exist in Solr but is marked as
+    #   persisted.
     # @return [Valkyrie::Resource] The resource with an `#id` value generated by the
     #   persistence backend.
     # @raise [Valkyrie::Persistence::StaleObjectError]
-    def save(resource:)
+    def save(resource:, external_resource: false)
       raise Valkyrie::Persistence::StaleObjectError, "The object #{resource.id} has been updated by another process." unless valid_lock?(resource)
+      raise Valkyrie::Persistence::ObjectNotFoundError, "The object #{resource.id} is previously persisted but not found at save time." unless external_resource || valid_for_save?(resource)
 
       # duplicate the resource so we are not creating side effects on the caller's resource
       internal_resource = resource.dup
@@ -34,6 +41,15 @@ module Valkyrie::Persistence::Memory
       cache[internal_resource.id] = internal_resource
     end
 
+    # return true if resource is
+    # persisted and found
+    # or
+    # not persisted
+    def valid_for_save?(resource)
+      return true unless resource.persisted? # a new resource
+      query_service.find_by(id: resource.id).present? # a persisted resource must be found
+    end
+
     # Save a batch of resources.
     # @param resources [Array<Valkyrie::Resource>] List of resources to save.
     # @return [Array<Valkyrie::Resource>] List of resources with an `#id` value

data/lib/valkyrie/persistence/postgres/persister.rb

@@ -17,9 +17,12 @@ module Valkyrie::Persistence::Postgres
     # @return [Valkyrie::Resource] the persisted/updated resource
     # @raise [Valkyrie::Persistence::StaleObjectError] raised if the resource
     #   was modified in the database between been read into memory and persisted
-    def save(resource:)
+    def save(resource:, external_resource: false)
       orm_object = resource_factory.from_resource(resource: resource)
       orm_object.transaction do
+        if !external_resource && resource.persisted? && !orm_object.persisted?
+          raise Valkyrie::Persistence::ObjectNotFoundError, "The object #{resource.id} is previously persisted but not found at save time."
+        end
         orm_object.save!
         if resource.id && resource.id.to_s != orm_object.id
           raise Valkyrie::Persistence::UnsupportedDatatype,

data/lib/valkyrie/persistence/solr/metadata_adapter.rb

@@ -27,18 +27,30 @@ module Valkyrie::Persistence::Solr
   #     )
   #   )
   class MetadataAdapter
-    attr_reader :connection, :resource_indexer
+    attr_reader :connection, :resource_indexer, :write_only
     # @param connection [RSolr::Client] The RSolr connection to index to.
     # @param resource_indexer [Class, #to_solr] An indexer which is able to
     #   receive a `resource` argument and then has an instance method `#to_solr`
-    def initialize(connection:, resource_indexer: NullIndexer)
+    # @param write_only [Boolean] If true act as a write only adapter.
+    # @param soft_commit [Boolean] If false, don't soft commit.
+    def initialize(connection:, resource_indexer: NullIndexer, write_only: false, soft_commit: true)
       @connection = connection
       @resource_indexer = resource_indexer
+      @write_only = write_only
+      @soft_commit = soft_commit
     end
 
     # @return [Valkyrie::Persistence::Solr::Persister] The solr persister.
     def persister
-      Valkyrie::Persistence::Solr::Persister.new(adapter: self)
+      @persister ||= Valkyrie::Persistence::Solr::Persister.new(adapter: self)
+    end
+
+    def write_only?
+      write_only
+    end
+
+    def soft_commit?
+      @soft_commit
     end
 
     # @return [Valkyrie::Persistence::Solr::QueryService] The solr query

data/lib/valkyrie/persistence/solr/model_converter.rb

@@ -82,7 +82,7 @@ module Valkyrie::Persistence::Solr
 
     # Determines whether or not a field is multivalued
     # @note this is tied to conventions in the Solr Schema
-    # @see https://github.com/samvera-labs/valkyrie/blob/master/solr/config/schema.xml
+    # @see https://github.com/samvera-labs/valkyrie/blob/main/solr/config/schema.xml
     # @see https://lucene.apache.org/solr/guide/defining-fields.html#defining-fields
     # @param [String] field
     # @return [Boolean]
@@ -114,6 +114,7 @@ module Valkyrie::Persistence::Solr
       properties.each_with_object({}) do |property, hsh|
         next if property == Valkyrie::Persistence::Attributes::OPTIMISTIC_LOCK
         attr = resource_attributes[property]
+        next if attr.nil?
         mapper_val = SolrMapperValue.for(Property.new(property, attr)).result
         unless mapper_val.respond_to?(:apply_to)
           raise "Unable to cast #{resource_attributes[:internal_resource]}#" \
@@ -162,8 +163,8 @@ module Valkyrie::Persistence::Solr
       # @param values [Array] Values to index into the given fields.
       def initialize(key:, fields:, values:)
         @key = key
-        @fields = Array.wrap(fields)
-        @values = Array.wrap(values)
+        @fields = fields
+        @values = values
       end
 
       # @param hsh [Hash] The solr hash to apply to.
@@ -238,10 +239,10 @@ module Valkyrie::Persistence::Solr
       # @note this prepends the string "serialized-" to the value indexed in Solr
       # This is indexed as a stored multivalued text
       # @see https://lucene.apache.org/solr/guide/defining-fields.html#defining-fields
-      # @see https://github.com/samvera-labs/valkyrie/blob/master/solr/config/schema.xml
+      # @see https://github.com/samvera-labs/valkyrie/blob/main/solr/config/schema.xml
       # @return [SolrRow]
       def result
-        SolrRow.new(key: value.key, fields: ["tsim"], values: "serialized-#{value.value.to_json}")
+        SolrRow.new(key: value.key, fields: ["tsim"], values: ["serialized-#{value.value.to_json}"])
       end
     end
 
@@ -267,24 +268,6 @@ module Valkyrie::Persistence::Solr
       end
     end
 
-    # Skips nil values.
-    class NilPropertyValue < ::Valkyrie::ValueMapper
-      SolrMapperValue.register(self)
-
-      # Determines whether or not a Property value responds as nil
-      # @param [Object] value
-      # @return [Boolean]
-      def self.handles?(value)
-        value.is_a?(Property) && value.value.nil?
-      end
-
-      # Constructs a SolrRow object for a Property with a nil value
-      # @return [SolrRow]
-      def result
-        SolrRow.new(key: value.key, fields: [], values: nil)
-      end
-    end
-
     # Casts {Valkyrie::ID} values into a recognizable string in solr.
     class IDPropertyValue < ::Valkyrie::ValueMapper
       SolrMapperValue.register(self)
@@ -423,7 +406,7 @@ module Valkyrie::Persistence::Solr
       # Constructs a SolrRow object with the String values and Solr field settings
       # @return [SolrRow]
       def result
-        SolrRow.new(key: value.key, fields: fields, values: value.value)
+        SolrRow.new(key: value.key, fields: fields, values: [value.value])
       end
 
       # Generates the Solr fields used during the indexing
@@ -436,7 +419,7 @@ module Valkyrie::Persistence::Solr
       #   - stored multivalued english text
       # If the string is greater than 1000 characters in length, it is only indexed as a stored multivalued text
       # @see https://lucene.apache.org/solr/guide/defining-fields.html#defining-fields
-      # @see https://github.com/samvera-labs/valkyrie/blob/master/solr/config/schema.xml
+      # @see https://github.com/samvera-labs/valkyrie/blob/main/solr/config/schema.xml
       # @return [Array<Symbol>]
       def fields
         if value.value.length > 1000

data/lib/valkyrie/persistence/solr/orm_converter.rb

@@ -79,7 +79,7 @@ module Valkyrie::Persistence::Solr
 
     # Construct the Hash containing the Valkyrie Resource attributes using the Solr Document
     # @note this filters for attributes which have been indexed as stored multivalued texts (tsim)
-    # @see https://github.com/samvera-labs/valkyrie/blob/master/solr/config/schema.xml
+    # @see https://github.com/samvera-labs/valkyrie/blob/main/solr/config/schema.xml
     # @see https://lucene.apache.org/solr/guide/defining-fields.html#defining-fields
     # @return [Hash]
     def attribute_hash

data/lib/valkyrie/persistence/solr/persister.rb

@@ -6,7 +6,7 @@ module Valkyrie::Persistence::Solr
   # Most methods are delegated to {Valkyrie::Persistence::Solr::Repository}
   class Persister
     attr_reader :adapter
-    delegate :connection, :resource_factory, to: :adapter
+    delegate :connection, :query_service, :resource_factory, :write_only?, :soft_commit?, to: :adapter
 
     # @param adapter [Valkyrie::Persistence::Solr::MetadataAdapter] The adapter with the
     #   configured solr connection.
@@ -15,11 +15,23 @@ module Valkyrie::Persistence::Solr
     end
 
     # (see Valkyrie::Persistence::Memory::Persister#save)
-    def save(resource:)
-      repository([resource]).persist.first
+    # @return [Boolean] If write_only, whether saving succeeded.
+    def save(resource:, external_resource: false)
+      if write_only?
+        repository([resource]).persist
+      else
+        raise Valkyrie::Persistence::ObjectNotFoundError, "The object #{resource.id} is previously persisted but not found at save time." unless external_resource || valid_for_save?(resource)
+        repository([resource]).persist.first
+      end
+    end
+
+    def valid_for_save?(resource)
+      return true unless resource.persisted? # a new resource
+      query_service.find_by(id: resource.id).present? # a persisted resource must be found
     end
 
     # (see Valkyrie::Persistence::Memory::Persister#save_all)
+    # @return [Boolean] If write_only, whether saving succeeded.
     def save_all(resources:)
       repository(resources).persist
     end
@@ -39,7 +51,7 @@ module Valkyrie::Persistence::Solr
     # @param [Array<Valkyrie::Resource>] resources
     # @return [Valkyrie::Persistence::Solr::Repository]
     def repository(resources)
-      Valkyrie::Persistence::Solr::Repository.new(resources: resources, connection: connection, resource_factory: resource_factory)
+      Valkyrie::Persistence::Solr::Repository.new(resources: resources, persister: self)
     end
   end
 end

data/lib/valkyrie/persistence/solr/repository.rb

@@ -3,17 +3,18 @@ module Valkyrie::Persistence::Solr
   # Responsible for handling the logic for persisting or deleting multiple
   # objects into or out of solr.
   class Repository
-    COMMIT_PARAMS = { softCommit: true, versions: true }.freeze
+    SOFT_COMMIT_PARAMS = { softCommit: true, versions: true }.freeze
+    NO_COMMIT_PARAMS = { versions: true }.freeze
 
-    attr_reader :resources, :connection, :resource_factory
+    attr_reader :resources, :persister
+    delegate :connection, :resource_factory, :write_only?, :soft_commit?, to: :persister
 
     # @param [Array<Valkyrie::Resource>] resources
     # @param [RSolr::Client] connection
     # @param [ResourceFactory] resource_factory
-    def initialize(resources:, connection:, resource_factory:)
+    def initialize(resources:, persister:)
       @resources = resources
-      @connection = connection
-      @resource_factory = resource_factory
+      @persister = persister
     end
 
     # Persist the resources into Solr
@@ -24,6 +25,7 @@ module Valkyrie::Persistence::Solr
         solr_document(resource)
       end
       results = add_documents(documents)
+      return true if write_only?
       versions = results["adds"]&.each_slice(2)&.to_h
       documents.map do |document|
         document["_version_"] = versions.fetch(document[:id])
@@ -35,7 +37,7 @@ module Valkyrie::Persistence::Solr
     # @return [RSolr::HashWithResponse]
     # rubocop:disable Style/IfUnlessModifier
     def add_documents(documents)
-      connection.add documents, params: COMMIT_PARAMS
+      connection.add documents, params: commit_params
     rescue RSolr::Error::Http => exception
       # Error 409 conflict is returned when versions do not match
       if exception.response&.fetch(:status) == 409
@@ -48,7 +50,7 @@ module Valkyrie::Persistence::Solr
     # Deletes a Solr Document using the ID
     # @return [Array<Valkyrie::Resource>] resources which have been deleted from Solr
     def delete
-      connection.delete_by_id resources.map { |resource| resource.id.to_s }, params: COMMIT_PARAMS
+      connection.delete_by_id resources.map { |resource| resource.id.to_s }, params: commit_params
       resources
     end
 
@@ -75,5 +77,13 @@ module Valkyrie::Persistence::Solr
       raise Valkyrie::Persistence::StaleObjectError, "One or more resources have been updated by another process." if resources.count > 1
       raise Valkyrie::Persistence::StaleObjectError, "The object #{resources.first.id} has been updated by another process."
     end
+
+    def commit_params
+      if persister.soft_commit?
+        SOFT_COMMIT_PARAMS
+      else
+        NO_COMMIT_PARAMS
+      end
+    end
   end
 end

data/lib/valkyrie/resource/access_controls.rb

@@ -11,7 +11,7 @@ module Valkyrie
     #       attribute :nested_resource
     #     end
     #
-    # @see https://github.com/samvera/hydra-head/tree/master/hydra-access-controls
+    # @see https://github.com/samvera/hydra-head/tree/main/hydra-access-controls
     # @see lib/valkyrie/indexers/access_controls_indexer/rb
     module AccessControls
       def self.included(klass)

data/lib/valkyrie/resource.rb

@@ -15,7 +15,6 @@ module Valkyrie
   # @see lib/valkyrie/specs/shared_specs/resource.rb
   # rubocop:disable Metrics/ClassLength
   class Resource < Dry::Struct
-    include Draper::Decoratable
     # Allows a Valkyrie::Resource to be instantiated without providing every
     # available key, and makes sure the defaults are set up if no value is
     # given.

data/lib/valkyrie/specs/shared_specs/file.rb

@@ -9,6 +9,7 @@ RSpec.shared_examples 'a Valkyrie::StorageAdapter::File' do
   it { is_expected.to respond_to(:read) }
   it { is_expected.to respond_to(:rewind) }
   it { is_expected.to respond_to(:id) }
+  it { is_expected.to respond_to(:close) }
   describe "#disk_path" do
     it "returns an existing disk path" do
       expect(File.exist?(file.disk_path)).to eq true

data/lib/valkyrie/specs/shared_specs/persister.rb

@@ -50,6 +50,24 @@ RSpec.shared_examples 'a Valkyrie::Persister' do |*flags|
     expect(reloaded.nested_resource.first.title).to eq ["Nested"]
   end
 
+  context "when a persisted resource is not in the database" do
+    it "throws an ObjectNotFoundError" do
+      expect(resource).not_to be_persisted
+      saved = persister.save(resource: resource)
+
+      expect(saved).to be_persisted
+      persister.delete(resource: saved)
+
+      expect { persister.save(resource: saved) }.to raise_error(Valkyrie::Persistence::ObjectNotFoundError)
+    end
+    it "is okay if it's from another persister" do
+      memory_adapter = Valkyrie::Persistence::Memory::MetadataAdapter.new
+      saved = memory_adapter.persister.save(resource: resource)
+
+      expect { persister.save(resource: saved, external_resource: true) }.not_to raise_error
+    end
+  end
+
   it "can persist single values" do
     resource.single_value = "A single value"
 
@@ -351,7 +369,7 @@ RSpec.shared_examples 'a Valkyrie::Persister' do |*flags|
           # update the resource in the datastore to make its token stale
           persister.save(resource: resource)
 
-          expect { persister.save(resource: resource) }.to raise_error(Valkyrie::Persistence::StaleObjectError, "The object #{resource.id} has been updated by another process.")
+          expect { persister.save(resource: resource) }.to raise_error(Valkyrie::Persistence::StaleObjectError)
         end
       end
 
@@ -425,7 +443,7 @@ RSpec.shared_examples 'a Valkyrie::Persister' do |*flags|
           persister.save(resource: resource2)
 
           expect { persister.save_all(resources: [resource1, resource2, resource3]) }
-            .to raise_error(Valkyrie::Persistence::StaleObjectError, "One or more resources have been updated by another process.")
+            .to raise_error(Valkyrie::Persistence::StaleObjectError)
         end
       end
     end

data/lib/valkyrie/specs/shared_specs/queries.rb

@@ -464,6 +464,13 @@ RSpec.shared_examples 'a Valkyrie query provider' do
     end
   end
 
+  describe ".custom_queries" do
+    it "raises NoMethodError when the custom query does not exist" do
+      expect(query_service.custom_queries).not_to respond_to :very_fake_query
+      expect { query_service.custom_queries.very_fake_query }.to raise_error(NoMethodError)
+    end
+  end
+
   describe ".register_query_handler" do
     it "can register a query handler" do
       class QueryHandler

data/lib/valkyrie/specs/shared_specs/storage_adapter.rb

@@ -30,6 +30,25 @@ RSpec.shared_examples 'a Valkyrie::StorageAdapter' do
     expect(uploaded_file.valid?(digests: { sha1: sha1 })).to be true
   end
 
+  it "doesn't leave a file handle open on upload/find_by" do
+    # No file handle left open from upload.
+    resource = Valkyrie::Specs::CustomResource.new(id: "testdiscovery")
+    pre_open_files = open_files
+    uploaded_file = storage_adapter.upload(file: file, original_filename: 'foo.jpg', resource: resource, fake_upload_argument: true)
+    file.close
+    expect(pre_open_files.size).to eq open_files.size
+
+    # No file handle left open from find_by
+    pre_open_files = open_files
+    the_file = storage_adapter.find_by(id: uploaded_file.id)
+    expect(the_file).to be_kind_of Valkyrie::StorageAdapter::File
+    expect(pre_open_files.size).to eq open_files.size
+  end
+
+  def open_files
+    `lsof +D . | awk '{print $9}'`.split.uniq[1..-1]
+  end
+
   it "can upload, validate, re-fetch, and delete a file" do
     resource = Valkyrie::Specs::CustomResource.new(id: "test")
     sha1 = Digest::SHA1.file(file).to_s

data/lib/valkyrie/specs/shared_specs/write_only/metadata_adapter.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+RSpec.shared_examples 'a write-only Valkyrie::MetadataAdapter' do |passed_adapter|
+  before do
+    raise 'adapter must be set with `let(:adapter)`' unless
+      defined? adapter
+  end
+  subject { passed_adapter || adapter }
+  let(:persister) { adapter.persister }
+  it { is_expected.to respond_to(:persister).with(0).arguments }
+  it { is_expected.to respond_to(:id).with(0).arguments }
+
+  describe "#id" do
+    it "is a valid string representation of an MD5 hash" do
+      expect(adapter.id).to be_a Valkyrie::ID
+      expect(adapter.id.to_s.length).to eq 32
+      expect(adapter.id.to_s).to match(/^[a-f,0-9]+$/)
+    end
+  end
+
+  describe "#write_only?" do
+    it "returns true" do
+      expect(adapter).to be_write_only
+    end
+  end
+
+  describe "persister" do
+    before do
+      class WriteOnlyCustomResource < Valkyrie::Resource
+        include Valkyrie::Resource::AccessControls
+        attribute :title
+        attribute :author
+        attribute :other_author
+        attribute :member_ids
+        attribute :nested_resource
+        attribute :single_value, Valkyrie::Types::String.optional
+        attribute :ordered_authors, Valkyrie::Types::Array.of(Valkyrie::Types::Anything).meta(ordered: true)
+        attribute :ordered_nested, Valkyrie::Types::Array.of(WriteOnlyCustomResource).meta(ordered: true)
+      end
+    end
+    after do
+      Object.send(:remove_const, :WriteOnlyCustomResource)
+    end
+
+    subject { persister }
+    let(:resource_class) { WriteOnlyCustomResource }
+    let(:resource) { resource_class.new }
+
+    it { is_expected.to respond_to(:save).with_keywords(:resource) }
+    it { is_expected.to respond_to(:save_all).with_keywords(:resources) }
+    it { is_expected.to respond_to(:delete).with_keywords(:resource) }
+
+    it "can save a resource" do
+      expect(persister.save(resource: resource)).to eq true
+    end
+
+    it "can save multiple resources at once" do
+      resource2 = resource_class.new
+      results = persister.save_all(resources: [resource, resource2])
+      expect(results).to eq true
+    end
+  end
+end

data/lib/valkyrie/specs/shared_specs.rb

@@ -13,3 +13,5 @@ require 'valkyrie/specs/shared_specs/change_set_persister.rb'
 require 'valkyrie/specs/shared_specs/file.rb'
 require 'valkyrie/specs/shared_specs/change_set.rb'
 require 'valkyrie/specs/shared_specs/solr_indexer.rb'
+# Write-only tests.
+require 'valkyrie/specs/shared_specs/write_only/metadata_adapter.rb'

data/lib/valkyrie/storage/disk.rb

@@ -36,11 +36,34 @@ module Valkyrie::Storage
     # @return [Valkyrie::StorageAdapter::File]
     # @raise Valkyrie::StorageAdapter::FileNotFound if nothing is found
     def find_by(id:)
-      Valkyrie::StorageAdapter::File.new(id: Valkyrie::ID.new(id.to_s), io: ::File.open(file_path(id), 'rb'))
+      Valkyrie::StorageAdapter::File.new(id: Valkyrie::ID.new(id.to_s), io: LazyFile.open(file_path(id), 'rb'))
     rescue Errno::ENOENT
       raise Valkyrie::StorageAdapter::FileNotFound
     end
 
+    ## LazyFile takes File.open parameters but doesn't leave a file handle open on
+    # instantiation. This way StorageAdapter#find_by doesn't open a handle
+    # silently and never clean up after itself.
+    class LazyFile
+      def self.open(path, mode)
+        # Open the file regularly and close it, so it can error if it doesn't
+        # exist.
+        File.open(path, mode).close
+        new(path, mode)
+      end
+
+      delegate(*(File.instance_methods - Object.instance_methods), to: :_inner_file)
+
+      def initialize(path, mode)
+        @__path = path
+        @__mode = mode
+      end
+
+      def _inner_file
+        @_inner_file ||= File.open(@__path, @__mode)
+      end
+    end
+
     # Delete the file on disk associated with the given identifier.
     # @param id [Valkyrie::ID]
     def delete(id:)

data/lib/valkyrie/storage_adapter.rb

@@ -67,7 +67,7 @@ module Valkyrie
     class File < Dry::Struct
       attribute :id, Valkyrie::Types::Any
       attribute :io, Valkyrie::Types::Any
-      delegate :size, :read, :rewind, to: :io
+      delegate :size, :read, :rewind, :close, to: :io
       def stream
         io
       end

data/lib/valkyrie/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Valkyrie
-  VERSION = "2.2.0"
+  VERSION = "3.0.0-beta.1"
 end

data/lib/valkyrie.rb

@@ -5,7 +5,6 @@ require 'active_support'
 require 'active_support/core_ext'
 require 'dry-types'
 require 'dry-struct'
-require 'draper'
 require 'reform'
 require 'rdf'
 require 'valkyrie/rdf_patches'
@@ -87,19 +86,6 @@ module Valkyrie
       Valkyrie::StorageAdapter.find(super.to_sym)
     end
 
-    # @api public
-    # Configure id_string_equality to be true in order to make Valkyrie::ID
-    # equal to the string value they contain. This will be the default behavior
-    # in v3.0.0.
-    #
-    # @return [Boolean] Whether `Valkyrie::ID` should be equal to their string counterpart.
-    def id_string_equality
-      super
-    end
-
-    # @!attribute [w] id_string_equality=
-    #   The setter for #id_string_equality; see it's implementation
-
     # @api public
     #
     # The returned anonymous method (e.g. responds to #call) has a signature of

data/valkyrie.gemspec

@@ -21,7 +21,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency 'dry-struct'
-  spec.add_dependency 'draper'
   spec.add_dependency 'activemodel'
   spec.add_dependency 'dry-types', '~> 1.0'
   spec.add_dependency 'rdf', '~> 3.0', '>= 3.0.10'
@@ -32,7 +31,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'json-ld'
   spec.add_dependency 'json'
   spec.add_dependency 'rdf-vocab'
-  spec.add_dependency 'disposable', '~> 0.4.5'
   spec.add_dependency 'faraday', '< 1.0'
 
   spec.add_development_dependency "bundler", "> 1.16.0", "< 3"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valkyrie
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 3.0.0.pre.beta.1
 platform: ruby
 authors:
 - Trey Pendragon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-05-06 00:00:00.000000000 Z
+date: 2021-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-struct
@@ -24,20 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: draper
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
@@ -184,20 +170,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: disposable
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.4.5
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.4.5
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -533,6 +505,7 @@ files:
 - lib/valkyrie/specs/shared_specs/resource.rb
 - lib/valkyrie/specs/shared_specs/solr_indexer.rb
 - lib/valkyrie/specs/shared_specs/storage_adapter.rb
+- lib/valkyrie/specs/shared_specs/write_only/metadata_adapter.rb
 - lib/valkyrie/storage.rb
 - lib/valkyrie/storage/disk.rb
 - lib/valkyrie/storage/fedora.rb
@@ -576,9 +549,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
 signing_key: