RubyGems - validocno - Versions diffs - 0.2.0 → 0.2.1 - Mend

validocno 0.2.0 → 0.2.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (10) hide show

data/lib/validocno/version.rb +1 -1
data/spec/fixtures/get_response.html +40 -0
data/spec/fixtures/invalid_post_response.html +13 -0
data/spec/fixtures/post_response.html +41 -0
data/spec/spec_helper.rb +3 -0
data/spec/validator_spec.rb +62 -3
data/spec/validocno_spec.rb +8 -32
data/validocno.gemspec +1 -0
metadata +82 -19
checksums.yaml +0 -7

data/lib/validocno/version.rb CHANGED Viewed

@@ -1,3 +1,3 @@
 module Validocno
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

data/spec/fixtures/get_response.html ADDED Viewed

@@ -0,0 +1,40 @@
+<div id="content1left" class="content" style="min-height: 500px;">
+  <br>
+  <p>
+  Teil on võimalus kontrollida isikut tõendavate dokumentide kehtivust,
+  kui sisestate dokumendi numbri. <b>NB!</b> Dokumendi numbris olevad tähed palume sisestada läbivalt suurte tähtedega.
+  </p>
+  <br>
+  <form name="reqForm" method="post" action="">
+    <input type="hidden" name="cmd" value="request">
+    <input type="hidden" name="csrf" value="iiGifsNdIY/OVVbEXnh3hMLtJgXsKomOlWKClE2DozCAo/KdBk0N7g==">
+    <table class="form">
+      <tbody>
+        <tr>
+          <td class="label">Dokumendi number:</td>
+          <td>
+            <input class="basicInputText" type="text"
+                   name="docNumber" size="20" maxlength="20" value="">
+          </td>
+        </tr>
+        <tr>
+          <td colspan="2">
+          </td>
+        </tr>
+        <tr>
+          <td colspan="2">
+          </td>
+        </tr>
+        <tr>
+          <td>
+          </td>
+          <td>
+            <input class="basicInputButton button100px" type="submit"
+                   name="subButton" value="Esita päring">
+          </td>
+        </tr>
+      </tbody>
+    </table>
+  </form>
+  <br>
+</div>

data/spec/fixtures/invalid_post_response.html ADDED Viewed

@@ -0,0 +1,13 @@
+<html>
+  <head>
+    <title>Wrong structure</title>
+  </head>
+  <body>
+    <div id="wrong">
+      <h1>Hello World</h1>
+      <p>
+        Wrong structure
+      </p>
+    </div>
+  </body>
+</html>

data/spec/fixtures/post_response.html ADDED Viewed

@@ -0,0 +1,41 @@
+<div id="content1left" class="content" style="min-height: 500px;">
+  <br>
+  <p>
+    Teil on võimalus kontrollida isikut tõendavate dokumentide kehtivust,
+    kui sisestate dokumendi numbri. <b>NB!</b> Dokumendi numbris olevad tähed palume sisestada läbivalt suurte tähtedega.
+  </p>
+  <br>
+  <form name="reqForm" method="post" action="">
+    <input type="hidden" name="cmd" value="request">
+    <input type="hidden" name="csrf" value="iiGifsNdIY/OVVbEXnh3hMLtJgXsKomOlWKClE2DozCAo/KdBk0N7g==">
+    <table class="form">
+      <tbody>
+        <tr>
+          <td class="label">Dokumendi number:</td>
+          <td>
+            <input class="basicInputText" type="text"
+                   name="docNumber" size="20" maxlength="20" value="">
+          </td>
+        </tr>
+        <tr>
+          <td colspan="2">
+          </td>
+        </tr>
+        <tr>
+          <td colspan="2">
+          </td>
+        </tr>
+        <tr>
+          <td>
+          </td>
+          <td>
+            <input class="basicInputButton button100px" type="submit"
+                   name="subButton" value="Esita päring">
+          </td>
+        </tr>
+      </tbody>
+    </table>
+  </form>
+  <br>
+  Dokument A1234567 on kehtiv.
+</div>

data/spec/spec_helper.rb CHANGED Viewed

@@ -1 +1,4 @@
 require 'validocno'
+require 'webmock/rspec'
+WebMock.disable_net_connect!(:allow_localhost => true)

data/spec/validator_spec.rb CHANGED Viewed

@@ -3,9 +3,41 @@ require 'spec_helper'
 describe Validocno::Validator do
   let(:doc_number) { 'A1234567' }
   let(:validator) { Validocno::Validator.new(doc_number) }
+  let(:get_response) do
+    body = File.new('spec/fixtures/get_response.html').read
+    Nokogiri::HTML(body)
+  end
+  let(:valid_nr_response) do
+    body = File.new('spec/fixtures/post_response.html').read
+    Nokogiri::HTML(body)
+  end
+  let(:expired_nr_response) do
+    body = File.new('spec/fixtures/post_response.html').read
+    body = body.gsub('A1234567', 'A0111856')
+    body = body.gsub('kehtiv', 'kehtetu')
+    Nokogiri::HTML(body)
+  end
+  let(:invalid_nr_response) do
+    body = File.new('spec/fixtures/post_response.html').read
+    body = body.gsub('A1234567', 'A1234567890')
+    body = body.gsub(
+      'Dokument A1234567890 on kehtiv.',
+      'Dokumenti A1234567890 ei ole välja antud.'
+    )
+    Nokogiri::HTML(body)
+  end
+  let(:invalid_post_response) do
+    body = File.new('spec/fixtures/invalid_post_response.html').read
+    Nokogiri::HTML(body)
+  end
   describe '.new' do
     it 'initializes with a document number' do
+      mock_response_with :get, :get
       expect(validator).to be
       expect { validator }.to_not raise_error
     end
@@ -15,23 +47,32 @@ describe Validocno::Validator do
     end
     it 'sets csrf_token instance variable' do
+      mock_response_with :get, :get
       expect(validator.csrf_token).to_not be_nil
     end
   end
   describe '#validate' do
     let(:invalid_doc_number) { 'A1234567890' }
     let(:expired_doc_number) { 'A0111856' }
-    let(:validator_with_invalid) { Validocno::Validator.new(invalid_doc_number) }
-    let(:validator_with_expired) { Validocno::Validator.new(expired_doc_number) }
+    let(:validator_with_invalid) do
+      Validocno::Validator.new(invalid_doc_number)
+    end
+    let(:validator_with_expired) do
+      Validocno::Validator.new(expired_doc_number)
+    end
     it 'returns hash with :valid and :message keys' do
+      mock_response_with :get, :get
+      mock_response_with :post, :valid_nr
       expect(validator.validate).to have_key(:valid)
       expect(validator.validate).to have_key(:message)
     end
     it 'validates document with valid number' do
+      mock_response_with :get, :get
+      mock_response_with :post, :valid_nr
       expect(validator.validate).to include(
         :valid => true,
         :message => "Dokument #{doc_number} on kehtiv."
@@ -39,6 +80,8 @@ describe Validocno::Validator do
     end
     it 'validates expired document' do
+      mock_response_with :get, :get
+      mock_response_with :post, :expired_nr
       expect(validator_with_expired.validate).to include(
         :valid => false,
         :message => "Dokument #{expired_doc_number} on kehtetu."
@@ -46,10 +89,26 @@ describe Validocno::Validator do
     end
     it 'validates document with invalid number' do
+      mock_response_with :get, :get
+      mock_response_with :post, :invalid_nr
       expect(validator_with_invalid.validate).to include(
         :valid => false,
         :message => "Dokumenti #{invalid_doc_number} ei ole välja antud."
       )
     end
+    it 'fails if node not found' do
+      mock_response_with :get, :get
+      mock_response_with :post, :invalid_post
+      expect { validator.validate }.to raise_error(StandardError)
+    end
+  end
+  private
+  def mock_response_with(type, response)
+    allow(Validocno::Client).to receive(type) { send("#{response}_response") }
+    allow_any_instance_of(Validocno::Validator).
+      to receive(:check_response) { true }
   end
 end

data/spec/validocno_spec.rb CHANGED Viewed

@@ -2,38 +2,14 @@ require 'spec_helper'
 describe Validocno do
   describe '.validate' do
-    let(:valid_doc_number) { 'A1234567' }
-    let(:expired_doc_number) { 'A0111856' }
-    let(:invalid_doc_number) { 'A1234567890' }
-    it 'returns hash with :valid and :message keys' do
-      expect(Validocno.validate(valid_doc_number)).to have_key(:valid)
-      expect(Validocno.validate(valid_doc_number)).to have_key(:message)
-    end
-    it 'validates document with valid number' do
-      expect(Validocno.validate(valid_doc_number)).to include(
-        :valid => true,
-        :message => "Dokument #{valid_doc_number} on kehtiv."
-      )
-    end
-    it 'validates expired document' do
-      expect(Validocno.validate(expired_doc_number)).to include(
-        :valid => false,
-        :message => "Dokument #{expired_doc_number} on kehtetu."
-      )
-    end
-    it 'validates document with invalid number' do
-      expect(Validocno.validate(invalid_doc_number)).to include(
-        :valid => false,
-        :message => "Dokumenti #{invalid_doc_number} ei ole välja antud."
-      )
-    end
-    it 'raises an error without a document number' do
-      expect { Validocno.validate }.to raise_error(ArgumentError)
+    let(:number) { 'A1234567' }
+    it 'calls Validocno::Validator#validate' do
+      allow_any_instance_of(Validocno::Validator).to receive(:csrf_token) {
+        'iiGifsNdIY/OVVbEXnh3hMLtJgXsKomOlWKClE2DozCAo/KdBk0N7g=='
+      }
+      expect_any_instance_of(Validocno::Validator).to receive(:validate)
+      Validocno.validate(number)
     end
   end
 end

data/validocno.gemspec CHANGED Viewed

@@ -27,4 +27,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.7'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.1.0'
+  spec.add_development_dependency 'webmock', '~> 1.20.0'
 end

metadata CHANGED Viewed

@@ -1,7 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: validocno
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  hash: 21
+  prerelease:
+  segments:
+  - 0
+  - 2
+  - 1
+  version: 0.2.1
 platform: ruby
 authors:
 - Artem Pakk
@@ -9,59 +15,100 @@ autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-12-04 00:00:00 Z
+date: 2014-12-09 00:00:00 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: &id001 !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - "="
       - !ruby/object:Gem::Version
+        hash: 51
+        segments:
+        - 0
+        - 11
+        - 0
         version: 0.11.0
-  prerelease: false
   version_requirements: *id001
-  type: :runtime
+  prerelease: false
   name: httparty
+  type: :runtime
 - !ruby/object:Gem::Dependency
   requirement: &id002 !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - &id006
-      - ">="
+    - - ">="
       - !ruby/object:Gem::Version
+        hash: 3
+        segments:
+        - 0
         version: "0"
-  prerelease: false
   version_requirements: *id002
-  type: :runtime
+  prerelease: false
   name: nokogiri
+  type: :runtime
 - !ruby/object:Gem::Dependency
   requirement: &id003 !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
+        hash: 1
+        segments:
+        - 1
+        - 7
         version: "1.7"
-  prerelease: false
   version_requirements: *id003
-  type: :development
+  prerelease: false
   name: bundler
+  type: :development
 - !ruby/object:Gem::Dependency
   requirement: &id004 !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
+        hash: 35
+        segments:
+        - 10
+        - 0
         version: "10.0"
-  prerelease: false
   version_requirements: *id004
-  type: :development
+  prerelease: false
   name: rake
+  type: :development
 - !ruby/object:Gem::Dependency
   requirement: &id005 !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
+        hash: 3
+        segments:
+        - 3
+        - 1
+        - 0
         version: 3.1.0
-  prerelease: false
   version_requirements: *id005
-  type: :development
+  prerelease: false
   name: rspec
+  type: :development
+- !ruby/object:Gem::Dependency
+  requirement: &id006 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        hash: 71
+        segments:
+        - 1
+        - 20
+        - 0
+        version: 1.20.0
+  version_requirements: *id006
+  prerelease: false
+  name: webmock
+  type: :development
 description: Ruby gem to check validity of Estonian ID card
 email:
 - artem.pakk@deskrock.ee
@@ -83,6 +130,9 @@ files:
 - lib/validocno/validator.rb
 - lib/validocno/version.rb
 - rubocop.yml
+- spec/fixtures/get_response.html
+- spec/fixtures/invalid_post_response.html
+- spec/fixtures/post_response.html
 - spec/spec_helper.rb
 - spec/validator_spec.rb
 - spec/validocno_spec.rb
@@ -90,29 +140,42 @@ files:
 homepage: https://github.com/deskrock/validocno
 licenses:
 - MIT
-metadata: {}
 post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
+      hash: 57
+      segments:
+      - 1
+      - 8
+      - 7
       version: 1.8.7
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - *id006
+  - - ">="
+    - !ruby/object:Gem::Version
+      hash: 3
+      segments:
+      - 0
+      version: "0"
 requirements: []
 rubyforge_project:
-rubygems_version: 2.0.14
+rubygems_version: 1.8.29
 signing_key:
-specification_version: 4
+specification_version: 3
 summary: Estonian ID card validator
 test_files:
+- spec/fixtures/get_response.html
+- spec/fixtures/invalid_post_response.html
+- spec/fixtures/post_response.html
 - spec/spec_helper.rb
 - spec/validator_spec.rb
 - spec/validocno_spec.rb

checksums.yaml DELETED Viewed

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: 4a796e1c3ed9671f9be2b7cb8a9e13d322cc10e5
-  data.tar.gz: 19f89fc43a3ab2ee3aa7be6e5ef9e0c06c632c02
-SHA512:
-  metadata.gz: c420d0018f0e9f22a016236c44def340e76283d2ec7710e32eb897d071c2abedec329dec404647bf5d976fe90fdc9382d382ed10508860ab8902494715690809
-  data.tar.gz: 9d596965f101a95758056b53cd07759dfb44d18a9e2fa55ca6c509cdc2ea182734e6639d690c0195e6ed4ae28c240db6b693809037902dc262a853a13eec8451