validocno 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 --- 
-SHA512: 
-  data.tar.gz: e304093ade6b07869240f13b2d965bc886afe6837287275c333abeadb5821cf1bf8585c0fbd6e4a340f63d12f383f89ee238257229a2f867112b0f593a72acef
-  metadata.gz: 8b8f554d4ec2eb480ff705872599f6394e32b5d07bf2389344f676c0f8a7c5e485922476b57d9d7688b1dd67bccf98fadf014612f3a222836e933a18de97f3a5
 SHA1: 
-  data.tar.gz: f74e88f86daa236c21f3dcc5e51fadc0588ff5c8
-  metadata.gz: 7df0320c190898d2d4c5829ab1d5015385134656
+  metadata.gz: 39e93c3f4784161ad642f67ef31d5c01097e42a8
+  data.tar.gz: b52f0bcc45b4ce28c05c2042d5b9fe1fb3ae5440
+SHA512: 
+  metadata.gz: 0248dd8e7065aa7d53787eef3007ad7fad74e85cd01fa348f37906b4acecfaabb9067fe6729d5f3439b2198d1a558cabd725f4f93127b534da592dea14180a92
+  data.tar.gz: fe920d230f9cb9383f7982a40a0846870d8f21ccd83c876a8aba1f8bd5124b7d9210ef57573e728290b967bc3533dea1121f487f21f4973a3c4dee5fa382a0c2

data/.rspec

@@ -0,0 +1 @@
--format documentation
+--color

data/README.md

@@ -21,12 +21,10 @@ Or install it yourself as:
 ## Usage
     > require 'validocno'
 
-    > document = Validocno::Validator.new 'A1234567'
-    > document.valid?
+    > Validocno.valid?('A1234567')
     => true
 
-    > document = Validocno::Validator.new 'A1234567890'
-    > document.valid?
+    > Validocno.valid?('A1234567890')
     => false
 
 ## Contributing

data/lib/validocno/validator.rb

@@ -0,0 +1,33 @@
+module Validocno
+  class Validator
+    CONTROL_URI = 'http://politsei.ee/et/teenused/e-paringud/dokumendi-kehtivuse-kontroll/'
+
+    def initialize(doc_number)
+      @doc_number = doc_number
+      @csrf_token = csrf_token
+    end
+
+    def csrf_token
+      response = Validocno::Client.get(CONTROL_URI)
+      response.at_css('#content1left form input[name="csrf"]')['value']
+    end
+
+    def response_string
+      options = {
+        :query => {
+          :cmd => 'request',
+          :csrf => @csrf_token,
+          :docNumber => @doc_number
+        }
+      }
+
+      response = Validocno::Client.post(CONTROL_URI, options)
+      response.at_css('#content1left').children.last.text.strip.to_s
+    end
+
+    def valid?
+      return true if response_string.match(/on kehtiv/)
+      false
+    end
+  end
+end

data/lib/validocno/version.rb

@@ -1,3 +1,3 @@
 module Validocno
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/lib/validocno.rb

@@ -7,39 +7,13 @@ require 'rubygems'
 require 'httparty'
 require 'nokogiri'
 
+require 'validocno/validator'
 require 'validocno/version'
 require 'validocno/http_client'
 
 module Validocno
-  class Validator
-    CONTROL_URI = 'http://politsei.ee/et/teenused/e-paringud/dokumendi-kehtivuse-kontroll/'
-
-    def initialize(doc_number)
-      @doc_number = doc_number
-      @csrf_token = csrf_token
-    end
-
-    def csrf_token
-      response = Validocno::Client.get(CONTROL_URI)
-      response.at_css('#content1left form input[name="csrf"]')['value']
-    end
-
-    def response_string
-      options = {
-        :query => {
-          :cmd => 'request',
-          :csrf => @csrf_token,
-          :docNumber => @doc_number
-        }
-      }
-
-      response = Validocno::Client.post(CONTROL_URI, options)
-      response.at_css('#content1left').children.last.text.strip.to_s
-    end
-
-    def valid?
-      return true if response_string.match(/on kehtiv/)
-      false
-    end
+  def self.valid?(doc_number)
+    validator = Validocno::Validator.new(doc_number)
+    validator.valid?
   end
 end

data/spec/validator_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe Validocno::Validator do
+  let(:doc_number) { 'A1234567' }
+  let(:validator) { Validocno::Validator.new(doc_number) }
+
+  describe '.new' do
+    it 'initializes with a document number' do
+      expect(validator).to be
+      expect { validator }.to_not raise_error
+    end
+
+    it 'raises an error without a document number' do
+      expect { Validocno::Validator.new }.to raise_error(ArgumentError)
+    end
+
+    it 'sets csrf_token instance variable' do
+      expect(validator.csrf_token).to_not be_nil
+    end
+
+  end
+
+  describe '#valid?' do
+    let(:invalid_doc_number) { 'A1234567890' }
+    let(:invalid_validator) { Validocno::Validator.new(invalid_doc_number) }
+
+    it 'returns true when document with valid number provided' do
+      expect(validator).to be_valid
+    end
+
+    it 'returns false when document with invalid number provided' do
+      expect(invalid_validator).to_not be_valid
+    end
+  end
+end

data/spec/validocno_spec.rb

@@ -1,28 +1,20 @@
 require 'spec_helper'
 
-describe Validocno::Validator do
-  describe '#initialize' do
-    it 'initializes new Validator object with document number' do
-      validator = Validocno::Validator.new('A1234567')
-      expect(validator).to be
-    end
-
-    it 'sets csrf_token instance variable' do
-      validator = Validocno::Validator.new('A1234567')
-      expect(validator.csrf_token).to_not be_nil
-    end
+describe Validocno do
+  describe '.valid?' do
+    let(:valid_doc_number) { 'A1234567' }
+    let(:invalid_doc_number) { 'A1234567890' }
 
-  end
-
-  describe '#valid?' do
     it 'returns true when document with valid number provided' do
-      validator = Validocno::Validator.new('A1234567')
-      expect(validator).to be_valid
+      expect(Validocno.valid?(valid_doc_number)).to be true
     end
 
     it 'returns false when document with invalid number provided' do
-      validator = Validocno::Validator.new('A123456789')
-      expect(validator).to_not be_valid
+      expect(Validocno.valid?(invalid_doc_number)).to be false
+    end
+
+    it 'raises an error without a document number' do
+      expect { Validocno.valid? }.to raise_error(ArgumentError)
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: validocno
 version: !ruby/object:Gem::Version 
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors: 
 - Artem Pakk
@@ -72,15 +72,18 @@ extra_rdoc_files: []
 
 files: 
 - .gitignore
+- .rspec
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - lib/validocno.rb
 - lib/validocno/http_client.rb
+- lib/validocno/validator.rb
 - lib/validocno/version.rb
 - rubocop.yml
 - spec/spec_helper.rb
+- spec/validator_spec.rb
 - spec/validocno_spec.rb
 - validocno.gemspec
 homepage: https://github.com/deskrock/validocno
@@ -112,4 +115,5 @@ specification_version: 4
 summary: Estonian ID card validator
 test_files: 
 - spec/spec_helper.rb
+- spec/validator_spec.rb
 - spec/validocno_spec.rb