validator-nric 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f3d2261299c9420bd15c70344beee9816fcfa6a2
-  data.tar.gz: 4de48ec5f800036bb0b03d789e4f6db96903a31c
+  metadata.gz: 4519cfffee6a44ba64c924238e8e340a101896a5
+  data.tar.gz: 9d6e02d7ac78bab245af14d9c2a3b790975b7458
 SHA512:
-  metadata.gz: 8f1b4f96be687f9257aa076b12c334af8a67fb992b356bd09092ad47bd8c669099aa6697522ac00ab3d063dce25857fd9fc3e890e052e03e1f098063b87dd95d
-  data.tar.gz: 594a8c6e2a3b833ac89f3e74313fec00161dedc258b9ac4ba29282e751a5a4825b91d7fbdc65dc94b8f868b74c5e4606aa882368c1910ca6a94360fe2854a7db
+  metadata.gz: 1e699c33aaa09b4dcdab9c5d0869cceed42faca104a0e0f0272e5f1e9a204770641d1270879df4077e3cca9e0519303d33f68cd199bd215488731481085c78e0
+  data.tar.gz: 3d6d44c196a58ef6fc1753e5402d5beb48cd708bebd2b9952f1621e2fc692d8309057bd7f032af22c012c0ea339bdc1e0d251c083fd0d45d03e1b372b0f97d86

data/.rubocop.yml

@@ -5,3 +5,6 @@ AllCops:
 
 Documentation:
   Enabled: false
+
+Metrics/BlockLength:
+  Max: 50

data/lib/validator/nric.rb

@@ -12,7 +12,7 @@ module Validator
     module_function
 
     # The multiplier for each individual digit
-    WEIGHT = [2, 7, 6, 5, 4, 3, 2]
+    WEIGHT = [2, 7, 6, 5, 4, 3, 2].freeze
 
     # Century prefix lookup tables
     #
@@ -23,10 +23,10 @@ module Validator
     #
     # Notice the it is backward of ABCDEFGHIZJ
     # For T and G, there is a shift of 4 places
-    S_TABLE = %w(J Z I H G F E D C B A)
-    T_TABLE = %w(G F E D C B A J Z I H)
-    F_TABLE = %w(X W U T R Q P N M L K)
-    G_TABLE = %w(R Q P N M L K X W U T)
+    S_TABLE = %w(J Z I H G F E D C B A).freeze
+    T_TABLE = %w(G F E D C B A J Z I H).freeze
+    F_TABLE = %w(X W U T R Q P N M L K).freeze
+    G_TABLE = %w(R Q P N M L K X W U T).freeze
 
     def mod(value)
       ic_array = value.each_char.map(&:to_i)
@@ -39,7 +39,7 @@ module Validator
 
     def check(nric)
       return false if nric.nil? || nric.size != 9
-      nric.upcase!
+      nric = nric.upcase
       return false unless %w(S T F G).include?(nric[0])
 
       century_prefix = nric[0, 1]

data/lib/validator/nric/version.rb

@@ -1,5 +1,5 @@
 module Validator
   module Nric
-    VERSION = '0.0.2'
+    VERSION = '0.0.3'.freeze
   end
 end

data/spec/spec_helper.rb

@@ -87,5 +87,4 @@ RSpec.configure do |config|
   # test failures related to randomization by passing the same `--seed` value
   # as the one that triggered the failure.
   Kernel.srand config.seed
-
 end

data/spec/validator/nric_spec.rb

@@ -1,5 +1,4 @@
 RSpec.describe Validator::Nric do
-
   describe 'check' do
     it 'returns false if nric is nil' do
       expect(subject.check(nil)).to be false
@@ -40,5 +39,4 @@ RSpec.describe Validator::Nric do
       expect(subject.lookup('S', 10)).to eq 'A'
     end
   end
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: validator-nric
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - mech
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-11 00:00:00.000000000 Z
+date: 2017-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -106,11 +106,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.2
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Validates Singapore NRIC
 test_files:
 - spec/spec_helper.rb
 - spec/validator/nric_spec.rb
-has_rdoc: