validation_profiler 1.3.4 → 1.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e81208909d259403e8b90697aeed8ef8bcd0d66e
-  data.tar.gz: c26fabf37e6cc9ff74a90bde7e5b88161e303058
+  metadata.gz: 7829ec1df6578a2bfe80d7724bd7fadce92494f5
+  data.tar.gz: b196fe267a544e1046774a9bbcb6428bc537a5b7
 SHA512:
-  metadata.gz: ed8245b2cc2d4aac5a32f9fc96adb0284bfc05a4c1df509e84b0339bcc79f5e8b77c019a476683257c7cdd407305f5cd31e217618c05b6f18a55720467edfa56
-  data.tar.gz: b75cc8fa44bf2265728f75101e9117c47787e107d6acb84d0cb7a235156f392528b6f69e745f0c1ceca09d942335a40aef64ce8e90b248febbe6a0f997b23737
+  metadata.gz: 78d04018153cc0434f32436b1d42b1d4cde2ea409906d25dec22f1b20c3c603c2e7716101ae35bedba91359d0f15c218f3650dca3e1d3608891fb805e3b4c414
+  data.tar.gz: cae3746d4cd3ac17ba7fa5c827073f51cfc84ca3c0d038fc7c2e11c9970c8e1e475cb619e2e53113272a873ed9957a8899f1592aea9a449bc80feeffb5b49db5

data/lib/validation_profiler/rules/time_validation_rule.rb

@@ -48,4 +48,4 @@ module ValidationProfiler
 
     end
   end
-end
+end

data/lib/validation_profiler/rules/validation_rule.rb

@@ -1,43 +1,43 @@
 module ValidationProfiler
   module Rules
     class ValidationRule
-
       def get_field_value(obj, field)
-        #attempt to get the field value from the object
+        # attempt to get the field value from the object
         field_value = nil
-        #check if the object is a hash
+
+        # check if the object is a hash
         if obj.is_a?(Hash)
           if obj.has_key?(field)
-            #get the field value
+            # get the field value
             field_value = obj[field]
           elsif obj.has_key?(field.to_s)
             field_value = obj[field.to_s]
           end
         else
-          #if the object does not contain the specified field raise an exception
-          if !obj.respond_to?(field)
-            raise ValidationProfiler::Exceptions::FieldNotFound.new(field)
-          end
+          # if the object does not contain the specified field raise an exception
+          raise ValidationProfiler::Exceptions::FieldNotFound, field unless obj.respond_to?(field)
 
-          #get the field value
+          # get the field value
           field_value = obj.send(field)
         end
       end
 
       def is_required?(field_value, attributes = {})
         required = attributes[:required]
-        if required == nil
-          required = true
-        end
+        required = true if required.nil?
 
-        #check if the field is required
-        if field_value == nil && required == false
-          return false
-        else
-          return true
-        end
+        # check if the field is required
+        return false if required_field?(field_value, required)
+        true
       end
 
+      private
+
+      def required_field?(field_value, required)
+        (field_value.nil? ||
+          (field_value.respond_to?(:empty?) && field_value.empty?)) &&
+          !required
+      end
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: validation_profiler
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.3.5
 platform: ruby
 authors:
 - Sage One
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-12-05 00:00:00.000000000 Z
+date: 2017-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler