validation_hints 8.1.19 → 8.1.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a63f8c6fa440f31200326f8154cc5354a656f62c7c31e9e0080c4d63215970c
-  data.tar.gz: '08183d70145bc652dcd5c686e2b154126bb07cd657a5d0b057b660e2486e9f91'
+  metadata.gz: fa2d51e94503ff4656ea0f9c90b45ea1616e7ffee979ca955f01b9e4704586a1
+  data.tar.gz: 7c27666b62f82f62c833ff502535eb666e75141196b1f59d49212680e7756ac5
 SHA512:
-  metadata.gz: 782c4cf1f1e60d73cef7413654f36e745b3b6303c1f996330d548d8e8892917e0ff9bc8ceff5d2149230fe12f260c33cd15237e96635c33e4f947f9c0a10f530
-  data.tar.gz: c3dbf979e54ffa77b364389a9805a6c4383ec64dda72611466a2b48222c91ba40a4ab76d21c7554595fbcf314a8da91908ceca5c4bbcec4bf0aaa064fbf89e71
+  metadata.gz: c2cad72f9115996ec3ea3e8a8a2f0cade7a6b5f1ae447d1a5da4984330263c3508d165ee94ab54d9807014bab62bb8e26e90d3ae524f992c069707dcc78d0a47
+  data.tar.gz: 0a56db43ba4abe2fa3545ca5e71e2afecb42a461549a4975e4b7f3566955a20a4d72e0ada001893b498c0afd34c543ac7e531c19843849de7c18bf7ec4a37832

data/CHANGELOG.md

@@ -2,6 +2,16 @@
 
 All notable changes to this project are documented here.
 
+## 8.1.20
+
+### Fixed
+
+- **A bare `validates :foo, numericality: true` now emits a `"must be a number"` hint — previously it emitted nothing.** `numericality` is listed in `VALIDATORS_WITHOUT_MAIN_KEYS`, so `Hints#messages_for_validator` computed the `numericality.must_be_a_number` base key but then skipped adding it under the `unless VALIDATORS_WITHOUT_MAIN_KEYS.include?(key)` guard. A bare `numericality: true` carries no option-specific keys (`only_integer`, ranges, `odd`/`even`, …), so the result was an **empty** hint list. The base `"must be a number"` message is now always emitted for `numericality`, with any option-specific messages appended after it. Existing option/range hints are unchanged except that they are now prefixed with `"must be a number"` (e.g. `only_integer` → `["must be a number", "must be an integer"]`; a `greater_than_or_equal_to`/`less_than_or_equal_to` range → `["must be a number", "must be greater than or equal to …", "must be less than or equal to …"]`).
+
+### Added
+
+- **`hints.messages.money` i18n key (`"must be a valid amount"`).** money-rails' `monetize` registers a `MoneyRails::ActiveModel::MoneyValidator` (validator key `money`) on the monetized attribute; without a mapping that produced no usable hint. The new key lets a money-validated attribute surface a meaningful label hint.
+
 ## 8.1.19
 
 ### Changed

data/lib/active_model/hints.rb

@@ -228,8 +228,15 @@ module ActiveModel
       end
 
       message_key = key
-      message_key = "numericality.must_be_a_number" if key == "numericality"
-      unless VALIDATORS_WITHOUT_MAIN_KEYS.include?(key)
+      if key == "numericality"
+        # +numericality+ is listed in VALIDATORS_WITHOUT_MAIN_KEYS so the
+        # guard below would skip its base message — but a bare
+        # +numericality: true+ carries no option-specific keys, so it would
+        # then emit nothing at all. Always surface the "must be a number"
+        # base hint here; option keys (only_integer, ranges, odd/even, …)
+        # are appended by the options loop below.
+        result << generate_message(attribute, "numericality.must_be_a_number", options)
+      elsif !VALIDATORS_WITHOUT_MAIN_KEYS.include?(key)
         result << generate_message(attribute, message_key, options)
       end
 

data/lib/validation_hints/locale/en.yml

@@ -26,6 +26,7 @@ en:
       confirmation: "doesn't match confirmation"
       acceptance: "must be accepted"
       presence: "can't be blank"
+      money: "must be a valid amount"
       length:
         maximum: "must not be longer than %{count} characters"
         minimum: "must not be shorter than %{count} characters"

data/lib/validation_hints/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module ValidationHints
-  VERSION = "8.1.19"
+  VERSION = "8.1.20"
 end

data/test/active_model/hints_test.rb

@@ -34,10 +34,39 @@ class ActiveModelHintsTest < Minitest::Test
 
   def test_numericality_option_hints
     hints = @person.hints[:age]
+    assert_includes hints, "must be a number"
     assert_includes hints, "must be an integer"
     assert_includes hints, "must be greater than 19"
   end
 
+  def test_bare_numericality_emits_must_be_a_number
+    model = Class.new(ActiveRecord::Base) do
+      self.table_name = "people"
+      validates :age, numericality: true
+      def self.name
+        "BareNumericalityModel"
+      end
+    end
+
+    assert_equal ["must be a number"], model.new.hints[:age]
+  end
+
+  def test_numericality_range_options_keep_their_messages
+    model = Class.new(ActiveRecord::Base) do
+      self.table_name = "people"
+      validates :age, numericality: { greater_than_or_equal_to: -90, less_than_or_equal_to: 90 }
+      def self.name
+        "RangeNumericalityModel"
+      end
+    end
+
+    hints = model.new.hints[:age]
+    assert_equal "must be a number", hints.first,
+      "expected the base must-be-a-number hint to come first"
+    assert_includes hints, "must be greater than or equal to -90"
+    assert_includes hints, "must be less than or equal to 90"
+  end
+
   def test_inclusion_hint_uses_list
     hints = @person.hints[:status]
     assert_equal 1, hints.size

data/test/validation_hints_test.rb

@@ -4,7 +4,7 @@ require "test_helper"
 
 class ValidationHintsTest < Minitest::Test
   def test_version
-    assert_equal "8.1.4", ValidationHints::VERSION
+    assert_equal "8.1.20", ValidationHints::VERSION
   end
 
   def test_locale_path_exists

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: validation_hints
 version: !ruby/object:Gem::Version
-  version: 8.1.19
+  version: 8.1.20
 platform: ruby
 authors:
 - Ace Suares