validation_delegation 0.0.2 → 0.0.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YTI4MDc4MTVlZTMzYTk3NDU3ZDBmNmJmNjEyNzU5OTJjYjY4ZTAxNQ==
+    NTNmNTZlODFiMmJhMGVjYWI4ZmM2MTNlMTc5NzUyMzA2NjRiZjc5Zg==
   data.tar.gz: !binary |-
-    NzAwZmExNjNkMmJlMTBiNDg1OTIwYzZhNWNjMDkzYmRiM2Y2MGFjMQ==
+    MjA4NmQ1NzlhYzE5M2JmNmI1YTM3ZWIwNWQ0ZjQ5Nzg2YWU4YjcwZg==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    NDM5OWQ1NjdiYjBjNmM1MTdjNjA2MmYzMDMwMTFiOTk2MTI0NWRmMTJlMzE1
-    YjMxN2M2MjllNGZmODJjODhkYWI1ZjVlODQxZjAyMTNiZTBhZDA3MDdmODg2
-    Y2Q2ZDMyNzQ0ZGJmMTVmNWQyZTcwMmVjZmVmODFlOGI5MjViMTM=
+    YzIyYTY4ZmFhNTUzOWI1M2U5MDYxMWQxMzUxZjJhM2Q0OWU5YjcwMWNiMjgw
+    MDJiN2U3MjM3MzQ2Y2ZkYzM5YjlkNmJlOTRlMTkxMDIwNjM2YzgyNDkxN2Fh
+    YWQwODg3MGJjZWMwNzcxMjFlMDhmYzQ1MmQ4ODdkYjYyNTYwZjM=
   data.tar.gz: !binary |-
-    MGYwZDY5NjBlMDY3ZTM5YmE4MmY4MDhkOTBhNzc0MzVlNTFhMjdlM2Y5NDU4
-    NWE3N2E1Y2M5NzE2OGMwNDY2OTAyYWU4ZjRlMzNmZGEzMzllMDdjZmQ1NDc2
-    MmYxMGQxNWUwY2Q4Yzk4NjY0Yjk0NDFmNTJmZmNkN2U5NTIyYzE=
+    YzUwNWNjY2U3MmU4MWFkZGUzMzM1NjkzZjYxZjE4YTRlMTAyOWUzMzA5N2E5
+    ZTY5MTk0OTI5MTgwNjg5OGNiNGIyYTM3ODNiZDljNjFjMGQ5MTgyZGYyNjZk
+    ZjJmYjAxOTg2MTA3MmFmZDhhZGViNGUxZmM1N2IwNTU4ZGZjODk=

data/README.md

@@ -31,6 +31,7 @@ end
 
 class SignUp
   include ActiveModel::Validations
+  include ValidationDelegation
 
   # delegate validation to the user
   delegate_validation to: :user
@@ -83,6 +84,7 @@ If you do not want to copy errors directly onto the composing object, you can sp
 ```Ruby
 class SignUp
   include ActiveModel::Model
+  include ValidationDelegation
 
   delegate_validation :organization, to: :organization
 
@@ -114,6 +116,8 @@ signup.errors.full_messages
 
 ```Ruby
 class SignUp
+  # ...
+
   delegate_validation to: :user, if: :validate_user?
 
   def validate_user?
@@ -126,6 +130,8 @@ end
 
 ```Ruby
 class SignUp
+  # ...
+
   delegate_validation to: :user, unless: :skip_validation?
 
   def skip_validation?
@@ -138,6 +144,8 @@ end
 
 ```Ruby
 class SignUp
+  # ...
+
   delegate_validation to: :user, only: :email
 end
 
@@ -154,6 +162,8 @@ signup.errors.full_messages
 
 ```Ruby
 class SignUp
+  # ...
+
   delegate_validation to: :user, except: :email
 end
 

data/lib/validation_delegation.rb

@@ -24,7 +24,7 @@ module ValidationDelegation
   end
 
   def format_attribute(attribute_name)
-    attribute_name.to_s.humanize.downcase.gsub(/\./, " ")
+    self.class.human_attribute_name(attribute_name).downcase
   end
 
   module ClassMethods

data/lib/validation_delegation/version.rb

@@ -1,3 +1,3 @@
 module ValidationDelegation
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/validation_delegation_spec.rb

@@ -85,7 +85,7 @@ describe ValidationDelegation do
     expect(subject).to have_error("is invalid").on(:attr)
   end
 
-  context "an method is supplied" do
+  context "a method is supplied" do
     it "copies errors to the specified method and prefixes the attribute name" do
       TestClass.delegate_validation :my_method, to: :validator
       expect(subject).to have_error("attr is invalid").on(:my_method)
@@ -99,11 +99,21 @@ describe ValidationDelegation do
       expect(subject).to have_error("attr is bananas").on(:my_method)
     end
 
-    it "reformats nested attribute errors" do
+    it "translates errors if possible" do
+      TestClass.delegate_validation :my_method, to: :validator
+
+      allow(TestClass).to receive(:human_attribute_name)
+        .with(:attr)
+        .and_return("Human attribute")
+
+      expect(subject).to have_error("human attribute is invalid").on(:my_method)
+    end
+
+    it "translates nested attribute errors" do
       TestClass.delegate_validation :my_method, to: :validator
       validator.errors[:"associated_class.attribute"] << "is bananas"
 
-      expect(subject).to have_error("associated class attribute is bananas").on(:my_method)
+      expect(subject).to have_error("attribute is bananas").on(:my_method)
     end
 
     it "copies errors if the :if option is true" do
@@ -143,5 +153,4 @@ describe ValidationDelegation do
       expect(subject).to have_error("attr is invalid").on(:my_method)
     end
   end
-
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: validation_delegation
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Ben Eddy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-03 00:00:00.000000000 Z
+date: 2014-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport