validates_serialized 0.0.5 → 0.0.6

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YjIwMjgyMDM4ZmYzODU0NzdiMzhlYjc2MTFhNDkyMzNkYzc3NzBhNA==
+    MGQ0NGRmZWEwNjRkNTRkZmE1MTE2NTE5YjlmZDliMTc5MjZhY2M2NA==
   data.tar.gz: !binary |-
-    ZjBjODhhN2NmMjM0Mzc2MDMyZjg0MTVlMzNiZGEwMjA4MzVmMjM3Yg==
+    NGUzM2I0YTU2MDkyNTIxNDE4N2VjOGE1ZmQ4YTliNWIzYmNiNzg5Yg==
 SHA512:
   metadata.gz: !binary |-
-    NmE0NzU3YzY1YTZiMGI1ZTkwNmRkZDcxYTVjZTc2NzkxNjE0OTAwNGZkMThm
-    ZmZhOTFhOWU3YmQ2ZTVkOGVkZGUxZTg2MTc3MmY3OTIwZmU5ZjJkYzg4ZDdl
-    OTZlOWU3MjRhNzBhNmI3MWQwZmUyYzE4M2U2MDhjMGNjMWU3OGU=
+    MWZjMmRjMDE0MDRkN2U4NmUzNjVhYjRmMzk2NmJiNWYxY2I4NmFlMWU4NGZm
+    MzQxZjYxMzkzZTJlODkxZmJhOTBjMTFiZGExY2VhYTRkYjliY2ViNzZlOWJm
+    NTY1N2M3ODkxMGI4MzRhZjEzMDQzN2IzN2UzM2ZjNzY2YjNkMmU=
   data.tar.gz: !binary |-
-    NmQxNGNiYTU1OGUxNTQ2ZjQzODVjZTExNWI2ZDc2YWRkODBmNzA1OWEyZWI5
-    NTk1Y2Y5NjRjMTI1MjA2NzE3Y2IyMzA5NmE2NWViMTA4NTUxMTRiZDVkMzNh
-    ZDhiZTkyYzg1ODM4NjRhNDAzOTM2OWQ1MmQ5ZmMwZThjN2M3MmQ=
+    ZDkyMGQyNWI5NTQ5Y2M3NGU2MjJiMjU3Y2IyOTcxYzcxOGNjYjhkYTNiYjJj
+    ZmYzZWRhMTAwMGI5NTc2YTAxZTQ1YWYzY2JmMTQ1NjA5NDY5NjlhODAxNzNh
+    OGFiYTg1MWJjZjM1ZWM1Njc4ZTk5NDcxOWY3NjExMzU4ZmJlY2Q=

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    validates_serialized (0.0.3)
+    validates_serialized (0.0.5)
       activemodel (>= 3.0, < 5.0)
 
 GEM

data/lib/validates_serialized/validateable_array_value.rb

@@ -1,17 +1,9 @@
 require 'active_model'
 
-class ValidateableArrayValue
+class ValidateableArrayValue < ValidateableObject
   include ::ActiveModel::Validations
 
-  def initialize(value)
-    @value = value
-  end
-
   def value
-    @value
-  end
-
-  def method_missing(sym, *args, &block)
-    @value.send sym, *args, &block
+    @object
   end
 end

data/lib/validates_serialized/validateable_hash.rb

@@ -1,15 +1,14 @@
 require 'active_model'
 
-class ValidateableHash < Hash
+class ValidateableHash < ValidateableObject
   include ::ActiveModel::Validations
 
-  def initialize(hash)
-    @hash = hash
-  end
-
   private
   def method_missing(method, *args, &block)
-    # Delegate all methods to access the hash
-    @hash[method]
+    if @object.keys.include?(method)
+      @object[method]
+    else
+      super
+    end
   end
 end

data/lib/validates_serialized/validateable_object.rb

@@ -10,5 +10,6 @@ class ValidateableObject
   private
   def method_missing(method, *args, &block)
     @object.send(method, *args, &block)
+  rescue NoMethodError => e
   end
 end

data/lib/validates_serialized/version.rb

@@ -1,3 +1,3 @@
 module ValidatesSerialized
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/lib/validates_serialized.rb

@@ -1,7 +1,7 @@
 require 'validates_serialized/version'
+require 'validates_serialized/validateable_object'
 require 'validates_serialized/validateable_array_value'
 require 'validates_serialized/validateable_hash'
-require 'validates_serialized/validateable_object'
 require 'validates_serialized/each_validator'
 require 'validates_serialized/validators/serialized_validator'
 require 'validates_serialized/validators/array_validator'

data/spec/acceptance_spec.rb

@@ -103,9 +103,9 @@ describe ValidatesSerialized do
     model.should be_valid
   end
 
-  it "raises error without Serialized author" do
+  it "is invalid without Serialized author" do
     model = Blog.new(ratings: [1, 3, 1], comments: { admin: "This is great!" })
-    expect { model.valid? }.to raise_error
+    model.should_not be_valid
   end
 
   it "is invalid without author name" do

data/spec/validateable_array_value_spec.rb

@@ -14,7 +14,17 @@ describe ValidateableArrayValue do
     subject.errors.should be_empty
   end
 
-  it "returns itself on :value method" do
-    subject.value.should eq(1)
+  describe "delegating attributes" do
+    it "returns itself on :value method" do
+      subject.value.should eq(1)
+    end
+
+    it "delegates object methods without error" do
+      expect { subject.object_id }.not_to raise_error
+    end
+
+    it "does not raise error for non-existent methods" do
+      expect { subject.arglebargle }.not_to raise_error
+    end
   end
 end

data/spec/validateable_hash_spec.rb

@@ -25,6 +25,14 @@ describe ValidateableHash do
     it "returns nil for non-existent key_3" do
       subject.key_3.should be_nil
     end
+
+    it "delegates object methods without error" do
+      expect { subject.object_id }.not_to raise_error
+    end
+
+    it "does not raises error for non-existent methods" do
+      expect { subject.arglebargle }.not_to raise_error
+    end
   end
 
   describe "validation block" do

data/spec/validateable_object_spec.rb

@@ -43,6 +43,14 @@ describe ValidateableObject do
     it "delegates name attribute" do
       subject.name.should eq("Thomas")
     end
+
+    it "delegates object methods without error" do
+      expect { subject.object_id }.not_to raise_error
+    end
+
+    it "does not raise error for non-existent methods" do
+      expect { subject.arglebargle }.not_to raise_error
+    end
   end
 
   describe "validation block" do
@@ -66,7 +74,7 @@ describe ValidateableObject do
       subject.class_eval do
         validates :other_property, inclusion: { in: [ 'a', 'b', 'c' ] }
       end
-      expect { subject.valid? }.to raise_error(NoMethodError)
+      expect { subject.valid? }.not_to raise_error
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: validates_serialized
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - brycesenz