validates_lengths_from_database 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b858050297bdf446939c8671bc1b2260345e6bc223762cb0a533264e8dce2b1a
-  data.tar.gz: a5f5f3f169cb2919f1bedd7baa548cebb4a75730ca953280636e4f1fa3058a73
+  metadata.gz: 9b22b423bd4a2bdda0b3acd66414b3621c2a003ef8f80b8983aca80989a45331
+  data.tar.gz: 695bf47b2bcd53dd6d7847df84ef296f68590121c958db72dfedaea60e120cde
 SHA512:
-  metadata.gz: 0d704d3980c28cbca2d1c09936d664e02d457ad311b570c1e01c5ca247b7e43129d90b8c82b8edb6c22978971a0a3c96e3dcf49e1791b06f33d9ec7db61b8e2a
-  data.tar.gz: b5b2d7c0c087479073b8b983c2dbc067531802a9f86b4eea76e72ec6d36e96bc85b34d01125ea3bb7316172e6fae8751b2a1c10ad58ef472bd7fa36caf8e1992
+  metadata.gz: f645747fd9a6669e2680f7a9bdb5b8c5e046a38f3289cc90dc0c08141b17df9dbe4f3023795b5158a9851aff9733ac3b3db6dec257ed2268e2623278a7e08986
+  data.tar.gz: 1b4eff8c550f2bb5c02073cc6c5c88f9e4c1e224d1eebbf517e7bfdde57d43bb47d4b8019e264fc45167fea87622952372fcdd8c249d724b4c7dc8efed3a9964

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## v1.1.0 (unreleased)
+
+- Validate that integer columns can hold the value, including MySQL `TINYINT` and `UNSIGNED` columns. Values Rails would refuse to save with an `ActiveModel::RangeError` now fail validation with "is out of range" (the `out_of_range` key) instead (#33)
+
 ## v1.0.1 (unreleased)
 
 - Add `validates_lengths_from_database` to ActiveRecord::Base whenever the gem is required, so it works without Rails and no longer depends on Rails being loaded first (#23)

data/README.md

@@ -87,6 +87,7 @@ end
 * **String (`VARCHAR`) columns** are limited to the column's length in characters.
 * **`TEXT` columns** are limited to the column's length in bytes, since that is how MySQL measures them.
 * **`DECIMAL` columns** with a precision and scale must fit within them. For example, `DECIMAL(5,2)` accepts -999.99 through 999.99.
+* **Integer columns** must fit the column's size, such as -32,768 through 32,767 for `SMALLINT`, including MySQL's `TINYINT` and `UNSIGNED` columns. These are exactly the values Rails would otherwise refuse to save with an `ActiveModel::RangeError`. Use `except:` to skip a column.
 
 Columns without a limit are skipped, so what this gem does depends on your database:
 
@@ -94,10 +95,11 @@ Columns without a limit are skipped, so what this gem does depends on your datab
 * **PostgreSQL**: Rails creates `t.string` columns with no length limit, and `TEXT` columns never have one, so only columns declared with an explicit `limit:` are validated.
 * **SQLite**: limits declared in migrations are validated, even though SQLite itself does not enforce them.
 
-## Translating the bytes error message
+## Translating error messages
 
 `TEXT` columns that are too long get the `too_long_bytes` error, which defaults to "is too long (maximum is %{count} bytes)".
-Override it in your locale files like any other ActiveModel error message:
+Integers that don't fit their column get the `out_of_range` error, which defaults to "is out of range".
+Override them in your locale files like any other ActiveModel error message:
 
 ```yaml
 en:
@@ -106,6 +108,7 @@ en:
       too_long_bytes:
         one: "is too long (maximum is 1 byte)"
         other: "is too long (maximum is %{count} bytes)"
+      out_of_range: "is out of range"
 ```
 
 ## Running Tests

data/config/locales/en.yml

@@ -4,3 +4,4 @@ en:
       too_long_bytes:
         one: "is too long (maximum is 1 byte)"
         other: "is too long (maximum is %{count} bytes)"
+      out_of_range: "is out of range"

data/lib/validates_lengths_from_database/core.rb

@@ -57,7 +57,7 @@ module ValidatesLengthsFromDatabase
 
       next if column_schema.nil?
       next if column_schema.respond_to?(:array) && column_schema.array
-      next unless [:string, :text, :decimal].include?(column_schema.type)
+      next unless [:string, :text, :decimal, :integer].include?(column_schema.type)
 
       case column_schema.type
       when :string
@@ -72,6 +72,8 @@ module ValidatesLengthsFromDatabase
         if column_schema.precision && column_schema.scale
           validate_numericality_with_precision(column, column_schema)
         end
+      when :integer
+        validate_integer_range(column)
       end
     end
   end
@@ -105,4 +107,13 @@ module ValidatesLengthsFromDatabase
       :greater_than => -max_val
     ).validate(self)
   end
+
+  # The column type knows its byte size and, on MySQL, whether it is unsigned,
+  # and serializable? is false for exactly the values Rails would refuse to save.
+  def validate_integer_range(column)
+    value = read_attribute_for_validation(column)
+    return if value.nil?
+
+    errors.add(column, :out_of_range) unless self.class.type_for_attribute(column).serializable?(value)
+  end
 end

data/lib/validates_lengths_from_database/version.rb

@@ -1,3 +1,3 @@
 module ValidatesLengthsFromDatabase
-  VERSION = "1.0.1"
+  VERSION = "1.1.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: validates_lengths_from_database
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Ben Hughes