validates_lengths_from_database 0.2.0 → 0.3.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: ec5757dde636f6b3d800c8a95b29aace5cfa1ce5
+  data.tar.gz: 41825787b212ff9cc5a06462e86007c00e9d17b9
+SHA512:
+  metadata.gz: b643589ff56a2155c33453422d525256fd012e00ff6b254d6b618c22fc31a776c2ba045c99c1816eb68ea91a2db4a1a9d617f20f0ee3797832e2bc3dbfe6317e
+  data.tar.gz: f398c90a2e7f11fe16abbd54b4a3d799f6ded5ccbb67c87464b40349286d729206cda438895799f83898846f5dbf05ceb4b80f1db355c6004fc27d264655d86c

data/Appraisals

@@ -1,20 +1,27 @@
-appraise "rails-2.3" do
+appraise "2.3" do
   gem "rails", "~> 2.3.2"
-  gem "validates_lengths_from_database", :path => "../"
 end
 
-appraise "rails-3.0" do
+appraise "3.0" do
   gem "rails", "~> 3.0.12"
-  gem "validates_lengths_from_database", :path => "../"
 end
 
-appraise "rails-3.1" do
+appraise "3.1" do
   gem "rails", "~> 3.1.4"
-  gem "validates_lengths_from_database", :path => "../"
 end
 
-appraise "rails-3.2" do
+appraise "3.2" do
   gem "rails", "~> 3.2.2"
-  gem "validates_lengths_from_database", :path => "../"
 end
 
+appraise "4.0" do
+  gem "rails", "~> 4.0.12"
+end
+
+appraise "4.1" do
+  gem "rails", "~> 4.1.8"
+end
+
+appraise "4.2" do
+  gem "rails", "~> 4.2.0"
+end

data/CHANGELOG

@@ -0,0 +1,7 @@
+== v0.3.0 (2015-01-03)
+
+* Explicit support for Rails 4.1 and 4.2
+* Up-to-date Appraisals and dependencies
+* Better support for postgres text columns via conditional length validation
+* Bug fix for postgres array column types
+

data/Gemfile.lock

@@ -1,32 +1,35 @@
 PATH
   remote: .
   specs:
-    validates_lengths_from_database (0.1.3)
+    validates_lengths_from_database (0.2.0)
       activerecord (>= 2.3.2)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    activemodel (3.2.2)
-      activesupport (= 3.2.2)
+    activemodel (3.2.12)
+      activesupport (= 3.2.12)
       builder (~> 3.0.0)
-    activerecord (3.2.2)
-      activemodel (= 3.2.2)
-      activesupport (= 3.2.2)
+    activerecord (3.2.12)
+      activemodel (= 3.2.12)
+      activesupport (= 3.2.12)
       arel (~> 3.0.2)
       tzinfo (~> 0.3.29)
-    activesupport (3.2.2)
+    activesupport (3.2.12)
       i18n (~> 0.6)
       multi_json (~> 1.0)
-    appraisal (0.4.1)
+    appraisal (1.0.2)
       bundler
       rake
-    arel (3.0.2)
-    builder (3.0.0)
+      thor (>= 0.14.0)
+    arel (3.0.3)
+    builder (3.0.4)
     diff-lcs (1.1.2)
     i18n (0.6.0)
+    iconv (1.0.4)
     json (1.6.6)
-    multi_json (1.2.0)
+    multi_json (1.10.1)
+    pg (0.17.1)
     rake (0.9.2.2)
     rdoc (3.12)
       json (~> 1.4)
@@ -39,14 +42,18 @@ GEM
       diff-lcs (~> 1.1.2)
     rspec-mocks (2.5.0)
     sqlite3 (1.3.5)
-    tzinfo (0.3.32)
+    thor (0.19.1)
+    tzinfo (0.3.42)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  appraisal (~> 0.4.0)
+  activesupport (>= 2.3.2)
+  appraisal (~> 1.0.2)
   i18n
+  iconv (~> 1.0.3)
+  pg (~> 0.17.1)
   rake
   rdoc (~> 3.12)
   rspec (~> 2.0)

data/README.rdoc

@@ -1,4 +1,6 @@
 {<img src="https://secure.travis-ci.org/rubiety/validates_lengths_from_database.png?branch=master" alt="Build Status" />}[http://travis-ci.org/rubiety/validates_lengths_from_database]
+{<img src="https://gemnasium.com/rubiety/validates_lengths_from_database.png" alt="Dependency Status" />}[https://gemnasium.com/rubiety/validates_lengths_from_database]
+{<img src="https://codeclimate.com/github/rubiety/validates_lengths_from_database.png" />}[https://codeclimate.com/github/rubiety/validates_lengths_from_database]
 
 == Validates Lengths from Database
 
@@ -43,3 +45,13 @@ Or to set the limit differently for string (VARCHAR) and (TEXT) columns:
 
 Note that unfortunately this cannot be done at a global level directly against ActiveRecord::Base, since the +validates_length_from_database+ method requires the class to have a table name (with the ability to load the schema).
 
+== Running Tests
+
+This gem uses appraisal to test with different versions of the dependencies. See Appraisal first for which versions are tested.
+
+  # Just the gems locked in Gemfile.lock
+  $ rake test
+
+  # All of the Appraisals:
+  $ rake appraisal test
+

data/Rakefile

@@ -3,18 +3,11 @@ require 'bundler/setup'
 
 require 'rake'
 require 'rspec/core/rake_task'
-require 'appraisal'
 
 Bundler::GemHelper.install_tasks
 
 desc 'Default: run unit tests.'
-task :default => [:clean, :all]
-
-desc "Run Specs against all Appraisals"
-task :all => :spec do
-  Rake::Task["appraisal:install"].execute
-  system("bundle exec rake -s appraisal spec")
-end
+task :default => [:clean, :test]
 
 desc "Run Specs"
 RSpec::Core::RakeTask.new(:spec) do |t|

data/lib/validates_lengths_from_database.rb

@@ -31,7 +31,8 @@ module ValidatesLengthsFromDatabase
         column_schema = columns.find {|c| c.name == column }
         next if column_schema.nil?
         next if ![:string, :text].include?(column_schema.type)
-        
+        next if column_schema.respond_to?(:array) && column_schema.array
+
         column_limit = options[:limit][column_schema.type] || column_schema.limit
         next unless column_limit
 

data/lib/validates_lengths_from_database/version.rb

@@ -1,3 +1,3 @@
 module ValidatesLengthsFromDatabase
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/spec/db/schema.rb

@@ -1,19 +1,33 @@
 ActiveRecord::Schema.define(:version => 0) do
-  
   create_table :articles, :force => true do |t|
     t.string :string_1, :limit => 5
     t.string :string_2, :limit => 5
-    t.text :text_1, :limit => 5
+
+    if postgresql?
+      # PostgreSQL doesn't support limits on text columns
+      t.text :text_1
+    else
+      t.text :text_1, :limit => 5
+    end
+
     t.date :date_1
     t.integer :integer_1
+
+    if database_supports_arrays?
+      t.string :array_1, :array => true, :limit => 5
+    end
   end
-  
+
   create_table :articles_high_limit, :force => true do |t|
     t.string :string_1
     t.string :string_2
     t.text :text_1
     t.date :date_1
     t.integer :integer_1
+
+    if database_supports_arrays?
+      t.string :array_1, :array => true
+    end
   end
-  
 end
+

data/spec/spec_helper.rb

@@ -1,12 +1,26 @@
 require "rubygems"
 require "rspec"
 require "active_record"
+require "active_support"
+require "yaml"
 
 # Establish DB Connection
 config = YAML::load(IO.read(File.join(File.dirname(__FILE__), 'db', 'database.yml')))
 ActiveRecord::Base.configurations = {'test' => config[ENV['DB'] || 'sqlite3']}
 ActiveRecord::Base.establish_connection(ActiveRecord::Base.configurations['test'])
 
+def database_supports_arrays?
+  postgresql? && active_record_4?
+end
+
+def postgresql?
+  ActiveRecord::Base.connection.instance_values["config"][:adapter] == 'postgresql'
+end
+
+def active_record_4?
+  ActiveRecord::VERSION::MAJOR >= 4
+end
+
 # Load Test Schema into the Database
 load(File.dirname(__FILE__) + "/db/schema.rb")
 

data/spec/validates_lengths_from_database_spec.rb

@@ -26,7 +26,7 @@ describe ValidatesLengthsFromDatabase do
     specify "defining validates_lengths_from_database should not raise an error" do
       lambda {
         class InvalidTableArticle < ActiveRecord::Base
-          set_table_name "articles_invalid"
+          self.table_name = "articles_invalid"
           validates_lengths_from_database
         end
       }.should_not raise_error
@@ -36,7 +36,7 @@ describe ValidatesLengthsFromDatabase do
   context "Model with validates_lengths_from_database" do
     before do
       class ArticleValidateAll < ActiveRecord::Base
-        set_table_name "articles"
+        self.table_name = "articles"
         validates_lengths_from_database
       end
     end
@@ -51,7 +51,7 @@ describe ValidatesLengthsFromDatabase do
       it "should have errors on all string/text attributes" do
         @article.errors["string_1"].join.should =~ /too long/
         @article.errors["string_2"].join.should =~ /too long/
-        @article.errors["text_1"].join.should =~ /too long/
+        @article.errors["text_1"].join.should =~ /too long/  unless postgresql?  # PostgreSQL doesn't support limits on text columns
       end
     end
 
@@ -62,12 +62,22 @@ describe ValidatesLengthsFromDatabase do
         @article.should be_valid
       end
     end
+
+    if database_supports_arrays?
+      context "an article with with string array attribute" do
+        before { @article = ArticleValidateAll.new(:array_1 => %w(1 2 3 4 5 6 7 8 9 10)); @article.valid? }
+
+        it "should be valid" do
+          @article.should be_valid
+        end
+      end
+    end
   end
-  
-  context "Model with validates_lengths_from_database :limit => 10" do
+
+  context "Model with validates_lengths_from_database :limit => 5" do
     before do
       class ArticleValidateLimit < ActiveRecord::Base
-        set_table_name "articles_high_limit"
+        self.table_name = "articles_high_limit"
         validates_lengths_from_database :limit => 5
       end
     end
@@ -94,11 +104,11 @@ describe ValidatesLengthsFromDatabase do
       end
     end
   end
-  
+
   context "Model with validates_lengths_from_database :limit => {:string => 5, :text => 100}" do
     before do
       class ArticleValidateSpecificLimit < ActiveRecord::Base
-        set_table_name "articles_high_limit"
+        self.table_name = "articles_high_limit"
         validates_lengths_from_database :limit => {:string => 5, :text => 100}
       end
     end
@@ -117,11 +127,11 @@ describe ValidatesLengthsFromDatabase do
       end
     end
   end
-  
+
   context "Model with validates_lengths_from_database :only => [:string_1, :text_1]" do
     before do
       class ArticleValidateOnly < ActiveRecord::Base
-        set_table_name "articles"
+        self.table_name = "articles"
         validates_lengths_from_database :only => [:string_1, :text_1]
       end
     end
@@ -136,7 +146,7 @@ describe ValidatesLengthsFromDatabase do
       it "should have errors on only string_1 and text_1" do
         @article.errors["string_1"].join.should =~ /too long/
         (@article.errors["string_2"] || []).should be_empty
-        @article.errors["text_1"].join.should =~ /too long/
+        @article.errors["text_1"].join.should =~ /too long/ unless postgresql?  # PostgreSQL doesn't support limits on text columns
       end
     end
 
@@ -152,7 +162,7 @@ describe ValidatesLengthsFromDatabase do
   context "Model with validates_lengths_from_database :except => [:string_1, :text_1]" do
     before do
       class ArticleValidateExcept < ActiveRecord::Base
-        set_table_name "articles"
+        self.table_name = "articles"
         validates_lengths_from_database :except => [:string_1, :text_1]
       end
     end
@@ -179,5 +189,5 @@ describe ValidatesLengthsFromDatabase do
       end
     end
   end
-  
+
 end

metadata

@@ -1,93 +1,155 @@
 --- !ruby/object:Gem::Specification
 name: validates_lengths_from_database
 version: !ruby/object:Gem::Version
-  version: 0.2.0
-  prerelease: 
+  version: 0.3.0
 platform: ruby
 authors:
 - Ben Hughes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-01 00:00:00.000000000Z
+date: 2015-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70330927789240 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.2
   type: :runtime
   prerelease: false
-  version_requirements: *70330927789240
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.3.2
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.3.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.3.2
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70330927787800 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :development
   prerelease: false
-  version_requirements: *70330927787800
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &70330927781040 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.4
   type: :development
   prerelease: false
-  version_requirements: *70330927781040
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.4
 - !ruby/object:Gem::Dependency
   name: appraisal
-  requirement: &70330927779540 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 1.0.2
   type: :development
   prerelease: false
-  version_requirements: *70330927779540
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.2
+- !ruby/object:Gem::Dependency
+  name: pg
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.17.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.17.1
 - !ruby/object:Gem::Dependency
   name: rdoc
-  requirement: &70330927777720 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.12'
   type: :development
   prerelease: false
-  version_requirements: *70330927777720
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.12'
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70330927776440 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70330927776440
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &70330927774820 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70330927774820
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: iconv
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.3
 description: Introspects your database string field maximum lengths and automatically
   defines length validations.
 email: ben@railsgarden.com
@@ -95,44 +157,45 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- Appraisals
+- CHANGELOG
+- Gemfile
+- Gemfile.lock
+- LICENSE
+- README.rdoc
+- Rakefile
+- init.rb
+- lib/validates_lengths_from_database.rb
 - lib/validates_lengths_from_database/railtie.rb
 - lib/validates_lengths_from_database/version.rb
-- lib/validates_lengths_from_database.rb
+- rails/init.rb
 - spec/db/database.yml
 - spec/db/schema.rb
 - spec/db/test.sqlite3
 - spec/spec_helper.rb
 - spec/validates_lengths_from_database_spec.rb
-- rails/init.rb
-- Appraisals
-- Gemfile
-- Gemfile.lock
-- LICENSE
-- Rakefile
-- README.rdoc
-- init.rb
 homepage: http://github.com/rubiety/validates_lengths_from_database
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.3.4
 requirements: []
 rubyforge_project: validates_lengths_from_database
-rubygems_version: 1.8.10
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Automatic maximum-length validations.
 test_files: []
+has_rdoc: