validates_email_format_of 1.8.0 → 1.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2329a74ad3d6ce656ab392715c9c2cbda4c4af6fbffcce69f5e98afd8018f0ae
-  data.tar.gz: 4ad12aef8277878f61c32a82b231d58251fe2e674ed262a021814075e9df2b17
+  metadata.gz: 11c21b2a28ee1659e6727cc106aaf912487adf9b519eceeebd68f3dbb1750b88
+  data.tar.gz: 8db0acd0c16c49e5042640bf159aa75caad8f75b899a5df91527d66c899012aa
 SHA512:
-  metadata.gz: b454131a1c1f7ded070a65144ccbb9a27add0efa96ce681b578d9e7497f39234b1985863327a51e2179752dc06b9586978c762accaf5daea7e600df34cf11599
-  data.tar.gz: 76badfe2f7d9b8b75142c2f9b369f485d5b0cd6d3db660206e120bd9eb426f1ed8bd089e58bcb9651c64e5e47ea589eef8c040021da8adb3635957e1f1e3fd27
+  metadata.gz: c3fcec1122983e8bbcff3e8a388260d040851467dbb89d6a1157e38ab59fbe908c3b8c69793ac2166ee1cedaf1d78d0c6613fc4ac8c450fb523c45fda1821b59
+  data.tar.gz: dbc08e3633edf9d254e80d6614795a36f4c806046aa6dafb1c0aa46e9aa729f19701fbf533be9253138d119b35c8203fdea1a64a87c6c364e0e53ded94e23a7c

data/.github/workflows/ci.yml

@@ -1,7 +1,6 @@
 name: CI
 
 on:
-  - push
   - pull_request
 
 permissions:
@@ -15,7 +14,7 @@ jobs:
 
     strategy:
       matrix:
-        ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
+        ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3", "jruby-head"]
         gemfile: ["4.2", "5.0", "5.1", "5.2", "6.0", "6.1", "7.0", "7.1"]
 
         exclude:
@@ -27,6 +26,8 @@ jobs:
             ruby: "3.2"
           - gemfile: "4.2"
             ruby: "3.3"
+          - gemfile: "4.2"
+            ruby: "jruby-head"
           - gemfile: "5.0"
             ruby: "3.0"
           - gemfile: "5.0"
@@ -35,6 +36,8 @@ jobs:
             ruby: "3.2"
           - gemfile: "5.0"
             ruby: "3.3"
+          - gemfile: "5.0"
+            ruby: "jruby-head"
           - gemfile: "5.1"
             ruby: "3.0"
           - gemfile: "5.1"
@@ -43,6 +46,8 @@ jobs:
             ruby: "3.2"
           - gemfile: "5.1"
             ruby: "3.3"
+          - gemfile: "5.1"
+            ruby: "jruby-head"
           - gemfile: "5.2"
             ruby: "3.0"
           - gemfile: "5.2"
@@ -51,6 +56,8 @@ jobs:
             ruby: "3.2"
           - gemfile: "5.2"
             ruby: "3.3"
+          - gemfile: "5.2"
+            ruby: "jruby-head"
           - gemfile: "6.0"
             ruby: "3.2"
           - gemfile: "6.0"

data/CHANGELOG.md

@@ -2,7 +2,20 @@
 
 ## [Unreleased]
 
-[Unreleased]: https://github.com/validates-email-format-of/validates_email_format_of/compare/v1.8.0...master
+[Unreleased]: https://github.com/validates-email-format-of/validates_email_format_of/compare/v1.8.2...master
+
+## [1.8.2]
+
+* Improve German translations - https://github.com/validates-email-format-of/validates_email_format_of/pull/111
+
+[1.8.2]: https://github.com/validates-email-format-of/validates_email_format_of/compare/v1.8.1...1.8.2
+
+## [1.8.1]
+
+* Fix IDN->Punycode conversion when domain names start with periods - https://github.com/validates-email-format-of/validates_email_format_of/issues/109
+* Add jruby to test matrix - https://github.com/validates-email-format-of/validates_email_format_of/pull/108
+
+[1.8.1]: https://github.com/validates-email-format-of/validates_email_format_of/compare/v1.8.0...1.8.1
 
 ## [1.8.0]
 
@@ -13,13 +26,13 @@
 * ⚠️ Deprecate `:with` option - https://github.com/validates-email-format-of/validates_email_format_of/issues/42
 * Require i18n >= 0.8.0 in modern Ruby versions - https://github.com/advisories/GHSA-34hf-g744-jw64
 
-[Unreleased]: https://github.com/validates-email-format-of/validates_email_format_of/compare/v1.7.2...master
+[1.8.0]: https://github.com/validates-email-format-of/validates_email_format_of/compare/v1.7.2...1.8.0
 
 ## [1.7.2]
 
 * Fix regression that disallowed domains starting with number - https://github.com/validates-email-format-of/validates_email_format_of/issues/88
 
-[Unreleased]: https://github.com/validates-email-format-of/validates_email_format_of/compare/v1.7.1...v1.7.2
+[1.7.2]: https://github.com/validates-email-format-of/validates_email_format_of/compare/v1.7.1...v1.7.2
 
 ## [1.7.1] (3 Aug 2022)
 

data/README.md

@@ -2,13 +2,13 @@
 
 [![Build Status](https://github.com/validates-email-format-of/validates_email_format_of/actions/workflows/ci.yml/badge.svg)]( https://github.com/validates-email-format-of/validates_email_format_of/actions/workflows/ci.yml?query=branch%3Amaster)
 
-A Ruby gem to validate email addresses against RFC 2822 and RFC 5322.
+A Ruby gem to validate email addresses against RFC 2822 and RFC 5322, with optional domain name lookups.
 
 ## Why this email validator?
 
 This gem is the O.G. email validation gem for Rails.  It was started back in 2006.
 
-Why use this validator?  Instead of trying to validate email addresses with one giant regular expression, this library parses addresses character by character.  This lets us handle weird cases like [nested comments](https://www.rfc-editor.org/rfc/rfc5322#appendix-A.5).  Gross but technically allowed.
+Why use this validator?  Instead of trying to validate email addresses with one giant regular expression, this library parses addresses character by character.  This lets us handle weird cases like [nested comments](https://www.rfc-editor.org/rfc/rfc5322#appendix-A.5).  Gross, but technically allowed.
 
 In reality, most email validating scripts will get you where you need to go.  This library just aims to go all the way.
 
@@ -45,14 +45,23 @@ end
 ### Usage without Rails
 
 ```ruby
+ValidatesEmailFormatOf::validate_email_format("example@mydomain.com") # => nil
+ValidatesEmailFormatOf::validate_email_format("invalid@") # => ["does not appear to be a valid email address"]
+
 # Optional, if you want error messages to be in your language
 ValidatesEmailFormatOf::load_i18n_locales
 I18n.locale = :pl
 
-ValidatesEmailFormatOf::validate_email_format("example@mydomain.com") # => nil
-ValidatesEmailFormatOf::validate_email_format("invalid@") # => ["does not appear to be a valid email address"]
+ValidatesEmailFormatOf::validate_email_format("invalid@") # => ["nieprawidłowy adres email"]
 ```
 
+## Internationalized Domain Names (IDN) and Punycode
+
+As of v1.8.0, this gem can validate email addresses using internationalized domain names (like `test@пример.рф`) as well as domains that have already been converted to Punycode code (like `test@xn--test@-3weu6azakd.xn--p1ai`).
+
+If you would like to forbid internationalized domains, you can pass the `idn: false` option.  Punycode is always accepted.
+
+
 ## Options
 
 | Option | Type | Description |
@@ -69,7 +78,7 @@ ValidatesEmailFormatOf::validate_email_format("invalid@") # => ["does not appear
 The standard ActiveModel validation options (`:on`, `:if`, `:unless`, `:allow_nil`, `:allow_blank`, etc...) all work as well when using the gem as part of a Rails application.
 ## Testing
 
-You can see our [current Ruby and Rails test matrix here](.github/workflows/ci.yml).
+The gem is tested against Rails 4.2 and onward across a bunch of Ruby versions including jruby. You can see our [current Ruby and Rails test matrix here](.github/workflows/ci.yml).
 
 To execute the unit tests against [all the Rails versions we support run](gemfiles/) <tt>bundle exec appraisal rspec</tt> or run against an individual version with <tt>bundle exec appraisal rails-6.0 rspec</tt>.
 ## Contributing
@@ -96,16 +105,16 @@ Yes, our Rspec syntax is that simple!
 
 ## Credits
 
-Written by Alex Dunae (dunae.ca), 2006-22.
+Written by [Alex Dunae](https://dunae.ca), 2006-24.
 
 Many thanks to the plugin's recent contributors: https://github.com/alexdunae/validates_email_format_of/contributors
 
-Thanks to Francis Hwang (http://fhwang.net/) at Diversion Media for creating the 1.1 update.
+Thanks to [Francis Hwang](http://fhwang.net/) at Diversion Media for creating the 1.1 update.
 
 Thanks to Travis Sinnott for creating the 1.3 update.
 
-Thanks to Denis Ahearn at Riverock Technologies (http://www.riverocktech.com/) for creating the 1.4 update.
+Thanks to Denis Ahearn at [Riverock Technologies](http://www.riverocktech.com/) for creating the 1.4 update.
 
-Thanks to George Anderson (http://github.com/george) and 'history' (http://github.com/history) for creating the 1.4.1 update.
+Thanks to [George Anderson](http://github.com/george) and ['history'](http://github.com/history) for creating the 1.4.1 update.
 
-Thanks to Isaac Betesh (https://github.com/betesh) for converting tests to Rspec and refactoring for version 1.6.0.
+Thanks to [Isaac Betesh](https://github.com/betesh) for converting tests to Rspec and refactoring for version 1.6.0.

data/config/locales/de.yml

@@ -2,7 +2,7 @@ de:
   activemodel: &errors
     errors:
       messages:
-        invalid_email_address: 'ist offensichtlich keine gültige EMail-Adresse'
+        invalid_email_address: 'ist anscheinend keine gültige E-Mail-Adresse'
         email_address_not_routable: 'kann nicht erreicht werden'
   activerecord:
     <<: *errors

data/lib/validates_email_format_of/version.rb

@@ -1,3 +1,3 @@
 module ValidatesEmailFormatOf
-  VERSION = "1.8.0"
+  VERSION = "1.8.2"
 end

data/lib/validates_email_format_of.rb

@@ -269,8 +269,8 @@ module ValidatesEmailFormatOf
   end
 
   def self.validate_domain_part_syntax(domain, idn: true)
-    domain = SimpleIDN.to_ascii(domain) if idn
     parts = domain.downcase.split(".", -1)
+    parts.map! { |part| SimpleIDN.to_ascii(part) } if idn
 
     return false if parts.length <= 1 # Only one domain part
 
@@ -299,7 +299,7 @@ module ValidatesEmailFormatOf
     if defined?(ActiveSupport::Deprecation)
       ActiveSupport::Deprecation.warn(msg)
     else
-      warn
+      warn(msg)
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,7 +1,5 @@
 require "active_model"
 require "active_support"
-require "pry"
-require "byebug"
 
 RSpec::Matchers.define :have_errors_on_email do
   match do |user|

data/spec/validates_email_format_of_spec.rb

@@ -140,7 +140,8 @@ describe ValidatesEmailFormatOf do
       "\nnewline@example.com",
       " spacesbefore@example.com",
       "spacesafter@example.com ",
-      "(unbalancedcomment@example.com"
+      "(unbalancedcomment@example.com",
+      "help@.example.co.uk" # TLD can not start with a period
     ].each do |address|
       describe address do
         it { should have_errors_on_email.because("does not appear to be a valid email address") }
@@ -203,7 +204,8 @@ describe ValidatesEmailFormatOf do
 
     describe "when idn support is enabled" do
       before(:each) do
-        allow(SimpleIDN).to receive(:to_ascii).once.with("exämple.com").and_return("xn--exmple-cua.com")
+        expect(SimpleIDN).to receive(:to_ascii).with("exämple").and_return("xn--exmple-cua")
+        expect(SimpleIDN).to receive(:to_ascii).with("com").and_return("com")
       end
       let(:options) { {idn: true} }
       describe "test@exämple.com" do

data/validates_email_format_of.gemspec

@@ -25,5 +25,4 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rspec"
   s.add_development_dependency "standard"
   s.add_development_dependency "appraisal"
-  s.add_development_dependency "pry-byebug"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: validates_email_format_of
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.8.2
 platform: ruby
 authors:
 - Alex Dunae
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-11 00:00:00.000000000 Z
+date: 2024-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -109,20 +109,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Validate email addresses against RFC 2822 and RFC 3696.
 email:
 - code@dunae.ca
@@ -187,7 +173,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.21
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: Validate email addresses against RFC 2822 and RFC 3696.