validates_cpf_cnpj 0.1.0 → 0.2.0

data/README.rdoc

@@ -21,7 +21,7 @@ As gem:
 
 Validating a CPF attribute:
 
-  class Patient
+  class Patient < ActiveRecord::Base
     validates_cpf :cpf_attr
     # or
     validates :cpf_attr, :cpf => true
@@ -29,7 +29,7 @@ Validating a CPF attribute:
 
 Validating a CNPJ attribute:
 
-  class Supplier
+  class Supplier < ActiveRecord::Base
     validates_cnpj :cnpj_attr
     # or
     validates :cnpj_attr, :cnpj => true
@@ -37,7 +37,7 @@ Validating a CNPJ attribute:
 
 Validating an attribute that can store both CPF or CNPJ:
 
-  class Customer
+  class Customer < ActiveRecord::Base
     validates_cpf_or_cnpj :cpf_cnpj_attr
     # or
     validates :cpf_cnpj_attr, :cpf_or_cnpj => true
@@ -45,11 +45,11 @@ Validating an attribute that can store both CPF or CNPJ:
 
 Regular validation options:
 
-  :allow_nil   - Allow a nil value to be valid
+  :allow_nil   - Allows a nil value to be valid
   :allow_blank - Allows a nil or empty string value to be valid
-  :if          - Execute validation when :if evaluates true
-  :unless      - Execute validation when :unless evaluates false
-  :on          - Specify validation context (e.g :save, :create or :update). Default is :save
+  :if          - Executes validation when :if evaluates true
+  :unless      - Executes validation when :unless evaluates false
+  :on          - Specifies validation context (e.g :save, :create or :update). Default is :save
 
 == Contributing
 

data/lib/validates_cpf_cnpj.rb

@@ -32,24 +32,18 @@ module ActiveModel
 
     module HelperMethods
       def validates_cpf(*attr_names)
-        configuration = { :on => :save }
-        configuration.update(attr_names.extract_options!)
         raise ArgumentError, "You need to supply at least one attribute" if attr_names.empty?
-        validates_with CpfValidator, _merge_attributes(attr_names).merge(configuration)
+        validates_with CpfValidator, _merge_attributes(attr_names)
       end
 
       def validates_cnpj(*attr_names)
-        configuration = { :on => :save }
-        configuration.update(attr_names.extract_options!)
         raise ArgumentError, "You need to supply at least one attribute" if attr_names.empty?
-        validates_with CnpjValidator, _merge_attributes(attr_names).merge(configuration)
+        validates_with CnpjValidator, _merge_attributes(attr_names)
       end
 
       def validates_cpf_or_cnpj(*attr_names)
-        configuration = { :on => :save }
-        configuration.update(attr_names.extract_options!)
         raise ArgumentError, "You need to supply at least one attribute" if attr_names.empty?
-        validates_with CpfOrCnpjValidator, _merge_attributes(attr_names).merge(configuration)
+        validates_with CpfOrCnpjValidator, _merge_attributes(attr_names)
       end
     end
   end

data/lib/validates_cpf_cnpj/cpf.rb

@@ -1,7 +1,12 @@
 module ValidatesCpfCnpj
   module Cpf
+    @@invalid_cpfs = %w{12345678909 11111111111 22222222222 33333333333 44444444444 55555555555 66666666666 77777777777 88888888888 99999999999 00000000000}
+
     def self.valid?(value)
       value.gsub!(/[^0-9]/, '')
+
+      return false if @@invalid_cpfs.member?(value)
+      
       digit = value.slice(-2, 2)
       control = ''
       if value.size == 11

data/lib/validates_cpf_cnpj/version.rb

@@ -1,3 +1,3 @@
 module ValidatesCpfCnpj
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/lib/validates_cpf_cnpj_spec.rb

@@ -8,40 +8,14 @@ describe ValidatesCpfCnpj do
     end
 
     context 'should be invalid when' do
-      it 'value is 1234567890' do
-        person = Person.new(:code => '1234567890')
-        person.validates_cpf(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 12345678901' do
-        person = Person.new(:code => '12345678901')
-        person.validates_cpf(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is ABC80033787883' do
-        person = Person.new(:code => 'ABC45678901')
-        person.validates_cpf(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 123.456.789-01' do
-        person = Person.new(:code => '123.456.789-01')
-        person.validates_cpf(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 800337.878-83' do
-        person = Person.new(:code => '800337.878-83')
-        person.validates_cpf(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 800337878-83' do
-        person = Person.new(:code => '800337878-83')
-        person.validates_cpf(:code)
-        person.errors.should_not be_empty
+      invalid_cpfs = %w{1234567890 12345678901 ABC45678901 123.456.789-01 800337.878-83 800337878-83}
+      
+      invalid_cpfs.each do |cpf|
+        it "value is #{cpf}" do
+          person = Person.new(:code => cpf)
+          person.validates_cpf(:code)
+          person.errors.should_not be_empty
+        end
       end
 
       it 'value is nil' do
@@ -55,6 +29,17 @@ describe ValidatesCpfCnpj do
         person.validates_cpf(:code)
         person.errors.should_not be_empty
       end
+
+      # This numbers will be considered valid by the algorithm but is known as not valid on real world, so they should be blocked
+      blocked_cpfs = %w{12345678909 11111111111 22222222222 33333333333 44444444444 55555555555 66666666666 77777777777 88888888888 99999999999 00000000000}
+
+      blocked_cpfs.each do |cpf|
+        it "is a well know invalid number: #{cpf}" do
+          person = Person.new(:code => cpf)
+          person.validates_cpf(:code)
+          person.errors.should_not be_empty
+        end
+      end
     end
 
     context 'should be valid when' do
@@ -120,47 +105,17 @@ describe ValidatesCpfCnpj do
     end
 
     context 'should be invalid when' do
-      it 'value is 1234567890123' do
-        person = Person.new(:code => '1234567890123')
-        person.validates_cnpj(:code)
-        person.errors.should_not be_empty
-      end
 
-      it 'value is 12345678901234' do
-        person = Person.new(:code => '12345678901234')
-        person.validates_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 123456789012345' do
-        person = Person.new(:code => '123456789012345')
-        person.validates_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is ABC05393625000184' do
-        person = Person.new(:code => 'ABC05393625000184')
-        person.validates_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 12.345.678/9012-34' do
-        person = Person.new(:code => '12.345.678/9012-34')
-        person.validates_cnpj(:code)
-        person.errors.should_not be_empty
-      end
+      invalid_cnpjs = %w{1234567890123 12345678901234 123456789012345 ABC05393625000184 12.345.678/9012-34 05393.625/0001-84 05393.6250001-84}
 
-      it 'value is 05393.625/0001-84' do
-        person = Person.new(:code => '05393.625/0001-84')
-        person.validates_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 05393.6250001-84' do
-        person = Person.new(:code => '05393.6250001-84')
-        person.validates_cnpj(:code)
-        person.errors.should_not be_empty
+      invalid_cnpjs.each do |cnpj|
+        it "value is #{cnpj}" do
+          person = Person.new(:code => cnpj)
+          person.validates_cnpj(:code)
+          person.errors.should_not be_empty
+        end
       end
+      
 
       it 'value is nil' do
         person = Person.new(:code => nil)
@@ -238,94 +193,14 @@ describe ValidatesCpfCnpj do
     end
 
     context 'should be invalid when' do
-      it 'value is 1234567890' do
-        person = Person.new(:code => '1234567890')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 12345678901' do
-        person = Person.new(:code => '12345678901')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is ABC80033787883' do
-        person = Person.new(:code => 'ABC45678901')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
 
-      it 'value is 123.456.789-01' do
-        person = Person.new(:code => '123.456.789-01')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 800337.878-83' do
-        person = Person.new(:code => '800337.878-83')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 800337878-83' do
-        person = Person.new(:code => '800337878-83')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is nil' do
-        person = Person.new(:code => nil)
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is empty' do
-        person = Person.new(:code => '')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 1234567890123' do
-        person = Person.new(:code => '1234567890123')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 12345678901234' do
-        person = Person.new(:code => '12345678901234')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 123456789012345' do
-        person = Person.new(:code => '123456789012345')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is ABC05393625000184' do
-        person = Person.new(:code => 'ABC05393625000184')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 12.345.678/9012-34' do
-        person = Person.new(:code => '12.345.678/9012-34')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 05393.625/0001-84' do
-        person = Person.new(:code => '05393.625/0001-84')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
-      end
-
-      it 'value is 05393.6250001-84' do
-        person = Person.new(:code => '05393.6250001-84')
-        person.validates_cpf_or_cnpj(:code)
-        person.errors.should_not be_empty
+      invalid_numbers = %w{1234567890 12345678901 ABC45678901 123.456.789-01 800337.878-83 800337878-83 1234567890123 12345678901234 123456789012345 ABC05393625000184 12.345.678/9012-34 05393.625/0001-84 05393.6250001-84}
+      invalid_numbers.each do |number|
+        it "value is #{number}" do
+          person = Person.new(:code => number)
+          person.validates_cpf_or_cnpj(:code)
+          person.errors.should_not be_empty
+        end
       end
 
       it 'value is nil' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: validates_cpf_cnpj
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-04 00:00:00.000000000 Z
+date: 2013-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &79122770 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *79122770
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &79122560 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +37,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *79122560
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &79122350 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +53,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *79122350
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &79122100 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +69,12 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *79122100
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.0.0
 description: CPF and CNPJ validations for ActiveModel and Rails
 email:
 - naldo_ds@yahoo.com.br
@@ -94,7 +114,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: validates_cpf_cnpj
-rubygems_version: 1.8.10
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: CPF/CNPJ ActiveModel validations