validates_by_schema 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 69129acef7a43c707e98663657e97dc1b7222ce1
-  data.tar.gz: 4368f63d8423b026079cea4fd215baf7c27791a7
+SHA256:
+  metadata.gz: 95a3e699ef49bdc2b00988cce281ee448bfc05020b5ce9388889a928ae74fe57
+  data.tar.gz: 544048310b55c334b2e287feb99e48f17258d3e9082137dfa9d5b633c8b4afa6
 SHA512:
-  metadata.gz: e1df6f34e85a82ca55287847596878ce45a3d3d8e076cfe7b150919769090f26ad94d68e92d9aaf0dfd9eced591d0bda74f602a5706b05041dc24a907be4e4a2
-  data.tar.gz: a391c996e1f204c10d3d622f8c7f9d15a8ecf1640e44078a09a8f07d8c351338dcb80515bdc8a6417f1baa069703d5ad04f42fc93eb800fd64d81dcbd1119d27
+  metadata.gz: 024cbf1790625db028dc7d351ff8d20797e762f31c2d91651da61ee6b533e73999d67aa871a3649db94140dc9ae86ceee3d09b311cf9a324c5cd075ce19a38ac
+  data.tar.gz: 8f4c69c1a0b59d300c7553f92f6056db6d6ffa50fd1b46f6bd65b0a7cd8e0b8baaaac0bc58fcdb0f3498613b87c0544397963f6107310e2aa5665af2505fd77a

data/README.md

@@ -1,9 +1,9 @@
 # Validates By Schema (validates_by_schema)
 [![Gem Version](http://img.shields.io/gem/v/validates_by_schema.svg?style=flat)](https://rubygems.org/gems/validates_by_schema)
 [![Build Status](http://img.shields.io/travis/joshwlewis/validates_by_schema.svg?style=flat)](https://travis-ci.org/joshwlewis/validates_by_schema)
-[![Dependency Status](http://img.shields.io/gemnasium/joshwlewis/validates_by_schema.svg?style=flat)](https://gemnasium.com/joshwlewis/validates_by_schema)
 [![Coverage Status](http://img.shields.io/coveralls/joshwlewis/validates_by_schema.svg?style=flat)](https://coveralls.io/r/joshwlewis/validates_by_schema)
-[![Code Climate](http://img.shields.io/codeclimate/github/joshwlewis/validates_by_schema.svg?style=flat)](https://codeclimate.com/github/joshwlewis/validates_by_schema)
+[![Code Climate](http://img.shields.io/codeclimate/maintainability/joshwlewis/validates_by_schema.svg?style=flat)](https://codeclimate.com/github/joshwlewis/validates_by_schema)
+
 
 Automatic validation based on your database schema column types and limits. Keep your code DRY by inferring column validations from table properties!
 

data/lib/validates_by_schema.rb

@@ -1,3 +1,6 @@
+require 'active_support/concern'
+require 'active_support/lazy_load_hooks'
+
 module ValidatesBySchema
   autoload :ValidationOption, 'validates_by_schema/validation_option'
 
@@ -6,32 +9,42 @@ module ValidatesBySchema
   module ClassMethods
 
     def validates_by_schema(options = {})
-      return unless table_exists?
+      @validates_by_schema_options = options
+      define_schema_validations if schema_loaded?
+    end
 
-      customized_columns(options).each do |c|
+    def load_schema!
+      super
+      # define schema validations lazy to avoid accessing the database
+      # at class load time.
+      define_schema_validations
+    end
+
+    private
+
+    def define_schema_validations
+      return unless @validates_by_schema_options
+
+      customized_schema_validatable_columns.each do |c|
         ValidationOption.new(self, c).define!
       end
 
-    rescue ::ActiveRecord::NoDatabaseError
-      # Since `db:create` and other tasks from Rails 5.2.0 might load models,
-      # we need to swallow this error to execute `db:create` properly.
+      @validates_by_schema_options = nil
     end
 
-    private
-
-    def customized_columns(options)
+    def customized_schema_validatable_columns
       # Allow user to specify :only or :except options
-      schema_validateable_columns.tap do |columns|
+      schema_validatable_columns.tap do |columns|
         { only: :select!, except: :reject! }.each do |k, v|
-          if options[k]
-            attrs = Array(options[k]).collect(&:to_s)
+          if @validates_by_schema_options[k]
+            attrs = Array(@validates_by_schema_options[k]).collect(&:to_s)
             columns.send(v) { |c| attrs.include?(c.name) }
           end
         end
       end
     end
 
-    def schema_validateable_columns
+    def schema_validatable_columns
       columns.reject do |c|
         ignored_columns_for_validates_by_schema.include?(c.name)
       end

data/lib/validates_by_schema/validation_option.rb

@@ -10,7 +10,9 @@ class ValidatesBySchema::ValidationOption
 
   def define!
     if association
-      klass.validates association.name, presence: true unless column.null
+      if !ActiveRecord::Base.belongs_to_required_by_default && !column.null
+        klass.validates association.name, presence: true
+      end
     else
       options = to_hash
       klass.validates column.name, options if options.present?
@@ -94,4 +96,5 @@ class ValidatesBySchema::ValidationOption
   def to_s
     to_hash.inspect
   end
+
 end

data/lib/validates_by_schema/version.rb

@@ -1,3 +1,3 @@
 module ValidatesBySchema
-  VERSION = '0.3.1'
+  VERSION = '0.4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: validates_by_schema
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Josh Lewis
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-16 00:00:00.000000000 Z
+date: 2019-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -144,7 +144,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Automatic validation based on your database schema column types and limits.