validates_as_vat_number 1.0.2 → 1.0.3

data/README.markdown

@@ -19,6 +19,8 @@ Then install it.
     	validates_as_vat_number :vat
     end
 
+## Acknowledgements
+Thanks to [sborsje](http://github.com/sborsje) for fixing the instance with valid ISO 3660 but unsupported codes.
 
 ## Note on Patches/Pull Requests
  

data/VERSION

@@ -1 +1 @@
-1.0.2
+1.0.3

data/lib/validates_as_vat_number.rb

@@ -9,8 +9,6 @@ module Develon
       }
       configuration.update(attr_names.pop) if attr_names.last.is_a?(Hash)
       
-      iso3661_country_codes = %w(AF AX AL DZ AS AD AO AI AQ AG AR AM AW AU AT AZ BS BH BD BB BY BE BZ BJ BM BT BO BA BW BV BR IO BN BG BF BI KH CM CA CV KY CF TD CL CN CX CC CO KM CG CD CK CR CI HR CU CY CZ DK DJ DM DO EC EG SV GQ ER EE ET FK FO FJ FI FR GF PF TF GA GM GE DE GH GI GR GL GD GP GU GT GG GN GW GY HT HM VA HN HK HU IS IN ID IR IQ IE IM IL IT JM JP JE JO KZ KE KI KP KR KW KG LA LV LB LS LR LY LI LT LU MO MK MG MW MY MV ML MT MH MQ MR MU YT MX FM MD MC MN ME MS MA MZ MM NA NR NP NL AN NC NZ NI NE NG NU NF MP NO OM PK PW PS PA PG PY PE PH PN PL PT PR QA RE RO RU RW BL SH KN LC MF PM VC WS SM ST SA SN RS SC SL SG SK SI SB SO ZA GS ES LK SD SR SJ SZ SE CH SY TW TJ TZ TH TL TG TK TO TT TN TR TM TC TV UG UA AE GB US UM UY UZ VU VE VN VG VI WF EH YE ZM ZW)
-      
       structures = { 'AT' => /^ATU\w{8}$/, 'BE' => /^BE0\d{9}$/, 'BG' => /^BG\d{9,10}$/, 'CY' => /^CY\w{8}L$/,
                      'CZ' => /^CZ\d{8,10}$/, 'DE' => /^DE\d{9}$/, 'DK' => /^DK\d{2}\s\d{2}\s\d{2}\s\d{2}$/,
                      'EE' => /^EE\d{9}$/, 'EL' => /^EL\d{9}$/, 'ES' => /^ESX\d{7}X$/, 'FI' => /^FI\d{8}$/, 'FR' => /^FR\w{2}\s\d{9}$/,
@@ -22,7 +20,7 @@ module Develon
 
       validates_each(attr_names,configuration) do |record, attr_name, value|
         country = country_code(value)
-        if iso3661_country_codes.include?(country)
+        if structures.include?(country)
           message = configuration[:message] unless structures[country].match(value) && check_vat(country, value.gsub(/^\w\w/, ''))
         else
           message = 'has an invalid country'

data/spec/validates_as_vat_number_spec.rb

@@ -17,10 +17,16 @@ describe Develon::ValidatesAsVatNumber do
     fake_company.valid?.should == false
     fake_company.errors.on('vat').should == 'is an invalid VAT number'
   end
+
+  it "should invalidate a non-supported iso3661 country code" do
+    fake_company = Company.new(:name => 'Fake Company', :vat => 'BO123456789')
+    fake_company.valid?.should == false
+    fake_company.errors.on('vat').should == 'has an invalid country'
+  end
   
   it "should invalidate locally if country is not valid" do
     develon = Company.new(:name => 'Develon', :vat => 'KO03018900245')
     develon.valid?.should == false
     develon.errors.on('vat').should == 'has an invalid country'
   end
-end
+end

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: validates_as_vat_number
 version: !ruby/object:Gem::Version 
-  version: 1.0.2
+  prerelease: false
+  segments: 
+  - 1
+  - 0
+  - 3
+  version: 1.0.3
 platform: ruby
 authors: 
 - Alessandro Dal Grande
@@ -10,19 +15,23 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-02-19 00:00:00 +01:00
+date: 2010-03-01 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rspec
-  type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 1
+        - 2
+        - 9
         version: 1.2.9
-    version: 
+  type: :development
+  version_requirements: *id001
 description: |-
   Now you can validate VAT using the European service called VIES, 
                          to ensure it exists. Only require this gem and call validate_as_vat_number 
@@ -63,18 +72,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: Permits VAT validation within ActiveRecord using EU VIES Web Service.