validates_as_email_address 0.0.3 → 0.1.0

data/CHANGELOG.rdoc

@@ -0,0 +1,19 @@
+== master
+
+== 0.1.0 / 2008-09-07
+
+* Allow all options to be passed to format/length validations so that future options can be defined without changing this plugin
+* Add support for overriding length limits
+* Add support for requiring that domains follow the RFC 1035 format (on by default) [Kacper Bielecki]
+
+== 0.0.3 / 2008-06-22
+
+* Remove log files from gems
+
+== 0.0.2 / 2008-05-05
+
+* Update documentation
+
+== 0.0.1 / 2007-09-26
+
+* Add documentation

data/{README → README.rdoc}

@@ -5,21 +5,21 @@ email addresses.
 
 == Resources
 
-Wiki
-
-* http://wiki.pluginaweek.org/Validates_as_email_address
-
 API
 
 * http://api.pluginaweek.org/validates_as_email_address
 
+Bugs
+
+* http://pluginaweek.lighthouseapp.com/projects/13293-validates_as_email_address
+
 Development
 
-* http://dev.pluginaweek.org/browser/trunk/validates_as_email_address
+* http://github.com/pluginaweek/validates_as_email_address
 
 Source
 
-* http://svn.pluginaweek.org/trunk/validates_as_email_address
+* git://github.com/pluginaweek/validates_as_email_address.git
 
 == Description
 
@@ -40,7 +40,7 @@ the email address.
 == Testing
 
 Before you can run any tests, the following gem must be installed:
-* plugin_test_helper[http://wiki.pluginaweek.org/Plugin_test_helper]
+* plugin_test_helper[http://github.com/pluginaweek/plugin_test_helper]
 
 To run against a specific version of Rails:
 

data/Rakefile

@@ -3,46 +3,54 @@ require 'rake/rdoctask'
 require 'rake/gempackagetask'
 require 'rake/contrib/sshpublisher'
 
-PKG_NAME           = 'validates_as_email_address'
-PKG_VERSION        = '0.0.3'
-PKG_FILE_NAME      = "#{PKG_NAME}-#{PKG_VERSION}"
-RUBY_FORGE_PROJECT = 'pluginaweek'
-
-desc 'Default: run unit tests.'
+spec = Gem::Specification.new do |s|
+  s.name              = 'validates_as_email_address'
+  s.version           = '0.1.0'
+  s.platform          = Gem::Platform::RUBY
+  s.summary           = 'Adds support for validating the format/length of email addresses'
+  
+  s.files             = FileList['{lib,test}/**/*'] + %w(CHANGELOG.rdoc init.rb LICENSE Rakefile README.rdoc) - FileList['test/app_root/{log,log/*,script,script/*}']
+  s.require_path      = 'lib'
+  s.has_rdoc          = true
+  s.test_files        = Dir['test/**/*_test.rb']
+  
+  s.author            = 'Aaron Pfeifer'
+  s.email             = 'aaron@pluginaweek.org'
+  s.homepage          = 'http://www.pluginaweek.org'
+  s.rubyforge_project = 'pluginaweek'
+end
+  
+desc 'Default: run all tests.'
 task :default => :test
 
-desc 'Test the validates_as_email_address plugin.'
+desc "Test the #{spec.name} plugin."
 Rake::TestTask.new(:test) do |t|
   t.libs << 'lib'
-  t.pattern = 'test/**/*_test.rb'
+  t.test_files = spec.test_files
   t.verbose = true
 end
 
-desc 'Generate documentation for the validates_as_email_address plugin.'
+begin
+  require 'rcov/rcovtask'
+  namespace :test do
+    desc "Test the #{spec.name} plugin with Rcov."
+    Rcov::RcovTask.new(:rcov) do |t|
+      t.libs << 'lib'
+      t.test_files = spec.test_files
+      t.rcov_opts << '--exclude="^(?!lib/)"'
+      t.verbose = true
+    end
+  end
+rescue LoadError
+end
+
+desc "Generate documentation for the #{spec.name} plugin."
 Rake::RDocTask.new(:rdoc) do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'ValidatesAsEmailAddress'
+  rdoc.title    = spec.name
   rdoc.template = '../rdoc_template.rb'
   rdoc.options << '--line-numbers' << '--inline-source'
-  rdoc.rdoc_files.include('README')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
-
-spec = Gem::Specification.new do |s|
-  s.name            = PKG_NAME
-  s.version         = PKG_VERSION
-  s.platform        = Gem::Platform::RUBY
-  s.summary         = 'Adds support for validating the format/length of email addresses'
-  
-  s.files           = FileList['{lib,test}/**/*'].to_a - FileList['test/app_root/log/*'].to_a + %w(CHANGELOG init.rb LICENSE Rakefile README)
-  s.require_path    = 'lib'
-  s.autorequire     = 'validates_as_email_address'
-  s.has_rdoc        = true
-  s.test_files      = Dir['test/**/*_test.rb']
-  
-  s.author          = 'Aaron Pfeifer'
-  s.email           = 'aaron@pluginaweek.org'
-  s.homepage        = 'http://www.pluginaweek.org'
+  rdoc.rdoc_files.include('README.rdoc', 'CHANGELOG.rdoc', 'LICENSE', 'lib/**/*.rb')
 end
   
 Rake::GemPackageTask.new(spec) do |p|
@@ -51,14 +59,14 @@ Rake::GemPackageTask.new(spec) do |p|
   p.need_zip = true
 end
 
-desc 'Publish the beta gem'
+desc 'Publish the beta gem.'
 task :pgem => [:package] do
-  Rake::SshFilePublisher.new('aaron@pluginaweek.org', '/home/aaron/gems.pluginaweek.org/public/gems', 'pkg', "#{PKG_FILE_NAME}.gem").upload
+  Rake::SshFilePublisher.new('aaron@pluginaweek.org', '/home/aaron/gems.pluginaweek.org/public/gems', 'pkg', "#{spec.name}-#{spec.version}.gem").upload
 end
 
-desc 'Publish the API documentation'
+desc 'Publish the API documentation.'
 task :pdoc => [:rdoc] do
-  Rake::SshDirPublisher.new('aaron@pluginaweek.org', "/home/aaron/api.pluginaweek.org/public/#{PKG_NAME}", 'rdoc').upload
+  Rake::SshDirPublisher.new('aaron@pluginaweek.org', "/home/aaron/api.pluginaweek.org/public/#{spec.name}", 'rdoc').upload
 end
 
 desc 'Publish the API docs and gem'
@@ -71,10 +79,10 @@ task :release => [:gem, :package] do
   ruby_forge = RubyForge.new.configure
   ruby_forge.login
   
-  %w( gem tgz zip ).each do |ext|
-    file = "pkg/#{PKG_FILE_NAME}.#{ext}"
+  %w(gem tgz zip).each do |ext|
+    file = "pkg/#{spec.name}-#{spec.version}.#{ext}"
     puts "Releasing #{File.basename(file)}..."
     
-    ruby_forge.add_release(RUBY_FORGE_PROJECT, PKG_NAME, PKG_VERSION, file)
+    ruby_forge.add_release(spec.rubyforge_project, spec.name, spec.version, file)
   end
 end

data/lib/validates_as_email_address.rb

@@ -1,40 +1,18 @@
 require 'validates_as_email_address/rfc_822'
+require 'validates_as_email_address/rfc_1035'
 
 module PluginAWeek #:nodoc:
   # Adds validations for email addresses
   module ValidatesAsEmailAddress
-    # The options that can be used when validating the format of the email address
-    EMAIL_FORMAT_OPTIONS = [
-      :wrong_format,
-      :allow_nil,
-      :on,
-      :if
-    ]
-    
-    # The options that can be used when validating the length of the email address
-    EMAIL_LENGTH_OPTIONS = [
-      :minimum,
-      :maximum,
-      :is,
-      :within,
-      :in,
-      :too_long,
-      :too_short,
-      :wrong_length,
-      :allow_nil,
-      :on,
-      :if
-    ]
-    
     # Validates whether the value of the specific attribute matches against the
-    # RFC822 specificiation.
+    # RFC822/RFC1035 specification.
     # 
     #   class Person < ActiveRecord::Base
     #     validates_as_email_address :email, :on => :create
     #   end
     # 
     # This will also validate that the email address is within the specification
-    # limits, specifically between 3 and 320 characters in length.
+    # limits, i.e. between 3 and 320 characters in length.
     # 
     # Configuration options for length:
     # * +minimum+ - The minimum size of the attribute
@@ -49,28 +27,29 @@ module PluginAWeek #:nodoc:
     # Configuration options for format:
     # * +wrong_format+ - A custom error message (default is: "is an invalid email address")
     # 
-    # Configuration options for both length and format:
+    # Miscellaneous configuration options:
     # * +allow_nil+ - Attribute may be nil; skip validation.
     # * +on+ - Specifies when this validation is active (default is :save, other options :create, :update)
     # * +if+ - Specifies a method, proc or string to call to determine if the validation should
-    # occur (e.g. :if => :allow_validation, or :if => Proc.new { |user| user.signup_step > 2 }).  The
+    # occur (e.g. :if => :allow_validation, or :if => lambda { |user| user.signup_step > 2 }).  The
     # method, proc or string should return or evaluate to a true or false value.
+    # * +strict+ - Specifies if the domain part of the email should be compliant to RFC 1035 (default is true). If set to false domains such as '-online.com', '[127.0.0.1]' become valid.
     def validates_as_email_address(*attr_names)
       configuration = attr_names.last.is_a?(Hash) ? attr_names.pop : {}
-      configuration.assert_valid_keys(EMAIL_FORMAT_OPTIONS | EMAIL_LENGTH_OPTIONS)
       configuration.reverse_merge!(
-        :wrong_format => ActiveRecord::Errors.default_error_messages[:invalid_email]
+        :wrong_format => ActiveRecord::Errors.default_error_messages[:invalid_email],
+        :strict => true
       )
       
       # Add format validation
-      format_configuration = configuration.reject {|key, value| !EMAIL_FORMAT_OPTIONS.include?(key)}
-      format_configuration[:message] = format_configuration.delete(:wrong_format)
-      format_configuration[:with] = RFC822::EmailAddress
+      format_configuration = configuration.dup
+      format_configuration[:message] = configuration.delete(:wrong_format)
+      format_configuration[:with] = configuration[:strict] ? RFC1035::EmailAddress : RFC822::EmailAddress
       validates_format_of attr_names, format_configuration
       
       # Add length validation
-      length_configuration = configuration.reject {|key, value| !EMAIL_LENGTH_OPTIONS.include?(key)}
-      length_configuration.reverse_merge!(:within => 3..320)
+      length_configuration = configuration.dup
+      length_configuration.reverse_merge!(:within => 3..320) unless ([:minimum, :maximum, :is, :within, :in] & configuration.keys).any?
       validates_length_of attr_names, length_configuration
     end
   end
@@ -80,6 +59,7 @@ ActiveRecord::Base.class_eval do
   extend PluginAWeek::ValidatesAsEmailAddress
 end
 
+# Add error messages specific to this validation
 ActiveRecord::Errors.default_error_messages.update(
   :invalid_email => 'is an invalid email address'
 )

data/lib/validates_as_email_address/rfc_1035.rb

@@ -0,0 +1,28 @@
+module PluginAWeek #:nodoc:
+  module ValidatesAsEmailAddress
+    # The standard describing the format of domains
+    module RFC1035
+      # Matches domain according to the RFC 1035 standard
+      Domain = begin
+        digit = "[\\d]"
+        letter = "[\\x61-\\x7a\\x41-\\x5a]"
+        let_dig = "(?:#{letter}|#{digit})"
+        ldh_str = "(?:#{let_dig}|[\\x2d])+"
+        label = "#{let_dig}(?:(?:#{ldh_str})*#{let_dig})"
+        subdomain = "(?:#{label}\\.)*#{label}"
+        domain = "(?:#{subdomain}|\\x20)"
+        
+        /#{domain}/
+      end
+      
+      # Matches email addresses with domains that follow the RFC 1035 standard
+      EmailAddress = begin
+        local_part = RFC822::LocalPart.source
+        domain = Domain.source
+        addr_spec = "(#{local_part})\\x40(#{domain})"
+        
+        /\A#{addr_spec}\z/
+      end
+    end
+  end
+end

data/lib/validates_as_email_address/rfc_822.rb

@@ -1,18 +1,37 @@
-# The standard describing the format of email addresses
-module RFC822
-  EmailAddress = begin
-    qtext = '[^\\x0d\\x22\\x5c\\x80-\\xff]'
-    dtext = '[^\\x0d\\x5b-\\x5d\\x80-\\xff]'
-    atom = '[^\\x00-\\x20\\x22\\x28\\x29\\x2c\\x2e\\x3a-\\x3c\\x3e\\x40\\x5b-\\x5d\\x7f-\\xff]+'
-    quoted_pair = '\\x5c[\\x00-\\x7f]'
-    domain_literal = "\\x5b(?:#{dtext}|#{quoted_pair})*\\x5d"
-    quoted_string = "\\x22(?:#{qtext}|#{quoted_pair})*\\x22"
-    domain_ref = atom
-    sub_domain = "(?:#{domain_ref}|#{domain_literal})"
-    word = "(?:#{atom}|#{quoted_string})"
-    domain = "#{sub_domain}(?:\\x2e#{sub_domain})*"
-    local_part = "#{word}(?:\\x2e#{word})*"
-    addr_spec = "(#{local_part})\\x40(#{domain})"
-    pattern = /\A#{addr_spec}\z/
+module PluginAWeek #:nodoc:
+  module ValidatesAsEmailAddress
+    # The standard describing the format of email addresses
+    module RFC822
+      # Matches the two parts of an email address (before/after @)
+      LocalPart, Domain = begin
+        # Shared
+        qtext = '[^\\x0d\\x22\\x5c\\x80-\\xff]'
+        dtext = '[^\\x0d\\x5b-\\x5d\\x80-\\xff]'
+        atom = '[^\\x00-\\x20\\x22\\x28\\x29\\x2c\\x2e\\x3a-\\x3c\\x3e\\x40\\x5b-\\x5d\\x7f-\\xff]+'
+        quoted_pair = '\\x5c[\\x00-\\x7f]'
+        domain_literal = "\\x5b(?:#{dtext}|#{quoted_pair})*\\x5d"
+        quoted_string = "\\x22(?:#{qtext}|#{quoted_pair})*\\x22"
+        
+        # Local part
+        word = "(?:#{atom}|#{quoted_string})"
+        local_part = "#{word}(?:\\x2e#{word})*"
+        
+        # Domain
+        domain_ref = atom
+        sub_domain = "(?:#{domain_ref}|#{domain_literal})"
+        domain = "#{sub_domain}(?:\\x2e#{sub_domain})*"
+        
+        [/#{local_part}/, /#{domain}/]
+      end
+      
+      # Matches email addresses according to the RFC822 standard
+      EmailAddress = begin
+        local_part = LocalPart.source
+        domain = Domain.source
+        addr_spec = "(#{local_part})\\x40(#{domain})"
+        
+        /\A#{addr_spec}\z/
+      end
+    end
   end
 end

data/test/app_root/app/models/user.rb

@@ -1,3 +1,2 @@
 class User < ActiveRecord::Base
-  validates_as_email_address :email
 end

data/test/factory.rb

@@ -1,26 +1,32 @@
 module Factory
-  # Build actions for the class
-  def self.build(klass, &block)
-    name = klass.to_s.underscore
-    define_method("#{name}_attributes", block)
+  # Build actions for the model
+  def self.build(model, &block)
+    name = model.to_s.underscore
     
-    module_eval <<-end_eval
-      def valid_#{name}_attributes(attributes = {})
-        #{name}_attributes(attributes)
-        attributes
-      end
-      
-      def new_#{name}(attributes = {})
-        #{klass}.new(valid_#{name}_attributes(attributes))
-      end
-      
-      def create_#{name}(*args)
-        record = new_#{name}(*args)
-        record.save!
-        record.reload
-        record
-      end
-    end_eval
+    define_method("#{name}_attributes", block)
+    define_method("valid_#{name}_attributes") {|*args| valid_attributes_for(model, *args)}
+    define_method("new_#{name}")              {|*args| new_record(model, *args)}
+    define_method("create_#{name}")           {|*args| create_record(model, *args)}
+  end
+  
+  # Get valid attributes for the model
+  def valid_attributes_for(model, attributes = {})
+    name = model.to_s.underscore
+    send("#{name}_attributes", attributes)
+    attributes
+  end
+  
+  # Build an unsaved record
+  def new_record(model, *args)
+    model.new(valid_attributes_for(model, *args))
+  end
+  
+  # Build and save/reload a record
+  def create_record(model, *args)
+    record = new_record(model, *args)
+    record.save!
+    record.reload
+    record
   end
   
   build User do |attributes|

data/test/unit/validates_as_email_address_test.rb

@@ -1,9 +1,20 @@
 require File.dirname(__FILE__) + '/../test_helper'
 
-class ValidatesAsEmailAddressTest < Test::Unit::TestCase
-  def test_should_be_valid_with_a_valid_set_of_attributes
-    user = new_user
-    assert user.valid?
+class ValidatesAsEmailAddressByDefaultTest < Test::Unit::TestCase
+  def setup
+    User.validates_as_email_address :email
+  end
+  
+  def test_should_not_allow_email_addresses_shorter_than_3_characters
+    user = new_user(:email => 'a@')
+    assert !user.valid?
+    assert_equal 2, Array(user.errors.on(:email)).size
+  end
+  
+  def test_should_not_allow_email_addresses_longer_than_320_characters
+    user = new_user(:email => 'a@' + 'a' * 315 + '.com')
+    assert !user.valid?
+    assert_equal 1, Array(user.errors.on(:email)).size
   end
   
   def test_should_allow_legal_rfc822_formats
@@ -11,9 +22,8 @@ class ValidatesAsEmailAddressTest < Test::Unit::TestCase
       'test@example',
       'test@example.com', 
       'test@example.co.uk',
-      '"J. P. \'s-Gravezande, a.k.a. The Hacker!"@example.com',
-      'me@[187.223.45.119]',
-      'someone@123.com',
+      '"J. Smith\'s House, a.k.a. Home!"@example.com',
+      'test@123.com',
     ].each do |address|
       user = new_user(:email => address)
       assert user.valid?, "#{address} should be legal."
@@ -22,9 +32,9 @@ class ValidatesAsEmailAddressTest < Test::Unit::TestCase
   
   def test_should_not_allow_illegal_rfc822_formats
     [
-      'Max@Job 3:14', 
-      'Job@Book of Job',
-      'J. P. \'s-Gravezande, a.k.a. The Hacker!@example.com',
+      'test@Monday 1:00', 
+      'test@Monday the first',
+      'J. Smith\'s House, a.k.a. Home!@example.com',
     ].each do |address|
       user = new_user(:email => address)
       assert !user.valid?, "#{address} should be illegal."
@@ -32,15 +42,193 @@ class ValidatesAsEmailAddressTest < Test::Unit::TestCase
     end
   end
   
-  def test_not_allow_emails_longer_than_320_characters
-    user = new_user(:email => 'a' * 313 + '@a.com')
+  def test_should_not_allow_illegal_rfc1035_formats
+    [
+      'test@[127.0.0.1]',
+      'test@-domain_not_starting_with_letter.com',
+      'test@domain_not_ending_with_alphanum-.com'
+    ].each do |address|
+      user = new_user(:email => address)
+      assert !user.valid?, "#{address} should be illegal."
+    end
+  end
+  
+  def teardown
+    User.class_eval do
+      @validate_callbacks = ActiveSupport::Callbacks::CallbackChain.new
+      @validate_on_create_callbacks = ActiveSupport::Callbacks::CallbackChain.new
+      @validate_on_update_callbacks = ActiveSupport::Callbacks::CallbackChain.new
+    end
+  end
+end
+
+class ValidatesAsEmailAddressTest < Test::Unit::TestCase
+  def test_should_allow_minimum_length
+    User.validates_as_email_address :email, :minimum => 8
+    
+    user = new_user(:email => 'a@aa.com')
+    assert user.valid?
+    
+    user = new_user(:email => 'a@a.com')
+    assert !user.valid?
+  end
+  
+  def test_should_not_check_maximum_length_if_minimum_length_defined
+    User.validates_as_email_address :email, :minimum => 10
+    
+    user = new_user(:email => 'a@' + 'a' * 315 + '.com')
     assert user.valid?
+  end
+  
+  def test_should_allow_maximum_length
+    User.validates_as_email_address :email, :maximum => 8
     
-    user.email = 'a' + user.email
+    user = new_user(:email => 'a@aa.com')
     assert user.valid?
     
-    user.email = 'a' + user.email
+    user = new_user(:email => 'a@aaa.com')
+    assert !user.valid?
+  end
+  
+  def test_should_not_check_minimum_length_if_maximum_length_defined
+    User.validates_as_email_address :email, :maximum => 8
+    
+    user = new_user(:email => 'a@a')
     assert !user.valid?
     assert_equal 1, Array(user.errors.on(:email)).size
   end
+  
+  def test_should_allow_exact_length
+    User.validates_as_email_address :email, :is => 8
+    
+    user = new_user(:email => 'a@aa.com')
+    assert user.valid?
+    
+    user = new_user(:email => 'a@a.com')
+    assert !user.valid?
+    
+    user = new_user(:email => 'a@aaa.com')
+    assert !user.valid?
+  end
+  
+  def test_should_allow_within_range
+    User.validates_as_email_address :email, :within => 8..10
+    
+    user = new_user(:email => 'a@a.com')
+    assert !user.valid?
+    
+    user = new_user(:email => 'a@aa.com')
+    assert user.valid?
+    
+    user = new_user(:email => 'a@aaaa.com')
+    assert user.valid?
+    
+    user = new_user(:email => 'a@aaaaa.com')
+    assert !user.valid?
+  end
+  
+  def test_should_allow_in_range
+    User.validates_as_email_address :email, :in => 8..10
+    
+    user = new_user(:email => 'a@a.com')
+    assert !user.valid?
+    
+    user = new_user(:email => 'a@aa.com')
+    assert user.valid?
+    
+    user = new_user(:email => 'a@aaaa.com')
+    assert user.valid?
+    
+    user = new_user(:email => 'a@aaaaa.com')
+    assert !user.valid?
+  end
+  
+  def test_should_allow_too_long_message
+    User.validates_as_email_address :email, :too_long => 'custom'
+    
+    user = new_user(:email => 'a@' + 'a' * 315 + '.com')
+    user.valid?
+    
+    assert_equal 'custom', Array(user.errors.on(:email)).last
+  end
+  
+  def test_should_allow_too_short_message
+    User.validates_as_email_address :email, :too_short => 'custom'
+    
+    user = new_user(:email => 'a@')
+    user.valid?
+    
+    assert_equal 'custom', Array(user.errors.on(:email)).last
+  end
+  
+  def test_should_allow_wrong_length_message
+    User.validates_as_email_address :email, :is => 8, :wrong_length => 'custom'
+    
+    user = new_user(:email => 'a@a.com')
+    user.valid?
+    
+    assert_equal 'custom', Array(user.errors.on(:email)).last
+  end
+  
+  def test_should_allow_wrong_format_message
+    User.validates_as_email_address :email, :is => 8, :wrong_format => 'custom'
+    
+    user = new_user(:email => 'a@a')
+    user.valid?
+    
+    assert_equal 'custom', Array(user.errors.on(:email)).first
+  end
+  
+  def test_should_validate_if_if_is_true
+    User.validates_as_email_address :email, :if => lambda {true}
+    
+    user = new_user(:email => 'a')
+    assert !user.valid?
+  end
+  
+  def test_should_not_validate_if_if_is_false
+    User.validates_as_email_address :email, :if => lambda {false}
+    
+    user = new_user(:email => 'a')
+    assert user.valid?
+  end
+  
+  def test_should_validate_if_unless_is_false
+    User.validates_as_email_address :email, :unless => lambda {false}
+    
+    user = new_user(:email => 'a')
+    assert !user.valid?
+  end
+  
+  def test_should_not_validate_if_unless_is_true
+    User.validates_as_email_address :email, :unless => lambda {true}
+    
+    user = new_user(:email => 'a')
+    assert user.valid?
+  end
+  
+  def teardown
+    User.class_eval do
+      @validate_callbacks = ActiveSupport::Callbacks::CallbackChain.new
+      @validate_on_create_callbacks = ActiveSupport::Callbacks::CallbackChain.new
+      @validate_on_update_callbacks = ActiveSupport::Callbacks::CallbackChain.new
+    end
+  end
+end
+
+class ValidatesAsEmailAddressUnrestrictedTest < Test::Unit::TestCase
+  def setup
+    User.validates_as_email_address :email, :strict => false
+  end
+  
+  def test_should_allow_illegal_rfc1035_formats
+    [
+      'test@[127.0.0.1]',
+      'test@-domain_not_starting_with_letter.com',
+      'test@domain_not_ending_with_alphanum-.com'
+    ].each do |address|
+      user = new_user(:email => address)
+      assert user.valid?, "#{address} should be legal."
+    end
+  end
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification 
 name: validates_as_email_address
 version: !ruby/object:Gem::Version 
-  version: 0.0.3
+  version: 0.1.0
 platform: ruby
 authors: 
 - Aaron Pfeifer
-autorequire: validates_as_email_address
+autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2008-06-22 00:00:00 -04:00
+date: 2008-09-12 00:00:00 -04:00
 default_executable: 
 dependencies: []
 
@@ -23,6 +23,7 @@ extra_rdoc_files: []
 
 files: 
 - lib/validates_as_email_address
+- lib/validates_as_email_address/rfc_1035.rb
 - lib/validates_as_email_address/rfc_822.rb
 - lib/validates_as_email_address.rb
 - test/app_root
@@ -32,16 +33,15 @@ files:
 - test/app_root/db
 - test/app_root/db/migrate
 - test/app_root/db/migrate/001_create_users.rb
-- test/app_root/log
 - test/test_helper.rb
 - test/factory.rb
 - test/unit
 - test/unit/validates_as_email_address_test.rb
-- CHANGELOG
+- CHANGELOG.rdoc
 - init.rb
 - LICENSE
 - Rakefile
-- README
+- README.rdoc
 has_rdoc: true
 homepage: http://www.pluginaweek.org
 post_install_message: 
@@ -63,8 +63,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   version: 
 requirements: []
 
-rubyforge_project: 
-rubygems_version: 1.1.1
+rubyforge_project: pluginaweek
+rubygems_version: 1.2.0
 signing_key: 
 specification_version: 2
 summary: Adds support for validating the format/length of email addresses

data/CHANGELOG

@@ -1,13 +0,0 @@
-*SVN*
-
-*0.0.3* (June 22nd, 2008)
-
-* Remove log files from gems
-
-*0.0.2* (May 5th, 2008)
-
-* Update documentation
-
-*0.0.1* (September 26th, 2007)
-
-* Add documentation