validates_as_email_address 0.0.2 → 0.0.3

data/CHANGELOG

@@ -1,5 +1,9 @@
 *SVN*
 
+*0.0.3* (June 22nd, 2008)
+
+* Remove log files from gems
+
 *0.0.2* (May 5th, 2008)
 
 * Update documentation

data/README

@@ -42,6 +42,14 @@ the email address.
 Before you can run any tests, the following gem must be installed:
 * plugin_test_helper[http://wiki.pluginaweek.org/Plugin_test_helper]
 
+To run against a specific version of Rails:
+
+  rake test RAILS_FRAMEWORK_ROOT=/path/to/rails
+
+== Dependencies
+
+* Rails 2.0 or later
+
 == References
 
 * Cal Henderson - {Parsing Email Adresses in PHP}[http://iamcal.com/publish/articles/php/parsing_email]

data/Rakefile

@@ -4,7 +4,7 @@ require 'rake/gempackagetask'
 require 'rake/contrib/sshpublisher'
 
 PKG_NAME           = 'validates_as_email_address'
-PKG_VERSION        = '0.0.2'
+PKG_VERSION        = '0.0.3'
 PKG_FILE_NAME      = "#{PKG_NAME}-#{PKG_VERSION}"
 RUBY_FORGE_PROJECT = 'pluginaweek'
 
@@ -22,6 +22,7 @@ desc 'Generate documentation for the validates_as_email_address plugin.'
 Rake::RDocTask.new(:rdoc) do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
   rdoc.title    = 'ValidatesAsEmailAddress'
+  rdoc.template = '../rdoc_template.rb'
   rdoc.options << '--line-numbers' << '--inline-source'
   rdoc.rdoc_files.include('README')
   rdoc.rdoc_files.include('lib/**/*.rb')
@@ -33,7 +34,7 @@ spec = Gem::Specification.new do |s|
   s.platform        = Gem::Platform::RUBY
   s.summary         = 'Adds support for validating the format/length of email addresses'
   
-  s.files           = FileList['{lib,test}/**/*'].to_a + %w(CHANGELOG init.rb LICENSE Rakefile README)
+  s.files           = FileList['{lib,test}/**/*'].to_a - FileList['test/app_root/log/*'].to_a + %w(CHANGELOG init.rb LICENSE Rakefile README)
   s.require_path    = 'lib'
   s.autorequire     = 'validates_as_email_address'
   s.has_rdoc        = true
@@ -61,13 +62,13 @@ task :pdoc => [:rdoc] do
 end
 
 desc 'Publish the API docs and gem'
-task :publish => [:pdoc, :release]
+task :publish => [:pgem, :pdoc, :release]
 
 desc 'Publish the release files to RubyForge.'
 task :release => [:gem, :package] do
   require 'rubyforge'
   
-  ruby_forge = RubyForge.new
+  ruby_forge = RubyForge.new.configure
   ruby_forge.login
   
   %w( gem tgz zip ).each do |ext|

data/test/factory.rb

@@ -0,0 +1,31 @@
+module Factory
+  # Build actions for the class
+  def self.build(klass, &block)
+    name = klass.to_s.underscore
+    define_method("#{name}_attributes", block)
+    
+    module_eval <<-end_eval
+      def valid_#{name}_attributes(attributes = {})
+        #{name}_attributes(attributes)
+        attributes
+      end
+      
+      def new_#{name}(attributes = {})
+        #{klass}.new(valid_#{name}_attributes(attributes))
+      end
+      
+      def create_#{name}(*args)
+        record = new_#{name}(*args)
+        record.save!
+        record.reload
+        record
+      end
+    end_eval
+  end
+  
+  build User do |attributes|
+    attributes.reverse_merge!(
+      :email => 'john.smith@gmail.com'
+    )
+  end
+end

data/test/test_helper.rb

@@ -4,4 +4,10 @@ require 'rubygems'
 require 'plugin_test_helper'
 
 # Run the migrations
-ActiveRecord::Migrator.migrate("#{RAILS_ROOT}/db/migrate")
+ActiveRecord::Migrator.migrate("#{Rails.root}/db/migrate")
+
+# Mixin the factory helper
+require File.expand_path("#{File.dirname(__FILE__)}/factory")
+class Test::Unit::TestCase #:nodoc:
+  include Factory
+end

data/test/unit/validates_as_email_address_test.rb

@@ -1,15 +1,12 @@
 require File.dirname(__FILE__) + '/../test_helper'
 
 class ValidatesAsEmailAddressTest < Test::Unit::TestCase
-  def test_should_require_legal_rfc822_format
-    [
-      'Max@Job 3:14', 
-      'Job@Book of Job',
-      'J. P. \'s-Gravezande, a.k.a. The Hacker!@example.com',
-    ].each do |address|
-      assert !User.new(:email => address).valid?, "#{address} should be illegal."
-    end
-    
+  def test_should_be_valid_with_a_valid_set_of_attributes
+    user = new_user
+    assert user.valid?
+  end
+  
+  def test_should_allow_legal_rfc822_formats
     [
       'test@example',
       'test@example.com', 
@@ -18,12 +15,32 @@ class ValidatesAsEmailAddressTest < Test::Unit::TestCase
       'me@[187.223.45.119]',
       'someone@123.com',
     ].each do |address|
-      assert User.new(:email => address).valid?, "#{address} should be legal."
+      user = new_user(:email => address)
+      assert user.valid?, "#{address} should be legal."
     end
   end
   
-  def test_not_allow_email_addresses_longer_than_320_characters
-    assert User.new(:email => 'a' * 314 + '@a.com').valid?
-    assert !User.new(:email => 'a' * 315 + '@a.com').valid?
+  def test_should_not_allow_illegal_rfc822_formats
+    [
+      'Max@Job 3:14', 
+      'Job@Book of Job',
+      'J. P. \'s-Gravezande, a.k.a. The Hacker!@example.com',
+    ].each do |address|
+      user = new_user(:email => address)
+      assert !user.valid?, "#{address} should be illegal."
+      assert_equal 1, Array(user.errors.on(:email)).size
+    end
+  end
+  
+  def test_not_allow_emails_longer_than_320_characters
+    user = new_user(:email => 'a' * 313 + '@a.com')
+    assert user.valid?
+    
+    user.email = 'a' + user.email
+    assert user.valid?
+    
+    user.email = 'a' + user.email
+    assert !user.valid?
+    assert_equal 1, Array(user.errors.on(:email)).size
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: validates_as_email_address
 version: !ruby/object:Gem::Version 
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors: 
 - Aaron Pfeifer
@@ -9,7 +9,7 @@ autorequire: validates_as_email_address
 bindir: bin
 cert_chain: []
 
-date: 2008-05-05 00:00:00 -04:00
+date: 2008-06-22 00:00:00 -04:00
 default_executable: 
 dependencies: []
 
@@ -22,19 +22,19 @@ extensions: []
 extra_rdoc_files: []
 
 files: 
-- lib/validates_as_email_address.rb
 - lib/validates_as_email_address
 - lib/validates_as_email_address/rfc_822.rb
+- lib/validates_as_email_address.rb
 - test/app_root
-- test/app_root/log
-- test/app_root/log/in_memory.log
-- test/app_root/db
-- test/app_root/db/migrate
-- test/app_root/db/migrate/001_create_users.rb
 - test/app_root/app
 - test/app_root/app/models
 - test/app_root/app/models/user.rb
+- test/app_root/db
+- test/app_root/db/migrate
+- test/app_root/db/migrate/001_create_users.rb
+- test/app_root/log
 - test/test_helper.rb
+- test/factory.rb
 - test/unit
 - test/unit/validates_as_email_address_test.rb
 - CHANGELOG
@@ -64,7 +64,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.1.0
+rubygems_version: 1.1.1
 signing_key: 
 specification_version: 2
 summary: Adds support for validating the format/length of email addresses

data/test/app_root/log/in_memory.log

@@ -1,39 +0,0 @@
-# Logfile created on Sun Apr 06 00:59:11 -0400 2008  SQL (0.000430)   select sqlite_version(*)
-  SQL (0.000442)   CREATE TABLE "schema_info" (version varchar(255))
-  SQL (0.000121)   INSERT INTO "schema_info" (version) VALUES(0)
-  SQL (0.000224)   SELECT version FROM schema_info
-Migrating to CreateUsers (1)
-  SQL (0.000223)    SELECT name
- FROM sqlite_master
- WHERE type = 'table' AND NOT name = 'sqlite_sequence'
-
-  SQL (0.000428)   select sqlite_version(*)
-  SQL (0.000429)   CREATE TABLE "schema_info" (version varchar(255))
-  SQL (0.000115)   INSERT INTO "schema_info" (version) VALUES(0)
-  SQL (0.000221)   SELECT version FROM schema_info
-Migrating to CreateUsers (1)
-  SQL (0.000359)   CREATE TABLE "users" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "email" varchar(320) NOT NULL) 
-  SQL (0.000106)   UPDATE schema_info SET version = 1
-  SQL (0.000431)   select sqlite_version(*)
-  SQL (0.000426)   CREATE TABLE "schema_info" (version varchar(255))
-  SQL (0.000114)   INSERT INTO "schema_info" (version) VALUES(0)
-  SQL (0.000224)   SELECT version FROM schema_info
-Migrating to CreateUsers (1)
-  SQL (0.000352)   CREATE TABLE "users" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "email" varchar(320) NOT NULL) 
-  SQL (0.000105)   UPDATE schema_info SET version = 1
-  SQL (0.000460)    SELECT name
- FROM sqlite_master
- WHERE type = 'table' AND NOT name = 'sqlite_sequence'
-
-  SQL (0.000260)   select sqlite_version(*)
-  SQL (0.000324)   CREATE TABLE "schema_migrations" ("version" varchar(255) NOT NULL) 
-  SQL (0.000255)   CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
-  SQL (0.000211)    SELECT name
- FROM sqlite_master
- WHERE type = 'table' AND NOT name = 'sqlite_sequence'
-
-  SQL (0.000150)   SELECT version FROM schema_migrations
-Migrating to CreateUsers (1)
-  SQL (0.000093)   SELECT version FROM schema_migrations
-  SQL (0.000361)   CREATE TABLE "users" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "email" varchar(320) NOT NULL) 
-  SQL (0.000151)   INSERT INTO schema_migrations (version) VALUES ('1')