valid_email2 3.5.0 → 3.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 85903e3f9f5d0e8222dcc7768e15632eecf4a6008e8a43c2d88549cfa9a140ae
-  data.tar.gz: 2519e54f15012418caa00608301ff19f91640ecf63e9cf88c586afa2d1a0d2d2
+  metadata.gz: f6543e0ca764df6ed5698a864b232260e456a0fc3b8e3f82918122e21cdca0c3
+  data.tar.gz: 989805e58182e1b4ab18b9a16a80a9507465f840bea19840abebe841d628dfa9
 SHA512:
-  metadata.gz: 811d82babbd7ad076fc077d4dea52074ecf6591926ed6b37b4f6595b614bc46eeacfd944db95ebc577a6cfb36d858009a051eed67e87fa5ce3f06b63c576c8b6
-  data.tar.gz: 653fe9f637840019997480853e5784e4fba055f4d579bce8af3b30e631da8fe86a5074e00564d72444f7b4a1cd0f4d7d829d9928e7c3962d1b612b595cc16545
+  metadata.gz: 59813d38f00f9c75cbaae7d944f47d50f9e0239f740c468e8718c51345af324f46411e13b2796c5881769a62127345529be92ae374d07082d07e06610e50b62a
+  data.tar.gz: 131d25e900327ff67b0cd80e17ecc0de83462394d8094cafbed93780ec9b4d472b8e1b95591dc8c894fc8c4f47a8a5a60d31d7fa3c6733210f1b429ca79ff72c

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## Version 3.6.0
+* Add strict_mx validation https://github.com/micke/valid_email2/pull/173
+
 ## Version 3.5.0
 * Disallow emails starting with a dot https://github.com/micke/valid_email2/pull/170
 * Add option to whitelist domains from MX check https://github.com/micke/valid_email2/pull/167

data/README.md

@@ -43,10 +43,14 @@ class User < ActiveRecord::Base
 end
 ```
 
-To validate that the domain has a MX record:
+To validate that the domain has an MX record or A record:
 ```ruby
 validates :email, 'valid_email_2/email': { mx: true }
 ```
+To validate strictly that the domain has an MX record:
+```ruby
+validates :email, 'valid_email_2/email': { strict_mx: true }
+```
 
 To validate that the domain is not a disposable email (checks domain and MX server):
 ```ruby
@@ -109,6 +113,7 @@ address = ValidEmail2::Address.new("lisinge@gmail.com")
 address.valid? => true
 address.disposable? => false
 address.valid_mx? => true
+address.valid_strict_mx? => true
 address.subaddressed? => false
 ```
 
@@ -120,6 +125,7 @@ Do so by adding this in your `spec_helper`:
 ```ruby
 config.before(:each) do
   allow_any_instance_of(ValidEmail2::Address).to receive(:valid_mx?).and_return(true)
+  allow_any_instance_of(ValidEmail2::Address).to receive(:valid_strict_mx?).and_return(true)
 end
 ```
 

data/config/disposable_email_domains.txt

@@ -4174,6 +4174,7 @@ avuimkgtbgccejft901.ml
 avuimkgtbgccejft901.tk
 avumail.com
 avvmail.com
+avxrja.com
 aw.kikwet.com
 awahal0vk1o7gbyzf0.cf
 awahal0vk1o7gbyzf0.ga
@@ -12324,6 +12325,7 @@ gd6ubc0xilchpozgpg.gq
 gd6ubc0xilchpozgpg.ml
 gd6ubc0xilchpozgpg.tk
 gdb.armageddon.org
+gdf.it
 gdfretertwer.com
 gdmail.top
 gdradr.com
@@ -12788,6 +12790,7 @@ gmailllll.ga
 gmaills.eu
 gmailmail.ga
 gmailmarina.com
+gmailnator.com
 gmailner.com
 gmailnew.com
 gmailom.co
@@ -12938,6 +12941,7 @@ golivejasmin.com
 gomail.in
 gomail.pgojual.com
 gomailbox.info
+gomaild.com
 gomaile.com
 gomailstar.xyz
 gomessage.ml
@@ -18053,6 +18057,7 @@ louboutinshoessalejp.com
 louboutinshoesstoresjp.com
 louboutinshoesus.com
 louder1.bid
+loufad.com
 louis-vuitton-onlinestore.com
 louis-vuitton-outlet.com
 louis-vuitton-outletenter.com
@@ -31422,7 +31427,6 @@ webcontact-france.eu
 webcool.club
 webdesign-guide.info
 webdesign-romania.net
-webdesignspecialist.com.au
 webdesigrsbio.gr
 webdespro.ru
 webdev-pro.ru
@@ -32327,6 +32331,7 @@ xdvsagsdg4we.ga
 xe2g.com
 xeames.net
 xeb9xwp7.tk
+xedmi.com
 xemaps.com
 xemne.com
 xenacareholdings.com
@@ -32377,6 +32382,7 @@ xhkss.net
 xijjfjoo.turystyka.pl
 xilopro.com
 xilor.com
+ximtyl.com
 xinbo.info
 xinbox.info
 xinfi.com.pl
@@ -33698,4 +33704,4 @@ zzv2bfja5.pl
 zzz.co
 zzz.com
 zzzmail.pl
-zzzzzzzzzzzzz.com
+zzzzzzzzzzzzz.com

data/lib/valid_email2/address.rb

@@ -85,6 +85,12 @@ module ValidEmail2
     def valid_mx?
       return false unless valid?
 
+      mx_or_a_servers.any?
+    end
+
+    def valid_strict_mx?
+      return false unless valid?
+
       mx_servers.any?
     end
 
@@ -119,7 +125,12 @@ module ValidEmail2
 
     def mx_servers
       @mx_servers ||= Resolv::DNS.open do |dns|
-        mx_servers = dns.getresources(address.domain, Resolv::DNS::Resource::IN::MX)
+        dns.getresources(address.domain, Resolv::DNS::Resource::IN::MX)
+      end
+    end
+
+    def mx_or_a_servers
+      @mx_or_a_servers ||= Resolv::DNS.open do |dns|
         (mx_servers.any? && mx_servers) ||
           dns.getresources(address.domain, Resolv::DNS::Resource::IN::A)
       end

data/lib/valid_email2/email_validator.rb

@@ -5,7 +5,7 @@ require "active_model/validations"
 module ValidEmail2
   class EmailValidator < ActiveModel::EachValidator
     def default_options
-      { regex: true, disposable: false, mx: false, disallow_subaddressing: false, multiple: false }
+      { regex: true, disposable: false, mx: false, strict_mx: false, disallow_subaddressing: false, multiple: false }
     end
 
     def validate_each(record, attribute, value)
@@ -48,6 +48,10 @@ module ValidEmail2
       if options[:mx]
         error(record, attribute) && return unless addresses.all?(&:valid_mx?)
       end
+
+      if options[:strict_mx]
+        error(record, attribute) && return unless addresses.all?(&:valid_strict_mx?)
+      end
     end
 
     def error(record, attribute)

data/lib/valid_email2/version.rb

@@ -1,3 +1,3 @@
 module ValidEmail2
-  VERSION = "3.5.0"
+  VERSION = "3.6.0"
 end

data/pull_mailchecker_emails.rb

@@ -8,7 +8,7 @@ require "net/http"
 whitelisted_emails = %w(
   onet.pl poczta.onet.pl fastmail.fm hushmail.com
   hush.ai hush.com hushmail.me naver.com qq.com example.com
-  yandex.net gmx.com gmx.es
+  yandex.net gmx.com gmx.es webdesignspecialist.com.au vp.com
 )
 
 existing_emails = File.open("config/disposable_email_domains.txt") { |f| f.read.split("\n") }

data/spec/valid_email2_spec.rb

@@ -19,6 +19,10 @@ class TestUserMX < TestModel
   validates :email, 'valid_email_2/email': { mx: true }
 end
 
+class TestUserStrictMX < TestModel
+  validates :email, 'valid_email_2/email': { strict_mx: true }
+end
+
 class TestUserDisallowDisposable < TestModel
   validates :email, 'valid_email_2/email': { disposable: true }
 end
@@ -253,6 +257,23 @@ describe ValidEmail2 do
     end
   end
 
+  describe "with strict mx validation" do
+    it "is valid if mx records are found" do
+      user = TestUserStrictMX.new(email: "foo@gmail.com")
+      expect(user.valid?).to be_truthy
+    end
+
+    it "is invalid if A records are found but no mx records are found" do
+      user = TestUserStrictMX.new(email: "foo@ghs.google.com")
+      expect(user.valid?).to be_falsey
+    end
+
+    it "is invalid if no mx records are found" do
+      user = TestUserStrictMX.new(email: "foo@subdomain.gmail.com")
+      expect(user.valid?).to be_falsey
+    end
+  end
+
   describe "with dotted validation" do
     it "is valid when address does not contain dots" do
       user = TestUserDotted.new(email: "johndoe@gmail.com")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valid_email2
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.6.0
 platform: ruby
 authors:
 - Micke Lisinge
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-30 00:00:00.000000000 Z
+date: 2021-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -157,7 +157,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: ActiveModel validation for email. Including MX lookup and disposable email