valid_email2 2.2.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4efb3075e063a636d33229b0a59d8f4209bf8837
-  data.tar.gz: 8b54ad8488422e2976cf7ee9a08fac064fe20357
+  metadata.gz: 4846126777b929a2c98071c1a37d123f862f27cb
+  data.tar.gz: 34855d8b778cdf6a2b37d367ad3c0bad450d13e9
 SHA512:
-  metadata.gz: 9628e362c4c828adc1d47005d05dc5c947aef9303445c7a667f55b0a194fa7b13d5f223adacef37c59480449d66ea665b6131b56e60b1a3d95de02ccdfbca01e
-  data.tar.gz: e369e0af8a46db2e93aee4f82957115313eda5d643a9752bd68b40c5834fc84822136642110fe4187c10697cdd1865df33fb363646c17f6fa7e6d179f8ac1e0e
+  metadata.gz: 85bfaea5ddd6e2d71d271f5c4cc6c5fda4b13c1e297d19357e496a6daaccf39d6b95dcf73e7b91177b26cf414ebb7a16a9e141a09fa270fd9d80c50f8d427e58
+  data.tar.gz: 8cbf2ca1cc79031ccdf1c5fa37131993dc2dab391191df74356a65ce8a3c07e13c398a7e0d52ff6bba55abc72688c775cdf0561c33dcffaea99e182af0b1d942

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## Version 2.2.1
+Fix regression where `ValidEmail2::Address.new` couldn't handle the address
+being nil (https://github.com/lisinge/valid_email2/issues/102)
+
 ## Version 2.2.0
 Removed backwards-compatability shim  (https://github.com/lisinge/valid_email2/pull/79)  
 Removed protonmail.com from disposable email domains (https://github.com/lisinge/valid_email2/pull/99)  

data/lib/valid_email2/address.rb

@@ -66,7 +66,9 @@ module ValidEmail2
     end
 
     def address_contain_emoticons? email_str
-      (email_str.each_char.select { |char| char.bytesize > 1 }.join).empty? ? false : true
+      return false if email_str.nil?
+
+      email_str.each_char.any? { |char| char.bytesize > 1 }
     end
   end
 end

data/lib/valid_email2/version.rb

@@ -1,3 +1,3 @@
 module ValidEmail2
-  VERSION = "2.2.0"
+  VERSION = "2.2.1"
 end

data/spec/valid_email2_spec.rb

@@ -16,10 +16,6 @@ class TestUserDisallowBlacklisted < TestModel
   validates :email, 'valid_email_2/email': { blacklist: true }
 end
 
-class BackwardsCompatibleUser < TestModel
-  validates :email, 'valid_email_2/email': true
-end
-
 describe ValidEmail2 do
   describe "basic validation" do
     subject(:user) { TestUser.new(email: "") }
@@ -60,14 +56,6 @@ describe ValidEmail2 do
       user = TestUser.new(email: "foo@bar..com")
       expect(user.valid?).to be_falsey
     end
-
-    it "still works with the backwards-compatible syntax" do
-      user = BackwardsCompatibleUser.new(email: "foo@bar.com")
-      expect(user.valid?).to be_truthy
-
-      user = BackwardsCompatibleUser.new(email: "foo@bar")
-      expect(user.valid?).to be_falsey
-    end
   end
 
   describe "disposable emails" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valid_email2
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Micke Lisinge
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-25 00:00:00.000000000 Z
+date: 2018-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler