valid_email2 1.1.5 → 1.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 89124fcb3dcff8c5eb8833cfa0f4bc7e52777974
-  data.tar.gz: 4d11dd11352a95f1965d838567081839531b5859
+  metadata.gz: dd308777bd64592b2de0a1af1308fd80b197d1b7
+  data.tar.gz: 11545bb3afeb1885a8513121d59a55955408392f
 SHA512:
-  metadata.gz: cbc8d2a1282dc1603bb086af4707500d8cb71e2f231d25a0bca4218762f8a9212ebe78ef8318ceb09b0ea75faed07a5b584dd6ee34cd868111688a2ce6f4bae5
-  data.tar.gz: 7ba94266099a2e3a453251d89d74b8d04f47f329d5d54b16787e06030edab5323a04da8769e32534fc9cf641e6791b928dd5da824bbd48b4d5e1597e3aa848be
+  metadata.gz: 04d4aefcd05f9e893203c686ce9ac0c87a0cc81ec711ebae25b10b2f4f59d738d5dc9001d852524fd9e297a4d8796bebff199217d7e083942aca79141117f101
+  data.tar.gz: d035191846afc8fc0327d7429adfa228d1bfef8b71ba51c96d3ccca05743216fd47f10809944f6e590de77e5ec6458437ce83cc5a075b79b2bf58b9afc3e579c

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## Version 1.1.6
+Fix a regression which changed validation on domains that caused domains with
+multiple consecutive dots to be valid.
+
 ## Version 1.1.5
 Be more lenient on the mail gem version dependency to allow people to use v2.6.
 Added more disposable email domains (https://github.com/lisinge/valid_email2/pull/14 and https://github.com/lisinge/valid_email2/pull/15)

data/lib/valid_email2/address.rb

@@ -21,8 +21,9 @@ module ValidEmail2
       return false if @parse_error
 
       if address.domain && address.address == @raw_address
+        domain = address.domain
         # Valid address needs to have a dot in the domain
-        !!address.domain.match(/\./)
+        !!domain.match(/\./) && !domain.match(/\.{2,}/)
       else
         false
       end

data/lib/valid_email2/version.rb

@@ -1,3 +1,3 @@
 module ValidEmail2
-  VERSION = "1.1.5"
+  VERSION = "1.1.6"
 end

data/spec/valid_email2_spec.rb

@@ -39,6 +39,11 @@ describe ValidEmail2 do
       Mail::Address.stub(:new).and_raise(Mail::Field::ParseError.new(nil, nil, nil))
       user.valid?.should be_false
     end
+
+    it "shouldn't be valid if the domain constains consecutives dots" do
+      user = TestUser.new(email: "foo@bar..com")
+      user.valid?.should be_false
+    end
   end
 
   describe "disposable emails" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valid_email2
 version: !ruby/object:Gem::Version
-  version: 1.1.5
+  version: 1.1.6
 platform: ruby
 authors:
 - Micke Lisinge
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-04 00:00:00.000000000 Z
+date: 2015-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler