valid_email 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '07881400a61a403d6c3e518404847d050d28e5b28e1442205cd36daf77f5ca1d'
-  data.tar.gz: 9aeb926a06b6a3ca32147ae9c2c01b7aee0c5c8932668f980ca9ab2a2c4c3519
+  metadata.gz: 7e0da2f8d6e1b69a777c0d9a6bb14632fa577ecfa55acb7128d436e1543a6842
+  data.tar.gz: c8a125e2971de31cd1e43a49827af99cb1a44130082c555b448083aa1fc6bbaf
 SHA512:
-  metadata.gz: 3f6cf4d94d6ecf345189b7ffc41f185977d2b23b21c011b98cfa01f5da7c1c9add6f00425b317547d14cd4dd5e4ca595b6e13523e25ceaf9163b04567b781707
-  data.tar.gz: 8aa4b92513c11e81b87b793a348d9581f6d11a70300006a3c1d6434032cf52b3aeacdf61b470db06ff74433ad677903156cc3967c6db7f833c9cb3bfe0c43c76
+  metadata.gz: 736072b973d66828d1f2cd78b6248599a5ecc3d054d0cbbd1354a4735447a97024575649c7bbe110edb576f18cedd647d378ceb12a9d8344639179c3c8d8ade0
+  data.tar.gz: 52fa87c50d4bf5570779706a39dea8c803b894256d7a92563b0b02009f92b262b6439565d4efd5345b65974f41dbd899085c6349f7c1cb4a5e9c82abcf21efe1

data/README.md

@@ -74,6 +74,17 @@ validates :email,
           }
 ```
 
+You can also detect a partial match on disposable accounts, good for services that use subdomains.
+
+```ruby
+validates :email,
+          email: {
+            message: I18n.t('validations.errors.models.user.invalid_email')
+            ban_disposable_email: true,
+            partial: true
+          }
+```
+
 If you don't want the MX validator stuff, just require the right file
 
 ```ruby

data/lib/valid_email/ban_disposable_email_validator.rb

@@ -15,9 +15,19 @@ class BanDisposableEmailValidator < ActiveModel::EachValidator
   end
 
   def validate_each(record, attribute, value)
-    r = ValidateEmail.ban_disposable_email?(value)
-    record.errors.add attribute, (options[:message] || I18n.t(:invalid, :scope => "valid_email.validations.email")) unless r
+    # Check if part of domain is in disposable_email_services yml list
+    if options[:partial]
+      r = ValidateEmail.ban_partial_disposable_email?(value)
+      record.errors.add attribute, (options[:message] ||
+        I18n.t(:invalid, :scope => "valid_email.validations.email")) unless r
 
-    r
+      r
+    else
+      r = ValidateEmail.ban_disposable_email?(value)
+      record.errors.add attribute, (options[:message] ||
+        I18n.t(:invalid, :scope => "valid_email.validations.email")) unless r
+
+      r
+    end
   end
 end

data/lib/valid_email/email_validator.rb

@@ -18,7 +18,7 @@ class EmailValidator < ActiveModel::EachValidator
     # Check if domain is disposable
     if r && options[:ban_disposable_email]
       require 'valid_email/ban_disposable_email_validator'
-      r = BanDisposableEmailValidator.new(:attributes => attributes, message: options[:message]).validate(record)
+      r = BanDisposableEmailValidator.new(:attributes => attributes, message: options[:message], partial: options[:partial]).validate(record)
     end
     unless r
       msg = (options[:message] || I18n.t(:invalid, :scope => "valid_email.validations.email"))

data/lib/valid_email/validate_email.rb

@@ -128,5 +128,15 @@ class ValidateEmail
     rescue Mail::Field::ParseError
       false
     end
+
+    def ban_partial_disposable_email?(value)
+      m = Mail::Address.new(value)
+      m.domain && !BanDisposableEmailValidator.config.any? do |bde|
+        next if bde == nil
+        m.domain.end_with?(bde)
+      end
+    rescue Mail::Field::ParseError
+      false
+    end
   end
 end

data/lib/valid_email/version.rb

@@ -1 +1 @@
-ValidEmailVersion = "0.2.0"
+ValidEmailVersion = "0.2.1"

data/spec/email_validator_spec.rb

@@ -43,6 +43,10 @@ describe EmailValidator do
     validates :email, :email => {:ban_disposable_email => true}
   end
 
+  person_class_partial_disposable_email = Class.new(email_class) do
+    validates :email, :email => {:ban_disposable_email => true, :partial => true}
+  end
+
   person_class_nil_allowed = Class.new(email_class) do
     validates :email, :email => {:allow_nil => true}
   end
@@ -147,7 +151,6 @@ describe EmailValidator do
         expect(subject.valid?).to be_falsey
         expect(subject).to have_error_messages(:email, errors)
       end
-
     end
 
     describe "validating email with MX and fallback to A" do
@@ -248,6 +251,22 @@ describe EmailValidator do
       end
     end
 
+    describe "validating email against partial disposable service match" do
+      subject { person_class_partial_disposable_email.new }
+
+      it "passes when email from trusted email services" do
+        subject.email = 'john@test.mail.ru'
+        expect(subject.valid?).to be_truthy
+        expect(subject.errors[:email]).to be_empty
+      end
+
+      it "fails when disposable email services partially matches email domain" do
+        subject.email = 'john@sub.grr.la'
+        expect(subject.valid?).to be_falsey
+        expect(subject.errors[:email]).to eq errors
+      end
+    end
+
     describe "validating domain" do
       subject { person_class_domain.new }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valid_email
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Ramihajamalala Hery
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-29 00:00:00.000000000 Z
+date: 2024-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -145,7 +145,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.13
+rubygems_version: 3.5.6
 signing_key:
 specification_version: 4
 summary: ActiveModel Validation for email