valid_email 0.0.13 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ca6b2a7baefd0f49bd9f7bceb9bdcc809164fd2b
-  data.tar.gz: 0a66612b626c0e168b2f18e419cf8ca42c554370
+  metadata.gz: e74f85e1ed674767b2c063685a30bb2ebbc6e9fe
+  data.tar.gz: fe2254848da959f25c12732890ba4acd020c618d
 SHA512:
-  metadata.gz: e462c60e4c9e72b373a6a17132b29c17d08589c40f32a261690395aae79dafb96072ad40b4b30904632498906a6003ee1acb0ce75417f019e5d4541333d24bc1
-  data.tar.gz: fcb9dc08ef5995b1b2c69b55b4224001f47ba09995adf206a3c1a53fad0e25ebf501b3923754f04ec97d5e0a636a3011dde80ae45275bd2d2a89bd216881ada8
+  metadata.gz: c5b07afeee1c98a219e66d40358e46a898939951cfeb6f5aef6d2bd6f76b77f62e3da37442d614746905c54b0a6acee5cf5f4c1ae3fa67a18f2607b1d2d95493
+  data.tar.gz: db5b162817ff28baee70881951062943363808f7f519954d15e91a0eb66207839249b84f8f0b819396e4a22c16de18081a4e209d9d8e4d42126559a5fde3f924

data/.travis.yml

@@ -5,4 +5,9 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1
+  - 2.2.1
+  - 2.2.2
+  - 2.3.3
+  - 2.4.0
   - jruby-19mode
+  - jruby-20mode

data/History.md

@@ -0,0 +1,11 @@
+
+0.1.0 / 2017-09-27
+==================
+
+  * #86 Change dependency on mail to >= 2.6.1
+  * #85 adding disposable email domains from getnada
+  * #84 ValidateEmail.valid?: make domain validation true by default
+  * #83 Allow to configure timeouts for dns
+  * #82 Travis CI. Support for more Ruby versions
+  * #80 rescue Mail::Field::ParseError also in domain_valid?
+  * #78 Added pt-BR translation

data/README.md

@@ -40,12 +40,11 @@ Or
 
     validates :email, :email => {:message => I18n.t('validations.errors.models.user.invalid_email')}, :mx => {:message => I18n.t('validations.errors.models.user.invalid_mx')}
 
-You can check if the email domain looks valid. This uses a regular expression so no external services are required, which improves the performance of this check:
-
-    validates :email, :email => {:domain => true}
-
+By default, the email domain is validated using a regular expression, which does not require an external service and improves performance.
 Alternatively, you can check if an email domain has a MX or A record by using `:mx_with_fallback` instead of `:mx`.
 
+    validates :email, :email => {:mx_with_fallback => true}
+
 You can detect disposable accounts
 
     validates :email, :email => {:ban_disposable_email => true, :message => I18n.t('validations.errors.models.user.invalid_email')}

data/config/locales/pt-BR.yml

@@ -0,0 +1,5 @@
+pt-BR:
+  valid_email:
+    validations:
+      email:
+        invalid: "é inválido"

data/config/valid_email.yml

@@ -1,16 +1,4 @@
 disposable_email_services:
-  - mailinator.com
-  - devnullmail.com
-  - daddymail.biz
-  - grr.la
-  - drdrb.net
-  - getairmail.com
-  - evopo.com
-  - 6paq.com
-  - paplease.com
-  - acentri.com
-  - droplar.com
-  - appixie.com
   - 0-mail.com
   - 0815.ru
   - 0clickemail.com
@@ -29,21 +17,18 @@ disposable_email_services:
   - 675hosting.com
   - 675hosting.net
   - 675hosting.org
+  - 6paq.com
   - 6url.com
   - 75hosting.com
   - 75hosting.net
   - 75hosting.org
   - 7tags.com
   - 9ox.net
-  - disposableemailaddresses.com
-  - putthisinyourspamdatabase.com
-  - sendspamhere.com
-  - spamherelots.com
-  - spamhereplease.com
-  - tempemail.net
   - a-bc.net
+  - acentri.com
   - afrobacon.com
   - ajaxapp.net
+  - amail.club
   - amail4.me
   - amilegit.com
   - amiri.net
@@ -53,8 +38,11 @@ disposable_email_services:
   - antichef.com
   - antichef.net
   - antispam.de
+  - appixie.com
   - armyspy.com
   - azmeil.tk
+  - banit.club
+  - banit.me
   - baxomale.ht.cx
   - beefmilk.com
   - binkmail.com
@@ -69,11 +57,13 @@ disposable_email_services:
   - bsnow.net
   - bugmenot.com
   - bumpymail.com
+  - cars2.club
   - casualdx.com
   - centermail.com
   - centermail.net
   - chogmail.com
   - choicemail1.com
+  - cmail.club
   - cool.fr.nf
   - correo.blogos.net
   - cosmorph.com
@@ -84,6 +74,7 @@ disposable_email_services:
   - cust.in
   - cuvox.de
   - dacoolest.com
+  - daddymail.biz
   - dandikmail.com
   - dayrep.com
   - deadaddress.com
@@ -96,6 +87,7 @@ disposable_email_services:
   - discardmail.com
   - discardmail.de
   - disposableaddress.com
+  - disposableemailaddresses.com
   - disposeamail.com
   - disposemail.com
   - dispostable.com
@@ -107,6 +99,9 @@ disposable_email_services:
   - dontreg.com
   - dontsendmespam.de
   - drdrb.com
+  - drdrb.net
+  - droplar.com
+  - duck2.club
   - dump-email.info
   - dumpandjunk.com
   - dumpmail.de
@@ -133,6 +128,7 @@ disposable_email_services:
   - etranquil.com
   - etranquil.net
   - etranquil.org
+  - evopo.com
   - explodemail.com
   - fakeinbox.com
   - fakeinformation.com
@@ -158,6 +154,7 @@ disposable_email_services:
   - get1mail.com
   - get2mail.fr
   - getairmail.com
+  - getnada.com
   - getonemail.com
   - getonemail.net
   - ghosttexter.de
@@ -174,6 +171,7 @@ disposable_email_services:
   - gowikitv.com
   - great-host.in
   - greensloth.com
+  - grr.la
   - gsrv.co.uk
   - guerillamail.biz
   - guerillamail.com
@@ -299,6 +297,8 @@ disposable_email_services:
   - myspacepimpedup.com
   - myspamless.com
   - mytrashmail.com
+  - nada.email
+  - nada.ltd
   - neomailbox.com
   - nepwk.com
   - nervmich.net
@@ -336,6 +336,7 @@ disposable_email_services:
   - ovpn.to
   - owlpic.com
   - pancakemail.com
+  - paplease.com
   - pimpedupmyspace.com
   - pjjkp.com
   - politikerclub.de
@@ -345,6 +346,7 @@ disposable_email_services:
   - proxymail.eu
   - prtnx.com
   - punkass.com
+  - putthisinyourspamdatabase.com
   - qq.com
   - quickinbox.com
   - rcpt.at
@@ -366,6 +368,7 @@ disposable_email_services:
   - sandelf.de
   - saynotospams.com
   - selfdestructingmail.com
+  - sendspamhere.com
   - sharklasers.com
   - shiftmail.com
   - shitmail.me
@@ -413,6 +416,8 @@ disposable_email_services:
   - spamgourmet.com
   - spamgourmet.net
   - spamgourmet.org
+  - spamherelots.com
+  - spamhereplease.com
   - spamhole.com
   - spamify.com
   - spaminator.de
@@ -440,6 +445,7 @@ disposable_email_services:
   - tempe-mail.com
   - tempemail.biz
   - tempemail.com
+  - tempemail.net
   - tempinbox.co.uk
   - tempinbox.com
   - tempmail.it
@@ -500,6 +506,7 @@ disposable_email_services:
   - whyspam.me
   - willselfdestruct.com
   - winemaven.info
+  - wmail.club
   - wronghead.com
   - wuzup.net
   - wuzupmail.net

data/lib/valid_email/mx_validator.rb

@@ -3,6 +3,12 @@ require 'active_model/validations'
 require 'resolv'
 require 'valid_email/validate_email'
 class MxValidator < ActiveModel::EachValidator
+  def self.config
+    @@config = { timeouts: [] } unless defined? @@config
+
+    @@config
+  end
+
   def validate_each(record,attribute,value)
     r = ValidateEmail.mx_valid?(value)
     record.errors.add attribute, (options[:message] || I18n.t(:invalid, :scope => "valid_email.validations.email")) unless r

data/lib/valid_email/validate_email.rb

@@ -10,7 +10,7 @@ class ValidateEmail
     def valid?(value, user_options={})
       options = {
         :mx => false,
-        :domain => false,
+        :domain => true,
         :message => nil
       }.merge(user_options)
 
@@ -92,6 +92,7 @@ class ValidateEmail
 
       mx = []
       Resolv::DNS.open do |dns|
+        dns.timeouts = MxValidator.config[:timeouts] unless MxValidator.config[:timeouts].empty?
         mx.concat dns.getresources(m.domain, Resolv::DNS::Resource::IN::MX)
         mx.concat dns.getresources(m.domain, Resolv::DNS::Resource::IN::A) if fallback
       end
@@ -110,6 +111,9 @@ class ValidateEmail
       return false unless m.domain
 
       !(m.domain =~ DOMAIN_REGEX).nil?
+
+    rescue Mail::Field::ParseError
+      false
     end
 
     def ban_disposable_email?(value)

data/lib/valid_email/version.rb

@@ -1 +1 @@
-ValidEmailVersion = "0.0.13"
+ValidEmailVersion = "0.1.0"

data/spec/email_validator_spec.rb

@@ -100,6 +100,18 @@ describe EmailValidator do
         expect(subject.errors[:email]).to eq errors
       end
 
+      it "fails when email ends with a period" do
+        subject.email = 'john@doe.com.'
+        expect(subject.valid?).to be_falsey
+        expect(subject.errors[:email]).to eq errors
+      end
+
+      it "fails when email ends with special characters" do
+        subject.email = 'john@doe.com&'
+        expect(subject.valid?).to be_falsey
+        expect(subject.errors[:email]).to eq errors
+      end
+
       it "fails when email is valid with information" do
         subject.email = '"John Doe" <john@doe.com>'
         expect(subject.valid?).to be_falsey

data/spec/validate_email_spec.rb

@@ -64,6 +64,7 @@ describe ValidateEmail do
           'test..com',
           'test@test.com',
           "example.org$\'",
+          "foo bar.com",
         ]
 
         invalid_domains.each do |invalid_domain|

data/valid_email.gemspec

@@ -21,7 +21,14 @@ Gem::Specification.new do |s|
 
   # specify any dependencies here; for example:
   s.add_development_dependency "rspec", "~> 2.99"
-  s.add_development_dependency "rake"
-  s.add_runtime_dependency "mail", "~> 2.6.1"
-  s.add_runtime_dependency "activemodel"
+  s.add_development_dependency "rake", '< 11.0'
+  s.add_runtime_dependency "mail", ">= 2.6.1"
+  if Gem::Version.new(RUBY_VERSION) <= Gem::Version.new('2.0')
+    s.add_runtime_dependency 'mime-types', '<= 2.6.2'
+  end
+  if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.2.2')
+    s.add_runtime_dependency "activemodel", '< 5.0.0'
+  else
+    s.add_runtime_dependency "activemodel"
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valid_email
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.1.0
 platform: ruby
 authors:
 - Ramihajamalala Hery
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-11 00:00:00.000000000 Z
+date: 2017-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -28,28 +28,28 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '11.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '11.0'
 - !ruby/object:Gem::Dependency
   name: mail
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.6.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.6.1
 - !ruby/object:Gem::Dependency
@@ -76,6 +76,7 @@ files:
 - ".gitignore"
 - ".travis.yml"
 - Gemfile
+- History.md
 - LICENSE
 - README.md
 - Rakefile
@@ -87,6 +88,7 @@ files:
 - config/locales/id.yml
 - config/locales/ja.yml
 - config/locales/pl.yml
+- config/locales/pt-BR.yml
 - config/locales/ru.yml
 - config/locales/sv.yml
 - config/locales/uk.yml
@@ -126,7 +128,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: valid_email
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: ActiveModel Validation for email