valid_email 0.0.7 → 0.0.8

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: c4456e6c2847371b010454617b3f74f87570bbcd
+  data.tar.gz: d75f3182b16f5c2f7494bdb1b676a9ceab8fc861
+SHA512:
+  metadata.gz: 055db62d9c82b22cd0f62544672e982b2d319ff5be0b95e69db6f32018d56322d35bca05d6db068c62c1d6d5edae7d3558e451c3f2e97c7911f4b03e35f4b5a6
+  data.tar.gz: e7f916e652702635a7730eea9dbc2fdafaf1384d8af203ada7420d76990cf106e70bc595c1f988b5e32771f63f76eac1c869ac9fcd4146bf801a499e6d9e5697

data/.travis.yml

@@ -0,0 +1,9 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 2.0.0
+  - 2.1.0
+  - 2.1.1
+  - 2.1.2
+  - jruby-19mode
+

data/README.md

@@ -66,6 +66,13 @@ ValidateEmail.mx_valid_with_fallback?('email@randommail.com')
 ValidateEmail.valid?('email@randommail.com')
 ```
 
+Load it (and not the rails extensions) with 
+
+    gem 'valid_email', require: 'valid_email/validate_email'
+
+
+### String and Nil object extensions
+
 There is also a String and Nil class extension, if you require the gem in this way in Gemfile:
 
 ```ruby
@@ -75,17 +82,23 @@ gem 'valid_email', require: ['valid_email/all_with_extensions']
 You will be able to use the following methods:
 ```ruby
 nil.email? # => false
-"jhon@gmail.com".email? # => May return true if it exists. It accepts a hash of options like ValidateEmail.valid?
+"john@gmail.com".email? # => May return true if it exists. It accepts a hash of options like ValidateEmail.valid?
 ```
 
 # Credits
 
-* Dush dusanek[at]iquest.cz
 * Ramihajamalala Hery hery[at]rails-royce.org
-* Marco Perrando mperrando[at]soluzioninrete.it
+* Fire-Dragon-DoL francesco.belladonna[at]gmail.com
+* dush dusanek[at]iquest.cz
 * MIke Carter mike[at]mcarter.me
-* Oleg Shur workshur[at]gmail.com
+* Heng heng[at]reamaze.com
+* Marco Perrando mperrando[at]soluzioninrete.it
 * Jörg Thalheim joerg[at]higgsboson.tk
+* Andrey Deryabin deriabin[at]gmail.com
+* Nicholas Rutherford nick.rutherford[at]gmail.com
+* Oleg Shur workshur[at]gmail.com
+* Joel Chippindale joel[at]joelchippindale.com
+* Sami Haahtinen sami[at]haahtinen.name
 * Jean Boussier jean.boussier[at]gmail.com
 
 # Note on Patches/Pull Requests

data/Rakefile

@@ -7,4 +7,4 @@ RSpec::Core::RakeTask.new do |t|
 end
 
 task :default => [:spec]
-task :build
+task :build => [:spec]

data/lib/valid_email/validate_email.rb

@@ -9,14 +9,13 @@ class ValidateEmail
         m = Mail::Address.new(value)
         # We must check that value contains a domain and that value is an email address
         r = m.domain && m.address == value
-        t = m.__send__(:tree)
-        # We need to dig into treetop
-        # A valid domain must have dot_atom_text elements size > 1
-        # user@localhost is excluded
-        # treetop must respond to domain
-        # We exclude valid email values like <user@localhost.com>
-        # Hence we use m.__send__(tree).domain
-        r &&= (t.domain.dot_atom_text.elements.size > 1)
+
+        # Check that domain consists of dot-atom-text elements > 1
+        # In mail 2.6.1, domains are invalid per rfc2822 are parsed when they shouldn't
+        # This is to make sure we cover those cases
+        domain_dot_elements = m.domain.split(/\./)
+        r &&= domain_dot_elements.none?(&:blank?) && domain_dot_elements.size > 1
+
         # Check if domain has DNS MX record
         if r && options[:mx]
           require 'valid_email/mx_validator'

data/lib/valid_email/version.rb

@@ -1 +1 @@
-ValidEmailVersion = "0.0.7"
+ValidEmailVersion = "0.0.8"

data/spec/email_validator_spec.rb

@@ -76,6 +76,18 @@ describe EmailValidator do
         subject.errors[:email].should == errors
       end
 
+      it "should fail when email domain is prefixed with dot" do
+        subject.email = 'john@.doe'
+        subject.valid?.should be_false
+        subject.errors[:email].should == errors
+      end
+
+      it "should fail when email domain contains two consecutive dots" do
+        subject.email = 'john@doe-two..com'
+        subject.valid?.should be_false
+        subject.errors[:email].should == errors
+      end
+
       it "should fail when email is valid with information" do
         subject.email = '"John Doe" <john@doe.com>'
         subject.valid?.should be_false

data/valid_email.gemspec

@@ -19,8 +19,8 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   # specify any dependencies here; for example:
-  s.add_development_dependency "rspec"
+  s.add_development_dependency "rspec", "~> 2.99"
   s.add_development_dependency "rake"
-  s.add_runtime_dependency "mail"
+  s.add_runtime_dependency "mail", "~> 2.6.1"
   s.add_runtime_dependency "activemodel"
 end

metadata

@@ -1,78 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: valid_email
 version: !ruby/object:Gem::Version
-  version: 0.0.7
-  prerelease: 
+  version: 0.0.8
 platform: ruby
 authors:
 - Ramihajamalala Hery
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-02 00:00:00.000000000 Z
+date: 2014-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.99'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.99'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mail
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.6.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.6.1
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: ActiveModel Validation for email
@@ -82,8 +73,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rvmrc
+- ".gitignore"
+- ".rvmrc"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -110,27 +102,26 @@ files:
 - valid_email.gemspec
 homepage: http://my.rails-royce.org/2010/07/21/email-validation-in-ruby-on-rails-without-regexp
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: valid_email
-rubygems_version: 1.8.23.2
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: ActiveModel Validation for email
 test_files:
 - spec/email_validator_spec.rb