valid_email 0.0.9 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dfc486fd0dfb112acae3207a3d736b5209daedb8
-  data.tar.gz: c4e004a30caf02049223de8ae0f0bbf8eec8e2ac
+  metadata.gz: 380a2215e68ccc58972d59859e42e66ac5192e74
+  data.tar.gz: ca2e75012a59423ff84bc3103d6ca2f3441609f4
 SHA512:
-  metadata.gz: 1f819b01ba5a32c6dbf8b076f3a4adc8ba7113d7ad2ebef9844ceaaa52386afa7b767894e37216771b04b16e5c6c8cc1cf1a2d8c0f3bade63f340de3bb8161b7
-  data.tar.gz: fcb080bf8c42242267320265e878680c3dac036d3bd5364f9629cbb16b8a93ba1488c98ee2f4d3ffbd8b5593a2bf5d167fc411ac706e1e863b4e41ba685401f4
+  metadata.gz: 07183982261298da84f84214d363ff420c61c6bac3a8f787d449b3184e2ae4ae31b8b3fb2285ac9e5817112cc8dce7d54aadf26389062b17cbb5d30221189916
+  data.tar.gz: dbd5ffaf12d3fab07b3f936abc8f2e060c4046f32340781af03399580b31d0d2bedb613f6ee95f8a9a9f0020ad4402b1609a0777ca6f2648765762815de48f9d

data/lib/valid_email/validate_email.rb

@@ -10,11 +10,13 @@ class ValidateEmail
         # We must check that value contains a domain and that value is an email address
         r = m.domain && m.address == value
         if r
-          # Check that domain consists of dot-atom-text elements > 1
+          # Check that domain consists of dot-atom-text elements > 1 and does not
+          # contain spaces.
+          #
           # In mail 2.6.1, domains are invalid per rfc2822 are parsed when they shouldn't
           # This is to make sure we cover those cases
           domain_dot_elements = m.domain.split(/\./)
-          r &&= domain_dot_elements.none?(&:blank?) && domain_dot_elements.size > 1
+          r &&= m.domain.match(/^\S+$/) && domain_dot_elements.none?(&:blank?) && domain_dot_elements.size > 1
 
           # Check if domain has DNS MX record
           if r && options[:mx]

data/lib/valid_email/version.rb

@@ -1 +1 @@
-ValidEmailVersion = "0.0.9"
+ValidEmailVersion = "0.0.10"

data/spec/email_validator_spec.rb

@@ -66,49 +66,55 @@ describe EmailValidator do
       subject { person_class.new }
 
       it "should fail when email empty" do
-        subject.valid?.should be_false
+        subject.valid?.should be_falsey
         subject.errors[:email].should == errors
       end
 
       it "should fail when email is not valid" do
         subject.email = 'joh@doe'
-        subject.valid?.should be_false
+        subject.valid?.should be_falsey
         subject.errors[:email].should == errors
       end
 
       it "should fail when email domain is prefixed with dot" do
         subject.email = 'john@.doe'
-        subject.valid?.should be_false
+        subject.valid?.should be_falsey
         subject.errors[:email].should == errors
       end
 
       it "should fail when email domain contains two consecutive dots" do
         subject.email = 'john@doe-two..com'
-        subject.valid?.should be_false
+        subject.valid?.should be_falsey
         subject.errors[:email].should == errors
       end
 
       it "should fail when email is valid with information" do
         subject.email = '"John Doe" <john@doe.com>'
-        subject.valid?.should be_false
+        subject.valid?.should be_falsey
         subject.errors[:email].should == errors
       end
 
       it "should pass when email is simple email address" do
         subject.email = 'john@doe.com'
-        subject.valid?.should be_true
+        subject.valid?.should be_truthy
         subject.errors[:email].should be_empty
       end
 
       it "should fail when email is simple email address not stripped" do
         subject.email = 'john@doe.com            '
-        subject.valid?.should be_false
+        subject.valid?.should be_falsey
+        subject.errors[:email].should == errors
+      end
+
+      it "should fail when domain contains a space" do
+        subject.email = 'john@doe .com'
+        subject.valid?.should be_falsey
         subject.errors[:email].should == errors
       end
 
       it "should fail when passing multiple simple email addresses" do
         subject.email = 'john@doe.com, maria@doe.com'
-        subject.valid?.should be_false
+        subject.valid?.should be_falsey
         subject.errors[:email].should == errors
       end
 
@@ -119,19 +125,19 @@ describe EmailValidator do
 
       it "should pass when email domain has MX record" do
         subject.email = 'john@gmail.com'
-        subject.valid?.should be_true
+        subject.valid?.should be_truthy
         subject.errors[:email].should be_empty
       end
 
       it "should pass when email domain has no MX record but has an A record" do
         subject.email = 'john@subdomain.rubyonrails.org'
-        subject.valid?.should be_true
+        subject.valid?.should be_truthy
         subject.errors[:email].should be_empty
       end
 
       it "should fail when domain does not exists" do
         subject.email = 'john@nonexistentdomain.abc'
-        subject.valid?.should be_false
+        subject.valid?.should be_falsey
         subject.errors[:email].should == errors
       end
     end
@@ -141,19 +147,19 @@ describe EmailValidator do
 
       it "should pass when email domain has MX record" do
         subject.email = 'john@gmail.com'
-        subject.valid?.should be_true
+        subject.valid?.should be_truthy
         subject.errors[:email].should be_empty
       end
 
       it "should fail when email domain has no MX record" do
         subject.email = 'john@subdomain.rubyonrails.org'
-        subject.valid?.should be_false
+        subject.valid?.should be_falsey
         subject.errors[:email].should == errors
       end
 
       it "should fail when domain does not exists" do
         subject.email = 'john@nonexistentdomain.abc'
-        subject.valid?.should be_false
+        subject.valid?.should be_falsey
         subject.errors[:email].should == errors
       end
     end
@@ -191,13 +197,13 @@ describe EmailValidator do
 
       it "should pass when email from trusted email services" do
         subject.email = 'john@mail.ru'
-        subject.valid?.should be_true
+        subject.valid?.should be_truthy
         subject.errors[:email].should be_empty
       end
 
       it "should fail when email from disposable email services" do
         subject.email = 'john@grr.la'
-        subject.valid?.should be_false
+        subject.valid?.should be_falsey
         subject.errors[:email].should == errors
       end
     end

data/spec/extensions_validator_spec.rb

@@ -6,19 +6,19 @@ describe String do
   it { "mymail@gmail".should respond_to(:email?) }
 
   it "is a valid e-mail" do
-    "mymail@gmail.com".email?.should be_true
+    "mymail@gmail.com".email?.should be_truthy
   end
 
   it "is not valid when text is not a real e-mail" do
-    "invalidMail".email?.should be_false
+    "invalidMail".email?.should be_falsey
   end
 
   context "when nil" do
 
     it "is invalid e-mail" do
-      nil.email?.should be_false
+      nil.email?.should be_falsey
     end
 
   end
 
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valid_email
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Ramihajamalala Hery
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-09 00:00:00.000000000 Z
+date: 2014-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -74,7 +74,6 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".rvmrc"
 - ".travis.yml"
 - Gemfile
 - LICENSE

data/.rvmrc

@@ -1 +0,0 @@
-rvm use --create ruby-1.9.3@email_validator