valid_attribute 1.3.0 → 1.3.1

data/{README.markdown → README.md}

@@ -1,6 +1,8 @@
 # ValidAttribute #
 
 [![Build Status](http://travis-ci.org/bcardarella/valid_attribute.png)](http://travis-ci.org/bcardarella/valid_attribute)
+[![Dependency Status](https://gemnasium.com/bcardarella/valid_attribute.png?travis)](https://gemnasium.com/bcardarella/valid_attribute)
+[![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/bcardarella/valid_attribute)
 
 ValidAttribute is a minimalist matcher for validation BDD.
 

data/lib/valid_attribute/matcher.rb

@@ -6,25 +6,23 @@ module ValidAttribute
       self.attr = attr
     end
 
+    # The collection of values to test against for the given
+    # attribute
+    #
+    # @params [Array]
+    #
+    # @return [ValidAttribute::Matcher]
     def when(*values)
       self.values = values
       self
     end
 
     def failure_message
-      if failed_values.size == 1
-        " expected #{subject.class}##{attr} to accept the value: #{quote_values(failed_values)}"
-      else
-        " expected #{subject.class}##{attr} to accept the values: #{quote_values(failed_values)}"
-      end
+      message(failed_values, 'accept')
     end
 
     def negative_failure_message
-      if passed_values.size == 1
-        " expected #{subject.class}##{attr} to reject the value: #{quote_values(passed_values)}"
-      else
-        " expected #{subject.class}##{attr} to reject the values: #{quote_values(passed_values)}"
-      end
+      message(passed_values, 'reject')
     end
 
     def description
@@ -45,6 +43,13 @@ module ValidAttribute
       !!@clone
     end
 
+    # Force the matcher to clone the subject in between
+    # testing each value.
+    #
+    # *Warning* This could lead to unintended results. The clone
+    # is not a deep copy
+    #
+    # @return [ValidAttribute::Matcher]
     def clone
       @clone = true
     end
@@ -89,5 +94,8 @@ module ValidAttribute
       values.map { |value| value.inspect }.join(', ')
     end
 
+    def message(values, verb)
+      " expected #{subject.class}##{attr} to #{verb} the value#{values.size == 1 ? nil : 's'}: #{quote_values(values)}"
+    end
   end
 end

data/lib/valid_attribute/version.rb

@@ -1,3 +1,3 @@
 module ValidAttribute
-  VERSION = '1.3.0'
+  VERSION = '1.3.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: valid_attribute
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-10 00:00:00.000000000 Z
+date: 2012-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -91,22 +91,6 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: debugger
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Minimalist validation matcher
 email:
 - bcardarella@gmail.com
@@ -114,16 +98,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .rvmrc
-- .travis.yml
-- .yardopts
-- Gemfile
-- HISTORY
-- README.markdown
-- Rakefile
-- lib/valid_attribute.rb
 - lib/valid_attribute/matcher.rb
 - lib/valid_attribute/method.rb
 - lib/valid_attribute/minitest.rb
@@ -131,12 +105,8 @@ files:
 - lib/valid_attribute/spec.rb
 - lib/valid_attribute/test_unit.rb
 - lib/valid_attribute/version.rb
-- spec/minitest_spec.rb
-- spec/spec_helper.rb
-- spec/test_unit_spec.rb
-- spec/user.rb
-- spec/valid_attribute_spec.rb
-- valid_attribute.gemspec
+- lib/valid_attribute.rb
+- README.md
 homepage: https://github.com/bcardarella/valid_attribute
 licenses: []
 post_install_message: 
@@ -151,7 +121,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2438991157879859276
+      hash: 1648759370003077665
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -160,16 +130,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2438991157879859276
+      hash: 1648759370003077665
 requirements: []
-rubyforge_project: valid_attribute
+rubyforge_project: 
 rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Minimalist validation matcher
-test_files:
-- spec/minitest_spec.rb
-- spec/spec_helper.rb
-- spec/test_unit_spec.rb
-- spec/user.rb
-- spec/valid_attribute_spec.rb
+test_files: []

data/.gitignore

@@ -1,7 +0,0 @@
-*.gem
-.bundle
-*.lock
-pkg/*
-doc/
-.yardoc
-bin/*

data/.rspec

@@ -1,2 +0,0 @@
---color
---debugger

data/.rvmrc

@@ -1 +0,0 @@
-rvm --create default@valid_attribute > /dev/null

data/.travis.yml

@@ -1,7 +0,0 @@
-rvm:
-  - 1.8.7
-  - 1.9.2
-  - 1.9.3
-  - rbx-18mode
-  - ree
-  - jruby

data/.yardopts

@@ -1,2 +0,0 @@
---markup-provider=redcarpet
---markup=markdown

data/Gemfile

@@ -1,4 +0,0 @@
-source "http://rubygems.org"
-
-# Specify your gem's dependencies in valid_attribute.gemspec
-gemspec

data/HISTORY

@@ -1,30 +0,0 @@
-== 1.2.0
-  MiniTest::Spec support [wojtekmach]
-
-== 1.1.0
-  #when is not necessary [davisre]
-
-== 1.0.0
-  Gold!
-
-== 0.2.1
-  Better value quoting using #inspect
-
-== 0.2.0
-  Test::Unit::TestCase support. You should use shoulda-context
-  Fixed logic bug with #does_not_match?
-
-== 0.1.0
-  Version bump. API is stable
-
-== 0.0.4
-  fix for multiple should_not values
-
-== 0.0.3
-  should_not fix for when the validation key doesn't exist yet
-  removed .message method. Not good BDD
-  will test all values instead of stopping at the first invalid value
-
-== 0.0.2
-  Removed default value, allways required to pass value
-  Changed #with to #when

data/Rakefile

@@ -1,8 +0,0 @@
-require 'bundler'
-require 'rspec/core/rake_task'
-Bundler::GemHelper.install_tasks
-
-RSpec::Core::RakeTask.new('default') do |t|
-  t.pattern = FileList['spec/**/*_spec.rb']
-end
-

data/spec/minitest_spec.rb

@@ -1,10 +0,0 @@
-require 'spec_helper'
-require 'minitest/spec'
-require 'valid_attribute/minitest'
-
-describe 'MiniTest::Spec' do
-  it '.have_valid' do
-    have_valid(:name).should be_instance_of(ValidAttribute::Matcher)
-  end
-end
-

data/spec/spec_helper.rb

@@ -1,17 +0,0 @@
-require 'rubygems'
-require 'bundler'
-Bundler.require
-
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-require 'rspec'
-require 'rspec/autorun'
-require 'bourne'
-require 'valid_attribute'
-require 'debugger'
-
-RSpec.configure do |config|
-  config.mock_with :mocha
-end
-
-

data/spec/test_unit_spec.rb

@@ -1,12 +0,0 @@
-# This is a RSpec spec to test TestUnit... yeah that's right
-
-require 'spec_helper'
-require 'test/unit'
-require 'valid_attribute/test_unit'
-
-describe 'Test::Unit::TestCase' do
-  it '.have_valid' do
-    Test::Unit::TestCase.have_valid(:name).should be_instance_of(ValidAttribute::Matcher)
-  end
-end
-

data/spec/user.rb

@@ -1,12 +0,0 @@
-class User
-  attr_accessor :name
-  attr_accessor :email
-
-  def errors
-    @error ||= {}
-  end
-
-  def valid?
-    errors.empty?
-  end
-end

data/spec/valid_attribute_spec.rb

@@ -1,179 +0,0 @@
-require 'spec_helper'
-require 'user'
-
-class Should
-  include ValidAttribute::Method
-end
-
-describe 'ValidAttribute' do
-
-  before do
-    @should = Should.new
-    @user   = User.new
-  end
-
-  describe 'matcher result' do
-    context 'data is valid' do
-      before do
-        @user.stubs(:valid?).returns(true)
-        @user.stubs(:errors).returns({})
-        @matcher = @should.have_valid(:name).when('abc', 123)
-      end
-
-      it 'matches? returns true' do
-        @matcher.matches?(@user).should be_true
-      end
-
-      it 'does_not_match? returns false' do
-        @matcher.does_not_match?(@user).should be_false
-      end
-
-      describe 'messages' do
-        it '#negative_failure_message' do
-          @matcher.matches?(@user)
-          @matcher.negative_failure_message.should == " expected User#name to reject the values: \"abc\", 123"
-        end
-      end
-    end
-
-    context 'data is invalid' do
-      before do
-        @user.stubs(:valid?).returns(false)
-        @user.stubs(:errors).returns({:name => ["can't be blank"]})
-        @matcher = @should.have_valid(:name).when(:abc, nil)
-      end
-
-      it 'matches? returns false' do
-        @matcher.matches?(@user).should be_false
-      end
-
-      it 'does_not_match? returns true' do
-        @matcher.does_not_match?(@user).should be_true
-      end
-
-      describe 'messages' do
-        it '#failure_message' do
-          @matcher.matches?(@user)
-          @matcher.failure_message.should == " expected User#name to accept the values: :abc, nil"
-        end
-      end
-    end
-
-    context 'data is valid then invalid' do
-      before do
-        @user.stubs(:valid?).returns(true).then.returns(false)
-        @user.stubs(:errors).returns({}).then.returns({:name => ["can't be blank"]})
-        @matcher = @should.have_valid(:name).when('abc', 123)
-      end
-
-      it 'matches? returns false' do
-        @matcher.matches?(@user).should be_false
-      end
-
-      it 'does_not_match? returns false' do
-        @matcher.does_not_match?(@user).should be_false
-      end
-
-      describe 'messages' do
-        it '#failure_message' do
-          @matcher.matches?(@user)
-          @matcher.failure_message.should == " expected User#name to accept the value: 123"
-        end
-
-        it '#negative_failure_message' do
-          @matcher.matches?(@user)
-          @matcher.negative_failure_message.should == " expected User#name to reject the value: \"abc\""
-        end
-
-        it '#description' do
-          @matcher.description.should == "be valid when name is: \"abc\", 123"
-        end
-      end
-    end
-
-    context 'no values are specified with .when' do
-      context 'data is not set' do
-        before do
-          @user.stubs(:valid?).returns(true)
-          @user.stubs(:name).returns(nil)
-          @matcher = @should.have_valid(:name)
-        end
-
-        subject do
-          @matcher.matches?(@user)
-          @matcher
-        end
-
-        its(:description) { should eq('be valid when name is: nil') }
-      end
-
-      context 'data is valid' do
-        before do
-          @user.stubs(:valid?).returns(true)
-          @user.stubs(:name).returns(:abc)
-          @matcher = @should.have_valid(:name)
-        end
-
-        it 'matches? returns true' do
-          @matcher.matches?(@user).should be_true
-        end
-
-        it 'does_not_match? returns false' do
-          @matcher.does_not_match?(@user).should be_false
-        end
-
-        describe 'messages' do
-          it '#negative_failure_message' do
-            @matcher.matches?(@user)
-            @matcher.negative_failure_message.should == " expected User#name to reject the value: :abc"
-          end
-        end
-      end
-
-      context 'data is invalid' do
-        before do
-          @user.stubs(:valid?).returns(false)
-          @user.stubs(:errors).returns({:name => ["can't be a symbol"]})
-          @user.stubs(:name).returns(:abc)
-          @matcher = @should.have_valid(:name)
-        end
-
-        it 'matches? returns false' do
-          @matcher.matches?(@user).should be_false
-        end
-
-        it 'does_not_match? returns true' do
-          @matcher.does_not_match?(@user).should be_true
-        end
-
-        describe 'messages' do
-          it '#failure_message' do
-            @matcher.matches?(@user)
-            @matcher.failure_message.should == " expected User#name to accept the value: :abc"
-          end
-        end
-      end
-    end
-
-    describe 'cloning' do
-      before do
-        @matcher = @should.have_valid(:name)
-      end
-
-      context 'when no cloning' do
-        it 'returns false' do
-          @matcher.clone?.should be_false
-        end
-      end
-      context 'when cloned' do
-        before do
-          @matcher.clone
-        end
-        it 'returns true' do
-          @matcher.clone?.should be_true
-        end
-      end
-    end
-  end
-
-end

data/valid_attribute.gemspec

@@ -1,28 +0,0 @@
-# -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
-require "valid_attribute/version"
-
-Gem::Specification.new do |s|
-  s.name        = "valid_attribute"
-  s.version     = ValidAttribute::VERSION
-  s.platform    = Gem::Platform::RUBY
-  s.authors     = ["Brian Cardarella"]
-  s.email       = ["bcardarella@gmail.com"]
-  s.homepage    = "https://github.com/bcardarella/valid_attribute"
-  s.summary     = %q{Minimalist validation matcher}
-  s.description = %q{Minimalist validation matcher}
-
-  s.rubyforge_project = "valid_attribute"
-
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ["lib"]
-
-  s.add_development_dependency 'rake'
-  s.add_development_dependency 'rspec'
-  s.add_development_dependency 'bourne'
-  s.add_development_dependency 'minitest'
-  s.add_development_dependency 'minitest-matchers'
-  s.add_development_dependency 'debugger'
-end