uuids 4.1.5 → 4.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2ff54ff39b28a1294143e1dc4817badd60fcd7c7
-  data.tar.gz: aa8d3e4492186faa6de6ebb24f7ad6ed96b178f1
+  metadata.gz: e60466e84069bbbe17ea18d0cab274efc374b119
+  data.tar.gz: 313ba714a9c86ce92e0a6d24a4ba39d91dbee873
 SHA512:
-  metadata.gz: 99f7458e54159881f912fd66f483702a0b8870e421a8031d45c7a18e27b9f579cce2e93eeaea4fa8bf4337f2fabb1a965a3b5ade19c9e291b1507a0e10e7deaa
-  data.tar.gz: b0227c73c54278136b57c46f39e3a1df961557e41c6a0ac41faa480f00f1dbdd2b9b3ae9c234b038a6b61ca1bd2c188c8740b0890cacb4e439a2192c8a05c464
+  metadata.gz: b858909ab9bd547df281aebca36d15331de2194902ac2ef43dd21d0500a1bbb065ce34d1ae67756e9051506839adf5b1ba5b41226ef947a66c21f22ceef8db78
+  data.tar.gz: b74a87db3c878373a5ee13849ff38b7c147593ebf23681bdbabcf21ec783555d69418fb4275ccbaacb3bae9915989c2118823971bc5caf57c28c76c7bd91812a

data/README.rdoc

@@ -149,10 +149,8 @@ The module also contains the service object +Add+:
 Depending on the result of creation, the listener will receive either the
 <tt>:created, uuid, messages</tt> or <tt>:error, messages</tt> notification.
 
-The service doesn't know what the record is. In the success message it
-will be referred as the record "with id: %{id}".
-To provide more concise messaging, the service should be reloaded with a
-new <tt>name</tt> method.
+The service doesn't know what the record is. To provide more concise messaging,
+the service should be reloaded with a new <tt>name</tt> method.
 
     module Users
       module Services

data/app/services/add.rb

@@ -21,6 +21,10 @@ module Uuids
     #   )
     #   service.subscribe some_listener
     #   service.run
+    #
+    # @change Creates the uuid assigned to the record.
+    # @publish created(uuid,messages) when the uuid has been created.
+    # @publish error(messages) when the uuid cannot be created.
     class Add < Hexx::Service
 
       # @!scope class
@@ -44,11 +48,10 @@ module Uuids
 
       # Runs the service and publishes its results.
       # @example (see Uuids::Services::Add)
-      # @change Creates the uuid assigned to the record.
-      # @publish created(uuid,messages) when the uuid has been created.
-      # @publish error(messages) when the uuid cannot be created.
+      # @change  (see Uuids::Services::Add)
+      # @publish (see Uuids::Services::Add)
       def run
-        escape { create_uuid }
+        run!
       rescue => err
         publish :error, err.messages
       else
@@ -59,9 +62,11 @@ module Uuids
 
       attr_reader :uuid
 
-      def create_uuid
-        @uuid = Models::Uuid.create! record: record, value: value
-        add_message "success", :created, uuid: uuid, record: name
+      def run!
+        escape do
+          @uuid = Models::Uuid.create! record: record, value: value
+          add_message "success", :created, uuid: uuid, record: name
+        end
       end
 
       def name

data/lib/uuids/base/belongs_to.rb

@@ -54,14 +54,14 @@ module Uuids
       # @api hide
       # Constructs the object and adds the attribute.
       # @example (see Uuids::Base::BelongsTo)
-      # @params [ActiveRecord::Base] klass The model to add attribute to.
+      # @param [ActiveRecord::Base] klass The model to add attribute to.
       #   Should have a corresponding column for reference by uuid.
-      # @params [String, Symbol] name The name of the attribute to be added.
-      # @params [ActiveRecord::Base] model The model to be referred by uuid.
+      # @param [String, Symbol] name The name of the attribute to be added.
+      # @param [ActiveRecord::Base] model The model to be referred by uuid.
       #   Should include the <tt>Uuids::Base</tt> module.
       # @raise (see Uuids::Base::BelongsTo#add)
-      def self.add(*args)
-        new(*args).add
+      def self.add(klass, name, model)
+        new(klass, name, model).add
       end
 
       # @api hide

data/lib/uuids/version.rb

@@ -1,5 +1,5 @@
 module Uuids
 
   # Current release.
-  VERSION = "4.1.5"
+  VERSION = "4.1.6"
 end

data/spec/dummy/db/schema.rb

@@ -30,12 +30,12 @@ ActiveRecord::Schema.define(version: 20151215182355) do
   end
 
   create_table "uuids_uuids", force: :cascade do |t|
-    t.string  "value",       limit: 36,  null: false
-    t.integer "record_id",               null: false
-    t.string  "record_type", limit: 255, null: false
+    t.string  "value",       limit: 36, null: false
+    t.integer "record_id",              null: false
+    t.string  "record_type",            null: false
   end
 
-  add_index "uuids_uuids", ["record_id", "record_type"], name: "index_uuids_uuids_on_record_id_and_record_type"
+  add_index "uuids_uuids", ["record_type", "record_id"], name: "index_uuids_uuids_on_record_type_and_record_id"
   add_index "uuids_uuids", ["value"], name: "index_uuids_uuids_on_value", unique: true
 
 end

data/spec/support/development/helpers/sandbox.rb

@@ -2,7 +2,7 @@ require_relative "capture_stdout"
 
 # Path to the `tmp/sandbox`.
 def sandbox
-  @sandbox ||= File.expand_path "../../../../../tmp/sandbox", __FILE__
+  @sandbox ||= File.expand_path "../../../../sandbox", __FILE__
 end
 
 # Clears `tmp/sandbox`.

data/spec/uuids/services/add_spec.rb

@@ -12,8 +12,7 @@ module Uuids::Services
     let!(:params) do
       {
         "record" => record,
-        "value"  => SecureRandom.uuid,
-        "wrong"  => "wrong"
+        "value"  => SecureRandom.uuid
       }
     end
 
@@ -25,28 +24,13 @@ module Uuids::Services
       service
     end
 
-    describe ".new" do
-
-      it "sets #record" do
-        expect(subject.record).to eq params["record"]
-      end
-
-      it "sets #value" do
-        expect(subject.value).to eq params["value"]
-      end
-
-      it "whitelists params" do
-        expect(subject.params).to eq params.slice("record", "value")
-      end
-    end
-
     describe "#run" do
 
       context "with valid params" do
 
         it "adds a uuid to the record" do
           expect { subject.run }.to change { uuids_class.count }.by 1
-          expect(uuids_class.last).to correspond_to subject.params
+          expect(uuids_class.last).to correspond_to params
         end
 
         it "publishes :created" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: uuids
 version: !ruby/object:Gem::Version
-  version: 4.1.5
+  version: 4.1.6
 platform: ruby
 authors:
 - Andrew Kozin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-22 00:00:00.000000000 Z
+date: 2014-12-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hexx-active_record
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement