uswds-rails 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0fe0957d5eafc6b562cf44545eaba7e0858db10b
-  data.tar.gz: 662a549b3b3081eb4e0981d1f212c4b1cdf7a53b
+SHA256:
+  metadata.gz: 527c148580ccd2b9a299708c1b5b201c414354dd44a9e2475e7b8bd20cac88c8
+  data.tar.gz: 66988327aca6e9c6cdb79a97d6a8607390b28ca95b0ca4622ace9bf19fe66536
 SHA512:
-  metadata.gz: 3b14ca0ba6d7891f8c1d0c55c8e8f5c35e5cda430d1a334008198c61c35a16d4538478dc8efa7c13fb57e927d28f4bb1f9d04d32311462078d22b7ebe33de25a
-  data.tar.gz: fe8cac3ee16bea6b12d4dc44107fe0d7795192f701aaeb3c7ef4fb753e43b5e5d95023d7537b9b5c6c4c6adaa1671ed3b1faa8b2c68377b17399404160e524a1
+  metadata.gz: 1b720d9e61d6a19bf768482ac93bdea0f06a6f54e4f8b319c264b99c475fab574e28f6ad70d04b6332e1b0d1620447444034eac5a4a0375db96042b003ce8b80
+  data.tar.gz: f00dbd78b4f5566165781d2d7f7295919e2974536fab4370bb9af91f2309a94acdde39cb350fa7a7ec62b5636d76ce8fc9eb8b3f312c5703b26087443886424e

data/.codeclimate.yml

@@ -9,6 +9,7 @@ engines:
     enabled: true
   rubocop:
     enabled: true
+    channel: rubocop-0-51
 ratings:
   paths:
     - lib/

data/.rubocop

@@ -1,3 +1,5 @@
 --display-cop-names
 --display-style-guide
 --extra-details
+--force-exclusion
+--parallel

data/.ruby-version

@@ -1 +1 @@
-2.4.1
+2.4.2

data/.travis.yml

@@ -1,9 +1,9 @@
 language: ruby
 cache: bundler
 rvm:
-  - 2.2.7
-  - 2.3.4
-  - 2.4.1
+  - 2.2.8
+  - 2.3.5
+  - 2.4.2
 before_install:
   - gem update --system
   - gem update bundler

data/CONTRIBUTING.md

@@ -16,9 +16,9 @@ There are several ways in which you can help improve this project:
 
 ## Getting Started
 
-uswds-rails is written in [Ruby](https://www.ruby-lang.org/en/) (version 2.4.1) and development dependencies are managed using the [Bundler](http://bundler.io/) gem. [Travis CI builds](https://travis-ci.org/jgarber623/uswds-rails) use Ruby 2.2.7, 2.3.4, and 2.4.1.
+uswds-rails is written in [Ruby](https://www.ruby-lang.org/en/) (version 2.4.2) and development dependencies are managed using the [Bundler](http://bundler.io/) gem. [Travis CI builds](https://travis-ci.org/jgarber623/uswds-rails) use Ruby 2.2.8, 2.3.5, and 2.4.2.
 
-I manage Ruby versions with [rbenv](https://github.com/rbenv/rbenv). I'd recommend you do the same or use a similar Ruby version manager ([chruby](https://github.com/postmodern/chruby/) or [RVM](https://rvm.io/) come to mind). Once you've installed Ruby 2.4.1 using your method of choice, install the project's gems by running:
+I manage Ruby versions with [rbenv](https://github.com/rbenv/rbenv). I'd recommend you do the same or use a similar Ruby version manager ([chruby](https://github.com/postmodern/chruby/) or [RVM](https://rvm.io/) come to mind). Once you've installed Ruby 2.4.2 using your method of choice, install the project's gems by running:
 
 ```sh
 bundle install

data/README.md

@@ -10,22 +10,22 @@ A Ruby gem for integrating the [U.S. Web Design Standards](https://github.com/18
 
 ## Getting Started
 
-Before installing and using uswds-rails, you'll want to have Ruby 2.2.7 (or newer) installed on your computer. There are plenty of ways to go about this, but my preference is [rbenv](https://github.com/sstephenson/rbenv). If you're developing on a Mac and using [Homebrew](http://brew.sh/), installing rbenv is [super easy](https://github.com/sstephenson/rbenv#homebrew-on-mac-os-x).
+Before installing and using uswds-rails, you'll want to have Ruby 2.2.8 (or newer) installed on your computer. There are plenty of ways to go about this, but my preference is [rbenv](https://github.com/sstephenson/rbenv). If you're developing on a Mac and using [Homebrew](http://brew.sh/), installing rbenv is [super easy](https://github.com/sstephenson/rbenv#homebrew-on-mac-os-x).
 
-uswds-rails _might_ work with other versions of Ruby, but it's developed in 2.4.1 and automatically tested against 2.2.7 and 2.3.4 by [Travis CI](https://travis-ci.org/jgarber623/uswds-rails).
+uswds-rails _might_ work with other versions of Ruby, but it's developed in 2.4.2 and automatically tested against 2.2.8 and 2.3.5 by [Travis CI](https://travis-ci.org/jgarber623/uswds-rails).
 
 ## Installation
 
 Add uswds-rails to your Ruby on Rails project's Gemfile:
 
 ```rb
-ruby '2.4.1'
+ruby '2.4.2'
 
 source 'https://rubygems.org'
 source 'https://rails-assets.org'
 
 gem 'rails', '~> 5.1'
-gem 'uswds-rails', '~> 1.3'
+gem 'uswds-rails', '~> 1.4'
 ```
 
 Run `bundle install` to install uswds-rails and its dependencies.

data/app/assets/stylesheets/uswds/components/_navigation.scss

@@ -1,40 +1,42 @@
 // Header navigation ------------- //
 
 @mixin nav-border {
+  border-bottom: 0.4rem solid $color-primary;
+  padding-bottom: 0.6rem;
+}
+
+@mixin nav-border-thick {
   border-bottom: 0.7rem solid $color-primary;
-  padding-bottom: 1rem;
+  padding-bottom: 0.9rem;
 }
 
 .usa-navbar {
-  border-bottom: 1px solid $color-gray-lighter;
+  border-bottom: 1px solid $color-gray-light;
   height: 4rem;
 
   @include media($nav-width) {
     border-bottom: none;
     display: inline-block;
+    height: 7.8rem; // XXX magic number
   }
 }
 
 .usa-nav-link {
   @include font-smoothing;
 
-  &:focus {
-    outline-offset: 0;
-  }
-
-  &.usa-accordion-button {
-    @include media($nav-width) {
-      span {
-        margin-right: -2rem;
-        padding-right: 2rem;
+  &:hover {
+    span {
+      @include media($nav-width) {
+        @include nav-border;
       }
     }
   }
 
-  &:hover {
+  &.usa-accordion-button {
     span {
       @include media($nav-width) {
-        @include nav-border;
+        margin-right: 0;
+        padding-right: 1.5rem;
       }
     }
   }
@@ -54,7 +56,7 @@
   @include position(fixed, 0 0 0 auto);
 
   background: $color-white;
-  border-left: 1px solid $color-gray-lighter;
+  border-left: 1px solid $color-gray-light;
   border-right: 0;
   display: flex;
   flex-direction: column;
@@ -64,40 +66,20 @@
   width: $sliding-panel-width;
   z-index: $z-index-nav;
 
-  // Defaulting to hidden is very important for ensuring
-  // that the nav contents aren't in the tab order if
-  // the nav menu is off-screen.
-  visibility: hidden;
-
   @include media($nav-width) {
-    @include padding(5rem 0 0 null);
-    background: transparent;
+    @include padding(4.5rem 0 0 null);
     border-left: none;
     display: block;
     float: right;
     overflow-y: visible;
-    padding-left: 0;
     position: relative;
     transform: translateX(0);
     width: auto;
-    visibility: visible;
   }
 
   &.is-visible {
-    // It's very important that we scope the transition to
-    // only include 'transform' here; we used to transition
-    // on 'all', but this prevented the close button from
-    // being focused after activating the nav menu, as the
-    // button wasn't yet visible due to 'visibility'
-    // implicitly being part of the CSS transition.
     transform: translateX(0);
-    transition: transform 0.3s ease-in-out;
-
-    visibility: visible;
-  }
-
-  a:focus {
-    outline-offset: 0;
+    transition: all 0.3s ease-in-out;
   }
 
   nav {
@@ -114,6 +96,10 @@
     color: $color-primary;
     font-weight: $font-bold;
     padding-left: 1.4rem;
+
+    @include media($nav-width) {
+      color: $color-base;
+    }
   }
 
   .usa-button {
@@ -122,7 +108,8 @@
 
   .usa-search {
     @include media($nav-width) {
-      margin-left: 1.8rem; // XXX magic number
+      margin-left: 1.5rem; // XXX magic number
+      top: 4px;
     }
   }
 }
@@ -153,11 +140,11 @@
 
     > a {
       @include media($nav-width) {
-        @include padding(1.3rem 1.5rem 1.7rem 1.5rem);
+        @include padding(1.3rem 1.5rem 2.2rem 1.5rem);
         color: $color-gray;
         font-size: $h5-font-size;
         font-weight: $font-bold;
-        line-height: 1.2;
+        line-height: 1;
       }
 
       &:hover {
@@ -168,27 +155,48 @@
     }
   }
 
+  a {
+    @include media($nav-width) {
+      @include padding(0.75rem null);
+    }
+
+    &:hover {
+      @include media($nav-width) {
+        // color: $color-base;
+      }
+    }
+  }
+
   button {
-    $button-vertical-offset: 44%;
+    $button-vertical-offset: 40%;
 
     @include button-unstyled;
     @include font-smoothing;
     font-weight: $font-normal;
-    padding: 1.4rem 1.5rem 1rem 1.8rem;
+    line-height: 1.3;
+    padding: 0.85rem 1.5rem 0.85rem 1.8rem;
 
     @include media($nav-width) {
-      @include padding(null 3.5rem 1.9rem 1.5rem);
+      @include padding(1.3rem 1.5rem 2.2rem 1.5rem);
       color: $color-gray;
       font-size: $h5-font-size;
       font-weight: $font-bold;
+      line-height: 1;
       width: initial;
     }
 
+    &:focus,
+    &:active {
+      box-shadow: $focus-outline;
+    }
+
     &:hover {
+      background-color: $color-gray-lightest;
       color: $color-primary;
 
       @include media($nav-width) {
         background-color: transparent;
+        // color: $color-base;
       }
     }
 
@@ -203,8 +211,10 @@
         background-image: asset-url('#{$image-path}/angle-arrow-down.png');
         background-image: asset-url('#{$image-path}/angle-arrow-down.svg');
         background-position: right 1.5rem top $button-vertical-offset;
+      }
 
-        &:hover {
+      &:hover {
+        @include media($nav-width) {
           background-image: asset-url('#{$image-path}/angle-arrow-down-primary.png');
           background-image: asset-url('#{$image-path}/angle-arrow-down-primary.svg');
         }
@@ -231,19 +241,60 @@
 
         span {
           @include nav-border;
+          color: $color-white;
         }
       }
     }
   }
 
   @include media($nav-width) {
-    a.usa-current { // stylelint-disable-line selector-no-qualifying-type
+    a.usa-current,
+    .usa-current { // stylelint-disable-line selector-no-qualifying-type
       // undo the sidenav style
       border-left: 0;
       padding-left: 1.5rem;
 
+      &:hover {
+        span {
+          color: $color-primary;
+        }
+      }
+
       span {
         @include nav-border;
+        color: $color-base;
+      }
+    }
+  }
+}
+
+// Extended header navigation ------- //
+
+.usa-header-extended {
+  .usa-nav-link {
+    &:hover {
+      span {
+        @include media($nav-width) {
+          @include nav-border-thick;
+        }
+      }
+    }
+  }
+
+  .usa-nav-primary {
+    button[aria-expanded=true] { /* stylelint-disable-line selector-no-qualifying-type */
+      span {
+        @include media($nav-width) {
+          @include nav-border-thick;
+        }
+      }
+    }
+
+    .usa-current {
+      @include media($nav-width) {
+        span {
+          @include nav-border-thick;
+        }
       }
     }
   }
@@ -262,29 +313,28 @@
     @include margin(3rem null);
 
     @include media($nav-width) {
-      @include margin(-0.2rem null 0 0);
+      @include margin(-0.9rem null 0 0);
       float: left;
-      width: 21.5rem;
     }
   }
 }
 
 .usa-nav-secondary-links {
   @include media($nav-width) {
-    float: right;
+    float: left;
   }
 
   li {
     @include media($nav-width) {
       display: inline;
-      padding-left: 1rem;
+      padding-left: 0.5rem;
     }
 
     &:not(:last-child)::after {
       @include media($nav-width) {
         color: $color-gray-lighter;
         content: '|';
-        padding-left: 1rem;
+        padding-left: 0.5rem;
       }
     }
   }
@@ -307,10 +357,11 @@
     display: none;
 
     @include media($nav-width) {
-      background-image: asset-url('#{$image-path}/search-primary.png');
-      background-image: asset-url('#{$image-path}/search-primary.svg');
+      background-image: asset-url('#{$image-path}/search-alt.png');
+      background-image: asset-url('#{$image-path}/search-alt.svg');
       background-repeat: no-repeat;
       background-position: left center;
+      background-size: 2.2rem;
       display: inline-block;
       padding-left: 2.3rem;
     }
@@ -334,15 +385,13 @@
 // Navigation submenu (dropdown and mega menu) ----- //
 
 .usa-nav-submenu {
-  // @include usa-sidenav-sublist;
-  padding-left: 1rem;
+  @include usa-sidenav-sublist;
 
   @include media($nav-width) {
     @include unstyled-list;
-    @include padding(1.15rem null);
+    @include padding(0.75rem null 0.9rem null);
     background-color: $color-primary-darkest;
-    min-width: 21.5rem;
-    width: auto;
+    width: 21.5rem;
     position: absolute;
   }
 
@@ -360,6 +409,7 @@
       @include media($nav-width) {
         background-color: $color-primary-darkest;
         color: $color-white;
+        padding-left: 1.5rem;
         text-decoration: underline;
       }
     }
@@ -376,18 +426,8 @@
 
   li {
     font-size: $h5-font-size;
-    list-style: none;
     margin-bottom: 0;
   }
-
-  .usa-width-one-fourth {
-    margin-right: 0;
-    width: 100%;
-
-    @include media($nav-width) {
-      @include span-columns(3);
-    }
-  }
 }
 
 // Navigation close button -------- //
@@ -427,10 +467,11 @@
 
 .usa-megamenu {
   @include media($nav-width) {
-    @include padding(2.15rem null); // XXX magic number
+    @include padding(3.15rem null); // XXX magic number
     // XXX this is the difference between the 2rem padding-left
     // of .usa-nav-inner and the $site-margins (3rem) padding-left
     // of .usa-megamenu
+    left: -1rem;
     width: 100%;
   }
 
@@ -465,7 +506,7 @@
     @include media($nav-width) {
       display: block;
       float: right;
-      margin-top: -4.8rem;
+      margin-top: -3.8rem;
     }
   }