username_suggester 0.2.2 → 0.3.0

data/.gitignore

@@ -1,3 +1,18 @@
-spec/debug.log
-spec/db/*.db
-username_suggester-*.gem
+.idea
+*.gem
+*.rbc
+.bundle
+.config
+.yardoc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp

data/Gemfile

@@ -0,0 +1,2 @@
+source "http://rubygems.org"
+gemspec

data/README.rdoc

@@ -1,3 +1,5 @@
+= TODO: Rewrite the readme at it's soooo old :(
+
 = UsernameSuggester
 
 It generates username suggestions for users. 

data/Rakefile

@@ -1,30 +1,7 @@
-require 'rake'
-require 'rake/testtask'
-require 'rake/rdoctask'
-require 'spec/rake/spectask'
+#!/usr/bin/env rake
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
 
-desc 'Default: run specs.'
-task :default => :spec
+RSpec::Core::RakeTask.new(:spec)
 
-desc 'Run the specs'
-Spec::Rake::SpecTask.new(:spec) do |t|
-  t.spec_opts = ['--colour --format progress --loadby mtime --reverse']
-  t.spec_files = FileList['spec/**/*_spec.rb']
-end
-
-desc 'Test the username_suggester plugin.'
-Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.libs << 'test'
-  t.pattern = 'test/**/*_test.rb'
-  t.verbose = true
-end
-
-desc 'Generate documentation for the username_suggester plugin.'
-Rake::RDocTask.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'UsernameSuggester'
-  rdoc.options << '--line-numbers' << '--inline-source'
-  rdoc.rdoc_files.include('README')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
+task :default => :spec

data/init.rb

@@ -0,0 +1 @@
+require 'username_suggester'

data/lib/username_suggester.rb

@@ -1,7 +1,3 @@
-# UsernameSuggester
+require "username_suggester/error"
 require "username_suggester/suggester"
-
-if defined?(ActiveRecord)
-  require "username_suggester/suggestions_for"
-  ActiveRecord::Base.send :include, UsernameSuggester::UsernameSuggestions
-end
+require "username_suggester/suggestions_for"

data/lib/username_suggester/error.rb

@@ -0,0 +1,3 @@
+module UsernameSuggester
+  class Error < StandardError; end
+end

data/lib/username_suggester/suggester.rb

@@ -1,62 +1,65 @@
-require 'set'
-
 module UsernameSuggester
   class Suggester
-    attr_reader :first_name
-    attr_reader :last_name
-    
-    # Creates a UsernameSuggester to suggest usernames
+
+    attr_reader :first_name, :last_name
+
+    # A Suggester class to suggest user_names
     #
     # ==== Parameters
     #
-    # * <tt>:first_name</tt> - Required. 
-    # * <tt>:last_name</tt> - Required. 
-    # * <tt>:options</tt> - There is one option -- :validate. You can pass in a Proc object and the suggestion will
-    #   be returned if involving the Proc with the suggestion returns true
+    # * <tt>:first_name</tt>  - Required.
+    # * <tt>:last_name</tt>   - Required.
+    # * <tt>:options</tt>     - See UsernameSuggester::SuggestionsFor
     #
-    def initialize(first_name, last_name, options = {})
-      @first_name = (first_name || "").downcase
-      @last_name = (last_name || "").downcase
-      @options = options
+    def initialize(first_name, last_name)
+      raise Error, "first_name or last_name has not been specified" if first_name.nil? || last_name.nil?
+
+      @first_name = first_name.downcase.gsub(/[^\w]/, '')
+      @last_name  = last_name.downcase.gsub(/[^\w]/, '')
     end
     
     # Generates the combinations without the knowledge of what names are available
     def name_combinations
       @name_combinations ||= [
-        "#{@first_name}",
-        "#{@last_name}",
-        "#{@first_name.first}#{@last_name}",
-        "#{@first_name}#{@last_name.first}",
-        "#{@first_name}#{@last_name}",
-        "#{@last_name.first}#{@first_name}",
-        "#{@last_name}#{@first_name.first}",
-        "#{@last_name}#{@first_name}"
+        "#{first_name}",
+        "#{last_name}",
+        "#{first_name[0]}#{last_name}",
+        "#{first_name}#{last_name[0]}",
+        "#{first_name}#{last_name}",
+        "#{last_name[0]}#{first_name}",
+        "#{last_name}#{first_name[0]}",
+        "#{last_name}#{first_name}"
       ].uniq.reject { |s| s.blank? }
     end
     
     # Generates suggestions and making sure they are not in unavailable_suggestions
-    def suggest(max_num_suggestion, unavailable_suggestions = [])
-      unavailable_set = unavailable_suggestions.to_set
-      results = []
+    def suggest(options)
+      candidates_to_exclude = options[:exclude]
+      validation_block      = options[:validate]
+      number_of_suggestions = options[:num_suggestions]
+
+      results    = []
       candidates = name_combinations.clone
-      while results.size < max_num_suggestion and !candidates.blank?
+      while results.size < number_of_suggestions && !candidates.blank?
         candidate = candidates.shift
-        if @options[:validate] and !@options[:validate].call(candidate)
+        if validation_block.try(:call, candidate)
           # Don't add the candidate to result
-        elsif unavailable_set.include? candidate
-          candidates << find_extended_candidate(candidate, unavailable_set)
+        elsif candidates_to_exclude.include? candidate
+          candidates << find_extended_candidate(candidate, candidates_to_exclude)
         else
           results << candidate
         end
       end
+
       results
     end
     
   private
+
     # Generates a candidate with "candidate<number>" which is not included in unavailable_set
-    def find_extended_candidate(candidate, unavailable_set)
+    def find_extended_candidate(candidate, candidates_to_exclude)
       i = 1
-      i+=rand(10) while unavailable_set.include? "#{candidate}#{i}"
+      i+=rand(10) while candidates_to_exclude.include? "#{candidate}#{i}"
       "#{candidate}#{i}"
     end
   end

data/lib/username_suggester/suggestions_for.rb

@@ -1,5 +1,5 @@
 module UsernameSuggester
-  module UsernameSuggestions
+  module SuggestionsFor
     def self.included(base)
       base.send :extend, ClassMethods
     end
@@ -19,23 +19,31 @@ module UsernameSuggester
       # <tt>:last_name_attribute</tt>:: The attribute which stores the last name. Default is <tt>:last_name</tt>
       # <tt>:num_suggestions</tt>:: Maximum suggestions generated. Default is <tt>10</tt>
       # <tt>:validate</tt>: An Proc object which takes in an username and return true if this is an validate username
-      # <tt>:exclusion</tt>: An array of strings that should not be suggested
+      # <tt>:exclude</tt>: An array of strings that should not be suggested
       #
-      def suggestions_for(attribute = :username, options = {})        
-        first_name_attribute = options[:first_name_attribute] || :first_name
-        last_name_attribute = options[:last_name_attribute] || :last_name
-        num_suggestions = options[:num_suggestions] || 10
-        exclusion = options[:exclusion] || []
+      def suggestions_for(attribute = :username, option_hash = {})
+        options = {
+          :first_name_attribute => :first_name,
+          :last_name_attribute  => :last_name,
+          :num_suggestions      => 5,
+          :exclude              => []
+        }.merge(option_hash)
         
-        send :define_method, "#{attribute}_suggestions".to_sym do
-          suggester = Suggester.new(send(first_name_attribute), send(last_name_attribute), options)
-          name_combinations_with_regex = suggester.name_combinations.map { |s| "^#{s}[0-9]*$" }
-          sql_conditions = Array.new(name_combinations_with_regex.size, "#{attribute} RLIKE ?").join(" OR ")
-          unavailable_choices = exclusion.concat(self.class.all(:select => attribute, 
-            :conditions => [sql_conditions].concat(name_combinations_with_regex)).map{ |c| c.send(attribute) })
-          suggester.suggest(num_suggestions, unavailable_choices)
+        define_method "#{attribute}_suggestions" do
+          suggester = Suggester.new(send(options[:first_name_attribute]), send(options[:last_name_attribute]))
+          suggestions_to_search = suggester.name_combinations.map { |s| "#{s}%" }
+
+          t = self.class.arel_table
+          unavailable_choices = self.class.find_by_sql(t.project(t[attribute])
+                                  .where(t[attribute].matches_any(suggestions_to_search).and(t[:id].not_eq(self.id))).to_sql)
+                                    .map(&attribute).map(&:downcase).uniq
+
+          options[:exclude] += unavailable_choices
+          suggester.suggest(options)
         end
       end
     end
   end
-end
+end
+
+ActiveRecord::Base.send :include, UsernameSuggester::SuggestionsFor

data/lib/username_suggester/version.rb

@@ -0,0 +1,3 @@
+module UsernameSuggester
+  VERSION = "0.3.0"
+end

data/spec/spec_helper.rb

@@ -1,13 +1,11 @@
-begin
-  require File.dirname(__FILE__) + '/../../../../spec/spec_helper'
-rescue LoadError
-  puts "You need to install rspec in your base app"
-  exit
-end
+require 'active_record'
+require 'with_model'
+
+# At last require our lib
+require 'username_suggester'
 
-plugin_spec_dir = File.dirname(__FILE__)
-ActiveRecord::Base.logger = Logger.new(plugin_spec_dir + "/debug.log")
+RSpec.configure do |config|
+  config.extend WithModel
+end
 
-databases = YAML::load(IO.read(plugin_spec_dir + "/db/database.yml"))
-ActiveRecord::Base.establish_connection(databases[ENV["DB"] || "mysql"])
-load(File.join(plugin_spec_dir, "db", "schema.rb"))
+ActiveRecord::Base.establish_connection(:adapter => "sqlite3", :database => ":memory:")

data/spec/username_suggester/suggester_spec.rb

@@ -0,0 +1,60 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe UsernameSuggester::Suggester do  
+  describe "name combinations" do
+    it "returns default combinations of first name and last name" do
+      UsernameSuggester::Suggester.new("Jerry", "Luk").name_combinations
+        .should eq(%w{jerry luk jluk jerryl jerryluk ljerry lukj lukjerry})
+    end
+
+    it "returns first name and first name initial if last name is blank" do
+      UsernameSuggester::Suggester.new("Jerry", "").name_combinations.should eq(%w{jerry j})
+    end
+
+    it "returns last name and last name initial if first name is blank" do
+      UsernameSuggester::Suggester.new("", "Luk").name_combinations.should eq(%w{luk l})
+    end
+
+    it "returns empty array for blank first name and last name" do
+      UsernameSuggester::Suggester.new("", "").name_combinations.should eq([])
+    end
+    
+    it "should not contain space even there is a space in names" do
+      UsernameSuggester::Suggester.new("Ting Ting", "").name_combinations.should eq(%w{tingting t})
+    end
+
+  end
+
+  describe "name suggestions options testing" do
+    before(:each) do
+      @suggester = UsernameSuggester::Suggester.new("Jerry", "Luk")
+      @options   = { :exclude => [], :num_suggestions => 10 }
+    end
+
+    it "return all available suggestions if no exclusions passed" do
+      @suggester.suggest(@options).should eq(%w{jerry luk jluk jerryl jerryluk ljerry lukj lukjerry})
+    end
+
+    it "return only first 3 suggestions" do
+      @options[:num_suggestions] = 3
+      @suggester.suggest(@options).should eq(%w{jerry luk jluk})
+    end
+
+    it "return suggestions but exclude the ones passed" do
+      @options[:exclude] = ["jerry", "lukjerry"]
+      @suggester.suggest(@options).should_not include("jerry", "lukjerry")
+    end
+
+    it "return alternative when excluded" do
+      @options[:exclude] = ["jerry"]
+      @suggester.suggest(@options).should include("jerry1")
+    end
+
+    it "filter out candidates using a proc block aka validation" do
+      # Remove all suggestions starting with j
+      @options[:validate] = proc { |s| s =~ /^j/ }
+      @suggester.suggest(@options).should eq(%w{luk ljerry lukj lukjerry})
+    end
+  end
+
+end

data/spec/username_suggester/suggestions_for_spec.rb

@@ -0,0 +1,76 @@
+require "spec_helper"
+
+describe UsernameSuggester::SuggestionsFor do
+
+  describe "default options given" do
+
+    with_model :User do
+      # User table migration
+      table do |t|
+        t.string :first_name, :last_name, :username
+        t.timestamps
+      end
+
+      # Lets test suggestions_for without any options
+      # By default there's nothing to exclude and number of suggestions equals 5
+      model do
+        suggestions_for :username
+      end
+    end
+
+    before(:each) do
+      @user = User.create(:first_name => "Jerry", :last_name => "Luk")
+    end
+
+    it "should be able to suggest usernames" do
+      @user.username_suggestions.should eq(%w{jerry luk jluk jerryl jerryluk})
+    end
+
+    it "should suggest usernames that are not taken" do
+      # Ooops some user stolen our "jerry" username, so we'll not showing it in suggestions array
+      another_user = User.create(:first_name => "Robo", :last_name => "Cop", :username => "jerry")
+      @user.username_suggestions.should_not include("jerry")
+
+      # But is should include some alternative
+      @user.username_suggestions.should_not include("jerry1")
+    end
+
+  end
+
+  describe "complex options given" do
+
+    with_model :User do
+      # User table migration
+      table do |t|
+        t.string :first, :last, :login_name
+        t.timestamps
+      end
+
+      model do
+        suggestions_for :login_name, :first_name_attribute => :first,
+                                     :last_name_attribute  => :last,
+                                     :num_suggestions      => 3,
+                                     :exclude              => ["reserved"],
+                                     :validate             => proc { |s| s =~ /admin/ }
+      end
+    end
+
+    before(:each) do
+      @user = User.create(:first => "Reserved", :last => "Luk Admin")
+    end
+
+    it "should exclude 'reserved' from the list of suggestions" do
+      @user.login_name_suggestions.should_not include("reserved")
+      @user.login_name_suggestions.size.should eq(3)
+    end
+
+    it "should suggest usernames that are taken by me" do
+      # Even if I have already this username it should suggest me the same cuz it's mine
+      @user.login_name = "reservedl"
+      @user.save
+      @user.login_name_suggestions.should include("reservedl")
+    end
+
+  end
+  
+end

data/username_suggester.gemspec

@@ -1,55 +1,23 @@
-Gem::Specification.new do |s|
-  s.name = %q{username_suggester}
-  s.version = "0.2.2"
-
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = ["jerryluk"]
-  s.date = %q{2010-06-30}
-  s.description = %q{Generates username suggestions for users}
-  s.email = %q{jerry@presdo.com}
-  s.extra_rdoc_files = [
-    "MIT-LICENSE",
-    "README.rdoc"
-  ]
-  s.files = [
-     ".gitignore",
-     "MIT-LICENSE",
-     "README.rdoc",
-     "Rakefile",
-     "username_suggester.gemspec",
-     "lib/username_suggester.rb",
-     "lib/username_suggester/suggester.rb",
-     "lib/username_suggester/suggestions_for.rb",
-     "spec/suggestions_for_spec.rb",
-     "spec/suggester_spec.rb",
-     "spec/spec_helper.rb",
-     "spec/db/database.yml",
-     "spec/db/schema.rb"
-  ]
-  s.homepage = %q{http://github.com/jerryluk/username_suggester}
-  s.rdoc_options = ["--charset=UTF-8"]
-  s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.6}
-  s.summary = %q{Generates username suggestions for users}
-  s.test_files = [
-    "spec/suggestions_for_spec.rb",
-    "spec/suggester_spec.rb",
-    "spec/spec_helper.rb",
-    "spec/db/database.yml",
-    "spec/db/schema.rb"
-  ]
+# -*- encoding: utf-8 -*-
+require File.expand_path('../lib/username_suggester/version', __FILE__)
 
-  if s.respond_to? :specification_version then
-    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
-    s.specification_version = 3
+Gem::Specification.new do |s|
+  s.name                      = "username_suggester"
+  s.version                   = UsernameSuggester::VERSION
+  s.platform                  = Gem::Platform::RUBY
+  s.summary                   = "Generates username suggestions for users"
+  s.required_rubygems_version = ">= 1.3.6"
+  s.authors                   = ["jerryluk", "fillman"]
+  s.email                     = ["jerry@presdo.com", "fila.luka@gmail.com"]
+  s.files                     = `git ls-files`.split("\n")
+  s.test_files                = `git ls-files -- {test,spec,features}/*`.split("\n")
+  s.require_path              = ["lib"]
+  s.homepage                  = "https://github.com/jerryluk/username_suggester"
 
-    if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
-      s.add_development_dependency(%q<rspec>, [">= 1.2.9"])
-    else
-      s.add_dependency(%q<rspec>, [">= 1.2.9"])
-    end
-  else
-    s.add_dependency(%q<rspec>, [">= 1.2.9"])
-  end
+  s.add_development_dependency 'with_model',   '~> 0.3'
+  s.add_development_dependency 'rspec',        '~> 2.11.0'
+  s.add_development_dependency 'activerecord', '~> 3.1'
+  s.add_development_dependency 'rake',         '~> 0.9'
+  s.add_development_dependency 'sqlite3',      '~> 1.3.6'
 end
 

metadata

@@ -1,99 +1,148 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: username_suggester
-version: !ruby/object:Gem::Version 
-  hash: 19
-  prerelease: false
-  segments: 
-  - 0
-  - 2
-  - 2
-  version: 0.2.2
+version: !ruby/object:Gem::Version
+  version: 0.3.0
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - jerryluk
+- fillman
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2010-06-30 00:00:00 -07:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-10-08 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: with_model
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.3'
+- !ruby/object:Gem::Dependency
   name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.11.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.11.0
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.1'
+  type: :development
   prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.1'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 13
-        segments: 
-        - 1
-        - 2
-        - 9
-        version: 1.2.9
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.9'
   type: :development
-  version_requirements: *id001
-description: Generates username suggestions for users
-email: jerry@presdo.com
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.3.6
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.3.6
+description: 
+email:
+- jerry@presdo.com
+- fila.luka@gmail.com
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
-- MIT-LICENSE
-- README.rdoc
-files: 
+extra_rdoc_files: []
+files:
 - .gitignore
+- Gemfile
 - MIT-LICENSE
 - README.rdoc
 - Rakefile
-- username_suggester.gemspec
+- init.rb
 - lib/username_suggester.rb
+- lib/username_suggester/error.rb
 - lib/username_suggester/suggester.rb
 - lib/username_suggester/suggestions_for.rb
-- spec/suggestions_for_spec.rb
-- spec/suggester_spec.rb
+- lib/username_suggester/version.rb
 - spec/spec_helper.rb
-- spec/db/database.yml
-- spec/db/schema.rb
-has_rdoc: true
-homepage: http://github.com/jerryluk/username_suggester
+- spec/username_suggester/suggester_spec.rb
+- spec/username_suggester/suggestions_for_spec.rb
+- username_suggester.gemspec
+homepage: https://github.com/jerryluk/username_suggester
 licenses: []
-
 post_install_message: 
-rdoc_options: 
-- --charset=UTF-8
-require_paths: 
-- lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+rdoc_options: []
+require_paths:
+- - lib
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
       - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+      hash: -4164584086967831757
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: 1.3.6
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Generates username suggestions for users
-test_files: 
-- spec/suggestions_for_spec.rb
-- spec/suggester_spec.rb
+test_files:
 - spec/spec_helper.rb
-- spec/db/database.yml
-- spec/db/schema.rb
+- spec/username_suggester/suggester_spec.rb
+- spec/username_suggester/suggestions_for_spec.rb

data/spec/db/database.yml

@@ -1,10 +0,0 @@
-sqlite3:
-  :adapter: sqlite3
-  :database: vendor/plugins/username_suggester/spec/db/username_suggester.sqlite3.db
-
-mysql:
-  :adapter: mysql
-  :database: username_suggester_test
-  :username: root
-  :password:
-  :host: localhost

data/spec/db/schema.rb

@@ -1,7 +0,0 @@
-ActiveRecord::Schema.define(:version => 0) do
-  create_table :users, :force => true do |t|
-    t.string :first_name
-    t.string :last_name
-    t.string :username
-  end
-end

data/spec/suggester_spec.rb

@@ -1,60 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper'
-
-describe UsernameSuggester::Suggester do  
-  describe "name combinations" do
-    it "returns combinations of first name and last name" do
-      UsernameSuggester::Suggester.new("Jerry", "Luk").name_combinations.should == [
-        "jerry",
-        "luk",
-        "jluk",
-        "jerryl",
-        "jerryluk",
-        "ljerry",
-        "lukj",
-        "lukjerry"
-      ]
-    end
-
-    it "returns first name and first name initial if last name is blank" do
-      UsernameSuggester::Suggester.new("Jerry", "").name_combinations.should == [
-        "jerry",
-        "j"
-      ]
-    end
-
-    it "returns last name and last name initial if first name is blank" do
-      UsernameSuggester::Suggester.new("", "Luk").name_combinations.should == [
-        "luk",
-        "l"
-      ]
-    end
-
-    it "returns empty array for blank first name and last name" do
-      UsernameSuggester::Suggester.new("", "").name_combinations.should == []
-    end
-  end
-  
-  describe "name suggestions" do
-    before(:each) do
-      @suggester = UsernameSuggester::Suggester.new("Jerry", "Luk")
-    end
-    
-    it "returns suggestions for names that are not in the unavailable suggestions" do
-      @suggester.suggest(5, []).should == ["jerry", "luk", "jluk", "jerryl", "jerryluk"]
-    end
-    
-    it "returns extended suggestions for names that are in the unavailable suggestions" do
-      UsernameSuggester::Suggester.send(:define_method, :rand) { 1 }
-      @suggester.suggest(10, ["jerry"]).should include "jerry1"
-      @suggester.suggest(10, ["jerry", "jerry1"]).should include "jerry2"
-      @suggester.suggest(10, ["jerry", "jerry1031"]).should include "jerry1"
-    end
-    
-    it "should only returns suggestions passing the validate proc" do
-      suggestions = UsernameSuggester::Suggester.new("Jerry", "Luk", 
-        :validate => Proc.new { |s| s.length <= 5 }).suggest(10, [])
-      suggestions.should include "jerry"
-      suggestions.should_not include "jerryl"
-    end
-  end
-end

data/spec/suggestions_for_spec.rb

@@ -1,40 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper'
-
-class User < ActiveRecord::Base
-  attr_accessible :first_name, :last_name, :username
-  suggestions_for :username, :exclusion => ['luk']
-end
-
-describe UsernameSuggester::UsernameSuggestions do
-  before(:each) do
-    @user = User.new(:first_name => "Jerry", :last_name => "Luk")
-  end
-  
-  it "should able to suggest usernames" do
-    suggestions = @user.username_suggestions
-    suggestions.should_not be_blank
-    suggestions.should include "jerry"
-  end
-  
-  it "should able to suggest usernames that are not taken" do
-    UsernameSuggester::Suggester.send(:define_method, :rand) { 1 }
-    
-    User.create!(:username => "jerry")
-    1.upto(10) do |i|
-      User.create!(:username => "jerry#{i}")
-    end
-    suggestions = @user.username_suggestions
-    suggestions.should_not be_blank
-    suggestions.should_not include "jerry"
-    suggestions.should include "jerry11"
-  end
-  
-  it "should not suggest usernames in the exclusion list" do
-    UsernameSuggester::Suggester.send(:define_method, :rand) { 1 }
-
-    suggestions = @user.username_suggestions
-    suggestions.should_not be_blank
-    suggestions.should_not include "luk"
-  end
-  
-end