username_suggester 0.1.0 → 0.2.0

data/.gitignore

@@ -0,0 +1,3 @@
+spec/debug.log
+spec/db/*.db
+

data/README.rdoc

@@ -6,6 +6,9 @@ using RLIKE for those DB does not support it. (although it will be slower)
 
 ==Usage
 
+In your environment.rb, add:
+  config.gem 'username_suggester'
+
 Assume you have an User model with attributes :username, :firstname, :lastname
 
   class User < ActiveRecord::Base
@@ -21,7 +24,7 @@ And now you can call the suggestion function like the following:
   user = User.new(:firstname => "Jerry", :lastname => "Luk")
   user.username_suggestions
   
-You can also filter the suggestions, let's say you want the username contains at least 4 characters:
+You can also filter the suggestions, let's say you want the username to contain at least 4 characters:
 
   suggestions_for :username, :num_suggestions => 10,
     :validate => Proc.new { |username| username.length >= 4 }

data/lib/username_suggester/suggester.rb

@@ -42,7 +42,7 @@ module UsernameSuggester
       while results.size < max_num_suggestion and !candidates.blank?
         candidate = candidates.shift
         if @options[:validate] and !@options[:validate].call(candidate)
-          # Do nothing
+          # Don't add the candidate to result
         elsif unavailable_set.include? candidate
           candidates << find_extended_candidate(candidate, unavailable_set)
         else
@@ -56,7 +56,7 @@ module UsernameSuggester
     # Generates a candidate with "candidate<number>" which is not included in unavailable_set
     def find_extended_candidate(candidate, unavailable_set)
       i = 1
-      i+=1 while unavailable_set.include? "#{candidate}#{i}"
+      i+=rand(10) while unavailable_set.include? "#{candidate}#{i}"
       "#{candidate}#{i}"
     end
   end

data/spec/db/database.yml

@@ -2,9 +2,9 @@ sqlite3:
   :adapter: sqlite3
   :database: vendor/plugins/username_suggester/spec/db/username_suggester.sqlite3.db
 
-# mysql:
-#   :adapter: mysql
-#   :database: username_suggester_test
-#   :username: root
-#   :password:
-#   :host: localhost
+mysql:
+  :adapter: mysql
+  :database: username_suggester_test
+  :username: root
+  :password:
+  :host: localhost

data/spec/suggester_spec.rb

@@ -1,6 +1,6 @@
 require File.dirname(__FILE__) + '/spec_helper'
 
-describe UsernameSuggester::Suggester do
+describe UsernameSuggester::Suggester do  
   describe "name combinations" do
     it "returns combinations of first name and last name" do
       UsernameSuggester::Suggester.new("Jerry", "Luk").name_combinations.should == [
@@ -44,6 +44,7 @@ describe UsernameSuggester::Suggester do
     end
     
     it "returns extended suggestions for names that are in the unavailable suggestions" do
+      UsernameSuggester::Suggester.send(:define_method, :rand) { 1 }
       @suggester.suggest(10, ["jerry"]).should include "jerry1"
       @suggester.suggest(10, ["jerry", "jerry1"]).should include "jerry2"
       @suggester.suggest(10, ["jerry", "jerry1031"]).should include "jerry1"

data/spec/suggestions_for_spec.rb

@@ -17,6 +17,8 @@ describe UsernameSuggester::UsernameSuggestions do
   end
   
   it "should able to suggest usernames that are not taken" do
+    UsernameSuggester::Suggester.send(:define_method, :rand) { 1 }
+    
     User.create!(:username => "jerry")
     1.upto(10) do |i|
       User.create!(:username => "jerry#{i}")

data/username_suggester.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = %q{username_suggester}
-  s.version = "0.1.0"
+  s.version = "0.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["jerryluk"]
@@ -12,6 +12,7 @@ Gem::Specification.new do |s|
     "README.rdoc"
   ]
   s.files = [
+     ".gitignore",
      "MIT-LICENSE",
      "README.rdoc",
      "Rakefile",

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: username_suggester
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 23
   prerelease: false
   segments: 
   - 0
-  - 1
+  - 2
   - 0
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors: 
 - jerryluk
@@ -44,6 +44,7 @@ extra_rdoc_files:
 - MIT-LICENSE
 - README.rdoc
 files: 
+- .gitignore
 - MIT-LICENSE
 - README.rdoc
 - Rakefile