user_notif 0.1.13.2 → 0.1.13.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d89e77a8e5e36c93ab7a5eea1f84ac336f023ba
-  data.tar.gz: b531d67c47e7878841487a5c1224a643f3a77d57
+  metadata.gz: 81c2e5b0f6e8a686ac293c356e80f8799d380b3d
+  data.tar.gz: 3d323c7cdaccbc701279a01d2875f98294233563
 SHA512:
-  metadata.gz: 875e68b2695a243be178f77258b06d6ffbe991402ea941dfccf6ee4a24ed9d929c7766bec2614dc80dcd491e42fd48e3a280d0e817ac592f426a037a15a3bf0c
-  data.tar.gz: 501521adc8b467ac8a5654e28e1e12914952f9842b99899114982c6c86638b85de6b743279a1286262d3bf3752dfa2e152a9012720b912c7be50b64a41cbd15e
+  metadata.gz: c82fd63175d78c7db9b9018bf64a258b5ad8e842ff4f7bb7838f848e645d4e7cf90b74ecd90b8cd560637338482f78d4303d18bbb0a06dd18801191beb0ff79c
+  data.tar.gz: 44a781b7932e5f9fa72312420cbd22d84f9750cc9525a34fc31345b9e8e0119aba21107fa30d6c2ca009d65c3ce6623d88db85afaebcfb3023d7083b409340c8

data/README.md

@@ -1,11 +1,15 @@
 # UserNotif
 
 [![Gem Version](https://badge.fury.io/rb/user_notif.svg)](https://badge.fury.io/rb/user_notif)
-[![Build Status](https://travis-ci.org/terry90/user_notif.svg?branch=master)](https://travis-ci.org/terry90/user_notif)
-[![Coverage Status](https://coveralls.io/repos/github/terry90/user_notif/badge.svg?branch=master)](https://coveralls.io/github/terry90/user_notif?branch=master)
-[![Code Climate](https://codeclimate.com/github/terry90/user_notif/badges/gpa.svg)](https://codeclimate.com/github/terry90/user_notif)
-[![Dependency Status](https://gemnasium.com/badges/github.com/terry90/user_notif.svg)](https://gemnasium.com/github.com/terry90/user_notif)
-[![security](https://hakiri.io/github/terry90/user_notif/master.svg)](https://hakiri.io/github/terry90/user_notif/master)
+[![Build Status](https://travis-ci.org/Insynia/user_notif.svg?branch=master)](https://travis-ci.org/Insynia/user_notif)
+[![Coverage Status](https://coveralls.io/repos/github/Insynia/user_notif/badge.svg?branch=master)](https://coveralls.io/github/Insynia/user_notif?branch=master)
+[![Code Climate](https://codeclimate.com/github/Insynia/user_notif/badges/gpa.svg)](https://codeclimate.com/github/Insynia/user_notif)
+[![Dependency Status](https://gemnasium.com/badges/github.com/Insynia/user_notif.svg)](https://gemnasium.com/github.com/Insynia/user_notif)
+[![security](https://hakiri.io/github/Insynia/user_notif/master.svg)](https://hakiri.io/github/Insynia/user_notif/master)
+
+## TODO
+
+Add belongs_to custom model (add this in initializer and load it like this belongs_to UserNotif.model_name... in notif.rb)
 
 ## Installation
 
@@ -51,6 +55,8 @@ In your `app/assets/javascripts/application.js`
 //
 ```
 
+Do not forget to restart your server to load the new assets.
+
 ## Usage
 
 Now you can create your first notification !
@@ -100,6 +106,12 @@ To display your notifications, you can use some helpers:
 
 The `small` parameter will take care of rendering the partial located in `app/views/notifs/[small,full]`
 
+You can also use the `notif_badge` helper to display a badge with the number of unread notifications.
+
+```erb
+<%= notif_badge(UserNotif.unread) %>
+```
+
 
 #### Cutomizing your views
 

data/Rakefile

@@ -1,7 +1,7 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
 task default: :spec
-task test: :spec
+task test: :spec

data/lib/generators/user_notif/install_templates/create_notifs.rb

@@ -10,4 +10,4 @@ class CreateNotifs < ActiveRecord::Migration
       t.timestamps
     end
   end
-end
+end

data/lib/generators/user_notif/install_templates/initializer.rb

@@ -5,4 +5,4 @@ UserNotif.setup do |config|
   # config.mailer_return_path = 'contact@myapp.com'
   # config.mailer_reply_to = 'contact@myapp.com'
   # config.mailer_cc = 'contact2@myapp.com'
-end
+end

data/lib/generators/user_notif/install_templates/notifs_controller.rb

@@ -5,10 +5,9 @@ module UserNotif
 
     def read
       set_notif
-      raise ActiveRecord::RecordNotFound.new('Not Found') unless @notif
-      raise ActiveRecord::RecordNotFound.new('Not Found') unless @notif
+      raise ActiveRecord::RecordNotFound, 'Not Found' unless @notif
       @notif.update!(unread: false)
-      render nothing: true
+      head :ok
     end
 
     private
@@ -19,7 +18,7 @@ module UserNotif
 
     def authorized?
       # This method assumes you are using Devise. You can change it to use your custom logic.
-      raise ActiveRecord::RecordNotFound.new('Not Found') unless @notif.owner == current_user
+      raise ActiveRecord::RecordNotFound, 'Not Found' unless @notif.owner == current_user
     end
   end
-end
+end

data/lib/generators/user_notif/user_notif_generator.rb

@@ -14,4 +14,4 @@ class UserNotifGenerator < Rails::Generators::NamedBase
     copy_file 'small_notif_view.html.erb', "app/views/notifs/small/_#{file_name}_notif.html.erb"
     copy_file 'full_notif_view.html.erb', "app/views/notifs/full/_#{file_name}_notif.html.erb"
   end
-end
+end

data/lib/user_notif.rb

@@ -21,4 +21,4 @@ module UserNotif
   @@app_name = 'My App'
 
   mattr_accessor :mailer_bcc, :mailer_return_path, :mailer_from, :mailer_reply_to, :mailer_cc, :mailer_date
-end
+end

data/lib/user_notif/notif.rb

@@ -8,7 +8,7 @@ module UserNotif
     scope :unread, -> { where(unread: true) }
 
     before_save :validate_target_and_user
-    after_create :notify_email
+    after_commit :notify_email, on: :create
 
     def email?
       true
@@ -26,7 +26,7 @@ module UserNotif
         from: UserNotif.mailer_sender,
         reply_to: UserNotif.mailer_reply_to,
         cc: UserNotif.mailer_cc,
-        date: Time.current,
+        date: Time.current
       }.merge(opts)
     end
 
@@ -37,13 +37,13 @@ module UserNotif
     private
 
     def validate_target_and_user
-      raise ModelExceptions::BadTypeNotification unless self.target.class == target_class
-      raise ModelExceptions::NotifOwnerNil if self.user == nil
+      raise ModelExceptions::BadTypeNotification unless target.class == target_class
+      raise ModelExceptions::NotifOwnerNil if user.nil?
     end
 
     def notify_email
       return unless email?
-      NotifMailer.notif_email(self.id).deliver_later
+      NotifMailer.notif_email(id).deliver_later
     end
   end
-end
+end

data/lib/user_notif/notif_mailer.rb

@@ -7,11 +7,10 @@ module UserNotif
       @target = notif.target
       @user = notif.user
       send_email({
-                   to: @user.email,
-                   template_path: 'notifs/mailer',
-                   template_name: notif.template_name
-                 }.merge(notif.email_options)
-      )
+        to: @user.email,
+        template_path: 'notifs/mailer',
+        template_name: notif.template_name
+      }.merge(notif.email_options))
     end
 
     private

data/lib/user_notif/railtie.rb

@@ -3,7 +3,7 @@ require 'rails/railtie'
 module UserNotif
   class Railtie < Rails::Railtie
     config.before_configuration do |app|
-      ActiveSupport::Dependencies.autoload_paths += %W(#{app.root}/app/models/notifs)
+      ActiveSupport::Dependencies.autoload_paths += %W[#{app.root}/app/models/notifs]
     end
 
     initializer 'user_notif.view_helpers' do
@@ -11,7 +11,7 @@ module UserNotif
     end
 
     initializer :assets do
-      Rails.application.config.assets.precompile += %w{ user_notif.js.coffee user_notif.scss }
+      Rails.application.config.assets.precompile += %w[user_notif.js.coffee user_notif.scss]
       Rails.application.config.assets.paths << UserNotif.root + '/vendor/assets/javascripts'
       Rails.application.config.assets.paths << UserNotif.root + '/vendor/assets/stylesheets'
     end

data/lib/user_notif/version.rb

@@ -1,3 +1,3 @@
 module UserNotif
-  VERSION = '0.1.13.2'
+  VERSION = '0.1.13.3'.freeze
 end

data/user_notif.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'user_notif/version'
@@ -9,8 +10,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ['Terry Raimondo']
   spec.email         = ['terry.raimondo@gmail.com']
 
-  spec.summary       = %q{Notification system for your users.}
-  spec.description   = %q{This gem adds notifications to your app, you can display the notifications where you want, add a dropdown on your header for example. Add views, mailer views and go !}
+  spec.summary       = 'Notification system for your users.'
+  spec.description   = 'This gem adds notifications to your app, you can display the notifications where you want, add a dropdown on your header for example. Add views, mailer views and go !'
   spec.homepage      = 'https://github.com/terry90/user_notif'
   spec.license       = 'MIT'
 
@@ -20,7 +21,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 1.11'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '>= 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec-rails', '~> 3.0'
   spec.add_development_dependency 'combustion', '~> 0.5.4'
@@ -29,7 +30,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'activerecord', '>= 4.0'
   spec.add_runtime_dependency 'actionmailer', '>= 4.0'
   spec.add_runtime_dependency 'railties', '>= 4.0'
-  spec.add_runtime_dependency 'sass-rails', '~> 5.0'
-  spec.add_runtime_dependency 'coffee-rails', '~> 4.1.0'
+  spec.add_runtime_dependency 'sass-rails', '>= 5.0'
+  spec.add_runtime_dependency 'coffee-rails', '>= 4.1.0'
   spec.add_runtime_dependency 'jquery-rails', '>= 4.0.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: user_notif
 version: !ruby/object:Gem::Version
-  version: 0.1.13.2
+  version: 0.1.13.3
 platform: ruby
 authors:
 - Terry Raimondo
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-06-15 00:00:00.000000000 Z
+date: 2017-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,14 +28,14 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
@@ -140,28 +140,28 @@ dependencies:
   name: sass-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
   name: coffee-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 4.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 4.1.0
 - !ruby/object:Gem::Dependency
@@ -238,7 +238,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Notification system for your users.