url_fetcher 1.0.3 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8c6eed420473ae21636daa796c36f23fb6dbea52
-  data.tar.gz: f5055142823e55cc5bb58dd1bdfa4d4c2e381e3e
+  metadata.gz: 9991d0da25a1994e5e1d046ce3f267473ca50158
+  data.tar.gz: b908958f96b23b0777be7b4db2017a124f2837e0
 SHA512:
-  metadata.gz: 082a8bf25261e514cb2f1bc41e5bf85063d0147689d3cb25b07239dd31839db54bad9774910683fb0ea9b44d8e9e78ce7cf51a92fab7c2d7ecfa64d265ea0d89
-  data.tar.gz: 54a1b9c69359f7e8886a3688200e8f24f18f96a35a7d9c09aa839e6b1b8896f63215043d3f08e13f4b16693b348a9877d613a488a588ee4a68b991dffcc471db
+  metadata.gz: 4fd94a1f0dfbb1240e3e5ddc4184ca09c3e408a717c099c13b385b3f15387dac8c4eca17970053ccf281a1f872335dc939c2c84e1adfce4e7264496bfdad0db3
+  data.tar.gz: 426266e185736573cb24e2b6ac5c0787e3e2458b58c155857b263b7b6ff2a195a8decbc65bb7da0d7e92f54a67ee928c140c8105f085342ebf7476e96eb7be1f

data/VERSION

@@ -1 +1 @@
-1.0.3
+1.1.0

data/lib/url_fetcher.rb

@@ -29,10 +29,18 @@ class UrlFetcher
     @response = fetch_response(@url, options)
   end
 
-  # Return an open stream to the downloaded URL.
+  # Return a stream to the downloaded URL.
   def body
     @response.body if success?
   end
+  
+  def close
+    body.close unless body.closed?
+  end
+  
+  def closed?
+    body.closed? if body
+  end
 
   # Get the header with the specified name from the response.
   def header(name)
@@ -93,7 +101,7 @@ class UrlFetcher
         raise FileTooBig.new(content_length) if content_length > (options[:max_size] || 10 * MEGABYTE)
         tempfile = Tempfile.new("url_fetcher", :encoding => 'ascii-8bit')
         resp.read_body(tempfile)
-        tempfile.close
+        tempfile.rewind
       end
     end
 

data/spec/url_fetcher_spec.rb

@@ -8,8 +8,12 @@ describe UrlFetcher do
     expect(url_fetcher).to be_success
     expect(url_fetcher).not_to be_redirect
     expect(url_fetcher.header("content-length")).to eql("5")
-    url_fetcher.body.open
+    expect(url_fetcher).to_not be_closed
+    expect(url_fetcher.body).to_not be_closed
     expect(url_fetcher.body.read).to eql("Hello")
+    url_fetcher.close
+    expect(url_fetcher).to be_closed
+    expect(url_fetcher.body).to be_closed
   end
 
   it "should perform a POST request" do
@@ -18,7 +22,6 @@ describe UrlFetcher do
     expect(url_fetcher).to be_success
     expect(url_fetcher).not_to be_redirect
     expect(url_fetcher.header("content-length")).to eql("5")
-    url_fetcher.body.open
     expect(url_fetcher.body.read).to eql("Hello")
   end
 
@@ -37,7 +40,7 @@ describe UrlFetcher do
     expect(url_fetcher).to be_success
     expect(url_fetcher).not_to be_redirect
     expect(url_fetcher.header("content-length")).to eql("5")
-    expect(url_fetcher.body.open.read).to eql("Hello")
+    expect(url_fetcher.body.read).to eql("Hello")
   end
 
   it "should honor redirects" do
@@ -48,7 +51,7 @@ describe UrlFetcher do
     expect(url_fetcher).to be_success
     expect(url_fetcher).not_to be_redirect
     expect(url_fetcher.header("content-length")).to eql("5")
-    expect(url_fetcher.body.open.read).to eql("Hello")
+    expect(url_fetcher.body.read).to eql("Hello")
   end
 
   it "should not honor redirects if :follow_redirects == false" do
@@ -71,7 +74,7 @@ describe UrlFetcher do
     expect(url_fetcher).to be_success
     expect(url_fetcher).not_to be_redirect
     expect(url_fetcher.header("content-length")).to eql("5")
-    expect(url_fetcher.body.open.read).to eql("Hello")
+    expect(url_fetcher.body.read).to eql("Hello")
     expect(redirects).to eql(["http://example.com/test2", "http://example.com/test3"])
   end
 
@@ -115,7 +118,8 @@ describe UrlFetcher do
     expect(url_fetcher).to be_success
     expect(url_fetcher).not_to be_redirect
     expect(url_fetcher.header("content-length")).to eql("5")
-    expect(url_fetcher.body.open.read).to eql("Hello")
+    expect(url_fetcher.body).to_not be_closed
+    expect(url_fetcher.body.read).to eql("Hello")
     expect(url_fetcher.body.path).not_to be_nil
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: url_fetcher
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.1.0
 platform: ruby
 authors:
 - weheartit
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-16 00:00:00.000000000 Z
+date: 2015-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -120,7 +120,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.3.0
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Fetch resources from the internetz with circular redirects support