uringmachine 0.6 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dc849d9467e24fa296a104e5b1caf71907495a3ed9cc68370bc6eb134a474cbf
-  data.tar.gz: 4fcdf5cd6055321f37375094aa11b56696c894d6a2c47ed9f756fb9a40d79753
+  metadata.gz: 602ceb6207baea6b38287928500c73df48258ca2f8cf843f02b45fa65c591e3e
+  data.tar.gz: 78b2bc7a274b03e2ae51510e213be0d23911c4db102ad4ab7eee435f915bb5c0
 SHA512:
-  metadata.gz: 3d83d7419000bd434bac101d72c6850274a71dd0324bd1732043cbdb08ef659b683e1010dc31093fe7a77e37368698db56592685bf7fe8a2f76ee4cd70cee52f
-  data.tar.gz: dcb79682bbdc20b99bd312aad22145642c4479009250f01f2e0c83f506026218d973b5c6e8b0aecff4e993acbe3998822bccbdf1de7c77a025b7560b5860ca77
+  metadata.gz: c0dcbb93493c9778cf4ac12769f88611364d4e190c9e9dfa666543643e3aa3b44fa01cc49cf1ea2a1ba4798c4893b75e8b47e5b1eeac23b48bc5a6d84046e458
+  data.tar.gz: 5b012fcc3e7fd1a6d4e68aae58b9d099f19d5a89670772cdfdd6ef4ac76ed9781f533fd576e2b19b02c7774ba31d3ce6ee06dc590e04ce07a62e3c7fb2394191

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 2025-04-23 Version 0.6.1
+
+- Improve `#snooze` to prevent op completion starvation
+
 # 2025-04-23 Version 0.6
 
 - Add `#periodically` for multishot timeout

data/ext/um/um.c

@@ -175,8 +175,28 @@ inline VALUE process_runqueue_op(struct um *machine, struct um_op *op) {
 inline VALUE um_fiber_switch(struct um *machine) {
   while (true) {
     struct um_op *op = um_runqueue_shift(machine);
-    if (op)
+    if (op) {
+      // in case of a snooze, we need to prevent a situation where completions
+      // are not processed because the runqueue is never empty. Theoretically,
+      // we can still have a situation where multiple fibers are all doing a
+      // snooze repeatedly, which can prevent completions from being processed.
+
+      // is the op a snooze op and is this the same fiber as the current one?
+      if (unlikely(op->kind == OP_SCHEDULE && op->fiber == rb_fiber_current())) {
+        //  are there any pending ops (i.e. waiting for completion)?
+        if (machine->pending_count > 0) {
+          // if yes, process completions, get runqueue head, put original op
+          // back on runqueue.
+          um_wait_for_and_process_ready_cqes(machine);
+          struct um_op *op2 = um_runqueue_shift(machine);
+          if (likely(op2 && op2 != op)) {
+            um_runqueue_push(machine, op);
+            op = op2; 
+          }
+        }
+      }
       return process_runqueue_op(machine, op);
+    }
 
     um_wait_for_and_process_ready_cqes(machine);
   }

data/lib/uringmachine/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class UringMachine
-  VERSION = '0.6'
+  VERSION = '0.6.1'
 end

data/test/run.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+Dir.glob("#{__dir__}/test_*.rb").each do |path|
+  require(path)
+end

data/test/test_um.rb

@@ -917,32 +917,28 @@ class QueueTest < UMBaseTest
     q = UM::Queue.new
     buf = []
 
-    f1 = Fiber.new do
+    machine.spin do
       buf << [1, machine.pop(q)]
-      machine.yield
     end
 
-    machine.schedule(f1, nil)
-
-    f2 = Fiber.new do
+    machine.spin do
       buf << [2, machine.pop(q)]
-      machine.yield
     end
 
-    machine.schedule(f2, nil)
-
     machine.snooze
     assert_equal [], buf
+    assert_equal 2, machine.pending_count
 
     machine.push(q, :foo)
     assert_equal 1, q.count
-    machine.sleep(0.02)
+    machine.snooze
+    assert_equal 1, machine.pending_count
     assert_equal [[1, :foo]], buf
 
     machine.push(q, :bar)
     assert_equal 1, q.count
 
-    machine.sleep(0.02)
+    machine.snooze
     assert_equal [[1, :foo], [2, :bar]], buf
     assert_equal 0, q.count
   end
@@ -969,7 +965,7 @@ class QueueTest < UMBaseTest
     end
     machine.schedule(f2, nil)
 
-    3.times { machine.snooze }
+    machine.snooze
 
     assert_equal [[1, :bar], [2, :foo]], buf.sort
     assert_equal 0, q.count
@@ -996,12 +992,12 @@ class QueueTest < UMBaseTest
     end
     machine.schedule(f2, nil)
 
-    machine.sleep 0.01
+    machine.snooze
 
     assert_equal [[1, :foo]], buf
     machine.push(q, :bar)
 
-    machine.sleep 0.01
+    machine.snooze
     assert_equal [[1, :foo], [2, :bar]], buf
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: uringmachine
 version: !ruby/object:Gem::Version
-  version: '0.6'
+  version: 0.6.1
 platform: ruby
 authors:
 - Sharon Rosner
@@ -136,6 +136,7 @@ files:
 - lib/uringmachine/version.rb
 - supressions/ruby.supp
 - test/helper.rb
+- test/run.rb
 - test/test_actor.rb
 - test/test_async_op.rb
 - test/test_ssl.rb