uri-amqp 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: f7de338a32e3ba26d0f93225ed1d37999a1dc693
-  data.tar.gz: 3d0f71029080bfb8e24d086bcfcacab932e9f602
+SHA256:
+  metadata.gz: b0908c708c9be720494c5eed8d83fb1d790bce2f25de4fb3b3d95442f4270b69
+  data.tar.gz: 9c1d2a089ab7d5a139f5ef292eca89c40cb96cbb56e7d09d05437ec28ddbb05e
 SHA512:
-  metadata.gz: c870fba77bfdd9d8db92648080d07f5002bd704ae6826b5cbfc21ab10e5ea8f229ba297c3dc230b9a820a182c13a01c6ff0808a05de449c24b7d73e144abcc12
-  data.tar.gz: 44bcacbb30d973c4fc4d1f4e6210a911ae134b6d91196f4919a0c40cc2774fd67d2a315e96239372807ad617f708827c8170e36594f1ef97d93362af0b2e0ca4
+  metadata.gz: 79426c0f1faa0f4cd0b5ef3f7dc625fecda95a0a03c03528e04238a07c07cd63121d14e1d43592fe730bbc2d8c59938b8e515b5a3da38e764c612a90090ac8f6
+  data.tar.gz: 9d04391e7d84f29a62ddaaaed181387d0b0ce5f159c2b04eb54d0132db4fd94224862d5175f9f60a4cd5d3df15749659bf23ffbee05bff894cb7f8fe405de704

data/.rubocop.yml

@@ -0,0 +1,20 @@
+AllCops:
+  TargetRubyVersion: 2.3
+
+Style/StringLiterals:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Naming/AccessorMethodName:
+  Enabled: false
+
+Metrics/ClassLength:
+  Max: 200
+
+Metrics/BlockLength:
+  Enabled: false
+
+Metrics/LineLength:
+  Enabled: false

data/.travis.yml

@@ -1,10 +1,13 @@
 sudo: false
 language: ruby
 rvm:
+  - 2.5
   - 2.4
   - 2.3
-  - 2.2
 before_install: gem install bundler -v 1.16.0
+script:
+  - bundle exec rake
+  - bundle exec rubocop
 
 notifications:
   email: false

data/CHANGELOG.md

@@ -0,0 +1,13 @@
+## [Unreleased]
+
+- Add frozen string literal pragma
+- Add gem downloads badge
+- Add travis build status badge
+
+## [1.0.1] - 2017-12-19
+
+- Add gem version badge
+
+## [1.0.0] - 2017-12-19
+
+- Init

data/Gemfile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in uri-amqp.gemspec
 gemspec

data/README.md

@@ -1,4 +1,7 @@
 [![Gem Version](https://badge.fury.io/rb/uri-amqp.svg)](https://badge.fury.io/rb/uri-amqp)
+[![Build Status](https://travis-ci.org/Tensho/uri-amqp.svg?branch=master)](https://travis-ci.org/Tensho/uri-amqp)
+[![Gem Downloads](https://img.shields.io/gem/dt/uri-amqp.svg)](https://rubygems.org/gems/uri-amqp)
+
 
 # URI::AMQP
 
@@ -26,45 +29,45 @@ Or install it yourself as:
 As any other URI (HTTP, FTP, LDAP) you may call `URI.parse` with string argument and it will automatically detect scheme and return `URI::AMQP` or `URI::AMQPS` instance.
 
 ```ruby
-uri = URI.parse("amqps://user:pass@host/vhost?heartbeat=10&connection_timeout=100&channel_max=1000&certfile=/examples/tls/client_cert.pem&keyfile=/examples/tls/client_key.pem")
+> uri = URI.parse("amqps://user:pass@host/vhost?heartbeat=10&connection_timeout=100&channel_max=1000&certfile=/examples/tls/client_cert.pem&keyfile=/examples/tls/client_key.pem")
 => #<URI::AMQPS amqps://user:pass@host/vhost?heartbeat=10&connection_timeout=100&channel_max=1000&certfile=/examples/tls/client_cert.pem&keyfile=/examples/tls/client_key.pem>
-uri.scheme
+> uri.scheme
 => "amqp"
-uri.user
+> uri.user
 => "user"
-uri.password
+> uri.password
 => "pass"
-uri.host
+> uri.host
 => "host"
-uri.vhost
+> uri.vhost
 => "vhost"
-uri.vhost
+> uri.vhost
 => "vhost"
-uri.heartbeat
+> uri.heartbeat
 => 10
-uri.connection_timeout
+> uri.connection_timeout
 => 100
-uri.channel_max
+> uri.channel_max
 => 1000
-uri.verify
+> uri.verify
 => false
-uri.fail_if_no_peer_cert
+> uri.fail_if_no_peer_cert
 => false
-uri.cacertfile
+> uri.cacertfile
 => nil
-uri.certfile 
+> uri.certfile 
 => "/examples/tls/client_cert.pem"
-uri.keyfile
+> uri.keyfile
 => "/examples/tls/client_key.pem"
 ```
 
 There are also implemented some checks:
 
-```
-uri = URI.parse("amqp://host/vhost/hurricane")
+```ruby
+> URI.parse("amqp://host/vhost/hurricane")
 => URI::InvalidComponentError: bad vhost (expected only leading "/"): /vhost/hurricane
 
-uri = URI.parse("amqp://host/vhost?certfile=/examples/tls/client_cert.pem&keyfile=/examples/tls/client_key.pem")
+> URI.parse("amqp://host/vhost?certfile=/examples/tls/client_cert.pem&keyfile=/examples/tls/client_key.pem")
 => URI::InvalidComponentError: bad certfile (expected only in "amqps" schema): /examples/tls/client_cert.pem
 ``` 
 
@@ -76,10 +79,16 @@ uri = URI.parse("amqp://host/vhost?certfile=/examples/tls/client_cert.pem&keyfil
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
+Run `bundle exec rubocop` before PR opening.
+
+## Testing
+
+    $ rake
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/Tensho/uri-amqp. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.

data/Rakefile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "bundler/setup"
 require "uri/amqp"

data/lib/uri/amqp.rb

@@ -1,10 +1,13 @@
+# frozen_string_literal: true
+
 require "cgi"
 require "uri/generic"
 
+# https://www.rabbitmq.com/protocol.html
+# https://www.rabbitmq.com/uri-spec.html
+# https://www.rabbitmq.com/uri-query-parameters.html
 module URI
   class AMQP < Generic
-    VERSION = "1.0.1"
-
     DEFAULT_PORT = 5672
 
     COMPONENT = %i[
@@ -73,44 +76,41 @@ module URI
     protected
 
     def set_userinfo(user, password = nil)
-      user &&= CGI::unescape(user)
-      password &&= CGI::unescape(password)
+      user &&= CGI.unescape(user)
+      password &&= CGI.unescape(password)
       super(user, password)
     end
 
     def set_user(value)
-      super(value && CGI::unescape(value))
+      super(value && CGI.unescape(value))
     end
 
     def set_host(value)
-      super(value && CGI::unescape(value))
+      super(value && CGI.unescape(value))
     end
 
     def set_vhost(value)
-      @vhost = if value
-        value.delete!('/')
-        CGI::unescape(value)
-      end
+      @vhost = value && CGI.unescape(value.delete('/'))
     end
 
     def set_heartbeat(value)
-      @heartbeat = value && value.to_i
+      @heartbeat = value&.to_i
     end
 
     def set_connection_timeout(value)
-      @connection_timeout = value && value.to_i
+      @connection_timeout = value&.to_i
     end
 
     def set_channel_max(value)
-      @channel_max = value && value.to_i
+      @channel_max = value&.to_i
     end
 
     def set_verify(value)
-      @verify = !!(value)
+      @verify = !value.nil?
     end
 
     def set_fail_if_no_peer_cert(value)
-      @fail_if_no_peer_cert = !!(value)
+      @fail_if_no_peer_cert = !value.nil?
     end
 
     def set_cacertfile(value)
@@ -150,7 +150,7 @@ module URI
     end
 
     def check_vhost(value)
-      raise InvalidComponentError, "bad vhost (expected only leading \"/\"): #{value}" if value && !(value =~ %r{^/[^/]*$})
+      raise InvalidComponentError, "bad vhost (expected only leading \"/\"): #{value}" if value && value !~ %r{^/[^/]*$}
     end
 
     %i[

data/lib/uri/amqp/version.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module URI
+  class AMQP < Generic
+    VERSION = '1.0.2'
+  end
+end

data/lib/uri/amqps.rb

@@ -1,23 +1,26 @@
+# frozen_string_literal: true
+
 require "uri/amqp"
 
+# https://www.rabbitmq.com/protocol.html
+# https://www.rabbitmq.com/uri-spec.html
+# https://www.rabbitmq.com/uri-query-parameters.html
+# https://www.rabbitmq.com/ssl.html
 module URI
   class AMQPS < AMQP
     DEFAULT_PORT = 5671
 
-    def check_verify(_)
-    end
+    # rubocop:disable Naming/UncommunicativeMethodParamName
+    def check_verify(_); end
 
-    def check_fail_if_no_peer_cert(_)
-    end
+    def check_fail_if_no_peer_cert(_); end
 
-    def check_cacertfile(_)
-    end
+    def check_cacertfile(_); end
 
-    def check_certfile(_)
-    end
+    def check_certfile(_); end
 
-    def check_keyfile(_)
-    end
+    def check_keyfile(_); end
+    # rubocop:enable Naming/UncommunicativeMethodParamName
   end
 
   @@schemes["AMQPS"] = AMQPS

data/uri-amqp.gemspec

@@ -1,6 +1,9 @@
-lib = File.expand_path("../lib", __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
+require "uri/amqp/version"
 require "uri/amqp"
 require "uri/amqps"
 
@@ -10,31 +13,32 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Andrew Babichev"]
   spec.email         = ["andrew.babichev@gmail.com"]
 
-  spec.summary       = %q{URI::AMQP}
-  spec.description   = %q{URI stdlib module extension for AMQP}
+  spec.summary       = "URI::AMQP"
+  spec.description   = "URI stdlib module extension for AMQP"
   spec.homepage      = "https://github.com/Tensho/uri-amqp"
   spec.license       = "MIT"
 
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
   # to allow pushing to a single host or delete this section to allow pushing to any host.
-  if spec.respond_to?(:metadata)
+  if spec.respond_to?(:metadata) # rubocop:disable Style/GuardClause
     spec.metadata["allowed_push_host"] = "https://rubygems.org"
   else
     raise "RubyGems 2.0 or newer is required to protect against public gem pushes."
   end
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = "> 2.2"
+  spec.required_ruby_version = ">= 2.3.0"
 
   spec.add_development_dependency "bundler", "~> 1.16"
+  spec.add_development_dependency "pry-byebug"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec-its", "~> 1.2.0"
-  spec.add_development_dependency "pry-byebug"
+  spec.add_development_dependency "rubocop"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: uri-amqp
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Andrew Babichev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-12-19 00:00:00.000000000 Z
+date: 2018-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.16'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -67,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.2.0
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -89,7 +103,9 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -98,6 +114,7 @@ files:
 - bin/console
 - bin/setup
 - lib/uri/amqp.rb
+- lib/uri/amqp/version.rb
 - lib/uri/amqps.rb
 - uri-amqp.gemspec
 homepage: https://github.com/Tensho/uri-amqp
@@ -111,9 +128,9 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '2.2'
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -121,7 +138,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: URI::AMQP