urbanopt-rnm-us 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 07dfa016051b9b8499a11ba5d8066a73c06131d628af10adb2dfc8c9848e7c30
-  data.tar.gz: a6e9f7af3ee4e92951d9225caa5eddfb8f97b20b0e1a5d95898a3f4a132405e3
+  metadata.gz: 78e5fa9802676b79db0cfaf9c6184581dafc1d5499c51dcf6c32070974baa221
+  data.tar.gz: f77669a0f5fa76cff7cf76b58d0fc67bc7671d8cbf964b6b9faec90ba2343a65
 SHA512:
-  metadata.gz: b25a77720880cc85ed29adabb35280a8e308692004183ef7da0a70ae0f4dd4e56c18d5299697490e8ed98e62e8007465ec31f80279c505595df23b144cbf16e5
-  data.tar.gz: e6a40b39b6f1f20f96df5379bf02c73205e00981e60bdf25dccaadb8780dd24522e18dcf423f3497fa7c03f6dd180cdc54531bd150666f2a33612b3a2b40c883
+  metadata.gz: 16e51e2d9b1c0aa9fbcb15f9e946a0feb65ab66133d1c43ab0c91ae6cab4afd0ff0746ef142a5bec279aec48be8812c37e845322800dc846e09a294916823ec7
+  data.tar.gz: 282ddcc5091620663891c2bd1637dd77fdb19097af21049b0d1f8992ac8a45bd9d68058bd1f61c201596dbfad0ccbb6872d0b2e90a85df26938aa540e71502a8

data/.github/workflows/ci.yml

@@ -0,0 +1,46 @@
+
+name: ci
+
+on:
+  # push:
+  schedule:
+    # https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule
+    # 5:23 am UTC (11:23pm MDT the day before) every weekday night in MDT
+    - cron: '23 5 * * 2-6'
+
+env:
+  # This env var should enforce develop branch of all dependencies
+  FAVOR_LOCAL_GEMS: true
+  GEM_DEVELOPER_KEY: ${{ secrets.GEM_DEVELOPER_KEY }}
+
+jobs:
+  weeknight-tests:
+    runs-on: ubuntu-latest
+    container:
+      image: docker://nrel/openstudio:3.5.1
+    steps:
+      - uses: actions/checkout@v3
+      - name: Update gems
+        run: |
+          ruby --version
+          bundle update
+          bundle exec certified-update
+      - name: Run Rspec
+        continue-on-error: true
+        # Continue to upload step even if a test fails, so we can troubleshoot
+        run: bundle exec rspec
+      - name: Upload artifacts
+        uses: actions/upload-artifact@v3
+        if: failure() # Only upload if rspec fails
+        with:
+          name: rspec_results
+          path: |
+            spec/test*/**
+            # coverage/
+          retention-days: 7 # save for 1 week before deleting
+      # coveralls action docs: https://github.com/marketplace/actions/coveralls-github-action
+      - name: Coveralls
+        uses: coverallsapp/github-action@master
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          path-to-lcov: "./coverage/lcov/urbanopt-rnm-us-gem.lcov"

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## Version 0.5.1
+Date Range 12/9/22 - 6/7/23
+
+- Fix to handle buildings with courtyard without creating additional erroneous buildings
+
 ## Version 0.5.0
 Date Range 9/30/22 - 12/8/22
 

data/LICENSE.md

@@ -1,4 +1,4 @@
-URBANopt (tm), Copyright (c) 2019-2022, Alliance for Sustainable Energy, LLC, and other
+URBANopt (tm), Copyright (c) 2019-2023, Alliance for Sustainable Energy, LLC, and other
 contributors. All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification,

data/README.md

@@ -1,6 +1,8 @@
+[![Coverage Status](https://coveralls.io/repos/github/urbanopt/urbanopt-rnm-us-gem/badge.svg?branch=develop)](https://coveralls.io/github/urbanopt/urbanopt-rnm-us-gem?branch=develop)
+
 # URBANopt RNM-US Gem
 
-The URBANopt<sup>&trade;</sup> RNM-US Gem includes functionalities to interface the URBANopt SDK to the RNM-US Gem for the development of a synthetic optimum distribution network in the considered district, given data related to the buildings energy consumption/DER energy generation and location, modeled by the other URBANopt modules. 
+The URBANopt<sup>&trade;</sup> RNM-US Gem includes functionalities to interface the URBANopt SDK to the RNM-US Gem for the development of a synthetic optimum distribution network in the considered district, given data related to the buildings energy consumption/DER energy generation and location, modeled by the other URBANopt modules.
 The RNM-US Gem is used to collect required data for the execution of RNM-US, which has been modeled in the other URBANopt modules, translating information provided
 in .json and .csv format into .txt files
 
@@ -15,7 +17,7 @@ The OpenDSS format presents results for power system analysis and simulations.
 The current functionalities of the RNM-US Gem include the creation of a streetmap text file, the substation txt file and multiple txt files related to the consumers peak loads and profiles and DERs peak generation and profiles.
 The streetmap text file is developed from coordinates information provided by geoJSON feature file input. The customers and generators text files, which define all the network consumers and DG included in the project, are created from their peak electricity demand/generation, and building location, provided by csv and json feature_report files modeled by the URBANopt Scenario Gem.
 The profiles txt files are divided among the consumers hourly profiles of active and reactive power and the DG hourly profiles of active and reactive power for the 2 most "extreme" days of maximum net demand and maximum net generation for the district .
-Finally, the extended profiles txt files provide the active and reactive profiles for each consumer/DG for the whole year. 
+Finally, the extended profiles txt files provide the active and reactive profiles for each consumer/DG for the whole year.
 
 
 ## Generate input files
@@ -67,4 +69,4 @@ The validation and results visualization functionality is written in python. Fol
 
 ```bash
 bundle exec rspec
-```
+```

data/lib/urbanopt/rnm/geojson_input.rb

@@ -210,7 +210,11 @@ module URBANopt
             street_coordinates[street_number] = each_street
             street_number += 1
           elsif street['geometry']['type'] == 'Polygon' && street['properties']['type'] == 'Building' && scenario_features.include?(street['properties']['id'])
-            for k in 0..street['geometry']['coordinates'].length - 1
+            puts "------ processing Building #{ street['properties']['name']} --------"
+            # this loop goes through each polygon and assign it a building and is not correct for buildings with
+            # inner courtyards (it would create 2 buildings)
+            # This assumes the outward footprint is the first polygon -- we only process the first one here
+            for k in 0..0
               h = 0 # index representing number of nodes for each single building
               building = [] # array containing every building node coordinates and id of 1 building
               for j in 0..street['geometry']['coordinates'][k].length - 1

data/lib/urbanopt/rnm/version.rb

@@ -40,6 +40,6 @@
 
 module URBANopt
   module RNM
-    VERSION = '0.5.0'.freeze
+    VERSION = '0.5.1'.freeze
   end
 end

data/urbanopt-rnm-us-gem.gemspec

@@ -35,4 +35,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rubocop', '~> 1.15.0'
   spec.add_development_dependency 'rubocop-checkstyle_formatter', '~> 0.4.0'
   spec.add_development_dependency 'rubocop-performance', '~> 1.11.3'
+  spec.add_development_dependency 'simplecov', '~> 0.18.2'
+  spec.add_development_dependency 'simplecov-lcov', '~> 0.8.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: urbanopt-rnm-us
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Katherine Fleming
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-12-13 00:00:00.000000000 Z
+date: 2023-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: certified
@@ -165,6 +165,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.11.3
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.18.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.18.2
+- !ruby/object:Gem::Dependency
+  name: simplecov-lcov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.8.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.8.0
 description: Library to create input files for RNM-US
 email:
 - katherine.fleming@nrel.gov
@@ -173,6 +201,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - CHANGELOG.md