urbanairship 2.2.1 → 2.2.2

data/lib/urbanairship.rb

@@ -68,7 +68,7 @@ module Urbanairship
     end
 
     def add_tag(tag)
-      do_request(:put, "/api/tags/#{tag}", :authenticate_with => :master_secret)
+      do_request(:put, "/api/tags/#{tag}", :authenticate_with => :master_secret, :content_type => 'text/plain')
     end
 
     def remove_tag(tag)
@@ -96,7 +96,7 @@ module Urbanairship
 
       request = klass.new(path)
       request.basic_auth @application_key, instance_variable_get("@#{options[:authenticate_with]}")
-      request.add_field "Content-Type", "application/json"
+      request.add_field "Content-Type", options[:content_type] || "application/json"
       request.body = options[:body] if options[:body]
 
       Timer.timeout(request_timeout) do

data/spec/response_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe Urbanairship::Response do
 
   before do

data/spec/urbanairship_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 shared_examples_for "an Urbanairship client" do
   before(:all) do
     FakeWeb.allow_net_connect = false
@@ -35,41 +37,40 @@ shared_examples_for "an Urbanairship client" do
     # feedback
     FakeWeb.register_uri(:get, /my_app_key\:my_master_secret\@go\.urbanairship.com\/api\/device_tokens\/feedback/, :status => ["200", "OK"], :body => "[{\"device_token\":\"token\",\"marked_inactive_on\":\"2010-10-14T19:15:13Z\",\"alias\":\"my_alias\"}]")
     FakeWeb.register_uri(:get, /my_app_key2\:my_master_secret2\@go\.urbanairship.com\/api\/device_tokens\/feedback/, :status => ["500", "Internal Server Error"])
-    
+
     #tags
     FakeWeb.register_uri(:get, /my_app_key\:my_master_secret\@go\.urbanairship.com\/api\/tags/, :status => ["200", "OK"], :body => "[{\"tags\":[\"tag1\",\"tag2\"]}]")
     FakeWeb.register_uri(:get, /my_app_key2\:my_master_secret2\@go\.urbanairship.com\/api\/tags/, :status => ["500", "Internal Server Error"])
-    
+
     #add_tag
     FakeWeb.register_uri(:put, /my_app_key\:my_master_secret\@go\.urbanairship.com\/api\/tags\/new_tag/, :status => ["200", "OK"])
     FakeWeb.register_uri(:put, /my_app_key\:my_master_secret\@go\.urbanairship.com\/api\/tags\/existing_tag/, :status => ["201", "OK"])
     FakeWeb.register_uri(:put, /my_app_key2\:my_master_secret2\@go\.urbanairship.com\/api\/tags\/a_tag/, :status => ["500", "Internal Server Error"])
-    
+
     #remove_tag
     FakeWeb.register_uri(:delete, /my_app_key\:my_master_secret\@go\.urbanairship.com\/api\/tags\/non_deleted_tag/, :status => ["204", "OK"])
     FakeWeb.register_uri(:delete, /my_app_key\:my_master_secret\@go\.urbanairship.com\/api\/tags\/deleted_tag/, :status => ["404", "OK"])
     FakeWeb.register_uri(:delete, /my_app_key2\:my_master_secret2\@go\.urbanairship.com\/api\/tags\/a_tag/, :status => ["500", "Internal Server Error"])
-    
+
     #tags_for_device_tokens
     FakeWeb.register_uri(:get, /my_app_key\:my_master_secret\@go\.urbanairship.com\/api\/device_tokens\/valid_device_token\/tags/, :status => ["200", "OK"], :body => "[{\"tags\":[\"tag1\",\"tag2\"]}]")
     FakeWeb.register_uri(:get, /my_app_key\:my_master_secret\@go\.urbanairship.com\/api\/device_tokens\/invalid_device_token\/tags/, :status => ["404", "OK"])
     FakeWeb.register_uri(:get, /my_app_key2\:my_master_secret2\@go\.urbanairship.com\/api\/device_tokens\/a_device_token\/tags/, :status => ["500", "Internal Server Error"])
-    
+
     ##tag_device
     FakeWeb.register_uri(:put, /my_app_key\:my_master_secret\@go\.urbanairship.com\/api\/device_tokens\/valid_device_token\/tags\/new_tag/, :status => ["201", "OK"])
     FakeWeb.register_uri(:put, /my_app_key\:my_master_secret\@go\.urbanairship.com\/api\/device_tokens\/valid_device_token\/tags\/existing_tag/, :status => ["200", "OK"])
     FakeWeb.register_uri(:put, /my_app_key2\:my_master_secret2\@go\.urbanairship.com\/api\/device_tokens\/a_device_token\/tags\/a_tag/, :status => ["500", "Internal Server Error"])
-    
+
     #untag_device
     FakeWeb.register_uri(:delete, /my_app_key\:my_master_secret\@go\.urbanairship.com\/api\/device_tokens\/valid_device_token\/tags\/existing_tag/, :status => ["204", "OK"])
     FakeWeb.register_uri(:delete, /my_app_key\:my_master_secret\@go\.urbanairship.com\/api\/device_tokens\/valid_device_token\/tags\/non_existant_tag/, :status => ["404", "OK"])
     FakeWeb.register_uri(:delete, /my_app_key2\:my_master_secret2\@go\.urbanairship.com\/api\/device_tokens\/a_device_token\/tags\/a_tag/, :status => ["500", "Internal Server Error"])
-    
+
     # push to segment
     FakeWeb.register_uri(:post, "https://my_app_key:my_master_secret@go.urbanairship.com/api/push/segments", :status => ["200", "OK"])
     FakeWeb.register_uri(:post, "https://my_app_key2:my_master_secret2@go.urbanairship.com/api/push/segments", :status => ["400", "Bad Request"])
     FakeWeb.register_uri(:post, /bad_key\:my_master_secret\@go\.urbanairship\.com/, :status => ["401", "Unauthorized"])
-    
   end
 
   describe "configuration" do
@@ -91,7 +92,7 @@ shared_examples_for "an Urbanairship client" do
       subject.master_secret.should == "asdf1234"
     end
   end
-  
+
   describe "::tags" do
     before(:each) do
       subject.application_key = "my_app_key"
@@ -106,27 +107,27 @@ shared_examples_for "an Urbanairship client" do
         subject.tags
       }.should raise_error(RuntimeError, "Must configure application_key, master_secret before making this request.")
     end
-    
+
     it "uses app key and secret to sign the request" do
       subject.tags
       FakeWeb.last_request['authorization'].should == "Basic #{Base64::encode64('my_app_key:my_master_secret').chomp}"
     end
-    
+
     it "returns valid tags" do
       response = subject.tags
       response.first.should include("tags")
       response.first["tags"].should include("tag1")
       response.first["tags"].should include("tag2")
     end
-    
+
     it "success? is false when the call doesn't return 200" do
       subject.application_key = "my_app_key2"
       subject.master_secret = "my_master_secret2"
       subject.tags.success?.should == false
     end
-   
+
   end
-  
+
   describe "::add_tag" do
     before(:each) do
       subject.application_key = "my_app_key"
@@ -141,30 +142,34 @@ shared_examples_for "an Urbanairship client" do
         subject.add_tag('a_tag')
       }.should raise_error(RuntimeError, "Must configure application_key, master_secret before making this request.")
     end
-    
+
     it "uses app key and secret to sign the request" do
       subject.add_tag('new_tag')
       FakeWeb.last_request['authorization'].should == "Basic #{Base64::encode64('my_app_key:my_master_secret').chomp}"
     end
-    
+
     it "adds a new tag" do
       subject.add_tag('new_tag').success?.should == true
       subject.add_tag('new_tag').code.should == "200"
     end
-    
+
     it "adds an exisiting tag" do
       subject.add_tag('existing_tag').success?.should == true
       subject.add_tag('existing_tag').code.should == "201"
     end
-    
+
     it "success? is false when the call doesn't return 200 or 201" do
       subject.application_key = "my_app_key2"
       subject.master_secret = "my_master_secret2"
       subject.add_tag('a_tag').success?.should == false
     end
-   
+
+    it "sets the content-type to text/plain" do
+      subject.add_tag('new_tag')
+      FakeWeb.last_request['content-type'].should == "text/plain"
+    end
   end
-  
+
   describe "::remove_tag" do
     before(:each) do
       subject.application_key = "my_app_key"
@@ -194,20 +199,20 @@ shared_examples_for "an Urbanairship client" do
      subject.remove_tag('deleted_tag').success?.should == false
      subject.remove_tag('deleted_tag').code.should == "404"
    end
-   
+
    it "success? is false when the call doesn't return 204" do
      subject.application_key = "my_app_key2"
      subject.master_secret = "my_master_secret2"
      subject.add_tag('a_tag').success?.should == false
    end
   end
-   
+
   describe "::tags_for_device" do
     before(:each) do
       subject.application_key = "my_app_key"
       subject.master_secret = "my_master_secret"
     end
-    
+
     it "raises an error if call is made without an app key and master secret configured" do
        subject.application_key = nil
        subject.master_secret = nil
@@ -216,12 +221,12 @@ shared_examples_for "an Urbanairship client" do
          subject.tags_for_device('a_device_token')
        }.should raise_error(RuntimeError, "Must configure application_key, master_secret before making this request.")
     end
-    
+
     it "uses app key and secret to sign the request" do
       subject.tags_for_device('valid_device_token')
       FakeWeb.last_request['authorization'].should == "Basic #{Base64::encode64('my_app_key:my_master_secret').chomp}"
     end
-    
+
     it "returns valid tags for a device" do
       response = subject.tags_for_device('valid_device_token')
       response.first.should include("tags")
@@ -229,25 +234,25 @@ shared_examples_for "an Urbanairship client" do
       response.first["tags"].should include("tag2")
       response.code.should == "200"
     end
-    
+
     it "returns invalid response for device token that is not found or registered" do
       response = subject.tags_for_device('invalid_device_token')
       response.code.should == "404"
     end
-    
+
     it "success? is false when the call doesn't return 200" do
       subject.application_key = "my_app_key2"
       subject.master_secret = "my_master_secret2"
       subject.tags_for_device('a_device_token').success?.should == false
     end
   end
-  
+
   describe "::tag_device" do
     before(:each) do
       subject.application_key = "my_app_key"
       subject.master_secret = "my_master_secret"
     end
-    
+
     it "raises an error if call is made without an app key and master secret configured" do
        subject.application_key = nil
        subject.master_secret = nil
@@ -256,25 +261,25 @@ shared_examples_for "an Urbanairship client" do
          subject.tag_device({:device_token => 'a_device_token', :tag => 'a_tag'})
        }.should raise_error(RuntimeError, "Must configure application_key, master_secret before making this request.")
     end
-    
+
     it "uses app key and secret to sign the request" do
       subject.tag_device({:device_token => 'valid_device_token', :tag => 'new_tag'})
       FakeWeb.last_request['authorization'].should == "Basic #{Base64::encode64('my_app_key:my_master_secret').chomp}"
     end
-    
+
     it "adds a valid device token to tag" do
       response = subject.tag_device({:device_token => 'valid_device_token', :tag => 'new_tag'})
       response.code.should == "201"
       response.success?.should == true
     end
-    
+
     it "adds a valid device token to an existing tag" do
       response = subject.tag_device({:device_token => 'valid_device_token', :tag => 'existing_tag'})
       response.code.should == "200"
       response.success?.should == true
     end
   end
-    
+
     describe "::untag_device" do
       before(:each) do
         subject.application_key = "my_app_key"
@@ -307,7 +312,6 @@ shared_examples_for "an Urbanairship client" do
         response.success?.should == false
       end
   end
-  
 
   describe "::register_device" do
     before(:each) do
@@ -522,7 +526,7 @@ shared_examples_for "an Urbanairship client" do
       subject.push.success?.should == false
     end
   end
-  
+
   describe "::push_to_segment" do
     before(:each) do
       @valid_params = {:segments => ['segment-id'], :aps => {:alert => 'foo'}}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: urbanairship
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-11 00:00:00.000000000 Z
+date: 2013-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json