update_cardinals_by 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0f0c9aa2f3667c4925560e59e838b79a294b918f48dda0f7092b01e476ad0c40
-  data.tar.gz: cdd625ca542d8d09e7d4ac17a03e48862f569d42a1694bfb94751780b4ed37c0
+  metadata.gz: 8e543f2da218b298efab597204971e384f20abae47b759e8897f4618212d2e46
+  data.tar.gz: 3b1e9d44200165458389d033d65e7a98c58603d54df313b9efa100a7412b9e5e
 SHA512:
-  metadata.gz: 6ff4b4a4137503a08368116b1b0f213bb41fe08a0d3ca06c8ba44694ca3d00d62e0ee54072efb418737b15af9f987022e9427a0a418e498f2816c5692b83e258
-  data.tar.gz: 382d155ff8ddc7b3aae7bc9936ee6d6186ac1f55e27dc444249fb23fda69c52c7cf0aa6c28f4c5fed2ae762cc29d6dc85b9faee7f4d704b08b537b2c28cbcd4f
+  metadata.gz: 52db2ed4276e33fd047d9c16399bd3269b8e8a14258ce84f09b1cd4fe8b5e380252ded9f8e88a079ef8a315c58fb7711613c30a6d1f9017aa616a72f93ce2431
+  data.tar.gz: 2d653a6f9e33ad54ed929da08c36568d398a74bba26031d3234e5324fd1f01a372372f1338271be76165a9b4854fbdd6616a8c27b6e41cb36c552ee0954380f4

data/README.md

@@ -37,6 +37,8 @@ end
 
 ## Changelog
 
+0.2.0 changed activerecord support to 5.2 and 6.0
+
 0.1.0 changed activerecord support from 4.2 to 5.0 and 5.1
 
 ## Developing

data/lib/update_cardinals_by.rb

@@ -26,7 +26,10 @@ module UpdateCardinalsBy
 
       yield res if block_given?
 
-      res.each { |attr, v| raw_write_attribute attr, v }
+      res.each do |attr, v|
+        write_attribute attr, v
+        clear_attribute_change attr
+      end
     end
   end
 end

data/lib/update_cardinals_by/version.rb

@@ -1,3 +1,3 @@
 module UpdateCardinalsBy
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/concerns/update_cardinals_by_spec.rb

@@ -15,23 +15,26 @@ class Account < ActiveRecord::Base
 end
 
 describe UpdateCardinalsBy do
-  let(:account) { Account.create credits: 100, money: BigDecimal(12, 34) }
+  let(:account) { Account.create credits: 100, money: BigDecimal("12.34") }
 
   describe 'update_cardinals_by!' do
     it 'accepts positive change' do
-      account.update_by!(credits: 20, money: BigDecimal(3, 16))
+      account.update_by!(credits: 20, money: BigDecimal("3.16"))
       expect(account.credits).to eq 120
-      expect(account.money).to eq BigDecimal(15, 50)
+      expect(account.money).to eq BigDecimal("15.50")
+      account.reload
+      expect(account.credits).to eq 120
+      expect(account.money).to eq BigDecimal("15.50")
     end
 
     it 'accepts negative change' do
-      account.update_by!(credits: -20, money: -BigDecimal(1, 24))
+      account.update_by!(credits: -20, money: -BigDecimal("1.24"))
       expect(account.credits).to eq 80
-      expect(account.money).to eq BigDecimal(11, 10)
+      expect(account.money).to eq BigDecimal("11.10")
     end
 
-    it 'leaves leaves the instance in a saved state' do
-      account.update_by!(credits: 20, money: BigDecimal(3, 16))
+    it 'leaves the instance in a saved state' do
+      account.update_by!(credits: 20, money: BigDecimal("3.16"))
       expect(account.changed?).to be_falsy
     end
 
@@ -42,10 +45,10 @@ describe UpdateCardinalsBy do
     end
 
     it 'passes the right types to the block' do
-      account.update_cardinals_by!(credits: 20, money: BigDecimal(3, 16)) do |res|
+      account.update_cardinals_by!(credits: 20, money: BigDecimal("3.16")) do |res|
         expect(res[:credits]).to be_a Integer
         expect(res[:money]).to be_a BigDecimal
       end
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: update_cardinals_by
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Hampei
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-02 00:00:00.000000000 Z
+date: 2020-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -19,7 +19,7 @@ dependencies:
         version: '5.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '5.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -147,7 +147,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: postgres database extension to increment/decrement values safely and get